[jira] [Comment Edited] (GROOVY-8602) Safe index doesn't work with map arguments

2018-09-02 Thread Paul King (JIRA)


[ 
https://issues.apache.org/jira/browse/GROOVY-8602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16601736#comment-16601736
 ] 

Paul King edited comment on GROOVY-8602 at 9/3/18 2:14 AM:
---

Reducing priority. The only place map indexing is allowed is immediately after 
a class constant, e.g.:
{code}
assert Date[year: 118, month: 8, date: 3].day == 1
{code}
I don't see a lot of value in supporting this:
{code}
assert Date?[year: 118, month: 8, date: 3].day == 1
{code}
If we supported using a class variable, I could see the value, e.g.:
{code}
def d = Date
assert d[year: 118, month: 8, date: 3].day == 1 // No map entry allowed at this 
place
{code}
But we don't support this. You could perhaps argue for a slightly better error 
message in the Date? case above.


was (Author: paulk):
Reducing priority. The only place map indexing is allowed is immediately after 
a class constant, e.g.:
{code}
assert Date[year: 118, month: 8, date: 3].day == 1
{code}
I don't see a lot of value in supporting this:
{code}
assert Date?[year: 118, month: 8, date: 3].day == 1
{code}
If we supported using a class variable, I could see the value, e.g.:
{code}
def d = Date
assert d[year: 118, month: 8, date: 3].day == 1 // No map entry allowed at this 
place
{code}
But we don't support this. You could perhaps argue for a slightly better error 
message in this case.

> Safe index doesn't work with map arguments
> --
>
> Key: GROOVY-8602
> URL: https://issues.apache.org/jira/browse/GROOVY-8602
> Project: Groovy
>  Issue Type: Bug
>Affects Versions: 3.0.0-alpha-2
>Reporter: Daniil Ovchinnikov
>Priority: Minor
>
> {{a[b:2]}} works.
> {{a?[b:2]}} produces {{Unexpected input: ''; Expecting ':' @ ...}}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (GROOVY-8602) Safe index doesn't work with map arguments

2018-09-02 Thread Paul King (JIRA)


[ 
https://issues.apache.org/jira/browse/GROOVY-8602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16601736#comment-16601736
 ] 

Paul King commented on GROOVY-8602:
---

Reducing priority. The only place map indexing is allowed is immediately after 
a class constant, e.g.:
{code}
assert Date[year: 118, month: 8, date: 3].day == 1
{code}
I don't see a lot of value in supporting this:
{code}
assert Date?[year: 118, month: 8, date: 3].day == 1
{code}
If we supported using a class variable, I could see the value, e.g.:
{code}
def d = Date
assert d[year: 118, month: 8, date: 3].day == 1 // No map entry allowed at this 
place
{code}
But we don't support this. You could perhaps argue for a slightly better error 
message in this case.

> Safe index doesn't work with map arguments
> --
>
> Key: GROOVY-8602
> URL: https://issues.apache.org/jira/browse/GROOVY-8602
> Project: Groovy
>  Issue Type: Bug
>Affects Versions: 3.0.0-alpha-2
>Reporter: Daniil Ovchinnikov
>Priority: Minor
>
> {{a[b:2]}} works.
> {{a?[b:2]}} produces {{Unexpected input: ''; Expecting ':' @ ...}}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (GROOVY-8602) Safe index doesn't work with map arguments

2018-09-02 Thread Paul King (JIRA)


 [ 
https://issues.apache.org/jira/browse/GROOVY-8602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Paul King updated GROOVY-8602:
--
Priority: Minor  (was: Critical)

> Safe index doesn't work with map arguments
> --
>
> Key: GROOVY-8602
> URL: https://issues.apache.org/jira/browse/GROOVY-8602
> Project: Groovy
>  Issue Type: Bug
>Affects Versions: 3.0.0-alpha-2
>Reporter: Daniil Ovchinnikov
>Priority: Minor
>
> {{a[b:2]}} works.
> {{a?[b:2]}} produces {{Unexpected input: ''; Expecting ':' @ ...}}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (GROOVY-8718) GroovyConsole MacOS fix required for JDK9+

2018-09-02 Thread Paul King (JIRA)


 [ 
https://issues.apache.org/jira/browse/GROOVY-8718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Paul King resolved GROOVY-8718.
---
   Resolution: Fixed
 Assignee: Paul King
Fix Version/s: 2.5.2

This appears to be fixed as part of the changes for 2.5.2.

> GroovyConsole MacOS fix required for JDK9+
> --
>
> Key: GROOVY-8718
> URL: https://issues.apache.org/jira/browse/GROOVY-8718
> Project: Groovy
>  Issue Type: Bug
>Reporter: Paul King
>Assignee: Paul King
>Priority: Major
> Fix For: 2.5.2
>
>
> As per http://openjdk.java.net/jeps/272, com.apple.eawt is not supported for 
> JDK9+ and we use that via e.g. MRJPrefsHandler. If I understand correctly, 
> the functionality seems mostly incorporated into java.awt.Desktop.
> A common workaround (to maintain JDK8 compatibility and work on JDK9+) seems 
> to be to use reflection to access the new classes, e.g.:
> https://github.com/SubOptimal/keystore-explorer/blob/master/kse/src/org/kse/gui/MacOsIntegration.java



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Comment Edited] (GROOVY-8727) JDK 11 Compilation Failure: ClassVisitor.visitNestMemberExperimental throws UnsupportedOperationException

2018-09-02 Thread Paul King (JIRA)


[ 
https://issues.apache.org/jira/browse/GROOVY-8727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16601689#comment-16601689
 ] 

Paul King edited comment on GROOVY-8727 at 9/2/18 11:10 PM:


This is expected behavior at the moment. We have ASM7_EXPERIMENTAL currently 
only in the 3.0 snapshots. Our current plan is to also release a new 2.5.x 
version when ASM7 is released.


was (Author: paulk):
This is expected behavior at the moment. We have ASM7_EXPERIMENTAL currently 
only in the 3.0 snapshots.

> JDK 11 Compilation Failure: ClassVisitor.visitNestMemberExperimental throws 
> UnsupportedOperationException 
> --
>
> Key: GROOVY-8727
> URL: https://issues.apache.org/jira/browse/GROOVY-8727
> Project: Groovy
>  Issue Type: Bug
>  Components: Compiler
>Affects Versions: 2.5.2
>Reporter: Misagh Moayyed
>Priority: Major
>
> *Description:*
> Using JDK 11 and Gradle 4.9, the following compilation error is seen:
>  
> {code:java}
> > Task :core:cas-server-core-tickets:compileTestGroovy FAILED
> startup failed:
> General error during class generation: java.lang.UnsupportedOperationException
> java.lang.UnsupportedOperationException
>   at 
> groovyjarjarasm.asm.ClassVisitor.visitNestMemberExperimental(ClassVisitor.java:248)
>   at groovyjarjarasm.asm.ClassReader.accept(ClassReader.java:651)
>   at groovyjarjarasm.asm.ClassReader.accept(ClassReader.java:391)
>   at 
> org.codehaus.groovy.ast.decompiled.AsmDecompiler.parseClass(AsmDecompiler.java:83)
>   at 
> org.codehaus.groovy.control.ClassNodeResolver.findDecompiled(ClassNodeResolver.java:254)
>   at 
> org.codehaus.groovy.control.ClassNodeResolver.tryAsLoaderClassOrScript(ClassNodeResolver.java:192)
>   at 
> org.codehaus.groovy.control.ClassNodeResolver.findClassNode(ClassNodeResolver.java:172)
>   at 
> org.codehaus.groovy.control.ClassNodeResolver.resolveName(ClassNodeResolver.java:128)
>   at 
> org.codehaus.groovy.ast.decompiled.AsmReferenceResolver.resolveClassNullable(AsmReferenceResolver.java:59)
>   at 
> org.codehaus.groovy.ast.decompiled.AsmReferenceResolver.resolveClass(AsmReferenceResolver.java:46)
>   at 
> org.codehaus.groovy.ast.decompiled.TypeSignatureParser.visitEnd(TypeSignatureParser.java:112)
>   at 
> groovyjarjarasm.asm.signature.SignatureReader.parseType(SignatureReader.java:206)
>   at 
> groovyjarjarasm.asm.signature.SignatureReader.parseType(SignatureReader.java:235)
>   at 
> groovyjarjarasm.asm.signature.SignatureReader.accept(SignatureReader.java:114)
>   at 
> org.codehaus.groovy.ast.decompiled.MemberSignatureParser.createMethodNode(MemberSignatureParser.java:95)
>   at 
> org.codehaus.groovy.ast.decompiled.DecompiledClassNode.lazyInitMembers(DecompiledClassNode.java:195)
>   at 
> org.codehaus.groovy.ast.decompiled.DecompiledClassNode.getMethods(DecompiledClassNode.java:103)
>   at org.codehaus.groovy.ast.ClassNode.getMethods(ClassNode.java:399)
>   at 
> org.codehaus.groovy.classgen.AnnotationVisitor.checkIfMandatoryAnnotationValuesPassed(AnnotationVisitor.java:168)
>   at 
> org.codehaus.groovy.classgen.AnnotationVisitor.visit(AnnotationVisitor.java:80)
>   at 
> org.codehaus.groovy.classgen.ExtendedVerifier.visitAnnotation(ExtendedVerifier.java:311)
>   at 
> org.codehaus.groovy.classgen.ExtendedVerifier.visitAnnotations(ExtendedVerifier.java:157)
>   at 
> org.codehaus.groovy.classgen.ExtendedVerifier.visitConstructorOrMethod(ExtendedVerifier.java:112)
>   at 
> org.codehaus.groovy.classgen.ExtendedVerifier.visitMethod(ExtendedVerifier.java:108)
>   at org.codehaus.groovy.ast.ClassNode.visitContents(ClassNode.java:1103)
>   at 
> org.codehaus.groovy.classgen.ExtendedVerifier.visitClass(ExtendedVerifier.java:91)
>   at 
> org.codehaus.groovy.control.CompilationUnit$18.call(CompilationUnit.java:827)
>   at 
> org.codehaus.groovy.control.CompilationUnit.applyToPrimaryClassNodes(CompilationUnit.java:1087)
>   at 
> org.codehaus.groovy.control.CompilationUnit.doPhaseOperation(CompilationUnit.java:631)
>   at 
> org.codehaus.groovy.control.CompilationUnit.processPhaseOperations(CompilationUnit.java:609)
>   at 
> org.codehaus.groovy.control.CompilationUnit.compile(CompilationUnit.java:586)
>   at 
> org.codehaus.groovy.control.CompilationUnit.compile(CompilationUnit.java:565)
>   at 
> org.gradle.api.internal.tasks.compile.ApiGroovyCompiler.execute(ApiGroovyCompiler.java:179)
>   at 
> org.gradle.api.internal.tasks.compile.ApiGroovyCompiler.execute(ApiGroovyCompiler.java:57)
>   at 
> org.gradle.api.internal.tasks.compile.GroovyCompilerFactory$DaemonSideCompiler.execute(GroovyCompilerFactory.java:77)
>   at 
> 

[jira] [Updated] (GROOVY-8727) JDK 11 Compilation Failure: ClassVisitor.visitNestMemberExperimental throws UnsupportedOperationException

2018-09-02 Thread Paul King (JIRA)


 [ 
https://issues.apache.org/jira/browse/GROOVY-8727?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Paul King updated GROOVY-8727:
--
Affects Version/s: (was: 2.5.1)
   2.5.2

> JDK 11 Compilation Failure: ClassVisitor.visitNestMemberExperimental throws 
> UnsupportedOperationException 
> --
>
> Key: GROOVY-8727
> URL: https://issues.apache.org/jira/browse/GROOVY-8727
> Project: Groovy
>  Issue Type: Bug
>  Components: Compiler
>Affects Versions: 2.5.2
>Reporter: Misagh Moayyed
>Priority: Major
>
> *Description:*
> Using JDK 11 and Gradle 4.9, the following compilation error is seen:
>  
> {code:java}
> > Task :core:cas-server-core-tickets:compileTestGroovy FAILED
> startup failed:
> General error during class generation: java.lang.UnsupportedOperationException
> java.lang.UnsupportedOperationException
>   at 
> groovyjarjarasm.asm.ClassVisitor.visitNestMemberExperimental(ClassVisitor.java:248)
>   at groovyjarjarasm.asm.ClassReader.accept(ClassReader.java:651)
>   at groovyjarjarasm.asm.ClassReader.accept(ClassReader.java:391)
>   at 
> org.codehaus.groovy.ast.decompiled.AsmDecompiler.parseClass(AsmDecompiler.java:83)
>   at 
> org.codehaus.groovy.control.ClassNodeResolver.findDecompiled(ClassNodeResolver.java:254)
>   at 
> org.codehaus.groovy.control.ClassNodeResolver.tryAsLoaderClassOrScript(ClassNodeResolver.java:192)
>   at 
> org.codehaus.groovy.control.ClassNodeResolver.findClassNode(ClassNodeResolver.java:172)
>   at 
> org.codehaus.groovy.control.ClassNodeResolver.resolveName(ClassNodeResolver.java:128)
>   at 
> org.codehaus.groovy.ast.decompiled.AsmReferenceResolver.resolveClassNullable(AsmReferenceResolver.java:59)
>   at 
> org.codehaus.groovy.ast.decompiled.AsmReferenceResolver.resolveClass(AsmReferenceResolver.java:46)
>   at 
> org.codehaus.groovy.ast.decompiled.TypeSignatureParser.visitEnd(TypeSignatureParser.java:112)
>   at 
> groovyjarjarasm.asm.signature.SignatureReader.parseType(SignatureReader.java:206)
>   at 
> groovyjarjarasm.asm.signature.SignatureReader.parseType(SignatureReader.java:235)
>   at 
> groovyjarjarasm.asm.signature.SignatureReader.accept(SignatureReader.java:114)
>   at 
> org.codehaus.groovy.ast.decompiled.MemberSignatureParser.createMethodNode(MemberSignatureParser.java:95)
>   at 
> org.codehaus.groovy.ast.decompiled.DecompiledClassNode.lazyInitMembers(DecompiledClassNode.java:195)
>   at 
> org.codehaus.groovy.ast.decompiled.DecompiledClassNode.getMethods(DecompiledClassNode.java:103)
>   at org.codehaus.groovy.ast.ClassNode.getMethods(ClassNode.java:399)
>   at 
> org.codehaus.groovy.classgen.AnnotationVisitor.checkIfMandatoryAnnotationValuesPassed(AnnotationVisitor.java:168)
>   at 
> org.codehaus.groovy.classgen.AnnotationVisitor.visit(AnnotationVisitor.java:80)
>   at 
> org.codehaus.groovy.classgen.ExtendedVerifier.visitAnnotation(ExtendedVerifier.java:311)
>   at 
> org.codehaus.groovy.classgen.ExtendedVerifier.visitAnnotations(ExtendedVerifier.java:157)
>   at 
> org.codehaus.groovy.classgen.ExtendedVerifier.visitConstructorOrMethod(ExtendedVerifier.java:112)
>   at 
> org.codehaus.groovy.classgen.ExtendedVerifier.visitMethod(ExtendedVerifier.java:108)
>   at org.codehaus.groovy.ast.ClassNode.visitContents(ClassNode.java:1103)
>   at 
> org.codehaus.groovy.classgen.ExtendedVerifier.visitClass(ExtendedVerifier.java:91)
>   at 
> org.codehaus.groovy.control.CompilationUnit$18.call(CompilationUnit.java:827)
>   at 
> org.codehaus.groovy.control.CompilationUnit.applyToPrimaryClassNodes(CompilationUnit.java:1087)
>   at 
> org.codehaus.groovy.control.CompilationUnit.doPhaseOperation(CompilationUnit.java:631)
>   at 
> org.codehaus.groovy.control.CompilationUnit.processPhaseOperations(CompilationUnit.java:609)
>   at 
> org.codehaus.groovy.control.CompilationUnit.compile(CompilationUnit.java:586)
>   at 
> org.codehaus.groovy.control.CompilationUnit.compile(CompilationUnit.java:565)
>   at 
> org.gradle.api.internal.tasks.compile.ApiGroovyCompiler.execute(ApiGroovyCompiler.java:179)
>   at 
> org.gradle.api.internal.tasks.compile.ApiGroovyCompiler.execute(ApiGroovyCompiler.java:57)
>   at 
> org.gradle.api.internal.tasks.compile.GroovyCompilerFactory$DaemonSideCompiler.execute(GroovyCompilerFactory.java:77)
>   at 
> org.gradle.api.internal.tasks.compile.GroovyCompilerFactory$DaemonSideCompiler.execute(GroovyCompilerFactory.java:65)
>   at 
> org.gradle.api.internal.tasks.compile.daemon.AbstractDaemonCompiler$CompilerCallable.call(AbstractDaemonCompiler.java:88)
>   at 
> 

[jira] [Updated] (GROOVY-8727) JDK 11 Compilation Failure: ClassVisitor.visitNestMemberExperimental throws UnsupportedOperationException

2018-09-02 Thread Paul King (JIRA)


 [ 
https://issues.apache.org/jira/browse/GROOVY-8727?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Paul King updated GROOVY-8727:
--
Affects Version/s: (was: 3.x)

> JDK 11 Compilation Failure: ClassVisitor.visitNestMemberExperimental throws 
> UnsupportedOperationException 
> --
>
> Key: GROOVY-8727
> URL: https://issues.apache.org/jira/browse/GROOVY-8727
> Project: Groovy
>  Issue Type: Bug
>  Components: Compiler
>Affects Versions: 2.5.2
>Reporter: Misagh Moayyed
>Priority: Major
>
> *Description:*
> Using JDK 11 and Gradle 4.9, the following compilation error is seen:
>  
> {code:java}
> > Task :core:cas-server-core-tickets:compileTestGroovy FAILED
> startup failed:
> General error during class generation: java.lang.UnsupportedOperationException
> java.lang.UnsupportedOperationException
>   at 
> groovyjarjarasm.asm.ClassVisitor.visitNestMemberExperimental(ClassVisitor.java:248)
>   at groovyjarjarasm.asm.ClassReader.accept(ClassReader.java:651)
>   at groovyjarjarasm.asm.ClassReader.accept(ClassReader.java:391)
>   at 
> org.codehaus.groovy.ast.decompiled.AsmDecompiler.parseClass(AsmDecompiler.java:83)
>   at 
> org.codehaus.groovy.control.ClassNodeResolver.findDecompiled(ClassNodeResolver.java:254)
>   at 
> org.codehaus.groovy.control.ClassNodeResolver.tryAsLoaderClassOrScript(ClassNodeResolver.java:192)
>   at 
> org.codehaus.groovy.control.ClassNodeResolver.findClassNode(ClassNodeResolver.java:172)
>   at 
> org.codehaus.groovy.control.ClassNodeResolver.resolveName(ClassNodeResolver.java:128)
>   at 
> org.codehaus.groovy.ast.decompiled.AsmReferenceResolver.resolveClassNullable(AsmReferenceResolver.java:59)
>   at 
> org.codehaus.groovy.ast.decompiled.AsmReferenceResolver.resolveClass(AsmReferenceResolver.java:46)
>   at 
> org.codehaus.groovy.ast.decompiled.TypeSignatureParser.visitEnd(TypeSignatureParser.java:112)
>   at 
> groovyjarjarasm.asm.signature.SignatureReader.parseType(SignatureReader.java:206)
>   at 
> groovyjarjarasm.asm.signature.SignatureReader.parseType(SignatureReader.java:235)
>   at 
> groovyjarjarasm.asm.signature.SignatureReader.accept(SignatureReader.java:114)
>   at 
> org.codehaus.groovy.ast.decompiled.MemberSignatureParser.createMethodNode(MemberSignatureParser.java:95)
>   at 
> org.codehaus.groovy.ast.decompiled.DecompiledClassNode.lazyInitMembers(DecompiledClassNode.java:195)
>   at 
> org.codehaus.groovy.ast.decompiled.DecompiledClassNode.getMethods(DecompiledClassNode.java:103)
>   at org.codehaus.groovy.ast.ClassNode.getMethods(ClassNode.java:399)
>   at 
> org.codehaus.groovy.classgen.AnnotationVisitor.checkIfMandatoryAnnotationValuesPassed(AnnotationVisitor.java:168)
>   at 
> org.codehaus.groovy.classgen.AnnotationVisitor.visit(AnnotationVisitor.java:80)
>   at 
> org.codehaus.groovy.classgen.ExtendedVerifier.visitAnnotation(ExtendedVerifier.java:311)
>   at 
> org.codehaus.groovy.classgen.ExtendedVerifier.visitAnnotations(ExtendedVerifier.java:157)
>   at 
> org.codehaus.groovy.classgen.ExtendedVerifier.visitConstructorOrMethod(ExtendedVerifier.java:112)
>   at 
> org.codehaus.groovy.classgen.ExtendedVerifier.visitMethod(ExtendedVerifier.java:108)
>   at org.codehaus.groovy.ast.ClassNode.visitContents(ClassNode.java:1103)
>   at 
> org.codehaus.groovy.classgen.ExtendedVerifier.visitClass(ExtendedVerifier.java:91)
>   at 
> org.codehaus.groovy.control.CompilationUnit$18.call(CompilationUnit.java:827)
>   at 
> org.codehaus.groovy.control.CompilationUnit.applyToPrimaryClassNodes(CompilationUnit.java:1087)
>   at 
> org.codehaus.groovy.control.CompilationUnit.doPhaseOperation(CompilationUnit.java:631)
>   at 
> org.codehaus.groovy.control.CompilationUnit.processPhaseOperations(CompilationUnit.java:609)
>   at 
> org.codehaus.groovy.control.CompilationUnit.compile(CompilationUnit.java:586)
>   at 
> org.codehaus.groovy.control.CompilationUnit.compile(CompilationUnit.java:565)
>   at 
> org.gradle.api.internal.tasks.compile.ApiGroovyCompiler.execute(ApiGroovyCompiler.java:179)
>   at 
> org.gradle.api.internal.tasks.compile.ApiGroovyCompiler.execute(ApiGroovyCompiler.java:57)
>   at 
> org.gradle.api.internal.tasks.compile.GroovyCompilerFactory$DaemonSideCompiler.execute(GroovyCompilerFactory.java:77)
>   at 
> org.gradle.api.internal.tasks.compile.GroovyCompilerFactory$DaemonSideCompiler.execute(GroovyCompilerFactory.java:65)
>   at 
> org.gradle.api.internal.tasks.compile.daemon.AbstractDaemonCompiler$CompilerCallable.call(AbstractDaemonCompiler.java:88)
>   at 
> 

[jira] [Commented] (GROOVY-8727) JDK 11 Compilation Failure: ClassVisitor.visitNestMemberExperimental throws UnsupportedOperationException

2018-09-02 Thread Paul King (JIRA)


[ 
https://issues.apache.org/jira/browse/GROOVY-8727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16601689#comment-16601689
 ] 

Paul King commented on GROOVY-8727:
---

This is expected behavior at the moment. We have ASM7_EXPERIMENTAL currently 
only in the 3.0 snapshots.

> JDK 11 Compilation Failure: ClassVisitor.visitNestMemberExperimental throws 
> UnsupportedOperationException 
> --
>
> Key: GROOVY-8727
> URL: https://issues.apache.org/jira/browse/GROOVY-8727
> Project: Groovy
>  Issue Type: Bug
>  Components: Compiler
>Affects Versions: 3.x, 2.5.1
>Reporter: Misagh Moayyed
>Priority: Major
>
> *Description:*
> Using JDK 11 and Gradle 4.9, the following compilation error is seen:
>  
> {code:java}
> > Task :core:cas-server-core-tickets:compileTestGroovy FAILED
> startup failed:
> General error during class generation: java.lang.UnsupportedOperationException
> java.lang.UnsupportedOperationException
>   at 
> groovyjarjarasm.asm.ClassVisitor.visitNestMemberExperimental(ClassVisitor.java:248)
>   at groovyjarjarasm.asm.ClassReader.accept(ClassReader.java:651)
>   at groovyjarjarasm.asm.ClassReader.accept(ClassReader.java:391)
>   at 
> org.codehaus.groovy.ast.decompiled.AsmDecompiler.parseClass(AsmDecompiler.java:83)
>   at 
> org.codehaus.groovy.control.ClassNodeResolver.findDecompiled(ClassNodeResolver.java:254)
>   at 
> org.codehaus.groovy.control.ClassNodeResolver.tryAsLoaderClassOrScript(ClassNodeResolver.java:192)
>   at 
> org.codehaus.groovy.control.ClassNodeResolver.findClassNode(ClassNodeResolver.java:172)
>   at 
> org.codehaus.groovy.control.ClassNodeResolver.resolveName(ClassNodeResolver.java:128)
>   at 
> org.codehaus.groovy.ast.decompiled.AsmReferenceResolver.resolveClassNullable(AsmReferenceResolver.java:59)
>   at 
> org.codehaus.groovy.ast.decompiled.AsmReferenceResolver.resolveClass(AsmReferenceResolver.java:46)
>   at 
> org.codehaus.groovy.ast.decompiled.TypeSignatureParser.visitEnd(TypeSignatureParser.java:112)
>   at 
> groovyjarjarasm.asm.signature.SignatureReader.parseType(SignatureReader.java:206)
>   at 
> groovyjarjarasm.asm.signature.SignatureReader.parseType(SignatureReader.java:235)
>   at 
> groovyjarjarasm.asm.signature.SignatureReader.accept(SignatureReader.java:114)
>   at 
> org.codehaus.groovy.ast.decompiled.MemberSignatureParser.createMethodNode(MemberSignatureParser.java:95)
>   at 
> org.codehaus.groovy.ast.decompiled.DecompiledClassNode.lazyInitMembers(DecompiledClassNode.java:195)
>   at 
> org.codehaus.groovy.ast.decompiled.DecompiledClassNode.getMethods(DecompiledClassNode.java:103)
>   at org.codehaus.groovy.ast.ClassNode.getMethods(ClassNode.java:399)
>   at 
> org.codehaus.groovy.classgen.AnnotationVisitor.checkIfMandatoryAnnotationValuesPassed(AnnotationVisitor.java:168)
>   at 
> org.codehaus.groovy.classgen.AnnotationVisitor.visit(AnnotationVisitor.java:80)
>   at 
> org.codehaus.groovy.classgen.ExtendedVerifier.visitAnnotation(ExtendedVerifier.java:311)
>   at 
> org.codehaus.groovy.classgen.ExtendedVerifier.visitAnnotations(ExtendedVerifier.java:157)
>   at 
> org.codehaus.groovy.classgen.ExtendedVerifier.visitConstructorOrMethod(ExtendedVerifier.java:112)
>   at 
> org.codehaus.groovy.classgen.ExtendedVerifier.visitMethod(ExtendedVerifier.java:108)
>   at org.codehaus.groovy.ast.ClassNode.visitContents(ClassNode.java:1103)
>   at 
> org.codehaus.groovy.classgen.ExtendedVerifier.visitClass(ExtendedVerifier.java:91)
>   at 
> org.codehaus.groovy.control.CompilationUnit$18.call(CompilationUnit.java:827)
>   at 
> org.codehaus.groovy.control.CompilationUnit.applyToPrimaryClassNodes(CompilationUnit.java:1087)
>   at 
> org.codehaus.groovy.control.CompilationUnit.doPhaseOperation(CompilationUnit.java:631)
>   at 
> org.codehaus.groovy.control.CompilationUnit.processPhaseOperations(CompilationUnit.java:609)
>   at 
> org.codehaus.groovy.control.CompilationUnit.compile(CompilationUnit.java:586)
>   at 
> org.codehaus.groovy.control.CompilationUnit.compile(CompilationUnit.java:565)
>   at 
> org.gradle.api.internal.tasks.compile.ApiGroovyCompiler.execute(ApiGroovyCompiler.java:179)
>   at 
> org.gradle.api.internal.tasks.compile.ApiGroovyCompiler.execute(ApiGroovyCompiler.java:57)
>   at 
> org.gradle.api.internal.tasks.compile.GroovyCompilerFactory$DaemonSideCompiler.execute(GroovyCompilerFactory.java:77)
>   at 
> org.gradle.api.internal.tasks.compile.GroovyCompilerFactory$DaemonSideCompiler.execute(GroovyCompilerFactory.java:65)
>   at 
> 

[jira] [Comment Edited] (GROOVY-8727) JDK 11 Compilation Failure: ClassVisitor.visitNestMemberExperimental throws UnsupportedOperationException

2018-09-02 Thread Dimitry Polivaev (JIRA)


[ 
https://issues.apache.org/jira/browse/GROOVY-8727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16601253#comment-16601253
 ] 

Dimitry Polivaev edited comment on GROOVY-8727 at 9/2/18 5:09 PM:
--

My asm bug report was closed with following statement: 
 

"I will close this issue as work as intended even if you may think it's 
surprising, currently ASM ClassReader support Java 11 (and even Java 12) so it 
recognizes Java 11 new attributes (here NestMembers). But here you are using a 
ClassVisitor which is configured to only recognize the ASM6 API, thus it fails 
at runtime with an UnsupportedOperation exception.

Even if NestMembers (and NestHosts) are class file attributes, they can not be 
ignored because the JVM access control semantics changes depending on these 
attributes (see JEP 181 [1]).

So either you do not support Java 11 class file or you change the visitor to 
accept ASM7 semantics and also change you visior accordingly.

[1] [http://openjdk.java.net/jeps/181];

(See [https://gitlab.ow2.org/asm/asm/issues/317854#note_39078])

It means that the fix should be implemented on the Groovy side.


was (Author: dpolivaev):
My asm bug report was closed with following statement: 
 

"I will close this issue as work as intended even if you may think it's 
surprising, currently ASM ClassReader support Java 11 (and even Java 12) so it 
recognizes Java 11 new attributes (here NestMembers). But here you are using a 
ClassVisitor which is configured to only recognize the ASM6 API, thus it fails 
at runtime with an UnsupportedOperation exception.

Even if NestMembers (and NestHosts) are class file attributes, they can not be 
ignored because the JVM access control semantics changes depending on these 
attributes (see JEP 181 [1]).

So either you do not support Java 11 class file or you change the visitor to 
accept ASM7 semantics and also change you visior accordingly.

[1] [http://openjdk.java.net/jeps/181];

It means that the fix should be implemented on Groovy side.

> JDK 11 Compilation Failure: ClassVisitor.visitNestMemberExperimental throws 
> UnsupportedOperationException 
> --
>
> Key: GROOVY-8727
> URL: https://issues.apache.org/jira/browse/GROOVY-8727
> Project: Groovy
>  Issue Type: Bug
>  Components: Compiler
>Affects Versions: 3.x, 2.5.1
>Reporter: Misagh Moayyed
>Priority: Major
>
> *Description:*
> Using JDK 11 and Gradle 4.9, the following compilation error is seen:
>  
> {code:java}
> > Task :core:cas-server-core-tickets:compileTestGroovy FAILED
> startup failed:
> General error during class generation: java.lang.UnsupportedOperationException
> java.lang.UnsupportedOperationException
>   at 
> groovyjarjarasm.asm.ClassVisitor.visitNestMemberExperimental(ClassVisitor.java:248)
>   at groovyjarjarasm.asm.ClassReader.accept(ClassReader.java:651)
>   at groovyjarjarasm.asm.ClassReader.accept(ClassReader.java:391)
>   at 
> org.codehaus.groovy.ast.decompiled.AsmDecompiler.parseClass(AsmDecompiler.java:83)
>   at 
> org.codehaus.groovy.control.ClassNodeResolver.findDecompiled(ClassNodeResolver.java:254)
>   at 
> org.codehaus.groovy.control.ClassNodeResolver.tryAsLoaderClassOrScript(ClassNodeResolver.java:192)
>   at 
> org.codehaus.groovy.control.ClassNodeResolver.findClassNode(ClassNodeResolver.java:172)
>   at 
> org.codehaus.groovy.control.ClassNodeResolver.resolveName(ClassNodeResolver.java:128)
>   at 
> org.codehaus.groovy.ast.decompiled.AsmReferenceResolver.resolveClassNullable(AsmReferenceResolver.java:59)
>   at 
> org.codehaus.groovy.ast.decompiled.AsmReferenceResolver.resolveClass(AsmReferenceResolver.java:46)
>   at 
> org.codehaus.groovy.ast.decompiled.TypeSignatureParser.visitEnd(TypeSignatureParser.java:112)
>   at 
> groovyjarjarasm.asm.signature.SignatureReader.parseType(SignatureReader.java:206)
>   at 
> groovyjarjarasm.asm.signature.SignatureReader.parseType(SignatureReader.java:235)
>   at 
> groovyjarjarasm.asm.signature.SignatureReader.accept(SignatureReader.java:114)
>   at 
> org.codehaus.groovy.ast.decompiled.MemberSignatureParser.createMethodNode(MemberSignatureParser.java:95)
>   at 
> org.codehaus.groovy.ast.decompiled.DecompiledClassNode.lazyInitMembers(DecompiledClassNode.java:195)
>   at 
> org.codehaus.groovy.ast.decompiled.DecompiledClassNode.getMethods(DecompiledClassNode.java:103)
>   at org.codehaus.groovy.ast.ClassNode.getMethods(ClassNode.java:399)
>   at 
> org.codehaus.groovy.classgen.AnnotationVisitor.checkIfMandatoryAnnotationValuesPassed(AnnotationVisitor.java:168)
>   at 
> org.codehaus.groovy.classgen.AnnotationVisitor.visit(AnnotationVisitor.java:80)
>   at 
> 

[jira] [Commented] (GROOVY-8727) JDK 11 Compilation Failure: ClassVisitor.visitNestMemberExperimental throws UnsupportedOperationException

2018-09-02 Thread Dimitry Polivaev (JIRA)


[ 
https://issues.apache.org/jira/browse/GROOVY-8727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16601253#comment-16601253
 ] 

Dimitry Polivaev commented on GROOVY-8727:
--

My asm bug report was closed with following statement: 
 

"I will close this issue as work as intended even if you may think it's 
surprising, currently ASM ClassReader support Java 11 (and even Java 12) so it 
recognizes Java 11 new attributes (here NestMembers). But here you are using a 
ClassVisitor which is configured to only recognize the ASM6 API, thus it fails 
at runtime with an UnsupportedOperation exception.

Even if NestMembers (and NestHosts) are class file attributes, they can not be 
ignored because the JVM access control semantics changes depending on these 
attributes (see JEP 181 [1]).

So either you do not support Java 11 class file or you change the visitor to 
accept ASM7 semantics and also change you visior accordingly.

[1] [http://openjdk.java.net/jeps/181];

It means that the fix should be implemented on Groovy side.

> JDK 11 Compilation Failure: ClassVisitor.visitNestMemberExperimental throws 
> UnsupportedOperationException 
> --
>
> Key: GROOVY-8727
> URL: https://issues.apache.org/jira/browse/GROOVY-8727
> Project: Groovy
>  Issue Type: Bug
>  Components: Compiler
>Affects Versions: 3.x, 2.5.1
>Reporter: Misagh Moayyed
>Priority: Major
>
> *Description:*
> Using JDK 11 and Gradle 4.9, the following compilation error is seen:
>  
> {code:java}
> > Task :core:cas-server-core-tickets:compileTestGroovy FAILED
> startup failed:
> General error during class generation: java.lang.UnsupportedOperationException
> java.lang.UnsupportedOperationException
>   at 
> groovyjarjarasm.asm.ClassVisitor.visitNestMemberExperimental(ClassVisitor.java:248)
>   at groovyjarjarasm.asm.ClassReader.accept(ClassReader.java:651)
>   at groovyjarjarasm.asm.ClassReader.accept(ClassReader.java:391)
>   at 
> org.codehaus.groovy.ast.decompiled.AsmDecompiler.parseClass(AsmDecompiler.java:83)
>   at 
> org.codehaus.groovy.control.ClassNodeResolver.findDecompiled(ClassNodeResolver.java:254)
>   at 
> org.codehaus.groovy.control.ClassNodeResolver.tryAsLoaderClassOrScript(ClassNodeResolver.java:192)
>   at 
> org.codehaus.groovy.control.ClassNodeResolver.findClassNode(ClassNodeResolver.java:172)
>   at 
> org.codehaus.groovy.control.ClassNodeResolver.resolveName(ClassNodeResolver.java:128)
>   at 
> org.codehaus.groovy.ast.decompiled.AsmReferenceResolver.resolveClassNullable(AsmReferenceResolver.java:59)
>   at 
> org.codehaus.groovy.ast.decompiled.AsmReferenceResolver.resolveClass(AsmReferenceResolver.java:46)
>   at 
> org.codehaus.groovy.ast.decompiled.TypeSignatureParser.visitEnd(TypeSignatureParser.java:112)
>   at 
> groovyjarjarasm.asm.signature.SignatureReader.parseType(SignatureReader.java:206)
>   at 
> groovyjarjarasm.asm.signature.SignatureReader.parseType(SignatureReader.java:235)
>   at 
> groovyjarjarasm.asm.signature.SignatureReader.accept(SignatureReader.java:114)
>   at 
> org.codehaus.groovy.ast.decompiled.MemberSignatureParser.createMethodNode(MemberSignatureParser.java:95)
>   at 
> org.codehaus.groovy.ast.decompiled.DecompiledClassNode.lazyInitMembers(DecompiledClassNode.java:195)
>   at 
> org.codehaus.groovy.ast.decompiled.DecompiledClassNode.getMethods(DecompiledClassNode.java:103)
>   at org.codehaus.groovy.ast.ClassNode.getMethods(ClassNode.java:399)
>   at 
> org.codehaus.groovy.classgen.AnnotationVisitor.checkIfMandatoryAnnotationValuesPassed(AnnotationVisitor.java:168)
>   at 
> org.codehaus.groovy.classgen.AnnotationVisitor.visit(AnnotationVisitor.java:80)
>   at 
> org.codehaus.groovy.classgen.ExtendedVerifier.visitAnnotation(ExtendedVerifier.java:311)
>   at 
> org.codehaus.groovy.classgen.ExtendedVerifier.visitAnnotations(ExtendedVerifier.java:157)
>   at 
> org.codehaus.groovy.classgen.ExtendedVerifier.visitConstructorOrMethod(ExtendedVerifier.java:112)
>   at 
> org.codehaus.groovy.classgen.ExtendedVerifier.visitMethod(ExtendedVerifier.java:108)
>   at org.codehaus.groovy.ast.ClassNode.visitContents(ClassNode.java:1103)
>   at 
> org.codehaus.groovy.classgen.ExtendedVerifier.visitClass(ExtendedVerifier.java:91)
>   at 
> org.codehaus.groovy.control.CompilationUnit$18.call(CompilationUnit.java:827)
>   at 
> org.codehaus.groovy.control.CompilationUnit.applyToPrimaryClassNodes(CompilationUnit.java:1087)
>   at 
> org.codehaus.groovy.control.CompilationUnit.doPhaseOperation(CompilationUnit.java:631)
>   at 
> org.codehaus.groovy.control.CompilationUnit.processPhaseOperations(CompilationUnit.java:609)
>   at 
> 

[jira] [Commented] (GROOVY-8727) JDK 11 Compilation Failure: ClassVisitor.visitNestMemberExperimental throws UnsupportedOperationException

2018-09-02 Thread Dimitry Polivaev (JIRA)


[ 
https://issues.apache.org/jira/browse/GROOVY-8727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16601240#comment-16601240
 ] 

Dimitry Polivaev commented on GROOVY-8727:
--

Submitted bug report https://gitlab.ow2.org/asm/asm/issues/317854

> JDK 11 Compilation Failure: ClassVisitor.visitNestMemberExperimental throws 
> UnsupportedOperationException 
> --
>
> Key: GROOVY-8727
> URL: https://issues.apache.org/jira/browse/GROOVY-8727
> Project: Groovy
>  Issue Type: Bug
>  Components: Compiler
>Affects Versions: 3.x, 2.5.1
>Reporter: Misagh Moayyed
>Priority: Major
>
> *Description:*
> Using JDK 11 and Gradle 4.9, the following compilation error is seen:
>  
> {code:java}
> > Task :core:cas-server-core-tickets:compileTestGroovy FAILED
> startup failed:
> General error during class generation: java.lang.UnsupportedOperationException
> java.lang.UnsupportedOperationException
>   at 
> groovyjarjarasm.asm.ClassVisitor.visitNestMemberExperimental(ClassVisitor.java:248)
>   at groovyjarjarasm.asm.ClassReader.accept(ClassReader.java:651)
>   at groovyjarjarasm.asm.ClassReader.accept(ClassReader.java:391)
>   at 
> org.codehaus.groovy.ast.decompiled.AsmDecompiler.parseClass(AsmDecompiler.java:83)
>   at 
> org.codehaus.groovy.control.ClassNodeResolver.findDecompiled(ClassNodeResolver.java:254)
>   at 
> org.codehaus.groovy.control.ClassNodeResolver.tryAsLoaderClassOrScript(ClassNodeResolver.java:192)
>   at 
> org.codehaus.groovy.control.ClassNodeResolver.findClassNode(ClassNodeResolver.java:172)
>   at 
> org.codehaus.groovy.control.ClassNodeResolver.resolveName(ClassNodeResolver.java:128)
>   at 
> org.codehaus.groovy.ast.decompiled.AsmReferenceResolver.resolveClassNullable(AsmReferenceResolver.java:59)
>   at 
> org.codehaus.groovy.ast.decompiled.AsmReferenceResolver.resolveClass(AsmReferenceResolver.java:46)
>   at 
> org.codehaus.groovy.ast.decompiled.TypeSignatureParser.visitEnd(TypeSignatureParser.java:112)
>   at 
> groovyjarjarasm.asm.signature.SignatureReader.parseType(SignatureReader.java:206)
>   at 
> groovyjarjarasm.asm.signature.SignatureReader.parseType(SignatureReader.java:235)
>   at 
> groovyjarjarasm.asm.signature.SignatureReader.accept(SignatureReader.java:114)
>   at 
> org.codehaus.groovy.ast.decompiled.MemberSignatureParser.createMethodNode(MemberSignatureParser.java:95)
>   at 
> org.codehaus.groovy.ast.decompiled.DecompiledClassNode.lazyInitMembers(DecompiledClassNode.java:195)
>   at 
> org.codehaus.groovy.ast.decompiled.DecompiledClassNode.getMethods(DecompiledClassNode.java:103)
>   at org.codehaus.groovy.ast.ClassNode.getMethods(ClassNode.java:399)
>   at 
> org.codehaus.groovy.classgen.AnnotationVisitor.checkIfMandatoryAnnotationValuesPassed(AnnotationVisitor.java:168)
>   at 
> org.codehaus.groovy.classgen.AnnotationVisitor.visit(AnnotationVisitor.java:80)
>   at 
> org.codehaus.groovy.classgen.ExtendedVerifier.visitAnnotation(ExtendedVerifier.java:311)
>   at 
> org.codehaus.groovy.classgen.ExtendedVerifier.visitAnnotations(ExtendedVerifier.java:157)
>   at 
> org.codehaus.groovy.classgen.ExtendedVerifier.visitConstructorOrMethod(ExtendedVerifier.java:112)
>   at 
> org.codehaus.groovy.classgen.ExtendedVerifier.visitMethod(ExtendedVerifier.java:108)
>   at org.codehaus.groovy.ast.ClassNode.visitContents(ClassNode.java:1103)
>   at 
> org.codehaus.groovy.classgen.ExtendedVerifier.visitClass(ExtendedVerifier.java:91)
>   at 
> org.codehaus.groovy.control.CompilationUnit$18.call(CompilationUnit.java:827)
>   at 
> org.codehaus.groovy.control.CompilationUnit.applyToPrimaryClassNodes(CompilationUnit.java:1087)
>   at 
> org.codehaus.groovy.control.CompilationUnit.doPhaseOperation(CompilationUnit.java:631)
>   at 
> org.codehaus.groovy.control.CompilationUnit.processPhaseOperations(CompilationUnit.java:609)
>   at 
> org.codehaus.groovy.control.CompilationUnit.compile(CompilationUnit.java:586)
>   at 
> org.codehaus.groovy.control.CompilationUnit.compile(CompilationUnit.java:565)
>   at 
> org.gradle.api.internal.tasks.compile.ApiGroovyCompiler.execute(ApiGroovyCompiler.java:179)
>   at 
> org.gradle.api.internal.tasks.compile.ApiGroovyCompiler.execute(ApiGroovyCompiler.java:57)
>   at 
> org.gradle.api.internal.tasks.compile.GroovyCompilerFactory$DaemonSideCompiler.execute(GroovyCompilerFactory.java:77)
>   at 
> org.gradle.api.internal.tasks.compile.GroovyCompilerFactory$DaemonSideCompiler.execute(GroovyCompilerFactory.java:65)
>   at 
> org.gradle.api.internal.tasks.compile.daemon.AbstractDaemonCompiler$CompilerCallable.call(AbstractDaemonCompiler.java:88)
>   at 
> 

[jira] [Commented] (GROOVY-8727) JDK 11 Compilation Failure: ClassVisitor.visitNestMemberExperimental throws UnsupportedOperationException

2018-09-02 Thread Dimitry Polivaev (JIRA)


[ 
https://issues.apache.org/jira/browse/GROOVY-8727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16601217#comment-16601217
 ] 

Dimitry Polivaev commented on GROOVY-8727:
--

The api version  used by ClassVisitors implemented by Groovy is defined in 
org.codehaus.groovy.control.CompilerConfiguration and set to 


{code:java}
ASM_API_VERSION = Opcodes.ASM6;
{code}


> JDK 11 Compilation Failure: ClassVisitor.visitNestMemberExperimental throws 
> UnsupportedOperationException 
> --
>
> Key: GROOVY-8727
> URL: https://issues.apache.org/jira/browse/GROOVY-8727
> Project: Groovy
>  Issue Type: Bug
>  Components: Compiler
>Affects Versions: 3.x, 2.5.1
>Reporter: Misagh Moayyed
>Priority: Major
>
> *Description:*
> Using JDK 11 and Gradle 4.9, the following compilation error is seen:
>  
> {code:java}
> > Task :core:cas-server-core-tickets:compileTestGroovy FAILED
> startup failed:
> General error during class generation: java.lang.UnsupportedOperationException
> java.lang.UnsupportedOperationException
>   at 
> groovyjarjarasm.asm.ClassVisitor.visitNestMemberExperimental(ClassVisitor.java:248)
>   at groovyjarjarasm.asm.ClassReader.accept(ClassReader.java:651)
>   at groovyjarjarasm.asm.ClassReader.accept(ClassReader.java:391)
>   at 
> org.codehaus.groovy.ast.decompiled.AsmDecompiler.parseClass(AsmDecompiler.java:83)
>   at 
> org.codehaus.groovy.control.ClassNodeResolver.findDecompiled(ClassNodeResolver.java:254)
>   at 
> org.codehaus.groovy.control.ClassNodeResolver.tryAsLoaderClassOrScript(ClassNodeResolver.java:192)
>   at 
> org.codehaus.groovy.control.ClassNodeResolver.findClassNode(ClassNodeResolver.java:172)
>   at 
> org.codehaus.groovy.control.ClassNodeResolver.resolveName(ClassNodeResolver.java:128)
>   at 
> org.codehaus.groovy.ast.decompiled.AsmReferenceResolver.resolveClassNullable(AsmReferenceResolver.java:59)
>   at 
> org.codehaus.groovy.ast.decompiled.AsmReferenceResolver.resolveClass(AsmReferenceResolver.java:46)
>   at 
> org.codehaus.groovy.ast.decompiled.TypeSignatureParser.visitEnd(TypeSignatureParser.java:112)
>   at 
> groovyjarjarasm.asm.signature.SignatureReader.parseType(SignatureReader.java:206)
>   at 
> groovyjarjarasm.asm.signature.SignatureReader.parseType(SignatureReader.java:235)
>   at 
> groovyjarjarasm.asm.signature.SignatureReader.accept(SignatureReader.java:114)
>   at 
> org.codehaus.groovy.ast.decompiled.MemberSignatureParser.createMethodNode(MemberSignatureParser.java:95)
>   at 
> org.codehaus.groovy.ast.decompiled.DecompiledClassNode.lazyInitMembers(DecompiledClassNode.java:195)
>   at 
> org.codehaus.groovy.ast.decompiled.DecompiledClassNode.getMethods(DecompiledClassNode.java:103)
>   at org.codehaus.groovy.ast.ClassNode.getMethods(ClassNode.java:399)
>   at 
> org.codehaus.groovy.classgen.AnnotationVisitor.checkIfMandatoryAnnotationValuesPassed(AnnotationVisitor.java:168)
>   at 
> org.codehaus.groovy.classgen.AnnotationVisitor.visit(AnnotationVisitor.java:80)
>   at 
> org.codehaus.groovy.classgen.ExtendedVerifier.visitAnnotation(ExtendedVerifier.java:311)
>   at 
> org.codehaus.groovy.classgen.ExtendedVerifier.visitAnnotations(ExtendedVerifier.java:157)
>   at 
> org.codehaus.groovy.classgen.ExtendedVerifier.visitConstructorOrMethod(ExtendedVerifier.java:112)
>   at 
> org.codehaus.groovy.classgen.ExtendedVerifier.visitMethod(ExtendedVerifier.java:108)
>   at org.codehaus.groovy.ast.ClassNode.visitContents(ClassNode.java:1103)
>   at 
> org.codehaus.groovy.classgen.ExtendedVerifier.visitClass(ExtendedVerifier.java:91)
>   at 
> org.codehaus.groovy.control.CompilationUnit$18.call(CompilationUnit.java:827)
>   at 
> org.codehaus.groovy.control.CompilationUnit.applyToPrimaryClassNodes(CompilationUnit.java:1087)
>   at 
> org.codehaus.groovy.control.CompilationUnit.doPhaseOperation(CompilationUnit.java:631)
>   at 
> org.codehaus.groovy.control.CompilationUnit.processPhaseOperations(CompilationUnit.java:609)
>   at 
> org.codehaus.groovy.control.CompilationUnit.compile(CompilationUnit.java:586)
>   at 
> org.codehaus.groovy.control.CompilationUnit.compile(CompilationUnit.java:565)
>   at 
> org.gradle.api.internal.tasks.compile.ApiGroovyCompiler.execute(ApiGroovyCompiler.java:179)
>   at 
> org.gradle.api.internal.tasks.compile.ApiGroovyCompiler.execute(ApiGroovyCompiler.java:57)
>   at 
> org.gradle.api.internal.tasks.compile.GroovyCompilerFactory$DaemonSideCompiler.execute(GroovyCompilerFactory.java:77)
>   at 
> org.gradle.api.internal.tasks.compile.GroovyCompilerFactory$DaemonSideCompiler.execute(GroovyCompilerFactory.java:65)
>   at 
> 

[jira] [Commented] (GROOVY-8727) JDK 11 Compilation Failure: ClassVisitor.visitNestMemberExperimental throws UnsupportedOperationException

2018-09-02 Thread Dimitry Polivaev (JIRA)


[ 
https://issues.apache.org/jira/browse/GROOVY-8727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16601216#comment-16601216
 ] 

Dimitry Polivaev commented on GROOVY-8727:
--

The problem comes because in asm 6.2.1 ClassVisitor method 
visitNestMemberExperimental checks that api version is not less than 
Opcodes.ASM7_EXPERIMENTAL = 17235968
{code:java}
   /** @deprecated */
@Deprecated
public void visitNestMemberExperimental(String nestMember) {
if (this.api < 17235968) {
throw new UnsupportedOperationException();
} else {
if (this.cv != null) {
this.cv.visitNestMemberExperimental(nestMember);
}

}
}
{code}
but the calling method ClassReader.accept(groovyjarjarasm.asm.ClassVisitor, 
groovyjarjarasm.asm.Attribute[], int) does not make any checks on it.
{code:java}
 if (nestMembersOffset != 0) {
fieldsCount = this.readUnsignedShort(nestMembersOffset);

for(methodsCount = nestMembersOffset + 2; fieldsCount-- > 0; 
methodsCount += 2) {

classVisitor.visitNestMemberExperimental(this.readClass(methodsCount, 
charBuffer));
}
}

{code}
It is rather ASM bug because ASM7_EXPERIMENTAL is considered experimental, so 
that fix should be probably implemented in asm.

But until it is fixed on any side, Groovy can not be used with Java 11. 
I have experienced this problem in freeplane 
([https://github.com/freeplane/freeplane/]) where some scripts can not be 
compiled when it runs under java 11.

> JDK 11 Compilation Failure: ClassVisitor.visitNestMemberExperimental throws 
> UnsupportedOperationException 
> --
>
> Key: GROOVY-8727
> URL: https://issues.apache.org/jira/browse/GROOVY-8727
> Project: Groovy
>  Issue Type: Bug
>  Components: Compiler
>Affects Versions: 3.x, 2.5.1
>Reporter: Misagh Moayyed
>Priority: Major
>
> *Description:*
> Using JDK 11 and Gradle 4.9, the following compilation error is seen:
>  
> {code:java}
> > Task :core:cas-server-core-tickets:compileTestGroovy FAILED
> startup failed:
> General error during class generation: java.lang.UnsupportedOperationException
> java.lang.UnsupportedOperationException
>   at 
> groovyjarjarasm.asm.ClassVisitor.visitNestMemberExperimental(ClassVisitor.java:248)
>   at groovyjarjarasm.asm.ClassReader.accept(ClassReader.java:651)
>   at groovyjarjarasm.asm.ClassReader.accept(ClassReader.java:391)
>   at 
> org.codehaus.groovy.ast.decompiled.AsmDecompiler.parseClass(AsmDecompiler.java:83)
>   at 
> org.codehaus.groovy.control.ClassNodeResolver.findDecompiled(ClassNodeResolver.java:254)
>   at 
> org.codehaus.groovy.control.ClassNodeResolver.tryAsLoaderClassOrScript(ClassNodeResolver.java:192)
>   at 
> org.codehaus.groovy.control.ClassNodeResolver.findClassNode(ClassNodeResolver.java:172)
>   at 
> org.codehaus.groovy.control.ClassNodeResolver.resolveName(ClassNodeResolver.java:128)
>   at 
> org.codehaus.groovy.ast.decompiled.AsmReferenceResolver.resolveClassNullable(AsmReferenceResolver.java:59)
>   at 
> org.codehaus.groovy.ast.decompiled.AsmReferenceResolver.resolveClass(AsmReferenceResolver.java:46)
>   at 
> org.codehaus.groovy.ast.decompiled.TypeSignatureParser.visitEnd(TypeSignatureParser.java:112)
>   at 
> groovyjarjarasm.asm.signature.SignatureReader.parseType(SignatureReader.java:206)
>   at 
> groovyjarjarasm.asm.signature.SignatureReader.parseType(SignatureReader.java:235)
>   at 
> groovyjarjarasm.asm.signature.SignatureReader.accept(SignatureReader.java:114)
>   at 
> org.codehaus.groovy.ast.decompiled.MemberSignatureParser.createMethodNode(MemberSignatureParser.java:95)
>   at 
> org.codehaus.groovy.ast.decompiled.DecompiledClassNode.lazyInitMembers(DecompiledClassNode.java:195)
>   at 
> org.codehaus.groovy.ast.decompiled.DecompiledClassNode.getMethods(DecompiledClassNode.java:103)
>   at org.codehaus.groovy.ast.ClassNode.getMethods(ClassNode.java:399)
>   at 
> org.codehaus.groovy.classgen.AnnotationVisitor.checkIfMandatoryAnnotationValuesPassed(AnnotationVisitor.java:168)
>   at 
> org.codehaus.groovy.classgen.AnnotationVisitor.visit(AnnotationVisitor.java:80)
>   at 
> org.codehaus.groovy.classgen.ExtendedVerifier.visitAnnotation(ExtendedVerifier.java:311)
>   at 
> org.codehaus.groovy.classgen.ExtendedVerifier.visitAnnotations(ExtendedVerifier.java:157)
>   at 
> org.codehaus.groovy.classgen.ExtendedVerifier.visitConstructorOrMethod(ExtendedVerifier.java:112)
>   at 
> org.codehaus.groovy.classgen.ExtendedVerifier.visitMethod(ExtendedVerifier.java:108)
>   at org.codehaus.groovy.ast.ClassNode.visitContents(ClassNode.java:1103)
>   at 

[jira] [Closed] (GROOVY-8771) global transformation declarations should move to META-INF/groovy instead of META-INF/services

2018-09-02 Thread Paul King (JIRA)


 [ 
https://issues.apache.org/jira/browse/GROOVY-8771?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Paul King closed GROOVY-8771.
-
Resolution: Won't Fix

As per dev mailing list, Andres prefers not to go ahead with this change at 
this stage. We can re-open if further impacts are discovered down the track.

> global transformation declarations should move to META-INF/groovy instead of 
> META-INF/services
> --
>
> Key: GROOVY-8771
> URL: https://issues.apache.org/jira/browse/GROOVY-8771
> Project: Groovy
>  Issue Type: Dependency upgrade
>Reporter: Paul King
>Assignee: Paul King
>Priority: Major
>
> We should still allow the old location if nothing is found at the new 
> location for backwards compatibility. This is similar to what we did for 
> {{source.Extensions}}.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (GROOVY-8771) global transformation declarations should move to META-INF/groovy instead of META-INF/services

2018-09-02 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/GROOVY-8771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16601181#comment-16601181
 ] 

ASF GitHub Bot commented on GROOVY-8771:


Github user paulk-asert closed the pull request at:

https://github.com/apache/groovy/pull/791


> global transformation declarations should move to META-INF/groovy instead of 
> META-INF/services
> --
>
> Key: GROOVY-8771
> URL: https://issues.apache.org/jira/browse/GROOVY-8771
> Project: Groovy
>  Issue Type: Dependency upgrade
>Reporter: Paul King
>Assignee: Paul King
>Priority: Major
>
> We should still allow the old location if nothing is found at the new 
> location for backwards compatibility. This is similar to what we did for 
> {{source.Extensions}}.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] groovy pull request #791: GROOVY-8771: global AST transformation declaration...

2018-09-02 Thread paulk-asert
Github user paulk-asert closed the pull request at:

https://github.com/apache/groovy/pull/791


---