[jira] [Resolved] (GROOVY-8867) Bump picocli to 3.7.0 from 3.6.0

2018-11-02 Thread Remko Popma (JIRA)


 [ 
https://issues.apache.org/jira/browse/GROOVY-8867?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Remko Popma resolved GROOVY-8867.
-
Resolution: Fixed

> Bump picocli to 3.7.0 from 3.6.0
> 
>
> Key: GROOVY-8867
> URL: https://issues.apache.org/jira/browse/GROOVY-8867
> Project: Groovy
>  Issue Type: Dependency upgrade
>  Components: command line processing
>Affects Versions: 2.5.3
>Reporter: Remko Popma
>Assignee: Remko Popma
>Priority: Major
> Fix For: 2.5.4
>
>
> CliBuilder-related: bump picocli to 3.7.0 from 3.6.0.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (GROOVY-8867) Bump picocli to 3.7.0 from 3.6.0

2018-11-02 Thread Remko Popma (JIRA)


 [ 
https://issues.apache.org/jira/browse/GROOVY-8867?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Remko Popma closed GROOVY-8867.
---

> Bump picocli to 3.7.0 from 3.6.0
> 
>
> Key: GROOVY-8867
> URL: https://issues.apache.org/jira/browse/GROOVY-8867
> Project: Groovy
>  Issue Type: Dependency upgrade
>  Components: command line processing
>Affects Versions: 2.5.3
>Reporter: Remko Popma
>Assignee: Remko Popma
>Priority: Major
> Fix For: 2.5.4
>
>
> CliBuilder-related: bump picocli to 3.7.0 from 3.6.0.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (GROOVY-8867) Bump picocli to 3.7.0 from 3.6.0

2018-11-02 Thread Remko Popma (JIRA)
Remko Popma created GROOVY-8867:
---

 Summary: Bump picocli to 3.7.0 from 3.6.0
 Key: GROOVY-8867
 URL: https://issues.apache.org/jira/browse/GROOVY-8867
 Project: Groovy
  Issue Type: Dependency upgrade
  Components: command line processing
Affects Versions: 2.5.3
Reporter: Remko Popma
Assignee: Remko Popma
 Fix For: 2.5.4


CliBuilder-related: bump picocli to 3.7.0 from 3.6.0.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (GROOVY-8866) Implement `GProperties` to handle properties file smartly

2018-11-02 Thread Daniel Sun (JIRA)


 [ 
https://issues.apache.org/jira/browse/GROOVY-8866?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Sun resolved GROOVY-8866.

   Resolution: Fixed
Fix Version/s: (was: 2.5.4)

Fixed by 
https://github.com/apache/groovy/commit/5de34ce58417ec48f0e1cdedfe78cb2600e9c913

> Implement `GProperties` to handle properties file smartly
> -
>
> Key: GROOVY-8866
> URL: https://issues.apache.org/jira/browse/GROOVY-8866
> Project: Groovy
>  Issue Type: New Feature
>Reporter: Daniel Sun
>Assignee: Daniel Sun
>Priority: Major
> Fix For: 3.0.0-alpha-4
>
>
> The `GProperties` supports interpolating in the values and importing other 
> properties in classpath



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] groovy pull request #818: GROOVY-8866: Implement `GProperties` to handle pro...

2018-11-02 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/groovy/pull/818


---


[jira] [Commented] (GROOVY-8866) Implement `GProperties` to handle properties file smartly

2018-11-02 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/GROOVY-8866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16673396#comment-16673396
 ] 

ASF GitHub Bot commented on GROOVY-8866:


Github user asfgit closed the pull request at:

https://github.com/apache/groovy/pull/818


> Implement `GProperties` to handle properties file smartly
> -
>
> Key: GROOVY-8866
> URL: https://issues.apache.org/jira/browse/GROOVY-8866
> Project: Groovy
>  Issue Type: New Feature
>Reporter: Daniel Sun
>Assignee: Daniel Sun
>Priority: Major
> Fix For: 3.0.0-alpha-4, 2.5.4
>
>
> The `GProperties` supports interpolating in the values and importing other 
> properties in classpath



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (GROOVY-8861) Simplify the switch for runtime groovydoc

2018-11-02 Thread Daniel Sun (JIRA)


 [ 
https://issues.apache.org/jira/browse/GROOVY-8861?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Sun resolved GROOVY-8861.

   Resolution: Fixed
Fix Version/s: 3.0.0-alpha-4

Fixed by 
https://github.com/apache/groovy/commit/57fe0c7731ffba88e4d06c5e212739941c97fda6

> Simplify the switch for runtime groovydoc
> -
>
> Key: GROOVY-8861
> URL: https://issues.apache.org/jira/browse/GROOVY-8861
> Project: Groovy
>  Issue Type: Improvement
>  Components: parser-antlr4
>Reporter: Daniel Sun
>Assignee: Daniel Sun
>Priority: Major
> Fix For: 3.0.0-alpha-4
>
>
> The Original switch for runtime groovydoc:
> {code:java}
> /**
>  * @Groovydoc
> {code}
> The simplified version will be:
> {code:java}
> /**@
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] groovy pull request #817: GROOVY-8861: Simplify the switch for runtime groov...

2018-11-02 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/groovy/pull/817


---


[jira] [Commented] (GROOVY-8861) Simplify the switch for runtime groovydoc

2018-11-02 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/GROOVY-8861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16673340#comment-16673340
 ] 

ASF GitHub Bot commented on GROOVY-8861:


Github user asfgit closed the pull request at:

https://github.com/apache/groovy/pull/817


> Simplify the switch for runtime groovydoc
> -
>
> Key: GROOVY-8861
> URL: https://issues.apache.org/jira/browse/GROOVY-8861
> Project: Groovy
>  Issue Type: Improvement
>  Components: parser-antlr4
>Reporter: Daniel Sun
>Assignee: Daniel Sun
>Priority: Major
>
> The Original switch for runtime groovydoc:
> {code:java}
> /**
>  * @Groovydoc
> {code}
> The simplified version will be:
> {code:java}
> /**@
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (GROOVY-8864) Backwards compatibility of traits

2018-11-02 Thread Paul King (JIRA)


 [ 
https://issues.apache.org/jira/browse/GROOVY-8864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Paul King resolved GROOVY-8864.
---
   Resolution: Fixed
 Assignee: Paul King
Fix Version/s: 2.5.4
   3.0.0-alpha-4

I have made our extra checks on generics not apply to traits. This retains the 
desired behavior from Groovy 2.4.  I think we should look to improving the 
underlying approach to achieve this behavior since it is relying on generics 
information existing within the helper class that wouldn't be allowed for Java. 
It isn't a problem with existing JDKs but could leave us exposed if the 
strictness of class checking changed in future versions.

> Backwards compatibility of traits
> -
>
> Key: GROOVY-8864
> URL: https://issues.apache.org/jira/browse/GROOVY-8864
> Project: Groovy
>  Issue Type: Task
>Affects Versions: 2.5.3
>Reporter: Paul King
>Assignee: Paul King
>Priority: Major
> Fix For: 3.0.0-alpha-4, 2.5.4
>
>
> In Groovy 2.4 we allow:
> {code}
> trait Foo {
>   static T get() { 
> ...
>   }
> }
> class Bar implements Foo {}
> assert Bar.getMethod("get").returnType.name == 'Bar'
> {code}
> This produces some useful type information in the generated class:
> {code}
> class Bar implements Foo { 
> ...
> static Bar get() {
> ((Foo$Trait$Helper.get(this)) as Bar)
> }
> ...
> }
> {code}
> It's a little strange in that a spurious generics type appears in the trait 
> helper class for 2.4 but we ignore it:
> {code}
> static java.lang.Object get(java.lang.Class $static$self) {
> ...
> }
> {code}
> In 2.5, we tightened this up to behave more like Java where you can't use a 
> class's generic type parameters in static methods or static fields. However, 
> a trait isn't a class but rather a mechanism for creating classes.
> This issue is to look at whether we can provide the 2.4 benefit of having 
> type information in the generated class but avoid any spurious generics info 
> appearing where it shouldn't.
> As some additional information, the following example shows that even in 2.4, 
> not all cases worked:
> {code}
> trait Foo {
>   static T get() { ... }
> }
> class Baz implements Foo {}
> def bz = new Baz()
> assert bz.getClass().getMethod("get").returnType == Object
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (GROOVY-8864) Backwards compatibility of traits

2018-11-02 Thread Paul King (JIRA)


 [ 
https://issues.apache.org/jira/browse/GROOVY-8864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Paul King updated GROOVY-8864:
--
Affects Version/s: 2.5.3

> Backwards compatibility of traits
> -
>
> Key: GROOVY-8864
> URL: https://issues.apache.org/jira/browse/GROOVY-8864
> Project: Groovy
>  Issue Type: Task
>Affects Versions: 2.5.3
>Reporter: Paul King
>Assignee: Paul King
>Priority: Major
> Fix For: 3.0.0-alpha-4, 2.5.4
>
>
> In Groovy 2.4 we allow:
> {code}
> trait Foo {
>   static T get() { 
> ...
>   }
> }
> class Bar implements Foo {}
> assert Bar.getMethod("get").returnType.name == 'Bar'
> {code}
> This produces some useful type information in the generated class:
> {code}
> class Bar implements Foo { 
> ...
> static Bar get() {
> ((Foo$Trait$Helper.get(this)) as Bar)
> }
> ...
> }
> {code}
> It's a little strange in that a spurious generics type appears in the trait 
> helper class for 2.4 but we ignore it:
> {code}
> static java.lang.Object get(java.lang.Class $static$self) {
> ...
> }
> {code}
> In 2.5, we tightened this up to behave more like Java where you can't use a 
> class's generic type parameters in static methods or static fields. However, 
> a trait isn't a class but rather a mechanism for creating classes.
> This issue is to look at whether we can provide the 2.4 benefit of having 
> type information in the generated class but avoid any spurious generics info 
> appearing where it shouldn't.
> As some additional information, the following example shows that even in 2.4, 
> not all cases worked:
> {code}
> trait Foo {
>   static T get() { ... }
> }
> class Baz implements Foo {}
> def bz = new Baz()
> assert bz.getClass().getMethod("get").returnType == Object
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)