[GitHub] [groovy] eric-milles edited a comment on pull request #1299: GROOVY-7304: handle private field access from closure for ++x and x++

2020-07-06 Thread GitBox
eric-milles edited a comment on pull request #1299: URL: https://github.com/apache/groovy/pull/1299#issuecomment-654564905 I'll have a look. I think the closure class is not having static compilation applied when the containing method is annotated. This is a bit like

[GitHub] [groovy] eric-milles edited a comment on pull request #1299: GROOVY-7304: handle private field access from closure for ++x and x++

2020-07-06 Thread GitBox
eric-milles edited a comment on pull request #1299: URL: https://github.com/apache/groovy/pull/1299#issuecomment-654564905 I'll have a look. I think the closure class is not having static compilation applied when the containing method is annotated. This is a bit like

[GitHub] [groovy] eric-milles commented on pull request #1299: GROOVY-7304: handle private field access from closure for ++x and x++

2020-07-06 Thread GitBox
eric-milles commented on pull request #1299: URL: https://github.com/apache/groovy/pull/1299#issuecomment-654564905 I'll have a look This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [groovy] paulk-asert commented on pull request #1299: GROOVY-7304: handle private field access from closure for ++x and x++

2020-07-06 Thread GitBox
paulk-asert commented on pull request #1299: URL: https://github.com/apache/groovy/pull/1299#issuecomment-654559298 This looks close to me. When I have @CS just on the method like in Jochen's example it still fails, but @CS on the class and it works.

[jira] [Updated] (GROOVY-9422) @CompileStatic non-static inner class instantiation in closure

2020-07-06 Thread Paul King (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-9422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paul King updated GROOVY-9422: -- Summary: @CompileStatic non-static inner class instantiation in closure (was: @CompileStatic

[jira] [Updated] (GROOVY-9422) @CompileStatic non-statin inner class instantiation in closure

2020-07-06 Thread Eric Milles (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-9422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Milles updated GROOVY-9422: Affects Version/s: 3.0.0 > @CompileStatic non-statin inner class instantiation in closure >

[jira] [Updated] (GROOVY-9422) @CompileStatic non-statin inner class instantiation in closure

2020-07-06 Thread Eric Milles (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-9422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Milles updated GROOVY-9422: Affects Version/s: (was: 3.0.1) 2.3.4 > @CompileStatic non-statin

[jira] [Updated] (GROOVY-9422) @CompileStatic non-statin inner class instantiation in closure

2020-07-06 Thread Eric Milles (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-9422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Milles updated GROOVY-9422: Affects Version/s: 2.4.0 > @CompileStatic non-statin inner class instantiation in closure >

[jira] [Updated] (GROOVY-9422) @CompileStatic non-statin inner class instantiation in closure

2020-07-06 Thread Eric Milles (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-9422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Milles updated GROOVY-9422: Affects Version/s: 2.5.0 > @CompileStatic non-statin inner class instantiation in closure >

[GitHub] [groovy] eric-milles opened a new pull request #1301: GROOVY-9422: non-static inner class constructor call sets type of "this"

2020-07-06 Thread GitBox
eric-milles opened a new pull request #1301: URL: https://github.com/apache/groovy/pull/1301 https://issues.apache.org/jira/browse/GROOVY-9422 https://issues.apache.org/jira/browse/GROOVY-6904 This is an automated message

[jira] [Assigned] (GROOVY-9422) @CompileStatic non-statin inner class instantiation in closure

2020-07-06 Thread Eric Milles (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-9422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Milles reassigned GROOVY-9422: --- Assignee: Eric Milles > @CompileStatic non-statin inner class instantiation in closure >

[jira] [Commented] (GROOVY-9471) NCDFE: nested class in middle class via static import resolution

2020-07-06 Thread Eric Milles (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-9471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17152320#comment-17152320 ] Eric Milles commented on GROOVY-9471: - Is "import static Outer.Inner" supposed to work in Groovy? I

[jira] [Resolved] (GROOVY-9611) Reflexive access to class attributes broken in Groovy 3

2020-07-06 Thread Eric Milles (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-9611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Milles resolved GROOVY-9611. - Fix Version/s: 3.0.5 Resolution: Fixed > Reflexive access to class attributes broken in

[jira] [Assigned] (GROOVY-9611) Reflexive access to class attributes broken in Groovy 3

2020-07-06 Thread Eric Milles (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-9611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Milles reassigned GROOVY-9611: --- Assignee: Paul King > Reflexive access to class attributes broken in Groovy 3 >

[jira] [Commented] (GROOVY-9613) java.lang.IllegalAccessError when accessing a protected method in the for-loop with Java 8

2020-07-06 Thread Eric Milles (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-9613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17152301#comment-17152301 ] Eric Milles commented on GROOVY-9613: - Is there a smaller example of this? Is GrailsApp subclassed

[jira] [Commented] (GROOVY-9611) Reflexive access to class attributes broken in Groovy 3

2020-07-06 Thread Gildas Morvan (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-9611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17152101#comment-17152101 ] Gildas Morvan commented on GROOVY-9611: --- [~paulk] Yes the bug is fixed with 3.0.5-SNAPSHOT. Thank

[jira] [Commented] (GROOVY-9611) Reflexive access to class attributes broken in Groovy 3

2020-07-06 Thread Paul King (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-9611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17152095#comment-17152095 ] Paul King commented on GROOVY-9611: --- https://groovy.apache.org/download.html look under Maven

[jira] [Resolved] (GROOVY-9620) MetaClassImpl uses findPropertyInClassHierarchy inefficiently

2020-07-06 Thread Paul King (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-9620?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paul King resolved GROOVY-9620. --- Fix Version/s: 3.0.5 4.0.0-alpha-1 Resolution: Fixed Proposed PR merged.

[GitHub] [groovy] paulk-asert commented on pull request #1300: GROOVY-9620: do not loop over findPropertyInClassHierarchy

2020-07-06 Thread GitBox
paulk-asert commented on pull request #1300: URL: https://github.com/apache/groovy/pull/1300#issuecomment-654306257 Merged, thanks! This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [groovy] asfgit closed pull request #1300: GROOVY-9620: do not loop over findPropertyInClassHierarchy

2020-07-06 Thread GitBox
asfgit closed pull request #1300: URL: https://github.com/apache/groovy/pull/1300 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Commented] (GROOVY-9611) Reflexive access to class attributes broken in Groovy 3

2020-07-06 Thread Gildas Morvan (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-9611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17152085#comment-17152085 ] Gildas Morvan commented on GROOVY-9611: --- [~paulk] Where can I find 3.0.5-SNAPSHOT? > Reflexive

[jira] [Resolved] (GROOVY-9622) Bump checkstyle to 8.34

2020-07-06 Thread Paul King (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-9622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paul King resolved GROOVY-9622. --- Fix Version/s: 3.0.5 4.0.0-alpha-1 Resolution: Fixed > Bump checkstyle to

[jira] [Resolved] (GROOVY-9623) Bump Jackson version to 2.11.1

2020-07-06 Thread Paul King (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-9623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paul King resolved GROOVY-9623. --- Fix Version/s: 3.0.5 4.0.0-alpha-1 Resolution: Fixed > Bump Jackson

[jira] [Resolved] (GROOVY-9625) Bump spotbugs/plugin to 4.0.6/4.4.4

2020-07-06 Thread Paul King (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-9625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paul King resolved GROOVY-9625. --- Fix Version/s: 3.0.5 4.0.0-alpha-1 Resolution: Fixed > Bump

[jira] [Resolved] (GROOVY-9624) Bump Codenarc to 1.6

2020-07-06 Thread Paul King (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-9624?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paul King resolved GROOVY-9624. --- Fix Version/s: 3.0.5 4.0.0-alpha-1 Resolution: Fixed > Bump Codenarc to

[jira] [Resolved] (GROOVY-9626) Bump rat to 0.7.0

2020-07-06 Thread Paul King (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-9626?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paul King resolved GROOVY-9626. --- Fix Version/s: 3.0.5 4.0.0-alpha-1 Resolution: Fixed > Bump rat to 0.7.0

[jira] [Resolved] (GROOVY-9627) Bump picocli to 4.4.0

2020-07-06 Thread Paul King (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-9627?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paul King resolved GROOVY-9627. --- Fix Version/s: 3.0.5 4.0.0-alpha-1 Resolution: Fixed > Bump picocli to

[jira] [Commented] (GROOVY-9627) Bump picocli to 4.4.0

2020-07-06 Thread Paul King (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-9627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17151957#comment-17151957 ] Paul King commented on GROOVY-9627: --- A breaking change if you are relying on the exact format of error

[jira] [Updated] (GROOVY-9627) Bump picocli to 4.4.0

2020-07-06 Thread Paul King (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-9627?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paul King updated GROOVY-9627: -- Labels: breaking (was: ) > Bump picocli to 4.4.0 > - > > Key:

[jira] [Created] (GROOVY-9627) Bump picocli to 4.4.0

2020-07-06 Thread Paul King (Jira)
Paul King created GROOVY-9627: - Summary: Bump picocli to 4.4.0 Key: GROOVY-9627 URL: https://issues.apache.org/jira/browse/GROOVY-9627 Project: Groovy Issue Type: Dependency upgrade

[jira] [Updated] (GROOVY-9611) Reflexive access to class attributes broken in Groovy 3

2020-07-06 Thread Paul King (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-9611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paul King updated GROOVY-9611: -- Description: Since Groovy 3, the reflexive access to Groovy class attributes from Java is broken.

[jira] [Commented] (GROOVY-9611) Reflexive access to class attributes broken in Groovy 3

2020-07-06 Thread Gildas Morvan (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-9611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17151930#comment-17151930 ] Gildas Morvan commented on GROOVY-9611: --- [~paulk] Thank you I'll try that asap.  > Reflexive

[jira] [Comment Edited] (GROOVY-9611) Reflexive access to class attributes broken in Groovy 3

2020-07-06 Thread Paul King (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-9611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17151926#comment-17151926 ] Paul King edited comment on GROOVY-9611 at 7/6/20, 10:11 AM: - [Gildas|#G]

[jira] [Comment Edited] (GROOVY-9611) Reflexive access to class attributes broken in Groovy 3

2020-07-06 Thread Paul King (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-9611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17151926#comment-17151926 ] Paul King edited comment on GROOVY-9611 at 7/6/20, 10:10 AM: -

[jira] [Commented] (GROOVY-9611) Reflexive access to class attributes broken in Groovy 3

2020-07-06 Thread Paul King (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-9611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17151926#comment-17151926 ] Paul King commented on GROOVY-9611: --- [~PVffR7dEbZuA!#G] There are changes already committed in

[jira] [Created] (GROOVY-9626) Bump rat to 0.7.0

2020-07-06 Thread Paul King (Jira)
Paul King created GROOVY-9626: - Summary: Bump rat to 0.7.0 Key: GROOVY-9626 URL: https://issues.apache.org/jira/browse/GROOVY-9626 Project: Groovy Issue Type: Dependency upgrade

[jira] [Created] (GROOVY-9625) Bump spotbugs/plugin to 4.0.6/4.4.4

2020-07-06 Thread Paul King (Jira)
Paul King created GROOVY-9625: - Summary: Bump spotbugs/plugin to 4.0.6/4.4.4 Key: GROOVY-9625 URL: https://issues.apache.org/jira/browse/GROOVY-9625 Project: Groovy Issue Type: Dependency

[jira] [Created] (GROOVY-9624) Bump Codenarc to 1.6

2020-07-06 Thread Paul King (Jira)
Paul King created GROOVY-9624: - Summary: Bump Codenarc to 1.6 Key: GROOVY-9624 URL: https://issues.apache.org/jira/browse/GROOVY-9624 Project: Groovy Issue Type: Dependency upgrade

[jira] [Created] (GROOVY-9623) Bump Jackson version to 2.11.1

2020-07-06 Thread Paul King (Jira)
Paul King created GROOVY-9623: - Summary: Bump Jackson version to 2.11.1 Key: GROOVY-9623 URL: https://issues.apache.org/jira/browse/GROOVY-9623 Project: Groovy Issue Type: Dependency upgrade

[jira] [Commented] (GROOVY-9611) Reflexive access to class attributes broken in Groovy 3

2020-07-06 Thread Gildas Morvan (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-9611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17151908#comment-17151908 ] Gildas Morvan commented on GROOVY-9611: --- [~paulk] I am not sure to understand your last comment?

[jira] [Created] (GROOVY-9622) Bump checksty

2020-07-06 Thread Paul King (Jira)
Paul King created GROOVY-9622: - Summary: Bump checksty Key: GROOVY-9622 URL: https://issues.apache.org/jira/browse/GROOVY-9622 Project: Groovy Issue Type: Dependency upgrade

[jira] [Updated] (GROOVY-9622) Bump checkstyle to 8.34

2020-07-06 Thread Paul King (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-9622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paul King updated GROOVY-9622: -- Summary: Bump checkstyle to 8.34 (was: Bump checksty) > Bump checkstyle to 8.34 >

[jira] [Assigned] (GROOVY-9622) Bump checkstyle to 8.34

2020-07-06 Thread Paul King (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-9622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paul King reassigned GROOVY-9622: - Assignee: Paul King > Bump checkstyle to 8.34 > --- > >