[jira] [Updated] (GROOVY-11263) Analyze dead code

2023-12-31 Thread Daniel Sun (Jira)


 [ 
https://issues.apache.org/jira/browse/GROOVY-11263?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Sun updated GROOVY-11263:

Description: 
Groovy allows dead code after {{throw}}, {{return}}, {{break}} and 
{{continue}}, e.g.

{code:java}
def m() {
   return
   def a = 1
}
{code}

It's better to avoid such dead code.


  was:
Groovy allows dead code after {{return}}, {{break}} and {{continue}}, e.g.

{code:java}
def m() {
   return
   def a = 1
}
{code}

It's better to avoid such dead code.



> Analyze dead code
> -
>
> Key: GROOVY-11263
> URL: https://issues.apache.org/jira/browse/GROOVY-11263
> Project: Groovy
>  Issue Type: Improvement
>Reporter: Daniel Sun
>Priority: Major
>  Labels: breaking_change
> Fix For: 5.x
>
>
> Groovy allows dead code after {{throw}}, {{return}}, {{break}} and 
> {{continue}}, e.g.
> {code:java}
> def m() {
>return
>def a = 1
> }
> {code}
> It's better to avoid such dead code.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (GROOVY-11264) Bump jarjar to 1.13.1

2023-12-31 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/GROOVY-11264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801500#comment-17801500
 ] 

ASF GitHub Bot commented on GROOVY-11264:
-

daniellansun commented on PR #2024:
URL: https://github.com/apache/groovy/pull/2024#issuecomment-1873133471

   `com.eed3si9n.jarjar.JarJarTask` is missing in jarjar 1.13.1




> Bump jarjar to 1.13.1
> -
>
> Key: GROOVY-11264
> URL: https://issues.apache.org/jira/browse/GROOVY-11264
> Project: Groovy
>  Issue Type: Dependency upgrade
>Reporter: Daniel Sun
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] GROOVY-11264: Bump jarjar to 1.13.1 [groovy]

2023-12-31 Thread via GitHub


daniellansun commented on PR #2024:
URL: https://github.com/apache/groovy/pull/2024#issuecomment-1873133471

   `com.eed3si9n.jarjar.JarJarTask` is missing in jarjar 1.13.1


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (GROOVY-11264) Bump jarjar to 1.13.1

2023-12-31 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/GROOVY-11264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801499#comment-17801499
 ] 

ASF GitHub Bot commented on GROOVY-11264:
-

daniellansun commented on PR #2024:
URL: https://github.com/apache/groovy/pull/2024#issuecomment-1873127529

   Let's check if the latest jarjar still leaves empty META-INF/services files.
   
   
https://github.com/apache/groovy/blob/80e92ec31a6afe2d8b1260a1452b698fbec9c963/versions.properties#L34




> Bump jarjar to 1.13.1
> -
>
> Key: GROOVY-11264
> URL: https://issues.apache.org/jira/browse/GROOVY-11264
> Project: Groovy
>  Issue Type: Dependency upgrade
>Reporter: Daniel Sun
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] GROOVY-11264: Bump jarjar to 1.13.1 [groovy]

2023-12-31 Thread via GitHub


daniellansun commented on PR #2024:
URL: https://github.com/apache/groovy/pull/2024#issuecomment-1873127529

   Let's check if the latest jarjar still leaves empty META-INF/services files.
   
   
https://github.com/apache/groovy/blob/80e92ec31a6afe2d8b1260a1452b698fbec9c963/versions.properties#L34


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (GROOVY-11264) Bump jarjar to 1.13.1

2023-12-31 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/GROOVY-11264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801498#comment-17801498
 ] 

ASF GitHub Bot commented on GROOVY-11264:
-

daniellansun opened a new pull request, #2024:
URL: https://github.com/apache/groovy/pull/2024

   https://issues.apache.org/jira/browse/GROOVY-11264
   




> Bump jarjar to 1.13.1
> -
>
> Key: GROOVY-11264
> URL: https://issues.apache.org/jira/browse/GROOVY-11264
> Project: Groovy
>  Issue Type: Dependency upgrade
>Reporter: Daniel Sun
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (GROOVY-11264) Bump jarjar to 1.13.1

2023-12-31 Thread Daniel Sun (Jira)
Daniel Sun created GROOVY-11264:
---

 Summary: Bump jarjar to 1.13.1
 Key: GROOVY-11264
 URL: https://issues.apache.org/jira/browse/GROOVY-11264
 Project: Groovy
  Issue Type: Dependency upgrade
Reporter: Daniel Sun






--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (GROOVY-11263) Analyze dead code

2023-12-31 Thread Daniel Sun (Jira)


 [ 
https://issues.apache.org/jira/browse/GROOVY-11263?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Sun updated GROOVY-11263:

Fix Version/s: 5.x

> Analyze dead code
> -
>
> Key: GROOVY-11263
> URL: https://issues.apache.org/jira/browse/GROOVY-11263
> Project: Groovy
>  Issue Type: Improvement
>Reporter: Daniel Sun
>Priority: Major
>  Labels: breaking_change
> Fix For: 5.x
>
>
> Groovy allows dead code after {{return}}, {{break}} and {{continue}}, e.g.
> {code:java}
> def m() {
>return
>def a = 1
> }
> {code}
> It's better to avoid such dead code.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (GROOVY-11263) Analyze dead code

2023-12-31 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/GROOVY-11263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801496#comment-17801496
 ] 

ASF GitHub Bot commented on GROOVY-11263:
-

daniellansun commented on code in PR #2023:
URL: https://github.com/apache/groovy/pull/2023#discussion_r1438949628


##
src/main/java/org/codehaus/groovy/classgen/DeadCodeAnalyzer.java:
##
@@ -0,0 +1,68 @@
+/*
+ *  Licensed to the Apache Software Foundation (ASF) under one
+ *  or more contributor license agreements.  See the NOTICE file
+ *  distributed with this work for additional information
+ *  regarding copyright ownership.  The ASF licenses this file
+ *  to you under the Apache License, Version 2.0 (the
+ *  "License"); you may not use this file except in compliance
+ *  with the License.  You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ *  Unless required by applicable law or agreed to in writing,
+ *  software distributed under the License is distributed on an
+ *  "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ *  KIND, either express or implied.  See the License for the
+ *  specific language governing permissions and limitations
+ *  under the License.
+ */
+package org.codehaus.groovy.classgen;
+
+import org.codehaus.groovy.ast.ClassCodeVisitorSupport;
+import org.codehaus.groovy.ast.stmt.BlockStatement;
+import org.codehaus.groovy.ast.stmt.BreakStatement;
+import org.codehaus.groovy.ast.stmt.ContinueStatement;
+import org.codehaus.groovy.ast.stmt.ReturnStatement;
+import org.codehaus.groovy.ast.stmt.Statement;
+import org.codehaus.groovy.control.SourceUnit;
+
+/**
+ * Analyze AST for dead code
+ *
+ * @since 5.0.0
+ */
+public class DeadCodeAnalyzer extends ClassCodeVisitorSupport {
+
+private final SourceUnit sourceUnit;
+
+public DeadCodeAnalyzer(final SourceUnit sourceUnit) {
+this.sourceUnit = sourceUnit;
+}
+
+@Override
+protected SourceUnit getSourceUnit() {
+return sourceUnit;

Review Comment:
   The method `org.codehaus.groovy.ast.ClassCodeVisitorSupport#addError` needs 
source unit, I use `addError` to collect and report errors.
   
   ```
   @Override
   public void addError(final String error, final ASTNode node) {
   getSourceUnit().addErrorAndContinue(new SyntaxException(error + 
'\n', node));
   }
   ```





> Analyze dead code
> -
>
> Key: GROOVY-11263
> URL: https://issues.apache.org/jira/browse/GROOVY-11263
> Project: Groovy
>  Issue Type: Improvement
>Reporter: Daniel Sun
>Priority: Major
>  Labels: breaking_change
>
> Groovy allows dead code after {{return}}, {{break}} and {{continue}}, e.g.
> {code:java}
> def m() {
>return
>def a = 1
> }
> {code}
> It's better to avoid such dead code.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] GROOVY-11263: Analyze dead code [groovy]

2023-12-31 Thread via GitHub


daniellansun commented on code in PR #2023:
URL: https://github.com/apache/groovy/pull/2023#discussion_r1438949628


##
src/main/java/org/codehaus/groovy/classgen/DeadCodeAnalyzer.java:
##
@@ -0,0 +1,68 @@
+/*
+ *  Licensed to the Apache Software Foundation (ASF) under one
+ *  or more contributor license agreements.  See the NOTICE file
+ *  distributed with this work for additional information
+ *  regarding copyright ownership.  The ASF licenses this file
+ *  to you under the Apache License, Version 2.0 (the
+ *  "License"); you may not use this file except in compliance
+ *  with the License.  You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ *  Unless required by applicable law or agreed to in writing,
+ *  software distributed under the License is distributed on an
+ *  "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ *  KIND, either express or implied.  See the License for the
+ *  specific language governing permissions and limitations
+ *  under the License.
+ */
+package org.codehaus.groovy.classgen;
+
+import org.codehaus.groovy.ast.ClassCodeVisitorSupport;
+import org.codehaus.groovy.ast.stmt.BlockStatement;
+import org.codehaus.groovy.ast.stmt.BreakStatement;
+import org.codehaus.groovy.ast.stmt.ContinueStatement;
+import org.codehaus.groovy.ast.stmt.ReturnStatement;
+import org.codehaus.groovy.ast.stmt.Statement;
+import org.codehaus.groovy.control.SourceUnit;
+
+/**
+ * Analyze AST for dead code
+ *
+ * @since 5.0.0
+ */
+public class DeadCodeAnalyzer extends ClassCodeVisitorSupport {
+
+private final SourceUnit sourceUnit;
+
+public DeadCodeAnalyzer(final SourceUnit sourceUnit) {
+this.sourceUnit = sourceUnit;
+}
+
+@Override
+protected SourceUnit getSourceUnit() {
+return sourceUnit;

Review Comment:
   The method `org.codehaus.groovy.ast.ClassCodeVisitorSupport#addError` needs 
source unit, I use `addError` to collect and report errors.
   
   ```
   @Override
   public void addError(final String error, final ASTNode node) {
   getSourceUnit().addErrorAndContinue(new SyntaxException(error + 
'\n', node));
   }
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (GROOVY-11263) Analyze dead code

2023-12-31 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/GROOVY-11263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801490#comment-17801490
 ] 

ASF GitHub Bot commented on GROOVY-11263:
-

blackdrag commented on code in PR #2023:
URL: https://github.com/apache/groovy/pull/2023#discussion_r1438940188


##
src/main/java/org/codehaus/groovy/classgen/DeadCodeAnalyzer.java:
##
@@ -0,0 +1,68 @@
+/*
+ *  Licensed to the Apache Software Foundation (ASF) under one
+ *  or more contributor license agreements.  See the NOTICE file
+ *  distributed with this work for additional information
+ *  regarding copyright ownership.  The ASF licenses this file
+ *  to you under the Apache License, Version 2.0 (the
+ *  "License"); you may not use this file except in compliance
+ *  with the License.  You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ *  Unless required by applicable law or agreed to in writing,
+ *  software distributed under the License is distributed on an
+ *  "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ *  KIND, either express or implied.  See the License for the
+ *  specific language governing permissions and limitations
+ *  under the License.
+ */
+package org.codehaus.groovy.classgen;
+
+import org.codehaus.groovy.ast.ClassCodeVisitorSupport;
+import org.codehaus.groovy.ast.stmt.BlockStatement;
+import org.codehaus.groovy.ast.stmt.BreakStatement;
+import org.codehaus.groovy.ast.stmt.ContinueStatement;
+import org.codehaus.groovy.ast.stmt.ReturnStatement;
+import org.codehaus.groovy.ast.stmt.Statement;
+import org.codehaus.groovy.control.SourceUnit;
+
+/**
+ * Analyze AST for dead code
+ *
+ * @since 5.0.0
+ */
+public class DeadCodeAnalyzer extends ClassCodeVisitorSupport {
+
+private final SourceUnit sourceUnit;
+
+public DeadCodeAnalyzer(final SourceUnit sourceUnit) {
+this.sourceUnit = sourceUnit;
+}
+
+@Override
+protected SourceUnit getSourceUnit() {
+return sourceUnit;

Review Comment:
   why do you need the source unit? I think there is also a conceptional 
mistake. I may be wrong though, but do we not reuse the Verifier for multiple 
source units? If yes, then having the source unit in the constructor there is 
wrong. If you really need the source unit you should use a setter in case of 
the Verifier I think





> Analyze dead code
> -
>
> Key: GROOVY-11263
> URL: https://issues.apache.org/jira/browse/GROOVY-11263
> Project: Groovy
>  Issue Type: Improvement
>Reporter: Daniel Sun
>Priority: Major
>  Labels: breaking_change
>
> Groovy allows dead code after {{return}}, {{break}} and {{continue}}, e.g.
> {code:java}
> def m() {
>return
>def a = 1
> }
> {code}
> It's better to avoid such dead code.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] GROOVY-11263: Analyze dead code [groovy]

2023-12-31 Thread via GitHub


blackdrag commented on code in PR #2023:
URL: https://github.com/apache/groovy/pull/2023#discussion_r1438940188


##
src/main/java/org/codehaus/groovy/classgen/DeadCodeAnalyzer.java:
##
@@ -0,0 +1,68 @@
+/*
+ *  Licensed to the Apache Software Foundation (ASF) under one
+ *  or more contributor license agreements.  See the NOTICE file
+ *  distributed with this work for additional information
+ *  regarding copyright ownership.  The ASF licenses this file
+ *  to you under the Apache License, Version 2.0 (the
+ *  "License"); you may not use this file except in compliance
+ *  with the License.  You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ *  Unless required by applicable law or agreed to in writing,
+ *  software distributed under the License is distributed on an
+ *  "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ *  KIND, either express or implied.  See the License for the
+ *  specific language governing permissions and limitations
+ *  under the License.
+ */
+package org.codehaus.groovy.classgen;
+
+import org.codehaus.groovy.ast.ClassCodeVisitorSupport;
+import org.codehaus.groovy.ast.stmt.BlockStatement;
+import org.codehaus.groovy.ast.stmt.BreakStatement;
+import org.codehaus.groovy.ast.stmt.ContinueStatement;
+import org.codehaus.groovy.ast.stmt.ReturnStatement;
+import org.codehaus.groovy.ast.stmt.Statement;
+import org.codehaus.groovy.control.SourceUnit;
+
+/**
+ * Analyze AST for dead code
+ *
+ * @since 5.0.0
+ */
+public class DeadCodeAnalyzer extends ClassCodeVisitorSupport {
+
+private final SourceUnit sourceUnit;
+
+public DeadCodeAnalyzer(final SourceUnit sourceUnit) {
+this.sourceUnit = sourceUnit;
+}
+
+@Override
+protected SourceUnit getSourceUnit() {
+return sourceUnit;

Review Comment:
   why do you need the source unit? I think there is also a conceptional 
mistake. I may be wrong though, but do we not reuse the Verifier for multiple 
source units? If yes, then having the source unit in the constructor there is 
wrong. If you really need the source unit you should use a setter in case of 
the Verifier I think



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (GROOVY-11263) Analyze dead code

2023-12-31 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/GROOVY-11263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801471#comment-17801471
 ] 

ASF GitHub Bot commented on GROOVY-11263:
-

daniellansun opened a new pull request, #2023:
URL: https://github.com/apache/groovy/pull/2023

   https://issues.apache.org/jira/browse/GROOVY-11263




> Analyze dead code
> -
>
> Key: GROOVY-11263
> URL: https://issues.apache.org/jira/browse/GROOVY-11263
> Project: Groovy
>  Issue Type: Improvement
>Reporter: Daniel Sun
>Priority: Major
>  Labels: breaking_change
>
> Groovy allows dead code after {{return}}, {{break}} and {{continue}}, e.g.
> {code:java}
> def m() {
>return
>def a = 1
> }
> {code}
> It's better to avoid such dead code.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (GROOVY-11263) Analyze dead code

2023-12-31 Thread Daniel Sun (Jira)


 [ 
https://issues.apache.org/jira/browse/GROOVY-11263?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Sun updated GROOVY-11263:

Labels: breaking_change  (was: )

> Analyze dead code
> -
>
> Key: GROOVY-11263
> URL: https://issues.apache.org/jira/browse/GROOVY-11263
> Project: Groovy
>  Issue Type: Improvement
>Reporter: Daniel Sun
>Priority: Major
>  Labels: breaking_change
>
> Groovy allows dead code after {{return}}, {{break}} and {{continue}}, e.g.
> {code:java}
> def m() {
>return
>def a = 1
> }
> {code}
> It's better to avoid such dead code.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (GROOVY-11263) Analyze dead code

2023-12-31 Thread Daniel Sun (Jira)


[ 
https://issues.apache.org/jira/browse/GROOVY-11263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801469#comment-17801469
 ] 

Daniel Sun commented on GROOVY-11263:
-

[~blackdrag] We could use the following code to skip ;-)

{code:java}
if (true) return
// some other code
{code}


> Analyze dead code
> -
>
> Key: GROOVY-11263
> URL: https://issues.apache.org/jira/browse/GROOVY-11263
> Project: Groovy
>  Issue Type: Improvement
>Reporter: Daniel Sun
>Priority: Major
>
> Groovy allows dead code after {{return}}, {{break}} and {{continue}}, e.g.
> {code:java}
> def m() {
>return
>def a = 1
> }
> {code}
> It's better to avoid such dead code.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (GROOVY-11263) Analyze dead code

2023-12-31 Thread Daniel Sun (Jira)


 [ 
https://issues.apache.org/jira/browse/GROOVY-11263?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Sun updated GROOVY-11263:

Description: 
Groovy allows dead code after {{return}}, {{break}} and {{continue}}, e.g.

{code:java}
def m() {
   return
   def a = 1
}
{code}

It's better to avoid such dead code.


  was:
Groovy allows dead code after {{return}}, e.g.

{code:java}
def m() {
   return
   def a = 1
}
{code}

It's better to avoid such dead code.



> Analyze dead code
> -
>
> Key: GROOVY-11263
> URL: https://issues.apache.org/jira/browse/GROOVY-11263
> Project: Groovy
>  Issue Type: Improvement
>Reporter: Daniel Sun
>Priority: Major
>
> Groovy allows dead code after {{return}}, {{break}} and {{continue}}, e.g.
> {code:java}
> def m() {
>return
>def a = 1
> }
> {code}
> It's better to avoid such dead code.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (GROOVY-11263) Analyze dead code

2023-12-31 Thread Jochen Theodorou (Jira)


[ 
https://issues.apache.org/jira/browse/GROOVY-11263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801466#comment-17801466
 ] 

Jochen Theodorou commented on GROOVY-11263:
---

[~daniel_sun] "It's better to avoid such dead code." I agree that it does not 
make sense here and that in general you do not want to have that. But I do find 
it quite nice to be able to just "return" when testing out things and not 
having to comment out all the code

> Analyze dead code
> -
>
> Key: GROOVY-11263
> URL: https://issues.apache.org/jira/browse/GROOVY-11263
> Project: Groovy
>  Issue Type: Improvement
>Reporter: Daniel Sun
>Priority: Major
>
> Groovy allows dead code after {{return}}, e.g.
> {code:java}
> def m() {
>return
>def a = 1
> }
> {code}
> It's better to avoid such dead code.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (GROOVY-11263) Analyze dead code

2023-12-31 Thread Daniel Sun (Jira)
Daniel Sun created GROOVY-11263:
---

 Summary: Analyze dead code
 Key: GROOVY-11263
 URL: https://issues.apache.org/jira/browse/GROOVY-11263
 Project: Groovy
  Issue Type: Improvement
Reporter: Daniel Sun


Groovy allows dead code after {{return}}, e.g.

{code:java}
def m() {
   return
   def a = 1
}
{code}

It's better to avoid such dead code.




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (GROOVY-11138) Bump gradle to 8.5

2023-12-31 Thread Daniel Sun (Jira)


[ 
https://issues.apache.org/jira/browse/GROOVY-11138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801449#comment-17801449
 ] 

Daniel Sun commented on GROOVY-11138:
-

https://github.com/apache/groovy/commit/6e8b11fca9f956a8291e9da7dcbd675cd84db285

Waiting for the release of asciidoctor-gradle 4.0

> Bump gradle to 8.5
> --
>
> Key: GROOVY-11138
> URL: https://issues.apache.org/jira/browse/GROOVY-11138
> Project: Groovy
>  Issue Type: Dependency upgrade
>Reporter: Daniel Sun
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] (GROOVY-11138) Bump gradle to 8.5

2023-12-31 Thread Daniel Sun (Jira)


[ https://issues.apache.org/jira/browse/GROOVY-11138 ]


Daniel Sun deleted comment on GROOVY-11138:
-

was (Author: daniel_sun):
https://github.com/apache/groovy/actions/runs/5701869495/job/15452991059

{code:java}
FAILURE: Build failed with an exception.

* What went wrong:
Could not determine the dependencies of task ':test'.
> Could not resolve all task dependencies for configuration 
> ':testRuntimeClasspath'.
   > No variants of project : match the consumer attributes:
   - Configuration ':grapesRuntimeElements' variant classes declares a 
library for use during runtime, compatible with Java 11, and its dependencies 
declared externally:
   - Incompatible because this component declares a component, 
preferably in the form of class files and the consumer needed a component, 
packaged as a jar
   - Other compatible attributes:
   - Doesn't say anything about org.apache.groovy.internal 
(required 'true')
   - Doesn't say anything about its target Java environment 
(preferred optimized for standard JVMs)
   - Configuration ':grapesRuntimeElements' variant resources declares a 
library for use during runtime, compatible with Java 11, and its dependencies 
declared externally:
   - Incompatible because this component declares a component, 
preferably only the resources files and the consumer needed a component, 
packaged as a jar
   - Other compatible attributes:
   - Doesn't say anything about org.apache.groovy.internal 
(required 'true')
   - Doesn't say anything about its target Java environment 
(preferred optimized for standard JVMs)

* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
> Get more help at https://help.gradle.org.

BUILD FAILED in 1m 19s

Publishing build scan...
https://ge.apache.org/s/ukzvepmkdll6u

Error: Process completed with exit code 1.
{code}


> Bump gradle to 8.5
> --
>
> Key: GROOVY-11138
> URL: https://issues.apache.org/jira/browse/GROOVY-11138
> Project: Groovy
>  Issue Type: Dependency upgrade
>Reporter: Daniel Sun
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (GROOVY-11138) Bump gradle to 8.5

2023-12-31 Thread Daniel Sun (Jira)


 [ 
https://issues.apache.org/jira/browse/GROOVY-11138?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Sun updated GROOVY-11138:

Summary: Bump gradle to 8.5  (was: Bump gradle to 8.2.1)

> Bump gradle to 8.5
> --
>
> Key: GROOVY-11138
> URL: https://issues.apache.org/jira/browse/GROOVY-11138
> Project: Groovy
>  Issue Type: Dependency upgrade
>Reporter: Daniel Sun
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)