paulk-asert commented on PR #1730:
URL: https://github.com/apache/groovy/pull/1730#issuecomment-1161563104
I quite like the idea. I also played around with putting the path in the
frame title instead of the label:
```
frame = swing.frame(title: "Groovy Object Browser: $path", location:
sandipchitale commented on PR #1730:
URL: https://github.com/apache/groovy/pull/1730#issuecomment-1161813439
I think there is more room in the label. But it will eventually get
truncated. I could make it wrap, actually not sure why it does not wrap as it
is Html. A tool tip (html title) wil
sandipchitale commented on PR #1730:
URL: https://github.com/apache/groovy/pull/1730#issuecomment-1161935157
Something like this:
The user can select the path from the
justinchuch opened a new pull request, #1731:
URL: https://github.com/apache/groovy/pull/1731
## Issue:
PackageHelperImpl#getPackageNames would not be able to find and return
the package names if the package path or filename of the jar contains
plus signs due to the behavior of U
sandipchitale commented on PR #1730:
URL: https://github.com/apache/groovy/pull/1730#issuecomment-1162440613
I went ahead and submitted the two commits. I used Alt-Double-Click instead
o Ctrl-Double-Click because the Ctrl key is also used for extending the
selection. Please pick and choose
sonatype-lift[bot] commented on code in PR #1730:
URL: https://github.com/apache/groovy/pull/1730#discussion_r903156123
##
subprojects/groovy-console/src/main/groovy/groovy/console/ui/ObjectBrowser.groovy:
##
@@ -239,6 +258,13 @@ class ObjectBrowser {
}
}
+vo
paulk-asert merged PR #1731:
URL: https://github.com/apache/groovy/pull/1731
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@g
paulk-asert commented on PR #1731:
URL: https://github.com/apache/groovy/pull/1731#issuecomment-1162885399
Looks good - merged!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific commen
paulk-asert commented on PR #1727:
URL: https://github.com/apache/groovy/pull/1727#issuecomment-1163796664
LGTM. As you will have seen in the code (but for the benefit of others
searching here later) you can provide a `groovy.sanitized.stacktraces` system
property in the meantime (or for an
paulk-asert commented on PR #1727:
URL: https://github.com/apache/groovy/pull/1727#issuecomment-1163799633
Actually, I have just recalled a related much earlier request: #256
(GROOVY-7756) which wants to tighten the exclusion list. I'll write an email
and see if anyone else has feedback bef
paulk-asert closed pull request #1730: Show path to current level in object
browser header. Show 'class name … instance' when starting path is not
specified.
URL: https://github.com/apache/groovy/pull/1730
--
This is an automated message from the Apache Git Service.
To respond to the message
paulk-asert commented on PR #1730:
URL: https://github.com/apache/groovy/pull/1730#issuecomment-1164471716
Merged. Thanks again!
Just on master for now. I did a little more refactoring to try to reduce
duplication and improve the API. It seems to work for me but if you wanted to
try it o
sandipchitale commented on PR #1730:
URL: https://github.com/apache/groovy/pull/1730#issuecomment-1164740913
@paulk-asert Thanks for merging and making corrections to my possible silly
mistakes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
sandipchitale commented on PR #1730:
URL: https://github.com/apache/groovy/pull/1730#issuecomment-1164966996
Works for me on master. Works great.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
paulk-asert commented on PR #1730:
URL: https://github.com/apache/groovy/pull/1730#issuecomment-1165294691
@sandipchitale No silly mistakes, I was just finessing slightly with an eye
on maintenance and consistency.
--
This is an automated message from the Apache Git Service.
To respond to
paulk-asert commented on PR #1727:
URL: https://github.com/apache/groovy/pull/1727#issuecomment-1165295996
Merged, thanks! I created this issue to track the details: GROOVY-10665.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
paulk-asert closed pull request #1727: StackTraceUtils: Add 'jdk.internal' to
the list of ignored packages
URL: https://github.com/apache/groovy/pull/1727
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
eric-milles opened a new pull request, #1732:
URL: https://github.com/apache/groovy/pull/1732
Adds support for assignment of optional to arrays or collections -- and by
extension an "iterator()" method and for-each iteration. Does not support
spread arguments (aka "def list = [*optional]"
eric-milles commented on PR #1732:
URL: https://github.com/apache/groovy/pull/1732#issuecomment-1165715088
You can also do this, but I don't think it is an improvement over
"optional.map(String::length).orElse(null)" or
"optional.orElse(null)?.length()":
```groovy
def nothing = Option
eric-milles commented on PR #1732:
URL: https://github.com/apache/groovy/pull/1732#issuecomment-1165725099
And this kind of thing is not supported without `getAt(int)` or
`getAt(Integer)`:
```groovy
def opt = Optional.of('')
def (String x) = opt
assert x == ''
```
--
This i
eric-milles opened a new pull request, #1733:
URL: https://github.com/apache/groovy/pull/1733
`IntStream`, `LongStream`, and `DoubleStream` do not have safe default for
`getAt(int)`. They could have `getAt(IntRange)` added safely. I don't think
`getAt(Range)` or `getAt(EmptyRange)` of `ge
eric-milles commented on PR #1733:
URL: https://github.com/apache/groovy/pull/1733#issuecomment-119486
https://issues.apache.org/jira/browse/GROOVY-10666 discusses the possibility
of supporting multiple-assignment for streams via `getAt(IntRange)`
--
This is an automated message from
daniellansun commented on PR #1733:
URL: https://github.com/apache/groovy/pull/1733#issuecomment-1166698028
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubs
eric-milles commented on PR #1732:
URL: https://github.com/apache/groovy/pull/1732#issuecomment-1167664770
@paulk-asert I agree, it seems the extension method `Optional
collect(Optional,Closure)` is not that valuable. If deprecated, it would
not resolve as an extension, which would then ca
eric-milles merged PR #1732:
URL: https://github.com/apache/groovy/pull/1732
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@g
paulk-asert commented on PR #1732:
URL: https://github.com/apache/groovy/pull/1732#issuecomment-1167957937
> @paulk-asert I agree, it seems the extension method `Optional
collect(Optional,Closure)` is not that valuable. If deprecated, it would
not resolve as an extension, which would then c
eric-milles merged PR #1733:
URL: https://github.com/apache/groovy/pull/1733
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@g
naveensrinivasan opened a new pull request, #1735:
URL: https://github.com/apache/groovy/pull/1735
This should help with keeping the GitHub actions updated on new releases.
This will also help with keeping it secure.
Dependabot helps in keeping the supply chain secure
https://docs.gi
paulk-asert merged PR #1725:
URL: https://github.com/apache/groovy/pull/1725
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@g
daniellansun commented on PR #1734:
URL: https://github.com/apache/groovy/pull/1734#issuecomment-1173035140
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscrib
paulk-asert opened a new pull request, #1736:
URL: https://github.com/apache/groovy/pull/1736
… IOOB exception on files with CR only
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
paulk-asert merged PR #1734:
URL: https://github.com/apache/groovy/pull/1734
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@g
daniellansun commented on PR #1736:
URL: https://github.com/apache/groovy/pull/1736#issuecomment-1173126188
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscrib
paulk-asert merged PR #1736:
URL: https://github.com/apache/groovy/pull/1736
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@g
paulk-asert commented on PR #1725:
URL: https://github.com/apache/groovy/pull/1725#issuecomment-1173196942
Merged. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
paulk-asert commented on PR #1726:
URL: https://github.com/apache/groovy/pull/1726#issuecomment-1174953790
We would not likely include indentation recommendations in this document.
Groovy as a language, like Java, is somewhat whitespace agnostic, i.e. it
supports multiple indentation practi
paulk-asert closed pull request #1726: Add indention
URL: https://github.com/apache/groovy/pull/1726
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: not
paulk-asert merged PR #1735:
URL: https://github.com/apache/groovy/pull/1735
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@g
paulk-asert commented on PR #1735:
URL: https://github.com/apache/groovy/pull/1735#issuecomment-1174954743
Merged, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
dependabot[bot] opened a new pull request, #1737:
URL: https://github.com/apache/groovy/pull/1737
Bumps [actions/checkout](https://github.com/actions/checkout) from 2 to 3.
Release notes
Sourced from https://github.com/actions/checkout/releases";>actions/checkout's
releases.
dependabot[bot] opened a new pull request, #1738:
URL: https://github.com/apache/groovy/pull/1738
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact)
from 1 to 3.
Release notes
Sourced from https://github.com/actions/upload-artifact/releases";>actions/upload
dependabot[bot] opened a new pull request, #1739:
URL: https://github.com/apache/groovy/pull/1739
Bumps
[gradle/wrapper-validation-action](https://github.com/gradle/wrapper-validation-action)
from 1.0.3 to 1.0.4.
Release notes
Sourced from https://github.com/gradle/wrapper-validat
dependabot[bot] opened a new pull request, #1740:
URL: https://github.com/apache/groovy/pull/1740
Bumps [actions/setup-java](https://github.com/actions/setup-java) from 1 to
3.
Release notes
Sourced from https://github.com/actions/setup-java/releases";>actions/setup-java's
release
vanillajonathan commented on PR #1726:
URL: https://github.com/apache/groovy/pull/1726#issuecomment-1175289424
This leads to the Groovy community applying indention inconsistently.
Developers are free to indent however they see fit, however I think it would
serve the Groovy community well
daniellansun merged PR #1737:
URL: https://github.com/apache/groovy/pull/1737
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@
daniellansun merged PR #1738:
URL: https://github.com/apache/groovy/pull/1738
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@
daniellansun merged PR #1740:
URL: https://github.com/apache/groovy/pull/1740
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@
daniellansun merged PR #1739:
URL: https://github.com/apache/groovy/pull/1739
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@
paulk-asert commented on PR #1726:
URL: https://github.com/apache/groovy/pull/1726#issuecomment-1176980188
Sometimes consistency is nice, sometimes inclusivity is nice.
OO vs functional style, dynamic vs static, tabs vs spaces.
As a general rule Groovy tries to be agnostic.
For those
vanillajonathan commented on PR #1726:
URL: https://github.com/apache/groovy/pull/1726#issuecomment-1177258198
The nice thing with a style guide is that it is just a guide, not rules. so
even with indention defined in the style guide developers would still be free
to use whatever they want.
paulk-asert opened a new pull request, #1741:
URL: https://github.com/apache/groovy/pull/1741
…browser
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mai
paulk-asert commented on PR #1741:
URL: https://github.com/apache/groovy/pull/1741#issuecomment-1177826918
I may yet change `Tuple2>` to just `List`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
paulk-asert merged PR #1741:
URL: https://github.com/apache/groovy/pull/1741
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@g
eric-milles opened a new pull request, #1742:
URL: https://github.com/apache/groovy/pull/1742
As discussed under 8965 and 10668, check LUB type first for common method
(fixes `testMultipleInstanceOf4`). Duck-typing (`testMultipleInstanceOf1` and
`testMultipleInstanceOf5`) is incomplete; cu
sandipchitale opened a new pull request, #1743:
URL: https://github.com/apache/groovy/pull/1743
- Hovering over cells shows a tooltip.
- CTRL+Right Click (BUTTON 3) copies the value to the clipboard.
--
This is an automated message from the Apache Git Service.
To respond to the message,
paulk-asert opened a new pull request, #1744:
URL: https://github.com/apache/groovy/pull/1744
…'' correctly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
paulk-asert commented on PR #1743:
URL: https://github.com/apache/groovy/pull/1743#issuecomment-1180469148
The tooltip stuff looks great. I am wondering whether a simple right-click
=> "copy cell" popup menu might be more consistent since we have such actions
in other places. Thoughts? Let
eric-milles commented on PR #1742:
URL: https://github.com/apache/groovy/pull/1742#issuecomment-1180578513
Updated to support duck-typing scenario. I'm still trying to figure how to
support 6790, 8142 and `(x instanceof Map || x instanceof List) ? x.size() : 1`
at the same time.
htt
sonatype-lift[bot] commented on code in PR #1742:
URL: https://github.com/apache/groovy/pull/1742#discussion_r918148023
##
src/main/java/org/codehaus/groovy/transform/stc/StaticTypeCheckingVisitor.java:
##
@@ -4702,37 +4703,36 @@ protected MethodNode findMethodOrFail(final Expre
eric-milles commented on code in PR #1742:
URL: https://github.com/apache/groovy/pull/1742#discussion_r918218290
##
src/main/java/org/codehaus/groovy/transform/stc/StaticTypeCheckingVisitor.java:
##
@@ -4702,37 +4703,36 @@ protected MethodNode findMethodOrFail(final Expression
sonatype-lift[bot] commented on code in PR #1742:
URL: https://github.com/apache/groovy/pull/1742#discussion_r918218361
##
src/main/java/org/codehaus/groovy/transform/stc/StaticTypeCheckingVisitor.java:
##
@@ -4702,37 +4703,36 @@ protected MethodNode findMethodOrFail(final Expre
eric-milles commented on PR #1742:
URL: https://github.com/apache/groovy/pull/1742#issuecomment-1180716117
STC still does not produce an error for `o instanceof Map || o instanceof
List ? o.entrySet() : null` -- this is not a new issue.
--
This is an automated message from the Apache Git
eric-milles commented on PR #1742:
URL: https://github.com/apache/groovy/pull/1742#issuecomment-1180735207
Another thing that surprised me is that LUB(Integer,Double) is Double, not
Number. I'm not sure why this is the case:
https://github.com/apache/groovy/blob/master/src/main/java/org/co
sandipchitale commented on PR #1743:
URL: https://github.com/apache/groovy/pull/1743#issuecomment-1180872636
Thanks. I like the use of the popup menu better. I do now know SwingBuilder
very well and could not figure out how to set up the popup menu on the table.
If you are familiar and have
paulk-asert commented on PR #1743:
URL: https://github.com/apache/groovy/pull/1743#issuecomment-1181228980
The tooltip part of the PR has been merged. Thanks!
I'll try to have a look at the popup menu idea in the next few days.
--
This is an automated message from the Apache Git Service
paulk-asert closed pull request #1743: Tooltip and CTRL+BUTTON3 click to copy
cell value to clipboard.
URL: https://github.com/apache/groovy/pull/1743
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
blackdrag commented on PR #1742:
URL: https://github.com/apache/groovy/pull/1742#issuecomment-1181626022
> Another thing that surprised me is that LUB(Integer,Double) is Double, not
Number. I'm not sure why this is the case:
https://github.com/apache/groovy/blob/master/src/main/java/org/cod
eric-milles merged PR #1742:
URL: https://github.com/apache/groovy/pull/1742
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@g
paulk-asert merged PR #1744:
URL: https://github.com/apache/groovy/pull/1744
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@g
paulk-asert merged PR #1745:
URL: https://github.com/apache/groovy/pull/1745
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@g
paulk-asert commented on PR #1745:
URL: https://github.com/apache/groovy/pull/1745#issuecomment-1182712098
Merged. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
yaccz closed pull request #256: Tighten the filtering prefixes
URL: https://github.com/apache/groovy/pull/256
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-
yaccz commented on PR #256:
URL: https://github.com/apache/groovy/pull/256#issuecomment-1182847708
Hi. I have read the mailing list just now and while I can't comment on the
solution since I only skimmed that due to not working with java anymore, I have
to commend @paulk-asert 's analysis o
eric-milles closed pull request #1269: GROOVY-7971: do not save instanceof
types under logical or
URL: https://github.com/apache/groovy/pull/1269
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
paulk-asert commented on PR #1746:
URL: https://github.com/apache/groovy/pull/1746#issuecomment-1184219784
I haven't yet created a constant for "_SKIPPABLE_ANNOTATIONS" and similarly
there is a private but not public constant for "_RECORD_HEADER". We could make
public constants or usage cou
daniellansun commented on PR #1746:
URL: https://github.com/apache/groovy/pull/1746#issuecomment-1185046328
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscrib
sandipchitale opened a new pull request, #1747:
URL: https://github.com/apache/groovy/pull/1747
I took a crack at porting OB and ASTB changes to GROOVY_3_0_x. I assumed
that work for the next 3.0.X release is being done on GROOVY_3_0_x . It is
possible I made some mistakes. Local testing s
sonatype-lift[bot] commented on code in PR #1747:
URL: https://github.com/apache/groovy/pull/1747#discussion_r922569792
##
src/test-resources/groovy/bugs/groovy9236/Main.groovy:
##
@@ -0,0 +1,31 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
sonatype-lift[bot] commented on code in PR #1747:
URL: https://github.com/apache/groovy/pull/1747#discussion_r922569875
##
src/test/groovy/DoWhileLoopTest.groovy:
##
@@ -18,6 +18,8 @@
*/
package groovy
+import groovy.test.GroovyTestCase
+
class DoWhileLoopTest extends Groo
sonatype-lift[bot] commented on code in PR #1747:
URL: https://github.com/apache/groovy/pull/1747#discussion_r922569947
##
src/test/groovy/IllegalAccessTests.groovy:
##
@@ -0,0 +1,88 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor
sonatype-lift[bot] commented on code in PR #1747:
URL: https://github.com/apache/groovy/pull/1747#discussion_r922570001
##
src/test/groovy/RegularExpressionsTest.groovy:
##
@@ -372,6 +394,7 @@ class RegularExpressionsTest extends GroovyTestCase {
assert matcher[0][1] ==
sonatype-lift[bot] commented on code in PR #1747:
URL: https://github.com/apache/groovy/pull/1747#discussion_r922570072
##
src/test/groovy/bugs/Groovy9589.groovy:
##
@@ -0,0 +1,68 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor lic
sonatype-lift[bot] commented on code in PR #1747:
URL: https://github.com/apache/groovy/pull/1747#discussion_r922570241
##
src/test/groovy/transform/stc/GenericsSTCTest.groovy:
##
@@ -1824,28 +4217,45 @@ assert result == 'ok'
'''
}
-static class MyList extend
sonatype-lift[bot] commented on code in PR #1747:
URL: https://github.com/apache/groovy/pull/1747#discussion_r922570145
##
src/test/groovy/lang/MetaClassRegistryTest.groovy:
##
@@ -28,7 +30,7 @@ class MetaClassRegistryTest extends GroovyTestCase {
static initSize
stati
sonatype-lift[bot] commented on code in PR #1747:
URL: https://github.com/apache/groovy/pull/1747#discussion_r922570332
##
src/test/org/codehaus/groovy/classgen/asm/sc/FieldsAndPropertiesStaticCompileTest.groovy:
##
@@ -535,24 +561,24 @@ import
org.codehaus.groovy.transform.sc.
sonatype-lift[bot] commented on code in PR #1747:
URL: https://github.com/apache/groovy/pull/1747#discussion_r922570423
##
src/test/org/codehaus/groovy/classgen/asm/sc/FieldsAndPropertiesStaticCompileTest.groovy:
##
@@ -759,33 +815,34 @@ import
org.codehaus.groovy.transform.sc.
sonatype-lift[bot] commented on code in PR #1747:
URL: https://github.com/apache/groovy/pull/1747#discussion_r922570687
##
src/test/org/codehaus/groovy/runtime/powerassert/AssertionTestUtil.groovy:
##
@@ -18,21 +18,26 @@
*/
package org.codehaus.groovy.runtime.powerassert
+i
sonatype-lift[bot] commented on code in PR #1747:
URL: https://github.com/apache/groovy/pull/1747#discussion_r922570811
##
subprojects/groovy-astbuilder/src/test/groovy/org/codehaus/groovy/ast/CodeVisitorSupportTest.groovy:
##
@@ -45,6 +48,7 @@ class CodeVisitorSupportTest exten
sonatype-lift[bot] commented on code in PR #1747:
URL: https://github.com/apache/groovy/pull/1747#discussion_r922570891
##
subprojects/groovy-groovydoc/src/test/groovy/org/codehaus/groovy/tools/groovydoc/testfiles/anno/Groovy.groovy:
##
@@ -0,0 +1,39 @@
+/*
+ * Licensed to the
sonatype-lift[bot] commented on code in PR #1747:
URL: https://github.com/apache/groovy/pull/1747#discussion_r922570982
##
subprojects/groovy-test/src/test/groovy/groovy/test/suite/ATestScriptThatsNoTestCase.groovy:
##
@@ -16,5 +16,7 @@
* specific language governing permissio
sonatype-lift[bot] commented on code in PR #1747:
URL: https://github.com/apache/groovy/pull/1747#discussion_r922571101
##
subprojects/parser-antlr4/src/test/resources/bugs/BUG-GROOVY-9433.groovy:
##
@@ -0,0 +1,19 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) unde
sonatype-lift[bot] commented on code in PR #1747:
URL: https://github.com/apache/groovy/pull/1747#discussion_r922571212
##
subprojects/parser-antlr4/src/test/resources/core/Comments_03x.groovy:
##
@@ -0,0 +1,23 @@
+#! /usr/bin/env nix-shell
+#! nix-shell -i groovy -p groovy
+#!
sonatype-lift[bot] commented on code in PR #1747:
URL: https://github.com/apache/groovy/pull/1747#discussion_r922571483
##
src/main/java/org/codehaus/groovy/antlr/AntlrParserPlugin.java:
##
@@ -1173,7 +1151,7 @@ private void verifyParameters(List parameters,
AST firstParameterN
sandipchitale opened a new pull request, #1748:
URL: https://github.com/apache/groovy/pull/1748
I took a crack at porting OB and ASTB changes to GROOVY_3_0_x. I assumed
that work for the next 3.0.X release is being done on GROOVY_3_0_x . It is
possible I made some mistakes. Local testing sh
sandipchitale closed pull request #1748: Post changes for drill-down
ObjectBrowser and use it in AST Browser.
URL: https://github.com/apache/groovy/pull/1748
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
sandipchitale commented on PR #1748:
URL: https://github.com/apache/groovy/pull/1748#issuecomment-1186019214
I filed a correct PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
sandipchitale closed pull request #1747: Post OB and ASTB changes to
GROOVY_3_0_x
URL: https://github.com/apache/groovy/pull/1747
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment
sandipchitale commented on PR #1747:
URL: https://github.com/apache/groovy/pull/1747#issuecomment-1186021941
Closed. Let me fix merge conflicts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
paulk-asert opened a new pull request, #1749:
URL: https://github.com/apache/groovy/pull/1749
…a phase of compilation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To uns
paulk-asert commented on PR #1746:
URL: https://github.com/apache/groovy/pull/1746#issuecomment-1188951542
Merged!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubs
201 - 300 of 4347 matches
Mail list logo
