[GitHub] groovy pull request #663: GROOVY-8471: Contents of META-INF/services/org.cod...

2018-02-13 Thread paulk-asert
GitHub user paulk-asert opened a pull request: https://github.com/apache/groovy/pull/663 GROOVY-8471: Contents of META-INF/services/org.codehaus.groovy.source… ….Extensions conflict with Maven/Jisaw You can merge this pull request into a Git repository by running: $ git

[GitHub] groovy pull request #659: GROOVY-8093: Final variable analysis broken within...

2018-02-06 Thread paulk-asert
GitHub user paulk-asert opened a pull request: https://github.com/apache/groovy/pull/659 GROOVY-8093: Final variable analysis broken within closure fields You can merge this pull request into a Git repository by running: $ git pull https://github.com/paulk-asert/groovy

[GitHub] groovy pull request #664: GROOVY-7956: Provide an AST transformation which i...

2018-02-19 Thread paulk-asert
GitHub user paulk-asert opened a pull request: https://github.com/apache/groovy/pull/664 GROOVY-7956: Provide an AST transformation which improves named param… …eter support You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] groovy pull request #:

2018-02-18 Thread paulk-asert
Github user paulk-asert commented on the pull request: https://github.com/apache/groovy/commit/9699e99483b8f53e4a77762225343a86ee3c4783#commitcomment-27642627 In src/main/java/org/apache/groovy/util/Maps.java: In src/main/java/org/apache/groovy/util/Maps.java on line 5802: Yes

[GitHub] groovy pull request #666: GROOVY-8480: org.codehaus.groovy.runtime.Extension...

2018-02-22 Thread paulk-asert
GitHub user paulk-asert opened a pull request: https://github.com/apache/groovy/pull/666 GROOVY-8480: org.codehaus.groovy.runtime.ExtensionModule should move … …to META-INF/groovy You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] groovy pull request #:

2018-02-23 Thread paulk-asert
Github user paulk-asert commented on the pull request: https://github.com/apache/groovy/commit/63fc0a4036538fcf329d3a5b104dd32aa56d2d56#commitcomment-27736777 In src/install/install-jdk.sh: In src/install/install-jdk.sh on line 1: It's missing an Apache header - but I just

[GitHub] groovy pull request #:

2018-02-23 Thread paulk-asert
Github user paulk-asert commented on the pull request: https://github.com/apache/groovy/commit/63fc0a4036538fcf329d3a5b104dd32aa56d2d56#commitcomment-27736578 In src/install/install-jdk.sh: In src/install/install-jdk.sh on line 1: fails RAT report ---

[GitHub] groovy pull request #:

2018-02-23 Thread paulk-asert
Github user paulk-asert commented on the pull request: https://github.com/apache/groovy/commit/63fc0a4036538fcf329d3a5b104dd32aa56d2d56#commitcomment-27736817 In src/install/install-jdk.sh: In src/install/install-jdk.sh on line 1: Just as a side note, it would be worth writing

[GitHub] groovy pull request #:

2018-02-18 Thread paulk-asert
Github user paulk-asert commented on the pull request: https://github.com/apache/groovy/commit/9699e99483b8f53e4a77762225343a86ee3c4783#commitcomment-27636375 In src/main/java/org/apache/groovy/util/Maps.java: In src/main/java/org/apache/groovy/util/Maps.java on line 5802: We

[GitHub] groovy pull request #:

2018-01-01 Thread paulk-asert
Github user paulk-asert commented on the pull request: https://github.com/apache/groovy/commit/a9cc446a9a3ee83e8be3faf14b61c24cfb441c6a#commitcomment-26576581 In buildSrc/src/main/groovy/org/codehaus/groovy/gradle/JarJarTask.groovy: In buildSrc/src/main/groovy/org/codehaus/groovy

[GitHub] groovy pull request #652: fix for: GROOVY-8430: @Field doesn't support final...

2018-01-02 Thread paulk-asert
GitHub user paulk-asert opened a pull request: https://github.com/apache/groovy/pull/652 fix for: GROOVY-8430: @Field doesn't support final fields You can merge this pull request into a Git repository by running: $ git pull https://github.com/paulk-asert/groovy groovy8430

[GitHub] groovy pull request #667: GROOVY-8379: Rework groovy-json FastStringUtils

2018-02-25 Thread paulk-asert
GitHub user paulk-asert opened a pull request: https://github.com/apache/groovy/pull/667 GROOVY-8379: Rework groovy-json FastStringUtils You can merge this pull request into a Git repository by running: $ git pull https://github.com/paulk-asert/groovy groovy8379

[GitHub] groovy pull request #760: GROOVY-8224: Stubs for classes implementing traits...

2018-06-19 Thread paulk-asert
GitHub user paulk-asert opened a pull request: https://github.com/apache/groovy/pull/760 GROOVY-8224: Stubs for classes implementing traits with fields don't … …include getters/setters You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] groovy pull request #780: GROOVY-8722: final modifier for non-abstract metho...

2018-08-05 Thread paulk-asert
GitHub user paulk-asert opened a pull request: https://github.com/apache/groovy/pull/780 GROOVY-8722: final modifier for non-abstract methods in traits is ign… …ored You can merge this pull request into a Git repository by running: $ git pull https://github.com/paulk-asert

[GitHub] groovy pull request #781: GROOVY-8732: @CompileStatic refers to private fiel...

2018-08-09 Thread paulk-asert
GitHub user paulk-asert opened a pull request: https://github.com/apache/groovy/pull/781 GROOVY-8732: @CompileStatic refers to private field in parent class Currently JavaBean style getters aren't recognised before some preliminary provisions are made for the case

[GitHub] groovy pull request #785: GROOVY-7330: Incorrect dynamic proxy creation from...

2018-08-17 Thread paulk-asert
GitHub user paulk-asert opened a pull request: https://github.com/apache/groovy/pull/785 GROOVY-7330: Incorrect dynamic proxy creation from map when there are… … default methods You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] groovy pull request #783: GROOVY-8748: CompileUnit could implement NodeMetaD...

2018-08-12 Thread paulk-asert
GitHub user paulk-asert opened a pull request: https://github.com/apache/groovy/pull/783 GROOVY-8748: CompileUnit could implement NodeMetaDataHandler to act a… …s a "global" node for metadata You can merge this pull request into a Git repository by running:

[GitHub] groovy pull request #787: GROOVY-8758: @WithReadLock in inner class of @Comp...

2018-08-20 Thread paulk-asert
GitHub user paulk-asert opened a pull request: https://github.com/apache/groovy/pull/787 GROOVY-8758: @WithReadLock in inner class of @CompileStatic class cau… …ses java.lang.VerifyError You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] groovy pull request #788: GROOVY-8757: Incorrect bytecode produced after com...

2018-08-25 Thread paulk-asert
GitHub user paulk-asert opened a pull request: https://github.com/apache/groovy/pull/788 GROOVY-8757: Incorrect bytecode produced after compiling class implem… …enting trait with generic method You can merge this pull request into a Git repository by running: $ git pull

[GitHub] groovy pull request #786: GROOVY-8753: Compiler error in STC: exception in p...

2018-08-17 Thread paulk-asert
GitHub user paulk-asert opened a pull request: https://github.com/apache/groovy/pull/786 GROOVY-8753: Compiler error in STC: exception in phase 'instruction s… …election' You can merge this pull request into a Git repository by running: $ git pull https://github.com/paulk

[GitHub] groovy pull request #776: GROOVY-8710: JAXB JDK9-11 compatibility for instal...

2018-07-24 Thread paulk-asert
GitHub user paulk-asert opened a pull request: https://github.com/apache/groovy/pull/776 GROOVY-8710: JAXB JDK9-11 compatibility for install You can merge this pull request into a Git repository by running: $ git pull https://github.com/paulk-asert/groovy groovy8710

[GitHub] groovy pull request #791: GROOVY-8771: global AST transformation declaration...

2018-09-02 Thread paulk-asert
Github user paulk-asert closed the pull request at: https://github.com/apache/groovy/pull/791 ---

[GitHub] groovy pull request #:

2018-09-07 Thread paulk-asert
Github user paulk-asert commented on the pull request: https://github.com/apache/groovy/commit/a7ebe87b8cb4ff7ce220a13af96788118d316006#commitcomment-30427238 In subprojects/groovy-test-junit5/build.gradle: In subprojects/groovy-test-junit5/build.gradle on line 28: Thanks

[GitHub] groovy pull request #791: GROOVY-8771: global AST transformation declaration...

2018-08-31 Thread paulk-asert
GitHub user paulk-asert opened a pull request: https://github.com/apache/groovy/pull/791 GROOVY-8771: global AST transformation declarations should move to ME… …TA-INF/groovy instead of META-INF/services You can merge this pull request into a Git repository by running

[GitHub] groovy pull request #792: GROOVY-8778: Cast short-hand breaks for empty map

2018-09-07 Thread paulk-asert
GitHub user paulk-asert opened a pull request: https://github.com/apache/groovy/pull/792 GROOVY-8778: Cast short-hand breaks for empty map You can merge this pull request into a Git repository by running: $ git pull https://github.com/paulk-asert/groovy groovy8778

[GitHub] groovy pull request #792: GROOVY-8778: Cast short-hand breaks for empty map

2018-09-07 Thread paulk-asert
Github user paulk-asert commented on a diff in the pull request: https://github.com/apache/groovy/pull/792#discussion_r216118264 --- Diff: subprojects/parser-antlr4/src/main/java/org/apache/groovy/parser/antlr4/AstBuilder.java --- @@ -2337,14 +2337,11 @@ public Expression

[GitHub] groovy pull request #792: GROOVY-8778: Cast short-hand breaks for empty map

2018-09-07 Thread paulk-asert
Github user paulk-asert commented on a diff in the pull request: https://github.com/apache/groovy/pull/792#discussion_r216115626 --- Diff: subprojects/parser-antlr4/src/main/java/org/apache/groovy/parser/antlr4/AstBuilder.java --- @@ -2337,14 +2337,11 @@ public Expression

[GitHub] groovy pull request #793: GROOVY-8780: Add `sha256` DGM

2018-09-07 Thread paulk-asert
Github user paulk-asert commented on a diff in the pull request: https://github.com/apache/groovy/pull/793#discussion_r216121214 --- Diff: src/main/java/org/codehaus/groovy/runtime/EncodingGroovyMethods.java --- @@ -389,6 +390,26 @@ public static String md5(byte[] self) throws

[GitHub] groovy pull request #793: GROOVY-8780: Add `sha256` DGM

2018-09-07 Thread paulk-asert
Github user paulk-asert commented on a diff in the pull request: https://github.com/apache/groovy/pull/793#discussion_r216121209 --- Diff: src/main/java/org/codehaus/groovy/runtime/EncodingGroovyMethods.java --- @@ -389,6 +390,26 @@ public static String md5(byte[] self) throws

[GitHub] groovy pull request #767: GROOVY-8233: Java stub generation incorrect for st...

2018-07-05 Thread paulk-asert
GitHub user paulk-asert opened a pull request: https://github.com/apache/groovy/pull/767 GROOVY-8233: Java stub generation incorrect for static properties of … …traits You can merge this pull request into a Git repository by running: $ git pull https://github.com/paulk

[GitHub] groovy pull request #772: GROOVY-8281: Final field is null in trait, but it ...

2018-07-10 Thread paulk-asert
GitHub user paulk-asert opened a pull request: https://github.com/apache/groovy/pull/772 GROOVY-8281: Final field is null in trait, but it has assigned value You can merge this pull request into a Git repository by running: $ git pull https://github.com/paulk-asert/groovy

[GitHub] groovy pull request #767: GROOVY-8233: Java stub generation incorrect for st...

2018-07-10 Thread paulk-asert
Github user paulk-asert closed the pull request at: https://github.com/apache/groovy/pull/767 ---

[GitHub] groovy pull request #773: GROOVY-8696: TypeWrapper leaks out of DecompiledCl...

2018-07-11 Thread paulk-asert
GitHub user paulk-asert opened a pull request: https://github.com/apache/groovy/pull/773 GROOVY-8696: TypeWrapper leaks out of DecompiledClassNode You can merge this pull request into a Git repository by running: $ git pull https://github.com/paulk-asert/groovy groovy8696

[GitHub] groovy pull request #775: GROOVY-8639: @Sortable annotation is not able to u...

2018-07-13 Thread paulk-asert
GitHub user paulk-asert opened a pull request: https://github.com/apache/groovy/pull/775 GROOVY-8639: @Sortable annotation is not able to use accessible paren… …t properties You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] groovy pull request #774: GROOVY-8282: Error while popping argument from ope...

2018-07-12 Thread paulk-asert
GitHub user paulk-asert opened a pull request: https://github.com/apache/groovy/pull/774 GROOVY-8282: Error while popping argument from operand stack tracker … …in class ...$Trait$Helper Bare named argument parameters are captured in a TupleExpression rather than

[GitHub] groovy pull request #655: GROOVY-8455: @TupleConstructor gives wrong orderin...

2018-01-22 Thread paulk-asert
GitHub user paulk-asert opened a pull request: https://github.com/apache/groovy/pull/655 GROOVY-8455: @TupleConstructor gives wrong ordering when includeSuper… …Fields is set You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] groovy pull request #673: GROOVY-8501: Switch internal details of @Immutable...

2018-03-08 Thread paulk-asert
GitHub user paulk-asert opened a pull request: https://github.com/apache/groovy/pull/673 GROOVY-8501: Switch internal details of @ImmutableBase existing const… …ructor validation You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] groovy pull request #:

2018-03-11 Thread paulk-asert
Github user paulk-asert commented on the pull request: https://github.com/apache/groovy/commit/ce256aab7653fa020ac323ef260d0c4a4cf25e44#commitcomment-28040924 I was hoping to have it out (for Apache voting) by now. I might still get that done before I hop on a plane tonight

[GitHub] groovy pull request #:

2018-03-15 Thread paulk-asert
Github user paulk-asert commented on the pull request: https://github.com/apache/groovy/commit/e154c3e560e998e158985316566c7e321579b193#commitcomment-28107242 In src/test/groovy/bugs/Groovy8439Bug.groovy: In src/test/groovy/bugs/Groovy8439Bug.groovy on line 22: It would

[GitHub] groovy pull request #:

2018-03-15 Thread paulk-asert
Github user paulk-asert commented on the pull request: https://github.com/apache/groovy/commit/3eb491cded846c352952cdb3a6fffed817e14741#commitcomment-28107251 In src/test/groovy/bugs/Groovy8439Bug.groovy: In src/test/groovy/bugs/Groovy8439Bug.groovy on line 50: It would

[GitHub] groovy pull request #:

2018-03-15 Thread paulk-asert
Github user paulk-asert commented on the pull request: https://github.com/apache/groovy/commit/3eb491cded846c352952cdb3a6fffed817e14741#commitcomment-28107275 In src/test/groovy/bugs/Groovy8439Bug.groovy: In src/test/groovy/bugs/Groovy8439Bug.groovy on line 50: The test passed

[GitHub] groovy pull request #:

2018-04-03 Thread paulk-asert
Github user paulk-asert commented on the pull request: https://github.com/apache/groovy/commit/f88d0122525cabf6bdf61ab051533f9983f352f1#commitcomment-28390910 In src/test/groovy/SerializableCompatibilityTest.groovy: In src/test/groovy/SerializableCompatibilityTest.groovy on line

[GitHub] groovy pull request #684: move commons-cli CliBuilder into its own subprojec...

2018-04-13 Thread paulk-asert
GitHub user paulk-asert opened a pull request: https://github.com/apache/groovy/pull/684 move commons-cli CliBuilder into its own subproject You can merge this pull request into a Git repository by running: $ git pull https://github.com/paulk-asert/groovy groovy-cli

[GitHub] groovy pull request #:

2018-04-13 Thread paulk-asert
Github user paulk-asert commented on the pull request: https://github.com/apache/groovy/commit/5443e87882f9b88169876f6d043ed54b5ae9023b#commitcomment-28576091 In src/main/java/org/codehaus/groovy/control/CompilerConfiguration.java: In src/main/java/org/codehaus/groovy/control

[GitHub] groovy pull request #:

2018-04-13 Thread paulk-asert
Github user paulk-asert commented on the pull request: https://github.com/apache/groovy/commit/5443e87882f9b88169876f6d043ed54b5ae9023b#commitcomment-28569181 In src/main/java/org/codehaus/groovy/control/CompilerConfiguration.java: In src/main/java/org/codehaus/groovy/control

[GitHub] groovy pull request #683: GROOVY-8539: Groovy fails to compile assignment op...

2018-04-11 Thread paulk-asert
GitHub user paulk-asert opened a pull request: https://github.com/apache/groovy/pull/683 GROOVY-8539: Groovy fails to compile assignment operators on boolean … …array You can merge this pull request into a Git repository by running: $ git pull https://github.com/paulk

[GitHub] groovy pull request #:

2018-04-24 Thread paulk-asert
Github user paulk-asert commented on the pull request: https://github.com/apache/groovy/commit/5443e87882f9b88169876f6d043ed54b5ae9023b#commitcomment-28711056 In src/main/java/org/codehaus/groovy/control/CompilerConfiguration.java: In src/main/java/org/codehaus/groovy/control

[GitHub] groovy pull request #678: GROOVY-8525: Binary compatibility issue for Groovy...

2018-03-30 Thread paulk-asert
GitHub user paulk-asert opened a pull request: https://github.com/apache/groovy/pull/678 GROOVY-8525: Binary compatibility issue for GroovyClassLoader between… … 2.4 vs later branches You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] groovy pull request #:

2018-03-30 Thread paulk-asert
Github user paulk-asert commented on the pull request: https://github.com/apache/groovy/commit/7e7b508c02bf35e72fca1efcb7cc0d8a4f25038a#commitcomment-28346403 In src/antlr/GroovyLexer.g4: In src/antlr/GroovyLexer.g4 on line 317: There is no doubt some merit to this approach

[GitHub] groovy pull request #:

2018-03-30 Thread paulk-asert
Github user paulk-asert commented on the pull request: https://github.com/apache/groovy/commit/7e7b508c02bf35e72fca1efcb7cc0d8a4f25038a#commitcomment-28346795 In src/antlr/GroovyLexer.g4: In src/antlr/GroovyLexer.g4 on line 317: I don't see this as a case of it can be done so

[GitHub] groovy pull request #:

2018-03-30 Thread paulk-asert
Github user paulk-asert commented on the pull request: https://github.com/apache/groovy/commit/7e7b508c02bf35e72fca1efcb7cc0d8a4f25038a#commitcomment-28347515 In src/antlr/GroovyLexer.g4: In src/antlr/GroovyLexer.g4 on line 317: But ''' and """ can quote t

[GitHub] groovy pull request #:

2018-04-02 Thread paulk-asert
Github user paulk-asert commented on the pull request: https://github.com/apache/groovy/commit/1bcaaeaf60078dd5a9aca5cbf1df8f45de68db60#commitcomment-28386425 If you get a chance to check the "Serializable incompatible(!)" warnings from the checkBinaryCompatibility task

[GitHub] groovy pull request #:

2018-04-02 Thread paulk-asert
Github user paulk-asert commented on the pull request: https://github.com/apache/groovy/commit/1bcaaeaf60078dd5a9aca5cbf1df8f45de68db60#commitcomment-28387373 my last reply was to your earlier comment. ---

[GitHub] groovy pull request #:

2018-04-02 Thread paulk-asert
Github user paulk-asert commented on the pull request: https://github.com/apache/groovy/commit/1bcaaeaf60078dd5a9aca5cbf1df8f45de68db60#commitcomment-28387375 Let me generate you an example ... ---

[GitHub] groovy pull request #:

2018-04-02 Thread paulk-asert
Github user paulk-asert commented on the pull request: https://github.com/apache/groovy/commit/1bcaaeaf60078dd5a9aca5cbf1df8f45de68db60#commitcomment-28387182 Yes but it will break serializability within a point release! ---

[GitHub] groovy pull request #:

2018-04-02 Thread paulk-asert
Github user paulk-asert commented on the pull request: https://github.com/apache/groovy/commit/1bcaaeaf60078dd5a9aca5cbf1df8f45de68db60#commitcomment-28387216 To keep serializability compatible within 2.4 we can add serialVersionUID values generated from the 2.4 codebase. We can

[GitHub] groovy pull request #:

2018-04-02 Thread paulk-asert
Github user paulk-asert commented on the pull request: https://github.com/apache/groovy/commit/1bcaaeaf60078dd5a9aca5cbf1df8f45de68db60#commitcomment-28387263 Best bet for checking is to just serialize from 2.4 using ObjectOutputStream into a dat file (binary file) and read that back

[GitHub] groovy pull request #:

2018-04-02 Thread paulk-asert
Github user paulk-asert commented on the pull request: https://github.com/apache/groovy/commit/1bcaaeaf60078dd5a9aca5cbf1df8f45de68db60#commitcomment-28387349 Not all the classes probably gave errors but yep, that will probably be the easiest. The only other comment I'll make

[GitHub] groovy pull request #:

2018-04-02 Thread paulk-asert
Github user paulk-asert commented on the pull request: https://github.com/apache/groovy/commit/1bcaaeaf60078dd5a9aca5cbf1df8f45de68db60#commitcomment-28387229 Also, I'd note that in some cases, like the ObservableList/Map/Set example which weren't serializable in the first place

[GitHub] groovy pull request #:

2018-04-02 Thread paulk-asert
Github user paulk-asert commented on the pull request: https://github.com/apache/groovy/commit/1bcaaeaf60078dd5a9aca5cbf1df8f45de68db60#commitcomment-28387291 Bonus points if you can pin-point what is causing the false positives - we should submit a bug report/PR to japicmp to fix

[GitHub] groovy pull request #:

2018-04-02 Thread paulk-asert
Github user paulk-asert commented on the pull request: https://github.com/apache/groovy/commit/1bcaaeaf60078dd5a9aca5cbf1df8f45de68db60#commitcomment-28387886 Please revert. That just also breaks serializable compability between 2.4.15 and 2_4_X HEAD!! Run this script

[GitHub] groovy pull request #:

2018-04-02 Thread paulk-asert
Github user paulk-asert commented on the pull request: https://github.com/apache/groovy/commit/1bcaaeaf60078dd5a9aca5cbf1df8f45de68db60#commitcomment-28388135 Technically we only need to "fix" the broken bits but it will be easiest to revert on all branches and work fr

[GitHub] groovy pull request #678: GROOVY-8525: Binary compatibility issue for Groovy...

2018-03-31 Thread paulk-asert
Github user paulk-asert closed the pull request at: https://github.com/apache/groovy/pull/678 ---

[GitHub] groovy pull request #679: GROOVY-8525: Binary compatibility issue for Groovy...

2018-03-30 Thread paulk-asert
Github user paulk-asert commented on a diff in the pull request: https://github.com/apache/groovy/pull/679#discussion_r178421035 --- Diff: src/main/java/org/codehaus/groovy/runtime/memoize/StampedCommonCache.java --- @@ -199,20 +208,35 @@ public int size() { return

[GitHub] groovy pull request #679: GROOVY-8525: Binary compatibility issue for Groovy...

2018-03-30 Thread paulk-asert
Github user paulk-asert commented on a diff in the pull request: https://github.com/apache/groovy/pull/679#discussion_r178421016 --- Diff: src/main/java/org/codehaus/groovy/runtime/memoize/StampedCommonCache.java --- @@ -175,6 +174,11 @@ private V compute(K key, ValueProvider

[GitHub] groovy pull request #676: Add DGM `md5`

2018-03-22 Thread paulk-asert
Github user paulk-asert commented on a diff in the pull request: https://github.com/apache/groovy/pull/676#discussion_r176448808 --- Diff: src/test/org/codehaus/groovy/runtime/DefaultGroovyMethodsTest.groovy --- @@ -310,4 +312,18 @@ class DefaultGroovyMethodsTest extends

[GitHub] groovy pull request #675: GROOVY-8514: NullPointerException in class Missing...

2018-03-22 Thread paulk-asert
Github user paulk-asert commented on a diff in the pull request: https://github.com/apache/groovy/pull/675#discussion_r176603885 --- Diff: src/main/groovy/groovy/lang/MissingMethodException.java --- @@ -48,7 +48,7 @@ public MissingMethodException(String method, Class type, Object

[GitHub] groovy pull request #675: GROOVY-8514: NullPointerException in class Missing...

2018-03-22 Thread paulk-asert
Github user paulk-asert commented on a diff in the pull request: https://github.com/apache/groovy/pull/675#discussion_r176602934 --- Diff: subprojects/groovy-jsr223/src/main/java/org/codehaus/groovy/jsr223/GroovyScriptEngineImpl.java --- @@ -367,6 +367,22 @@ private Object

[GitHub] groovy pull request #672: GROOVY-7624: Collection asImmutable() methods aren...

2018-03-06 Thread paulk-asert
GitHub user paulk-asert opened a pull request: https://github.com/apache/groovy/pull/672 GROOVY-7624: Collection asImmutable() methods aren't immutable You can merge this pull request into a Git repository by running: $ git pull https://github.com/paulk-asert/groovy

[GitHub] groovy pull request #811: GROOVY-8843: Fix illegal reflective access within ...

2018-10-15 Thread paulk-asert
Github user paulk-asert commented on a diff in the pull request: https://github.com/apache/groovy/pull/811#discussion_r225328503 --- Diff: src/main/java/org/codehaus/groovy/vmplugin/v9/Java9.java --- @@ -18,14 +18,78 @@ */ package org.codehaus.groovy.vmplugin.v9

[GitHub] groovy pull request #811: GROOVY-8843: Fix illegal reflective access within ...

2018-10-15 Thread paulk-asert
GitHub user paulk-asert opened a pull request: https://github.com/apache/groovy/pull/811 GROOVY-8843: Fix illegal reflective access within o.c.g.vmplugin.v7.J… …ava7 You can merge this pull request into a Git repository by running: $ git pull https://github.com/paulk-asert

[GitHub] groovy pull request #814: GROOVY-3278: Using referenced String constant as v...

2018-10-22 Thread paulk-asert
GitHub user paulk-asert opened a pull request: https://github.com/apache/groovy/pull/814 GROOVY-3278: Using referenced String constant as value of Annotation … …causes compile error You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] groovy pull request #819: GROOVY-7975/GROOVY-3278/GROOVY-7854: improved acce...

2018-11-04 Thread paulk-asert
GitHub user paulk-asert opened a pull request: https://github.com/apache/groovy/pull/819 GROOVY-7975/GROOVY-3278/GROOVY-7854: improved accessing of constants … …for annotation attributes You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] groovy pull request #823: GROOVY-8880: Traits - static/instance init blocks

2018-11-15 Thread paulk-asert
GitHub user paulk-asert opened a pull request: https://github.com/apache/groovy/pull/823 GROOVY-8880: Traits - static/instance init blocks You can merge this pull request into a Git repository by running: $ git pull https://github.com/paulk-asert/groovy groovy8880

[GitHub] groovy pull request #:

2018-11-05 Thread paulk-asert
Github user paulk-asert commented on the pull request: https://github.com/apache/groovy/commit/7d2d6319f694b87fc4e646d3d22679315e1411bf#commitcomment-31185822 In src/main/java/org/apache/groovy/ast/tools/ExpressionUtils.java: In src/main/java/org/apache/groovy/ast/tools

[GitHub] groovy pull request #822: GROOVY-7632: Groovy named parameters static check ...

2018-11-14 Thread paulk-asert
GitHub user paulk-asert opened a pull request: https://github.com/apache/groovy/pull/822 GROOVY-7632: Groovy named parameters static check (initial cut of sup… …port) You can merge this pull request into a Git repository by running: $ git pull https://github.com/paulk

[GitHub] groovy pull request #819: GROOVY-7975/GROOVY-3278/GROOVY-7854: improved acce...

2018-11-04 Thread paulk-asert
Github user paulk-asert commented on a diff in the pull request: https://github.com/apache/groovy/pull/819#discussion_r230627859 --- Diff: src/main/java/org/apache/groovy/ast/tools/ExpressionUtils.java --- @@ -18,20 +18,205 @@ */ package org.apache.groovy.ast.tools

[GitHub] groovy pull request #803: GROOVY-8806: Immutable classes break in groovy 2.5...

2018-10-03 Thread paulk-asert
GitHub user paulk-asert opened a pull request: https://github.com/apache/groovy/pull/803 GROOVY-8806: Immutable classes break in groovy 2.5.2 You can merge this pull request into a Git repository by running: $ git pull https://github.com/paulk-asert/groovy groovy8806

[GitHub] groovy pull request #:

2018-10-10 Thread paulk-asert
Github user paulk-asert commented on the pull request: https://github.com/apache/groovy/commit/fd21ad4e3b6d2a4297944d079ba8948e8d8e6052#commitcomment-30846605 True, I'll fix ---

[GitHub] groovy pull request #837: GROOVY-8917: Failed to infer parameter type of som...

2018-12-10 Thread paulk-asert
Github user paulk-asert commented on a diff in the pull request: https://github.com/apache/groovy/pull/837#discussion_r240369943 --- Diff: src/main/java/org/codehaus/groovy/classgen/asm/util/TypeUtil.java --- @@ -213,4 +220,15 @@ private static String makeRefDescription(String

[GitHub] groovy pull request #837: GROOVY-8917: Failed to infer parameter type of som...

2018-12-10 Thread paulk-asert
Github user paulk-asert commented on a diff in the pull request: https://github.com/apache/groovy/pull/837#discussion_r240451187 --- Diff: src/main/java/org/codehaus/groovy/classgen/asm/util/TypeUtil.java --- @@ -213,4 +220,15 @@ private static String makeRefDescription(String

[GitHub] groovy pull request #837: GROOVY-8917: Failed to infer parameter type of som...

2018-12-10 Thread paulk-asert
Github user paulk-asert commented on a diff in the pull request: https://github.com/apache/groovy/pull/837#discussion_r240451723 --- Diff: src/main/java/org/codehaus/groovy/classgen/asm/util/TypeUtil.java --- @@ -213,4 +220,15 @@ private static String makeRefDescription(String

[GitHub] groovy pull request #837: GROOVY-8917: Failed to infer parameter type of som...

2018-12-10 Thread paulk-asert
Github user paulk-asert commented on a diff in the pull request: https://github.com/apache/groovy/pull/837#discussion_r240451547 --- Diff: src/main/java/org/codehaus/groovy/classgen/asm/util/TypeUtil.java --- @@ -213,4 +220,15 @@ private static String makeRefDescription(String

[GitHub] groovy pull request #827: GROOVY-8882: CS: Loop over elements of String has ...

2018-11-20 Thread paulk-asert
GitHub user paulk-asert opened a pull request: https://github.com/apache/groovy/pull/827 GROOVY-8882: CS: Loop over elements of String has different element type You can merge this pull request into a Git repository by running: $ git pull https://github.com/paulk-asert/groovy

[GitHub] groovy pull request #830: GROOVY-7647: Incorrect line information for debug

2018-11-22 Thread paulk-asert
GitHub user paulk-asert opened a pull request: https://github.com/apache/groovy/pull/830 GROOVY-7647: Incorrect line information for debug You can merge this pull request into a Git repository by running: $ git pull https://github.com/paulk-asert/groovy groovy7647

[GitHub] groovy pull request #833: GROOVY-8903: Retrofit NamedParams to groovy.sql.Sq...

2018-11-27 Thread paulk-asert
GitHub user paulk-asert opened a pull request: https://github.com/apache/groovy/pull/833 GROOVY-8903: Retrofit NamedParams to groovy.sql.Sql You can merge this pull request into a Git repository by running: $ git pull https://github.com/paulk-asert/groovy groovy8903

[GitHub] groovy pull request #796: GROOVY-8775: Bug joint compilation in ant task gro...

2018-09-13 Thread paulk-asert
Github user paulk-asert closed the pull request at: https://github.com/apache/groovy/pull/796 ---

[GitHub] groovy pull request #796: GROOVY-8775: Bug joint compilation in ant task gro...

2018-09-13 Thread paulk-asert
GitHub user paulk-asert opened a pull request: https://github.com/apache/groovy/pull/796 GROOVY-8775: Bug joint compilation in ant task groovyc: classpath not set This doesn't fix the issue but enables a workaround until we fix fully You can merge this pull request into a Git

[GitHub] groovy pull request #797: GROOVY-8794: Add groovy-yaml subproject to support...

2018-09-15 Thread paulk-asert
Github user paulk-asert commented on a diff in the pull request: https://github.com/apache/groovy/pull/797#discussion_r217899699 --- Diff: subprojects/groovy-yaml/src/spec/doc/yaml-userguide.adoc --- @@ -0,0 +1,112

[GitHub] groovy pull request #797: GROOVY-8794: Add groovy-yaml subproject to support...

2018-09-15 Thread paulk-asert
Github user paulk-asert commented on a diff in the pull request: https://github.com/apache/groovy/pull/797#discussion_r217899707 --- Diff: build.gradle --- @@ -160,6 +160,8 @@ ext { spockVersion = '1.2-groovy-2.4-SNAPSHOT' // supports 3.0 antlr4Version = '4.7.1

[GitHub] groovy pull request #797: GROOVY-8794: Add groovy-yaml subproject to support...

2018-09-15 Thread paulk-asert
Github user paulk-asert commented on a diff in the pull request: https://github.com/apache/groovy/pull/797#discussion_r217899737 --- Diff: subprojects/groovy-yaml/src/spec/doc/yaml-userguide.adoc --- @@ -0,0 +1,112

[GitHub] groovy pull request #797: GROOVY-8794: Add groovy-yaml subproject to support...

2018-09-15 Thread paulk-asert
Github user paulk-asert commented on a diff in the pull request: https://github.com/apache/groovy/pull/797#discussion_r217899761 --- Diff: subprojects/groovy-yaml/src/spec/doc/yaml-userguide.adoc --- @@ -0,0 +1,112

[GitHub] groovy pull request #797: GROOVY-8794: Add groovy-yaml subproject to support...

2018-09-15 Thread paulk-asert
Github user paulk-asert commented on a diff in the pull request: https://github.com/apache/groovy/pull/797#discussion_r217899766 --- Diff: subprojects/groovy-yaml/src/spec/doc/yaml-userguide.adoc --- @@ -0,0 +1,112

[GitHub] groovy pull request #797: GROOVY-8794: Add groovy-yaml subproject to support...

2018-09-15 Thread paulk-asert
Github user paulk-asert commented on a diff in the pull request: https://github.com/apache/groovy/pull/797#discussion_r217901029 --- Diff: subprojects/groovy-yaml/src/spec/doc/yaml-userguide.adoc --- @@ -0,0 +1,112

[GitHub] groovy pull request #798: GROOVY-8549: Compile Static causes getAt to fail

2018-09-16 Thread paulk-asert
GitHub user paulk-asert opened a pull request: https://github.com/apache/groovy/pull/798 GROOVY-8549: Compile Static causes getAt to fail I started fixing this in STCSW first with something like below but then putAt also needs fixing. In the meantime, the added DGM methods

[GitHub] groovy pull request #795: GROOVY-8703: Unexpected behavior with @NamedVarian...

2018-09-12 Thread paulk-asert
GitHub user paulk-asert opened a pull request: https://github.com/apache/groovy/pull/795 GROOVY-8703: Unexpected behavior with @NamedVariant on constructor You can merge this pull request into a Git repository by running: $ git pull https://github.com/paulk-asert/groovy

<    1   2   3