[GitHub] groovy pull request #544: refactor: type safety and formatting

Github user graemerocher commented on a diff in the pull request: https://github.com/apache/groovy/pull/544#discussion_r117615150 --- Diff: src/main/org/codehaus/groovy/transform/trait/Traits.java --- @@ -355,19 +355,19 @@ static String getSuperTraitMethodName(ClassNode trait

[GitHub] groovy pull request #544: refactor: type safety and formatting

Github user graemerocher commented on a diff in the pull request: https://github.com/apache/groovy/pull/544#discussion_r117614896 --- Diff: src/main/org/codehaus/groovy/transform/trait/Traits.java --- @@ -355,19 +355,19 @@ static String getSuperTraitMethodName(ClassNode trait

[GitHub] groovy pull request #544: refactor: type safety and formatting

Github user graemerocher commented on a diff in the pull request: https://github.com/apache/groovy/pull/544#discussion_r117614868 --- Diff: src/main/org/codehaus/groovy/transform/trait/Traits.java --- @@ -355,19 +355,19 @@ static String getSuperTraitMethodName(ClassNode trait

[GitHub] groovy pull request #371: Serialization options for JsonOutput

Github user graemerocher commented on a diff in the pull request: https://github.com/apache/groovy/pull/371#discussion_r82400528 --- Diff: subprojects/groovy-json/src/main/java/groovy/json/JsonOutput.java --- @@ -601,4 +280,966 @@ public String toString

[GitHub] groovy pull request #371: Serialization options for JsonOutput

Github user graemerocher commented on a diff in the pull request: https://github.com/apache/groovy/pull/371#discussion_r81288571 --- Diff: subprojects/groovy-json/src/main/java/groovy/json/JsonOutput.java --- @@ -601,4 +280,966 @@ public String toString

[GitHub] groovy pull request #371: Serialization options for JsonOutput

Github user graemerocher commented on a diff in the pull request: https://github.com/apache/groovy/pull/371#discussion_r81288503 --- Diff: subprojects/groovy-json/src/main/java/groovy/json/JsonOutput.java --- @@ -601,4 +280,966 @@ public String toString

[GitHub] groovy pull request #429: GROOVY-7946 - allow writable values for StreamingJ...

GitHub user graemerocher opened a pull request: https://github.com/apache/groovy/pull/429 GROOVY-7946 - allow writable values for StreamingJsonBuilder See https://issues.apache.org/jira/browse/GROOVY-7946 You can merge this pull request into a Git repository by running: $ git

[GitHub] groovy pull request #416: GROOVY-7926 - Don't use a CastExpression if the re...

Github user graemerocher commented on a diff in the pull request: https://github.com/apache/groovy/pull/416#discussion_r78217077 --- Diff: src/main/org/codehaus/groovy/transform/trait/TraitComposer.java --- @@ -293,7 +293,8 @@ private static void createForwarderMethod

[GitHub] groovy pull request #416: GROOVY-7926 - Don't use a CastExpression if the re...

GitHub user graemerocher opened a pull request: https://github.com/apache/groovy/pull/416 GROOVY-7926 - Don't use a CastExpression if the return type is void. As per https://issues.apache.org/jira/browse/GROOVY-7926 traits currently try to cast the void type which leads

[GitHub] groovy pull request: Make sure generics are correct for generified...

GitHub user graemerocher opened a pull request: https://github.com/apache/groovy/pull/340 Make sure generics are correct for generified return types Fixes https://issues.apache.org/jira/browse/GROOVY-7846 You can merge this pull request into a Git repository by running: $ git

[GitHub] groovy pull request: StreamingJsonBuilder should handle nested clo...

GitHub user graemerocher opened a pull request: https://github.com/apache/groovy/pull/208 StreamingJsonBuilder should handle nested closures Currently StreamingJsonBuilder doesn't handle nested closures properly and instead these are delegated to `JsonOutput.toJson` which