[GitHub] groovy pull request #797: GROOVY-8794: Add groovy-yaml subproject to support...

2018-09-15 Thread jwagenleitner
Github user jwagenleitner commented on a diff in the pull request: https://github.com/apache/groovy/pull/797#discussion_r217889449 --- Diff: build.gradle --- @@ -183,6 +185,9 @@ dependencies { compile("org.apache.ivy:ivy:$ivyVersion") { transiti

[GitHub] groovy pull request #797: GROOVY-8794: Add groovy-yaml subproject to support...

2018-09-15 Thread jwagenleitner
Github user jwagenleitner commented on a diff in the pull request: https://github.com/apache/groovy/pull/797#discussion_r217889473 --- Diff: subprojects/groovy-yaml/src/main/java/groovy/yaml/YamlBuilder.java --- @@ -0,0 +1,264 @@ +/* + * Licensed to the Apache Software

[GitHub] groovy pull request #757: GROOVY-8008: AIOOB inner class ctor params with ru...

2018-06-18 Thread jwagenleitner
Github user jwagenleitner commented on a diff in the pull request: https://github.com/apache/groovy/pull/757#discussion_r196172656 --- Diff: src/main/java/org/codehaus/groovy/vmplugin/v5/Java5.java --- @@ -405,6 +408,32 @@ public void configureClassNode(CompileUnit compileUnit

[GitHub] groovy pull request #757: GROOVY-8008: AIOOB inner class ctor params with ru...

2018-06-14 Thread jwagenleitner
GitHub user jwagenleitner opened a pull request: https://github.com/apache/groovy/pull/757 GROOVY-8008: AIOOB inner class ctor params with runtime annotations Should also address [GROOVY-8505](https://issues.apache.org/jira/browse/GROOVY-8505) which is the same issue. You can

[GitHub] groovy pull request #756: GROOVY-8614: Invalid reference generated in InnerC...

2018-06-14 Thread jwagenleitner
GitHub user jwagenleitner opened a pull request: https://github.com/apache/groovy/pull/756 GROOVY-8614: Invalid reference generated in InnerClasses attribute fo… …r nested interface You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] groovy pull request #753: GROOVY-8632: Groovy 2.5.0 fails to compile Google ...

2018-06-08 Thread jwagenleitner
GitHub user jwagenleitner opened a pull request: https://github.com/apache/groovy/pull/753 GROOVY-8632: Groovy 2.5.0 fails to compile Google Java Client sample code Class files can contain INNERCLASS references to other classes inner classes whose name may be the same name

[GitHub] groovy pull request #747: GROOVY-8583: Fail to infer auto-return type from t...

2018-06-02 Thread jwagenleitner
GitHub user jwagenleitner opened a pull request: https://github.com/apache/groovy/pull/747 GROOVY-8583: Fail to infer auto-return type from ternary operator You can merge this pull request into a Git repository by running: $ git pull https://github.com/jwagenleitner/groovy

[GitHub] groovy pull request #729: GROOVY-8610: STC NPE using DGM collect on Iterator

2018-05-27 Thread jwagenleitner
GitHub user jwagenleitner opened a pull request: https://github.com/apache/groovy/pull/729 GROOVY-8610: STC NPE using DGM collect on Iterator You can merge this pull request into a Git repository by running: $ git pull https://github.com/jwagenleitner/groovy 8610-stc-collect

[GitHub] groovy pull request #724: Release 2.5.0 related fixes

2018-05-25 Thread jwagenleitner
GitHub user jwagenleitner opened a pull request: https://github.com/apache/groovy/pull/724 Release 2.5.0 related fixes Some recent commits seem to cause problems with the Nextflow 2.5.0 snapshot builds on the CI server. One can lead to a NPE (commit

[GitHub] groovy pull request #:

2018-05-21 Thread jwagenleitner
Github user jwagenleitner commented on the pull request: https://github.com/apache/groovy/commit/869c365161457c050d5a54c7ff43d73d3263f34e#commitcomment-29066081 thanks! ---

[GitHub] groovy pull request #713: GROOVY-8590: STC incorrectly infers type of nested...

2018-05-20 Thread jwagenleitner
GitHub user jwagenleitner opened a pull request: https://github.com/apache/groovy/pull/713 GROOVY-8590: STC incorrectly infers type of nested method call used i… …n a return stmt You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] groovy pull request #712: GROOVY-8171: Escaped dollar slashy difference betw...

2018-05-19 Thread jwagenleitner
GitHub user jwagenleitner opened a pull request: https://github.com/apache/groovy/pull/712 GROOVY-8171: Escaped dollar slashy difference between old and parrot … …parsers You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] groovy pull request #707: GROOVY-8509: SC error call to protected method fro...

2018-05-16 Thread jwagenleitner
GitHub user jwagenleitner opened a pull request: https://github.com/apache/groovy/pull/707 GROOVY-8509: SC error call to protected method from same package Because they were closely related, this PR also includes the following: 1. A change to the fix introduced by GROOVY

[GitHub] groovy pull request #:

2018-05-15 Thread jwagenleitner
Github user jwagenleitner commented on the pull request: https://github.com/apache/groovy/commit/b1d1232770aade9672668df4dbc6aa2e2076fa9e#commitcomment-28988363 In subprojects/groovy-sql/src/main/java/groovy/sql/Sql.java: In subprojects/groovy-sql/src/main/java/groovy/sql/Sql.java

[GitHub] groovy pull request #671: GROOVY-8422: Incorrect properties copy in Sql.newI...

2018-03-05 Thread jwagenleitner
GitHub user jwagenleitner opened a pull request: https://github.com/apache/groovy/pull/671 GROOVY-8422: Incorrect properties copy in Sql.newInstance The provided Properties should be passed to the DriverManager as-is. A copy is only needed when changes are made to the provided

[GitHub] groovy pull request #670: GROOVY-8475: unable to instantiate objects using t...

2018-03-04 Thread jwagenleitner
Github user jwagenleitner closed the pull request at: https://github.com/apache/groovy/pull/670 ---

[GitHub] groovy pull request #670: GROOVY-8475: unable to instantiate objects using t...

2018-03-03 Thread jwagenleitner
GitHub user jwagenleitner opened a pull request: https://github.com/apache/groovy/pull/670 GROOVY-8475: unable to instantiate objects using the "new" keyword in groovysh PR #100 was merged into 2_5_X and comments on GROOVY-7562 indicate it wasn't merged into 2_4_X due

[GitHub] groovy pull request #563: vmplugin

2017-10-01 Thread jwagenleitner
Github user jwagenleitner closed the pull request at: https://github.com/apache/groovy/pull/563 ---

[GitHub] groovy pull request #610: GROOVY-8326: @Override should not copied onto meth...

2017-09-30 Thread jwagenleitner
GitHub user jwagenleitner opened a pull request: https://github.com/apache/groovy/pull/610 GROOVY-8326: @Override should not copied onto methods generated by ap… …plying @Memoize You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] groovy pull request #609: GROOVY-8213: Closures are maybe not Threadsafe

2017-09-30 Thread jwagenleitner
GitHub user jwagenleitner opened a pull request: https://github.com/apache/groovy/pull/609 GROOVY-8213: Closures are maybe not Threadsafe To address @blackdrag 's comment in the JIRA I created a JMH benchmark to test a volatile read vs a recheck and sync, https://github.com

[GitHub] groovy pull request #605: GROOVY-8220: SC GroovyCastException on parameter f...

2017-09-23 Thread jwagenleitner
GitHub user jwagenleitner opened a pull request: https://github.com/apache/groovy/pull/605 GROOVY-8220: SC GroovyCastException on parameter flow typing GROOVY-8157 introduced flow typing for parameters and this fix is required in order to track their assignments in `if` branches

[GitHub] groovy pull request #593: GROOVY-8303: VerifyError for nested class this cal...

2017-08-27 Thread jwagenleitner
GitHub user jwagenleitner opened a pull request: https://github.com/apache/groovy/pull/593 GROOVY-8303: VerifyError for nested class this call to static method You can merge this pull request into a Git repository by running: $ git pull https://github.com/jwagenleitner/groovy

[GitHub] groovy pull request #592: GROOVY-8205: Regression test for STC Enum values D...

2017-08-26 Thread jwagenleitner
GitHub user jwagenleitner opened a pull request: https://github.com/apache/groovy/pull/592 GROOVY-8205: Regression test for STC Enum values DGM methods Issue fixed by commit 8c218dec34 (GROOVY-7283) You can merge this pull request into a Git repository by running: $ git pull

[GitHub] groovy pull request #584: GROOVY-8249: Newify local variable declaration fai...

2017-08-13 Thread jwagenleitner
GitHub user jwagenleitner opened a pull request: https://github.com/apache/groovy/pull/584 GROOVY-8249: Newify local variable declaration fails to resolve class… … expression You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] groovy pull request #583: migrate benchmarks to JMH

2017-08-13 Thread jwagenleitner
GitHub user jwagenleitner opened a pull request: https://github.com/apache/groovy/pull/583 migrate benchmarks to JMH You can merge this pull request into a Git repository by running: $ git pull https://github.com/jwagenleitner/groovy bench2perf Alternatively you can review

[GitHub] groovy pull request #582: GROOVY-8269: Unclear definition of default behavio...

2017-08-13 Thread jwagenleitner
GitHub user jwagenleitner opened a pull request: https://github.com/apache/groovy/pull/582 GROOVY-8269: Unclear definition of default behavior for trait multipl… …e inheritance conflicts You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] groovy pull request #581: GROOVY-8208: VariableExpressionTransformer does no...

2017-08-12 Thread jwagenleitner
GitHub user jwagenleitner opened a pull request: https://github.com/apache/groovy/pull/581 GROOVY-8208: VariableExpressionTransformer does not set source positi… …on on property expressions You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] groovy pull request #569: include indy in benchmark runs

2017-08-12 Thread jwagenleitner
Github user jwagenleitner closed the pull request at: https://github.com/apache/groovy/pull/569 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] groovy pull request #579: GROOVY-8242: @Newify default attribute value

2017-08-05 Thread jwagenleitner
GitHub user jwagenleitner opened a pull request: https://github.com/apache/groovy/pull/579 GROOVY-8242: @Newify default attribute value Class values are only required for Python-style conversions so the attribute should default to an empty array to indicate

[GitHub] groovy pull request #576: GROOVY-7995: @CS closure call from closure

2017-07-22 Thread jwagenleitner
GitHub user jwagenleitner opened a pull request: https://github.com/apache/groovy/pull/576 GROOVY-7995: @CS closure call from closure Short syntax of closure call invokes wrong closure if wrapped in another closure. This fix includes a combination of the contributed commit from

[GitHub] groovy pull request #575: cache GroovyRunnerRegistry values

2017-07-16 Thread jwagenleitner
GitHub user jwagenleitner opened a pull request: https://github.com/apache/groovy/pull/575 cache GroovyRunnerRegistry values The registry should be read heavy and most use made of the iterator. Few writes/loads should occur, so values should be cached in order to optimize

[GitHub] groovy pull request #573: add JMH to performance subproject

2017-07-09 Thread jwagenleitner
GitHub user jwagenleitner opened a pull request: https://github.com/apache/groovy/pull/573 add JMH to performance subproject You can merge this pull request into a Git repository by running: $ git pull https://github.com/jwagenleitner/groovy jmh-perf Alternatively you can

[GitHub] groovy pull request #572: GROOVY-8251: Implement withCloseable on AutoClosea...

2017-07-08 Thread jwagenleitner
GitHub user jwagenleitner opened a pull request: https://github.com/apache/groovy/pull/572 GROOVY-8251: Implement withCloseable on AutoCloseable `NioGroovyMethods.withAutoCloseable` was added for 2.5.0 as part of [GROOVY-7572](https://issues.apache.org/jira/browse/GROOVY-7572

[GitHub] groovy pull request #559: GROOVY-8222: Setting Source Position in newly crea...

2017-07-08 Thread jwagenleitner
Github user jwagenleitner commented on a diff in the pull request: https://github.com/apache/groovy/pull/559#discussion_r126288792 --- Diff: src/main/org/codehaus/groovy/classgen/AsmClassGenerator.java --- @@ -1218,7 +1218,7 @@ public void visitVariableExpression

[GitHub] groovy pull request #559: GROOVY-8222: Setting Source Position in newly crea...

2017-07-08 Thread jwagenleitner
Github user jwagenleitner commented on a diff in the pull request: https://github.com/apache/groovy/pull/559#discussion_r126286817 --- Diff: src/main/org/codehaus/groovy/classgen/AsmClassGenerator.java --- @@ -1251,11 +1251,13 @@ private void processClassVariable(String name

[GitHub] groovy pull request #559: GROOVY-8222: Setting Source Position in newly crea...

2017-07-08 Thread jwagenleitner
Github user jwagenleitner commented on a diff in the pull request: https://github.com/apache/groovy/pull/559#discussion_r126286728 --- Diff: src/main/org/codehaus/groovy/classgen/AsmClassGenerator.java --- @@ -1251,11 +1251,13 @@ private void processClassVariable(String name

[GitHub] groovy pull request #558: GROOVY-8218 @Sortable allows reversed natural orde...

2017-07-04 Thread jwagenleitner
Github user jwagenleitner commented on a diff in the pull request: https://github.com/apache/groovy/pull/558#discussion_r125553663 --- Diff: src/main/groovy/transform/Sortable.java --- @@ -145,4 +170,9 @@ * Must not be used if 'includes' is used

[GitHub] groovy pull request #558: GROOVY-8218 @Sortable allows reversed natural orde...

2017-07-04 Thread jwagenleitner
Github user jwagenleitner commented on a diff in the pull request: https://github.com/apache/groovy/pull/558#discussion_r12008 --- Diff: src/main/org/codehaus/groovy/transform/SortableASTTransformation.java --- @@ -82,6 +82,7 @@ public void visit(ASTNode[] nodes, SourceUnit

[GitHub] groovy pull request #558: GROOVY-8218 @Sortable allows reversed natural orde...

2017-07-04 Thread jwagenleitner
Github user jwagenleitner commented on a diff in the pull request: https://github.com/apache/groovy/pull/558#discussion_r125554738 --- Diff: src/main/org/codehaus/groovy/transform/AbstractASTTransformation.java --- @@ -115,6 +115,14 @@ public int getMemberIntValue(AnnotationNode

[GitHub] groovy pull request #558: GROOVY-8218 @Sortable allows reversed natural orde...

2017-07-04 Thread jwagenleitner
Github user jwagenleitner commented on a diff in the pull request: https://github.com/apache/groovy/pull/558#discussion_r125553175 --- Diff: src/main/org/codehaus/groovy/transform/SortableASTTransformation.java --- @@ -112,7 +113,7 @@ private static void implementComparable

[GitHub] groovy pull request #558: GROOVY-8218 @Sortable allows reversed natural orde...

2017-07-04 Thread jwagenleitner
Github user jwagenleitner commented on a diff in the pull request: https://github.com/apache/groovy/pull/558#discussion_r125552693 --- Diff: src/main/org/codehaus/groovy/ast/tools/GeneralUtils.java --- @@ -219,10 +219,38 @@ public static ClosureExpression closureX(Statement code

[GitHub] groovy pull request #571: GROOVY-8245: @Newify(auto=false) not transforming ...

2017-07-04 Thread jwagenleitner
GitHub user jwagenleitner opened a pull request: https://github.com/apache/groovy/pull/571 GROOVY-8245: @Newify(auto=false) not transforming declarations Also added default for `value` attribute for [GROOVY-8242](https://issues.apache.org/jira/browse/GROOVY-8242). You can merge

[GitHub] groovy pull request #569: include indy in benchmark runs

2017-06-27 Thread jwagenleitner
GitHub user jwagenleitner opened a pull request: https://github.com/apache/groovy/pull/569 include indy in benchmark runs You can merge this pull request into a Git repository by running: $ git pull https://github.com/jwagenleitner/groovy benchmarks Alternatively you can

[GitHub] groovy pull request #564: GROOVY-8197: Make JUnit3/4 GroovyRunners

2017-06-24 Thread jwagenleitner
GitHub user jwagenleitner opened a pull request: https://github.com/apache/groovy/pull/564 GROOVY-8197: Make JUnit3/4 GroovyRunners You can merge this pull request into a Git repository by running: $ git pull https://github.com/jwagenleitner/groovy 8197-groovyrunners

[GitHub] groovy pull request #563: vmplugin

2017-06-20 Thread jwagenleitner
GitHub user jwagenleitner opened a pull request: https://github.com/apache/groovy/pull/563 vmplugin Alternative to PR #562. I tried to make incremental commits to make it easier to review. Still outstanding are the indy related classes in `org.codehaus.groovy.vmplugin.v7

[GitHub] groovy pull request #562: rename Java8 package from vm8 to v8 for consistenc...

2017-06-18 Thread jwagenleitner
GitHub user jwagenleitner opened a pull request: https://github.com/apache/groovy/pull/562 rename Java8 package from vm8 to v8 for consistency You can merge this pull request into a Git repository by running: $ git pull https://github.com/jwagenleitner/groovy v8

[GitHub] groovy pull request #561: GROOVY-8230: Deadlock in GroovyClassLoader

2017-06-18 Thread jwagenleitner
GitHub user jwagenleitner opened a pull request: https://github.com/apache/groovy/pull/561 GROOVY-8230: Deadlock in GroovyClassLoader You can merge this pull request into a Git repository by running: $ git pull https://github.com/jwagenleitner/groovy 8230-gcl-deadlock

[GitHub] groovy pull request #560: GROOVY-8226: JSR308 initial plumbing tweaks

2017-06-12 Thread jwagenleitner
Github user jwagenleitner commented on a diff in the pull request: https://github.com/apache/groovy/pull/560#discussion_r121416370 --- Diff: src/main/org/codehaus/groovy/vmplugin/vm8/Java8.java --- @@ -51,4 +53,13 @@ public int getVersion() { return 8

[GitHub] groovy pull request #557: GROOVY-8056: GroovyCodeSource(URL) can leak a file...

2017-06-03 Thread jwagenleitner
Github user jwagenleitner closed the pull request at: https://github.com/apache/groovy/pull/557 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] groovy pull request #500: GROOVY-8056: GroovyCodeSource(URL) can leak a file...

2017-06-03 Thread jwagenleitner
Github user jwagenleitner closed the pull request at: https://github.com/apache/groovy/pull/500 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] groovy pull request #557: GROOVY-8056: GroovyCodeSource(URL) can leak a file...

2017-06-03 Thread jwagenleitner
GitHub user jwagenleitner opened a pull request: https://github.com/apache/groovy/pull/557 GROOVY-8056: GroovyCodeSource(URL) can leak a file handler A safer fix in terms of compatibility compared to PR #500. You can merge this pull request into a Git repository by running

[GitHub] groovy pull request #553: require JDK 8+ for release builds (2_5_X/2_6_X)

2017-05-27 Thread jwagenleitner
GitHub user jwagenleitner opened a pull request: https://github.com/apache/groovy/pull/553 require JDK 8+ for release builds (2_5_X/2_6_X) For 2_5_X and 2_6_X in order to compile all features JDK 8+ is required for building releases (related to PR #545). Also included

[GitHub] groovy pull request #551: GROOVY-8204: @Delegate on arrays causes NPE during...

2017-05-25 Thread jwagenleitner
Github user jwagenleitner commented on a diff in the pull request: https://github.com/apache/groovy/pull/551#discussion_r118507014 --- Diff: src/main/org/codehaus/groovy/ast/ClassHelper.java --- @@ -440,12 +440,15 @@ private static boolean hasUsableImplementation(ClassNode c

[GitHub] groovy pull request #545: GROOVY-7611: java.util.Optional should evaluate to...

2017-05-21 Thread jwagenleitner
GitHub user jwagenleitner opened a pull request: https://github.com/apache/groovy/pull/545 GROOVY-7611: java.util.Optional should evaluate to false if empty (Java8 VMPlugin) Target for this would be `2_5_X` and above. For `2_5_X` and `2_6_X` it would require that the release

[GitHub] groovy pull request #544: refactor: type safety and formatting

2017-05-20 Thread jwagenleitner
Github user jwagenleitner commented on a diff in the pull request: https://github.com/apache/groovy/pull/544#discussion_r117615134 --- Diff: src/main/org/codehaus/groovy/transform/trait/Traits.java --- @@ -355,19 +355,19 @@ static String getSuperTraitMethodName(ClassNode trait

[GitHub] groovy pull request #544: refactor: type safety and formatting

2017-05-20 Thread jwagenleitner
GitHub user jwagenleitner opened a pull request: https://github.com/apache/groovy/pull/544 refactor: type safety and formatting You can merge this pull request into a Git repository by running: $ git pull https://github.com/jwagenleitner/groovy refactor Alternatively you can

[GitHub] groovy pull request #:

2017-05-20 Thread jwagenleitner
Github user jwagenleitner commented on the pull request: https://github.com/apache/groovy/commit/b02d2f57c09ba6ba46553ed77aff191ec9ab274e#commitcomment-22218912 In src/main/org/apache/groovy/util/Maps.java: In src/main/org/apache/groovy/util/Maps.java on line 11: JDK9 added

[GitHub] groovy pull request #543: GROOVY-8166: Repeated operations in AnnotationColl...

2017-05-19 Thread jwagenleitner
GitHub user jwagenleitner opened a pull request: https://github.com/apache/groovy/pull/543 GROOVY-8166: Repeated operations in AnnotationCollectorTransform and … …Traits You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] groovy pull request #532: Prevent CachedField and CachedMethod from leaking ...

2017-05-17 Thread jwagenleitner
Github user jwagenleitner commented on a diff in the pull request: https://github.com/apache/groovy/pull/532#discussion_r117078128 --- Diff: src/main/groovy/lang/MetaClassImpl.java --- @@ -1832,6 +1832,9 @@ public Object getProperty(Class sender, Object object, String name

[GitHub] groovy pull request #533: GROOVY-7840: Verifier#makeDescriptorWithoutReturnT...

2017-05-15 Thread jwagenleitner
Github user jwagenleitner commented on a diff in the pull request: https://github.com/apache/groovy/pull/533#discussion_r116533820 --- Diff: src/main/org/apache/groovy/ast/tools/MethodNodeUtils.java --- @@ -0,0 +1,66 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] groovy pull request #540: GROOVY-7535: Groovy category throwing MissingMetho...

2017-05-13 Thread jwagenleitner
GitHub user jwagenleitner opened a pull request: https://github.com/apache/groovy/pull/540 GROOVY-7535: Groovy category throwing MissingMethodException and Miss… …ingPropertyException when using multiple threads You can merge this pull request into a Git repository by running

[GitHub] groovy pull request #532: Prevent CachedField and CachedMethod from leaking ...

2017-05-13 Thread jwagenleitner
Github user jwagenleitner commented on a diff in the pull request: https://github.com/apache/groovy/pull/532#discussion_r116365638 --- Diff: src/main/org/codehaus/groovy/reflection/AccessPermissionChecker.java --- @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache Software

[GitHub] groovy pull request #532: Prevent CachedField and CachedMethod from leaking ...

2017-05-13 Thread jwagenleitner
Github user jwagenleitner commented on a diff in the pull request: https://github.com/apache/groovy/pull/532#discussion_r116365514 --- Diff: src/main/org/codehaus/groovy/reflection/CachedMethod.java --- @@ -324,6 +337,12 @@ else if (o2 instanceof CachedMethod

[GitHub] groovy pull request #532: Prevent CachedField and CachedMethod from leaking ...

2017-05-13 Thread jwagenleitner
Github user jwagenleitner commented on a diff in the pull request: https://github.com/apache/groovy/pull/532#discussion_r116365223 --- Diff: src/main/org/codehaus/groovy/reflection/CachedField.java --- @@ -65,6 +72,12 @@ public Object getProperty(final Object object

[GitHub] groovy pull request #532: Prevent CachedField and CachedMethod from leaking ...

2017-05-13 Thread jwagenleitner
Github user jwagenleitner commented on a diff in the pull request: https://github.com/apache/groovy/pull/532#discussion_r116365151 --- Diff: src/main/org/codehaus/groovy/reflection/AccessPermissionChecker.java --- @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache Software

[GitHub] groovy pull request #532: Prevent CachedField and CachedMethod from leaking ...

2017-05-13 Thread jwagenleitner
Github user jwagenleitner commented on a diff in the pull request: https://github.com/apache/groovy/pull/532#discussion_r116365503 --- Diff: src/main/org/codehaus/groovy/reflection/CachedMethod.java --- @@ -124,6 +131,12 @@ public String getSignature

[GitHub] groovy pull request #532: Prevent CachedField and CachedMethod from leaking ...

2017-05-13 Thread jwagenleitner
Github user jwagenleitner commented on a diff in the pull request: https://github.com/apache/groovy/pull/532#discussion_r116365354 --- Diff: src/main/org/codehaus/groovy/reflection/CachedMethod.java --- @@ -90,6 +91,12 @@ public CachedClass getDeclaringClass

[GitHub] groovy pull request #532: Prevent CachedField and CachedMethod from leaking ...

2017-05-13 Thread jwagenleitner
Github user jwagenleitner commented on a diff in the pull request: https://github.com/apache/groovy/pull/532#discussion_r116365210 --- Diff: src/main/org/codehaus/groovy/reflection/CachedField.java --- @@ -51,6 +52,12 @@ public int getModifiers() { */ public

[GitHub] groovy pull request #532: Prevent CachedField and CachedMethod from leaking ...

2017-05-13 Thread jwagenleitner
Github user jwagenleitner commented on a diff in the pull request: https://github.com/apache/groovy/pull/532#discussion_r116365112 --- Diff: src/main/org/codehaus/groovy/reflection/AccessPermissionChecker.java --- @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache Software

[GitHub] groovy pull request #532: Prevent CachedField and CachedMethod from leaking ...

2017-05-13 Thread jwagenleitner
Github user jwagenleitner commented on a diff in the pull request: https://github.com/apache/groovy/pull/532#discussion_r116365147 --- Diff: src/main/org/codehaus/groovy/reflection/AccessPermissionChecker.java --- @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache Software

[GitHub] groovy pull request #533: GROOVY-7840: Verifier#makeDescriptorWithoutReturnT...

2017-05-13 Thread jwagenleitner
Github user jwagenleitner commented on a diff in the pull request: https://github.com/apache/groovy/pull/533#discussion_r116363909 --- Diff: src/main/org/apache/groovy/ast/tools/MethodNodeUtils.java --- @@ -0,0 +1,66 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] groovy pull request #533: GROOVY-7840: Verifier#makeDescriptorWithoutReturnT...

2017-05-13 Thread jwagenleitner
Github user jwagenleitner commented on a diff in the pull request: https://github.com/apache/groovy/pull/533#discussion_r116363829 --- Diff: src/main/org/apache/groovy/ast/tools/MethodNodeUtils.java --- @@ -0,0 +1,66 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] groovy pull request #533: GROOVY-7840: Verifier#makeDescriptorWithoutReturnT...

2017-05-13 Thread jwagenleitner
Github user jwagenleitner commented on a diff in the pull request: https://github.com/apache/groovy/pull/533#discussion_r116363767 --- Diff: src/main/org/apache/groovy/ast/tools/ClassNodeUtils.java --- @@ -0,0 +1,48 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] groovy pull request #:

2017-04-30 Thread jwagenleitner
Github user jwagenleitner commented on the pull request: https://github.com/apache/groovy/commit/0fb89906aa587920d11fae063bba1d1f8fe26254#commitcomment-21963417 Thanks, I had forgot to test with antlr4 enabled. --- If your project is set up for it, you can reply to this email

[GitHub] groovy pull request #531: fix spec test

2017-04-30 Thread jwagenleitner
GitHub user jwagenleitner opened a pull request: https://github.com/apache/groovy/pull/531 fix spec test You can merge this pull request into a Git repository by running: $ git pull https://github.com/jwagenleitner/groovy dollarslashy Alternatively you can review and apply

[GitHub] groovy pull request #530: Clarify documentation around indy

2017-04-30 Thread jwagenleitner
GitHub user jwagenleitner opened a pull request: https://github.com/apache/groovy/pull/530 Clarify documentation around indy From a recent [user mailing list question](http://mail-archives.apache.org/mod_mbox/groovy-users/201704.mbox/%3c44315a6eb40a3769a12a5bfe465da...@posteo.de%3E

[GitHub] groovy pull request #528: GROOVY-7579: Improve docs for invokeMethod

2017-04-23 Thread jwagenleitner
GitHub user jwagenleitner opened a pull request: https://github.com/apache/groovy/pull/528 GROOVY-7579: Improve docs for invokeMethod You can merge this pull request into a Git repository by running: $ git pull https://github.com/jwagenleitner/groovy groovy7579 Alternatively

[GitHub] groovy pull request #524: GROOVY-8156: Compile error when ListenerList annot...

2017-04-17 Thread jwagenleitner
GitHub user jwagenleitner opened a pull request: https://github.com/apache/groovy/pull/524 GROOVY-8156: Compile error when ListenerList annotation exists You can merge this pull request into a Git repository by running: $ git pull https://github.com/jwagenleitner/groovy

[GitHub] groovy pull request #523: cleanup now that jdk7 is baseline

2017-04-11 Thread jwagenleitner
GitHub user jwagenleitner opened a pull request: https://github.com/apache/groovy/pull/523 cleanup now that jdk7 is baseline Avoids reflective checks/constructions where it is no longer needed since 7 is now baseline in 2_5_X and master. You can merge this pull request into a Git

[GitHub] groovy pull request #522: GROOVY-8144: Invoking a public method declared in ...

2017-04-10 Thread jwagenleitner
GitHub user jwagenleitner opened a pull request: https://github.com/apache/groovy/pull/522 GROOVY-8144: Invoking a public method declared in a non-public class … …result in a IllegalAccessError Commit 1a4c9918a4f12e64 introduced the DecompiledClassNode as part

[GitHub] groovy pull request #520: GROOVY-8140: Invoke method not returning MOP super...

2017-04-02 Thread jwagenleitner
GitHub user jwagenleitner opened a pull request: https://github.com/apache/groovy/pull/520 GROOVY-8140: Invoke method not returning MOP super method if isCallTo… …Super See [dev mailing list discussion](http://mail-archives.apache.org/mod_mbox/groovy-dev/201703.mbox

[GitHub] groovy pull request #501: GROOVY-7248: MissingPropertyException: No such pro...

2017-02-20 Thread jwagenleitner
GitHub user jwagenleitner opened a pull request: https://github.com/apache/groovy/pull/501 GROOVY-7248: MissingPropertyException: No such property in finally block You can merge this pull request into a Git repository by running: $ git pull https://github.com/jwagenleitner

[GitHub] groovy pull request #500: GROOVY-8056: GroovyCodeSource(URL) can leak a file...

2017-02-18 Thread jwagenleitner
GitHub user jwagenleitner opened a pull request: https://github.com/apache/groovy/pull/500 GROOVY-8056: GroovyCodeSource(URL) can leak a file handler URLConnect.getContentEncoding returns the Content-Encoding HTTP Header [1] which is not a charset. Since this method would

[GitHub] groovy pull request #496: Add a ASMifier tab to AstBrowser

2017-02-12 Thread jwagenleitner
Github user jwagenleitner commented on a diff in the pull request: https://github.com/apache/groovy/pull/496#discussion_r100702338 --- Diff: subprojects/groovy-console/src/main/groovy/groovy/inspect/swingui/AstBrowser.groovy --- @@ -403,9 +420,13 @@ class AstBrowser

[GitHub] groovy pull request #489: GROOVY-8067: Possible deadlock when creating new C...

2017-02-08 Thread jwagenleitner
Github user jwagenleitner commented on a diff in the pull request: https://github.com/apache/groovy/pull/489#discussion_r100162935 --- Diff: subprojects/stress/src/test/java/org/codehaus/groovy/reflection/ClassInfoDeadlockStressTest.java --- @@ -0,0 +1,140

[GitHub] groovy pull request #491: GROOVY-8068: improper logging in groovy.sql.Sql

2017-02-07 Thread jwagenleitner
Github user jwagenleitner commented on a diff in the pull request: https://github.com/apache/groovy/pull/491#discussion_r99946115 --- Diff: subprojects/groovy-sql/src/main/java/groovy/sql/Sql.java --- @@ -578,17 +578,26 @@ public static Sql newInstance(Map<String, Object>

[GitHub] groovy pull request #484: GROOVY-8067: Possible deadlock when creating new C...

2017-02-07 Thread jwagenleitner
Github user jwagenleitner closed the pull request at: https://github.com/apache/groovy/pull/484 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] groovy pull request #491: GROOVY-8068: improper logging in groovy.sql.Sql

2017-02-07 Thread jwagenleitner
Github user jwagenleitner commented on a diff in the pull request: https://github.com/apache/groovy/pull/491#discussion_r99844410 --- Diff: subprojects/groovy-sql/src/main/java/groovy/sql/Sql.java --- @@ -578,17 +578,26 @@ public static Sql newInstance(Map<String, Object>

[GitHub] groovy pull request #490: GROOVY-8072: AstBrowser source view does not gener...

2017-02-05 Thread jwagenleitner
GitHub user jwagenleitner opened a pull request: https://github.com/apache/groovy/pull/490 GROOVY-8072: AstBrowser source view does not generate labels for stat… …ements You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] groovy pull request #489: GROOVY-8067: Possible deadlock when creating new C...

2017-02-04 Thread jwagenleitner
Github user jwagenleitner commented on a diff in the pull request: https://github.com/apache/groovy/pull/489#discussion_r99482851 --- Diff: src/main/org/codehaus/groovy/reflection/ClassInfo.java --- @@ -186,30 +185,20 @@ public void setStrongMetaClass(MetaClass answer

[GitHub] groovy pull request #489: GROOVY-8067: Possible deadlock when creating new C...

2017-02-04 Thread jwagenleitner
GitHub user jwagenleitner opened a pull request: https://github.com/apache/groovy/pull/489 GROOVY-8067: Possible deadlock when creating new ClassInfo entries in the cache As suggested in PR #484 removed the locking on the `ManagedLinkedList` by creating a new

[GitHub] groovy pull request #484: GROOVY-8067: Possible deadlock when creating new C...

2017-01-29 Thread jwagenleitner
GitHub user jwagenleitner opened a pull request: https://github.com/apache/groovy/pull/484 GROOVY-8067: Possible deadlock when creating new ClassInfo entries in the cache While I have been able to replicate the deadlock between `GroovyClassValuePreJava7$Segment

[GitHub] groovy pull request #325: GROOVY-7646 - Classes generated by Eval() never co...

2017-01-22 Thread jwagenleitner
Github user jwagenleitner closed the pull request at: https://github.com/apache/groovy/pull/325 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] groovy pull request #477: AstBrowser fix showing Trait object initializers

2017-01-14 Thread jwagenleitner
GitHub user jwagenleitner opened a pull request: https://github.com/apache/groovy/pull/477 AstBrowser fix showing Trait object initializers Fix to problem reported by @paulk-asert in PR #473 You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] groovy pull request #475: GROOVY-5471: Add "indy" option to Groovy Console (...

2017-01-03 Thread jwagenleitner
GitHub user jwagenleitner opened a pull request: https://github.com/apache/groovy/pull/475 GROOVY-5471: Add "indy" option to Groovy Console (and AstBrowser) You can merge this pull request into a Git repository by running: $ git pull https://github.com/jwagenleit

[GitHub] groovy pull request #473: GROOVY-4636: AST Browser does not show object init...

2016-12-31 Thread jwagenleitner
GitHub user jwagenleitner opened a pull request: https://github.com/apache/groovy/pull/473 GROOVY-4636: AST Browser does not show object initializer statements You can merge this pull request into a Git repository by running: $ git pull https://github.com/jwagenleitner/groovy

[GitHub] groovy pull request #462: GROOVY-6175: invoking Closure property like method...

2016-11-21 Thread jwagenleitner
GitHub user jwagenleitner opened a pull request: https://github.com/apache/groovy/pull/462 GROOVY-6175: invoking Closure property like method fails because of doCall Per the Closure class docs, to be able to use a Closure in short form, e.g., c(), in subclasses, you need to provide

[GitHub] groovy pull request #450: GROOVY-7089: Base64 URL Safe encoder

2016-10-24 Thread jwagenleitner
GitHub user jwagenleitner opened a pull request: https://github.com/apache/groovy/pull/450 GROOVY-7089: Base64 URL Safe encoder You can merge this pull request into a Git repository by running: $ git pull https://github.com/jwagenleitner/groovy GROOVY-7089-Base64Url

[GitHub] groovy pull request #:

2016-10-16 Thread jwagenleitner
Github user jwagenleitner commented on the pull request: https://github.com/apache/groovy/commit/3c074dc2058d4c5115f172094385d9efd302f3ce#commitcomment-19444132 :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] groovy pull request #432: GROOVY-7909 Calling parents method from trait usin...

2016-10-16 Thread jwagenleitner
Github user jwagenleitner commented on a diff in the pull request: https://github.com/apache/groovy/pull/432#discussion_r83546094 --- Diff: src/main/org/codehaus/groovy/transform/trait/SuperCallTraitTransformer.java --- @@ -36,13 +38,19 @@ import java.util.List

  1   2   >