[GitHub] groovy pull request #638: Remove deprecated StringGroovyMethods.capitalize c...

2017-11-17 Thread russellsanborn
GitHub user russellsanborn opened a pull request: https://github.com/apache/groovy/pull/638 Remove deprecated StringGroovyMethods.capitalize call I also noticed that propName was being capitalized three times in the createComparatorFor() method, so I only call it once

[GitHub] groovy pull request #636: Update DefaultGroovyMethods boolean operations

2017-11-13 Thread russellsanborn
GitHub user russellsanborn opened a pull request: https://github.com/apache/groovy/pull/636 Update DefaultGroovyMethods boolean operations * updated DefaultGroovyMethods.java boolean operations to allow for the left parameter to be null instead of throwing

[GitHub] groovy pull request #628: adding note about the ./gradlew command on unix li...

2017-11-04 Thread russellsanborn
GitHub user russellsanborn reopened a pull request: https://github.com/apache/groovy/pull/628 adding note about the ./gradlew command on unix like systems to README You can merge this pull request into a Git repository by running: $ git pull https://github.com/russellsanborn

[GitHub] groovy pull request #628: adding note about the ./gradlew command on unix li...

2017-11-04 Thread russellsanborn
Github user russellsanborn closed the pull request at: https://github.com/apache/groovy/pull/628 ---

[GitHub] groovy pull request #627: Made the DefaultGroovyMethodsTest file more groovy...

2017-11-04 Thread russellsanborn
Github user russellsanborn closed the pull request at: https://github.com/apache/groovy/pull/627 ---

[GitHub] groovy pull request #627: Made the DefaultGroovyMethodsTest file more groovy...

2017-11-04 Thread russellsanborn
GitHub user russellsanborn reopened a pull request: https://github.com/apache/groovy/pull/627 Made the DefaultGroovyMethodsTest file more groovy like. * Removed unnecessary semicolons and `public` modifiers. * replaced java style for loops with groovy `eachWithIndex` closures

[GitHub] groovy pull request #621: Replaced deprecated padLeft call in BaseDuration

2017-10-28 Thread russellsanborn
GitHub user russellsanborn opened a pull request: https://github.com/apache/groovy/pull/621 Replaced deprecated padLeft call in BaseDuration `StringGroovyMethods.padLeft(String, Number, String)` is deprecated. I converted this to use the recommended `StringGroovyMethods.padLeft

[GitHub] groovy pull request #620: Adding spacing around equals operator for consiste...

2017-10-27 Thread russellsanborn
GitHub user russellsanborn opened a pull request: https://github.com/apache/groovy/pull/620 Adding spacing around equals operator for consistency I noticed this while looking at the documentation for operators: http://groovy-lang.org/operators.html You can merge this pull