[GitHub] groovy pull request: Remove duplicate ReferenceBundle definitions

2016-01-27 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/groovy/pull/249


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] groovy pull request: Remove duplicate ReferenceBundle definitions

2016-01-26 Thread jwagenleitner
GitHub user jwagenleitner opened a pull request:

https://github.com/apache/groovy/pull/249

Remove duplicate ReferenceBundle definitions

Removed static initialization of default Soft/Weak bundles in 
ReferenceManager class.  The methods in that class were not used in the 
codebase.  Looking at the history of those static bundle references it appeared 
that 500 was the original threshold setting.  Typical startup creates roughly 
1000 managed references, so 500 seems like a more appropriate value than 5000.

Note: the deprecated methods are in the `org.codehaus.groovy.util` package 
which might be considered non-public even though the methods are public.  But 
just to be safe left them in place just in case they may be referenced in 
others code.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jwagenleitner/groovy refmanager

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/groovy/pull/249.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #249


commit 556ff46fc06d23bda84fad03161e586f4e1ebc8a
Author: John Wagenleitner 
Date:   2016-01-27T04:38:35Z

Remove duplicate ReferenceBundle definitions

Removed static initialization of default Soft/Weak bundles in 
ReferenceManager class.  The methods in that class were not used in the 
codebase.  Looking at the history of those static bundle references it appeared 
that 500 was the original threshold setting.  Typical startup creates roughly 
1000 managed references, so 500 seems like a more appropriate value than 5000.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---