[GitHub] groovy pull request #571: GROOVY-8245: @Newify(auto=false) not transforming ...

2017-08-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/groovy/pull/571 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] groovy pull request #579: GROOVY-8242: @Newify default attribute value

2017-08-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/groovy/pull/579 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] groovy pull request #579: GROOVY-8242: @Newify default attribute value

2017-08-05 Thread jwagenleitner
GitHub user jwagenleitner opened a pull request: https://github.com/apache/groovy/pull/579 GROOVY-8242: @Newify default attribute value Class values are only required for Python-style conversions so the attribute should default to an empty array to indicate it is not strictly

[GitHub] groovy pull request #578: Call iterators hasNext as last when simpler checks...

2017-07-31 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/groovy/pull/578 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] groovy pull request #578: Call iterators hasNext as last when simpler checks...

2017-07-27 Thread MartyNeal
GitHub user MartyNeal opened a pull request: https://github.com/apache/groovy/pull/578 Call iterators hasNext as last when simpler checks can be done first Addresses https://issues.apache.org/jira/browse/GROOVY-8271 You can merge this pull request into a Git repository by running:

[GitHub] groovy pull request #577: [GROOVY-8268] Add toString() override to ReturnSta...

2017-07-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/groovy/pull/577 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] groovy pull request #577: [GROOVY-8268] Add toString() override to ReturnSta...

2017-07-25 Thread abayer
GitHub user abayer opened a pull request: https://github.com/apache/groovy/pull/577 [GROOVY-8268] Add toString() override to ReturnStatement [GROOVY-8268](https://issues.apache.org/jira/browse/GROOVY-8268) Truly trivial, I know. =) You can merge this pull request into a Git

[GitHub] groovy pull request #576: GROOVY-7995: @CS closure call from closure

2017-07-22 Thread jwagenleitner
GitHub user jwagenleitner opened a pull request: https://github.com/apache/groovy/pull/576 GROOVY-7995: @CS closure call from closure Short syntax of closure call invokes wrong closure if wrapped in another closure. This fix includes a combination of the contributed commit from

[GitHub] groovy pull request #574: [GROOVY-8261] Adding some getText overrides

2017-07-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/groovy/pull/574 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] groovy pull request #575: cache GroovyRunnerRegistry values

2017-07-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/groovy/pull/575 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] groovy pull request #572: GROOVY-8251: Implement withCloseable on AutoClosea...

2017-07-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/groovy/pull/572 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] groovy pull request #575: cache GroovyRunnerRegistry values

2017-07-16 Thread jwagenleitner
GitHub user jwagenleitner opened a pull request: https://github.com/apache/groovy/pull/575 cache GroovyRunnerRegistry values The registry should be read heavy and most use made of the iterator. Few writes/loads should occur, so values should be cached in order to optimize iteratio

[GitHub] groovy pull request #558: GROOVY-8218 @Sortable allows reversed natural orde...

2017-07-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/groovy/pull/558 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] groovy pull request #573: add JMH to performance subproject

2017-07-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/groovy/pull/573 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] groovy pull request #567: GROOVY-8234: Add @Repeatable java8 annotation supp...

2017-07-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/groovy/pull/567 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] groovy pull request #565: GROOVY-8236: Report more meaningful error for vers...

2017-07-13 Thread paulk-asert
Github user paulk-asert closed the pull request at: https://github.com/apache/groovy/pull/565 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] groovy pull request #574: Adding some getText overrides

2017-07-12 Thread jglick
GitHub user jglick opened a pull request: https://github.com/apache/groovy/pull/574 Adding some getText overrides While debugging a `CompilationCustomizer` I noticed some cases where `getText` was less than helpful. @reviewbybees for my colleagues You can merge this pull r

[GitHub] groovy pull request #573: add JMH to performance subproject

2017-07-09 Thread jwagenleitner
GitHub user jwagenleitner opened a pull request: https://github.com/apache/groovy/pull/573 add JMH to performance subproject You can merge this pull request into a Git repository by running: $ git pull https://github.com/jwagenleitner/groovy jmh-perf Alternatively you can rev

[GitHub] groovy pull request #:

2017-07-08 Thread GreatAss-69802
Github user GreatAss-69802 commented on the pull request: https://github.com/apache/groovy/commit/8f6b7cdb7239e7e17b3fd42807558c0c85b50e3d#commitcomment-22993869 In src/test/org/codehaus/groovy/classgen/asm/sc/bugs/Groovy8240Bug.groovy: In src/test/org/codehaus/groovy/classgen/asm/

[GitHub] groovy pull request #572: GROOVY-8251: Implement withCloseable on AutoClosea...

2017-07-08 Thread jwagenleitner
GitHub user jwagenleitner opened a pull request: https://github.com/apache/groovy/pull/572 GROOVY-8251: Implement withCloseable on AutoCloseable `NioGroovyMethods.withAutoCloseable` was added for 2.5.0 as part of [GROOVY-7572](https://issues.apache.org/jira/browse/GROOVY-7572). It

[GitHub] groovy pull request #562: rename Java8 package from vm8 to v8 for consistenc...

2017-07-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/groovy/pull/562 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] groovy pull request #559: GROOVY-8222: Setting Source Position in newly crea...

2017-07-08 Thread jwagenleitner
Github user jwagenleitner commented on a diff in the pull request: https://github.com/apache/groovy/pull/559#discussion_r126288792 --- Diff: src/main/org/codehaus/groovy/classgen/AsmClassGenerator.java --- @@ -1218,7 +1218,7 @@ public void visitVariableExpression(VariableExpression

[GitHub] groovy pull request #559: GROOVY-8222: Setting Source Position in newly crea...

2017-07-08 Thread ArsenBabakhanyan
Github user ArsenBabakhanyan commented on a diff in the pull request: https://github.com/apache/groovy/pull/559#discussion_r126288571 --- Diff: src/main/org/codehaus/groovy/classgen/AsmClassGenerator.java --- @@ -1218,7 +1218,7 @@ public void visitVariableExpression(VariableExpress

[GitHub] groovy pull request #559: GROOVY-8222: Setting Source Position in newly crea...

2017-07-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/groovy/pull/559 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] groovy pull request #559: GROOVY-8222: Setting Source Position in newly crea...

2017-07-08 Thread blackdrag
Github user blackdrag commented on a diff in the pull request: https://github.com/apache/groovy/pull/559#discussion_r126288338 --- Diff: src/main/org/codehaus/groovy/classgen/AsmClassGenerator.java --- @@ -1218,7 +1218,7 @@ public void visitVariableExpression(VariableExpression exp

[GitHub] groovy pull request #559: GROOVY-8222: Setting Source Position in newly crea...

2017-07-08 Thread ArsenBabakhanyan
Github user ArsenBabakhanyan commented on a diff in the pull request: https://github.com/apache/groovy/pull/559#discussion_r126286972 --- Diff: src/main/org/codehaus/groovy/classgen/AsmClassGenerator.java --- @@ -1251,11 +1251,13 @@ private void processClassVariable(String name) {

[GitHub] groovy pull request #559: GROOVY-8222: Setting Source Position in newly crea...

2017-07-08 Thread jwagenleitner
Github user jwagenleitner commented on a diff in the pull request: https://github.com/apache/groovy/pull/559#discussion_r126286817 --- Diff: src/main/org/codehaus/groovy/classgen/AsmClassGenerator.java --- @@ -1251,11 +1251,13 @@ private void processClassVariable(String name) {

[GitHub] groovy pull request #559: GROOVY-8222: Setting Source Position in newly crea...

2017-07-08 Thread jwagenleitner
Github user jwagenleitner commented on a diff in the pull request: https://github.com/apache/groovy/pull/559#discussion_r126286728 --- Diff: src/main/org/codehaus/groovy/classgen/AsmClassGenerator.java --- @@ -1251,11 +1251,13 @@ private void processClassVariable(String name) {

[GitHub] groovy pull request #558: GROOVY-8218 @Sortable allows reversed natural orde...

2017-07-04 Thread jwagenleitner
Github user jwagenleitner commented on a diff in the pull request: https://github.com/apache/groovy/pull/558#discussion_r125553663 --- Diff: src/main/groovy/transform/Sortable.java --- @@ -145,4 +170,9 @@ * Must not be used if 'includes' is used. */ Stri

[GitHub] groovy pull request #558: GROOVY-8218 @Sortable allows reversed natural orde...

2017-07-04 Thread jwagenleitner
Github user jwagenleitner commented on a diff in the pull request: https://github.com/apache/groovy/pull/558#discussion_r12008 --- Diff: src/main/org/codehaus/groovy/transform/SortableASTTransformation.java --- @@ -82,6 +82,7 @@ public void visit(ASTNode[] nodes, SourceUnit sou

[GitHub] groovy pull request #558: GROOVY-8218 @Sortable allows reversed natural orde...

2017-07-04 Thread jwagenleitner
Github user jwagenleitner commented on a diff in the pull request: https://github.com/apache/groovy/pull/558#discussion_r125554738 --- Diff: src/main/org/codehaus/groovy/transform/AbstractASTTransformation.java --- @@ -115,6 +115,14 @@ public int getMemberIntValue(AnnotationNode no

[GitHub] groovy pull request #558: GROOVY-8218 @Sortable allows reversed natural orde...

2017-07-04 Thread jwagenleitner
Github user jwagenleitner commented on a diff in the pull request: https://github.com/apache/groovy/pull/558#discussion_r125553175 --- Diff: src/main/org/codehaus/groovy/transform/SortableASTTransformation.java --- @@ -112,7 +113,7 @@ private static void implementComparable(ClassNo

[GitHub] groovy pull request #558: GROOVY-8218 @Sortable allows reversed natural orde...

2017-07-04 Thread jwagenleitner
Github user jwagenleitner commented on a diff in the pull request: https://github.com/apache/groovy/pull/558#discussion_r125552693 --- Diff: src/main/org/codehaus/groovy/ast/tools/GeneralUtils.java --- @@ -219,10 +219,38 @@ public static ClosureExpression closureX(Statement code) {

[GitHub] groovy pull request #570: GROOVY-8240: Compilation error in @CompileStatic

2017-07-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/groovy/pull/570 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] groovy pull request #571: GROOVY-8245: @Newify(auto=false) not transforming ...

2017-07-04 Thread jwagenleitner
GitHub user jwagenleitner opened a pull request: https://github.com/apache/groovy/pull/571 GROOVY-8245: @Newify(auto=false) not transforming declarations Also added default for `value` attribute for [GROOVY-8242](https://issues.apache.org/jira/browse/GROOVY-8242). You can merge thi

[GitHub] groovy pull request #564: GROOVY-8197: Make JUnit3/4 GroovyRunners

2017-07-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/groovy/pull/564 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] groovy pull request #570: GROOVY-8240: Compilation error in @CompileStatic

2017-06-29 Thread avafanasiev
GitHub user avafanasiev opened a pull request: https://github.com/apache/groovy/pull/570 GROOVY-8240: Compilation error in @CompileStatic I have no idea why should generated methods should have receiver as declared class. It causes bug https://issues.apache.org/jira/browse/GROOVY-82

[GitHub] groovy pull request #569: include indy in benchmark runs

2017-06-27 Thread jwagenleitner
GitHub user jwagenleitner opened a pull request: https://github.com/apache/groovy/pull/569 include indy in benchmark runs You can merge this pull request into a Git repository by running: $ git pull https://github.com/jwagenleitner/groovy benchmarks Alternatively you can revi

[GitHub] groovy pull request #568: GROOVY-8042 groovyConsole gets confused with a sla...

2017-06-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/groovy/pull/568 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] groovy pull request #568: GROOVY-8042 groovyConsole gets confused with a sla...

2017-06-27 Thread dkhamitov
GitHub user dkhamitov opened a pull request: https://github.com/apache/groovy/pull/568 GROOVY-8042 groovyConsole gets confused with a slashy string with an escaped forward slash Hi, guys! Here is quite a simple fix for the case when a slashy string renders in yellow just up to the

[GitHub] groovy pull request #567: GROOVY-8234: Add @Repeatable java8 annotation supp...

2017-06-26 Thread paulk-asert
GitHub user paulk-asert opened a pull request: https://github.com/apache/groovy/pull/567 GROOVY-8234: Add @Repeatable java8 annotation support You can merge this pull request into a Git repository by running: $ git pull https://github.com/paulk-asert/groovy groovy8234 Alterna

[GitHub] groovy pull request #566: Added IgnoreDefaultEqualsAndToString

2017-06-25 Thread pditommaso
GitHub user pditommaso opened a pull request: https://github.com/apache/groovy/pull/566 Added IgnoreDefaultEqualsAndToString This annotation allows custom `Collection` and `Map` objects to bypass the default Groovy format and equality methods ie. `toString` and `equals`. You can me

[GitHub] groovy pull request #564: GROOVY-8197: Make JUnit3/4 GroovyRunners

2017-06-25 Thread paulk-asert
Github user paulk-asert commented on a diff in the pull request: https://github.com/apache/groovy/pull/564#discussion_r123887454 --- Diff: subprojects/groovy-testng/src/test/groovy/org/codehaus/groovy/testng/TestNgRunnerTest.groovy --- @@ -0,0 +1,41 @@ +/* + * Licensed to

[GitHub] groovy pull request #565: GROOVY-8236: Report more meaningful error for vers...

2017-06-25 Thread paulk-asert
GitHub user paulk-asert opened a pull request: https://github.com/apache/groovy/pull/565 GROOVY-8236: Report more meaningful error for versions of Groovy not … …supporting @Repeatable You can merge this pull request into a Git repository by running: $ git pull https://githu

[GitHub] groovy pull request #561: GROOVY-8230: Deadlock in GroovyClassLoader

2017-06-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/groovy/pull/561 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] groovy pull request #564: GROOVY-8197: Make JUnit3/4 GroovyRunners

2017-06-24 Thread jwagenleitner
GitHub user jwagenleitner opened a pull request: https://github.com/apache/groovy/pull/564 GROOVY-8197: Make JUnit3/4 GroovyRunners You can merge this pull request into a Git repository by running: $ git pull https://github.com/jwagenleitner/groovy 8197-groovyrunners Alternat

[GitHub] groovy pull request #563: vmplugin

2017-06-20 Thread jwagenleitner
GitHub user jwagenleitner opened a pull request: https://github.com/apache/groovy/pull/563 vmplugin Alternative to PR #562. I tried to make incremental commits to make it easier to review. Still outstanding are the indy related classes in `org.codehaus.groovy.vmplugin.v7`

[GitHub] groovy pull request #503: Provide logging for bytecode generation

2017-06-20 Thread danielsun1106
Github user danielsun1106 closed the pull request at: https://github.com/apache/groovy/pull/503 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] groovy pull request #546: GROOVY-7654: Iterable as List and Iterable.asList(...

2017-06-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/groovy/pull/546 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] groovy pull request #560: GROOVY-8226: JSR308 initial plumbing tweaks

2017-06-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/groovy/pull/560 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] groovy pull request #562: rename Java8 package from vm8 to v8 for consistenc...

2017-06-18 Thread jwagenleitner
GitHub user jwagenleitner opened a pull request: https://github.com/apache/groovy/pull/562 rename Java8 package from vm8 to v8 for consistency You can merge this pull request into a Git repository by running: $ git pull https://github.com/jwagenleitner/groovy v8 Alternatively

[GitHub] groovy pull request #561: GROOVY-8230: Deadlock in GroovyClassLoader

2017-06-18 Thread jwagenleitner
GitHub user jwagenleitner opened a pull request: https://github.com/apache/groovy/pull/561 GROOVY-8230: Deadlock in GroovyClassLoader You can merge this pull request into a Git repository by running: $ git pull https://github.com/jwagenleitner/groovy 8230-gcl-deadlock Alterna

[GitHub] groovy pull request #:

2017-06-16 Thread danielsun1106
Github user danielsun1106 commented on the pull request: https://github.com/apache/groovy/commit/9c99898433c4f11e0bdd38ebab528ae0d6c6072a#commitcomment-22586490 weird... some tests failed, but they pass before upgrading gradle. --- If your project is set up for it, you can reply to t

[GitHub] groovy pull request #:

2017-06-16 Thread melix
Github user melix commented on the pull request: https://github.com/apache/groovy/commit/6c4fa92328f48c9a0e2c85c4a26e65000dbd1088#commitcomment-22584865 Sorry my bad, it's not an API change, it's just that I had the build scan recipes plugin applied in an init script, so I didn't real

[GitHub] groovy pull request #:

2017-06-16 Thread danielsun1106
Github user danielsun1106 commented on the pull request: https://github.com/apache/groovy/commit/6c4fa92328f48c9a0e2c85c4a26e65000dbd1088#commitcomment-22584566 API changed... ``` Build file '/home/travis/build/apache/groovy/build.gradle' line: 63 * What went wron

[GitHub] groovy pull request #:

2017-06-16 Thread danielsun1106
Github user danielsun1106 commented on the pull request: https://github.com/apache/groovy/commit/dfd30db7d294233c2c737177aa1b13b6dfeadb8a#commitcomment-22583320 In gradle/wrapper/gradle-wrapper.properties: In gradle/wrapper/gradle-wrapper.properties on line 10: the file has not

[GitHub] groovy pull request #560: GROOVY-8226: JSR308 initial plumbing tweaks

2017-06-13 Thread paulk-asert
Github user paulk-asert commented on a diff in the pull request: https://github.com/apache/groovy/pull/560#discussion_r121667932 --- Diff: src/main/org/codehaus/groovy/vmplugin/vm8/Java8.java --- @@ -51,4 +53,13 @@ public int getVersion() { return 8; }

[GitHub] groovy pull request #560: GROOVY-8226: JSR308 initial plumbing tweaks

2017-06-12 Thread jwagenleitner
Github user jwagenleitner commented on a diff in the pull request: https://github.com/apache/groovy/pull/560#discussion_r121416370 --- Diff: src/main/org/codehaus/groovy/vmplugin/vm8/Java8.java --- @@ -51,4 +53,13 @@ public int getVersion() { return 8; }

[GitHub] groovy pull request #560: GROOVY-8226: JSR308 initial plumbing tweaks

2017-06-12 Thread paulk-asert
GitHub user paulk-asert opened a pull request: https://github.com/apache/groovy/pull/560 GROOVY-8226: JSR308 initial plumbing tweaks You can merge this pull request into a Git repository by running: $ git pull https://github.com/paulk-asert/groovy groovy8226 Alternatively you

[GitHub] groovy pull request #559: GROOVY-8222: Setting Source Position in newly crea...

2017-06-11 Thread ArsenBabakhanyan
GitHub user ArsenBabakhanyan opened a pull request: https://github.com/apache/groovy/pull/559 GROOVY-8222: Setting Source Position in newly created PropertyExpression You can merge this pull request into a Git repository by running: $ git pull https://github.com/ArsenBabakhany

[GitHub] groovy pull request #532: Prevent CachedField and CachedMethod from leaking ...

2017-06-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/groovy/pull/532 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] groovy pull request #558: GROOVY-8218 @Sortable allows reversed natural orde...

2017-06-03 Thread Leward
GitHub user Leward opened a pull request: https://github.com/apache/groovy/pull/558 GROOVY-8218 @Sortable allows reversed natural ordering See [GROOVY-8218](https://issues.apache.org/jira/browse/GROOVY-8218) You can merge this pull request into a Git repository by running: $ gi

[GitHub] groovy pull request #557: GROOVY-8056: GroovyCodeSource(URL) can leak a file...

2017-06-03 Thread jwagenleitner
Github user jwagenleitner closed the pull request at: https://github.com/apache/groovy/pull/557 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] groovy pull request #500: GROOVY-8056: GroovyCodeSource(URL) can leak a file...

2017-06-03 Thread jwagenleitner
Github user jwagenleitner closed the pull request at: https://github.com/apache/groovy/pull/500 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] groovy pull request #557: GROOVY-8056: GroovyCodeSource(URL) can leak a file...

2017-06-03 Thread jwagenleitner
GitHub user jwagenleitner opened a pull request: https://github.com/apache/groovy/pull/557 GROOVY-8056: GroovyCodeSource(URL) can leak a file handler A safer fix in terms of compatibility compared to PR #500. You can merge this pull request into a Git repository by running: $

[GitHub] groovy pull request #554: Fix a typo

2017-06-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/groovy/pull/554 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] groovy pull request #556: GROOVY-8209 simple http client without extra depen...

2017-06-01 Thread dlukyanov
GitHub user dlukyanov opened a pull request: https://github.com/apache/groovy/pull/556 GROOVY-8209 simple http client without extra dependecies [WIP] The idea is to create a simple http client without extra dependencies that will cover rest client needs. Code example: `

[GitHub] groovy pull request #555: GROOVY-8200 - Shorthand |= results in NPE

2017-05-31 Thread noamt
GitHub user noamt opened a pull request: https://github.com/apache/groovy/pull/555 GROOVY-8200 - Shorthand |= results in NPE Fixing the NPE with an explicit test and assignment of the right-hand boolean operator. Assigning a primitive boolean variable with null, like `boolean x

[GitHub] groovy pull request #554: Fix a typo

2017-05-31 Thread bcamur
GitHub user bcamur opened a pull request: https://github.com/apache/groovy/pull/554 Fix a typo Change verb 'clarify' to noun 'clarity'. You can merge this pull request into a Git repository by running: $ git pull https://github.com/bcamur/groovy patch-1 Alternatively you can r

[GitHub] groovy pull request #553: require JDK 8+ for release builds (2_5_X/2_6_X)

2017-05-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/groovy/pull/553 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] groovy pull request #553: require JDK 8+ for release builds (2_5_X/2_6_X)

2017-05-27 Thread jwagenleitner
GitHub user jwagenleitner opened a pull request: https://github.com/apache/groovy/pull/553 require JDK 8+ for release builds (2_5_X/2_6_X) For 2_5_X and 2_6_X in order to compile all features JDK 8+ is required for building releases (related to PR #545). Also included a co

[GitHub] groovy pull request #552: GROOVY-7979: Prevent JsonSlurper issue on a single...

2017-05-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/groovy/pull/552 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] groovy pull request #545: GROOVY-7611: java.util.Optional should evaluate to...

2017-05-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/groovy/pull/545 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] groovy pull request #544: refactor: type safety and formatting

2017-05-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/groovy/pull/544 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] groovy pull request #552: GROOVY-7979: Prevent JsonSlurper issue on a single...

2017-05-26 Thread JamesLaverack
GitHub user JamesLaverack opened a pull request: https://github.com/apache/groovy/pull/552 GROOVY-7979: Prevent JsonSlurper issue on a single minus Add bound checking to JSON parser code to account for a single minus character. You can merge this pull request into a Git repository

[GitHub] groovy pull request #551: GROOVY-8204: @Delegate on arrays causes NPE during...

2017-05-25 Thread paulk-asert
Github user paulk-asert commented on a diff in the pull request: https://github.com/apache/groovy/pull/551#discussion_r118622384 --- Diff: src/main/org/codehaus/groovy/ast/ClassHelper.java --- @@ -440,12 +440,15 @@ private static boolean hasUsableImplementation(ClassNode c, MethodN

[GitHub] groovy pull request #551: GROOVY-8204: @Delegate on arrays causes NPE during...

2017-05-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/groovy/pull/551 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] groovy pull request #550: GROOVY-8203: Add @Newify will cause ?. operator NP...

2017-05-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/groovy/pull/550 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] groovy pull request #549: GROOVY-8114: Include correct time unit in timeout ...

2017-05-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/groovy/pull/549 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] groovy pull request #548: GROOVY-3270: GroovyConsole: Configurable output ar...

2017-05-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/groovy/pull/548 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] groovy pull request #540: GROOVY-7535: Groovy category throwing MissingMetho...

2017-05-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/groovy/pull/540 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] groovy pull request #551: GROOVY-8204: @Delegate on arrays causes NPE during...

2017-05-25 Thread jwagenleitner
Github user jwagenleitner commented on a diff in the pull request: https://github.com/apache/groovy/pull/551#discussion_r118507014 --- Diff: src/main/org/codehaus/groovy/ast/ClassHelper.java --- @@ -440,12 +440,15 @@ private static boolean hasUsableImplementation(ClassNode c, Metho

[GitHub] groovy pull request #551: GROOVY-8204: @Delegate on arrays causes NPE during...

2017-05-25 Thread paulk-asert
GitHub user paulk-asert opened a pull request: https://github.com/apache/groovy/pull/551 GROOVY-8204: @Delegate on arrays causes NPE during compilation You can merge this pull request into a Git repository by running: $ git pull https://github.com/paulk-asert/groovy groovy8204

[GitHub] groovy pull request #550: GROOVY-8203: Add @Newify will cause ?. operator NP...

2017-05-25 Thread paulk-asert
GitHub user paulk-asert opened a pull request: https://github.com/apache/groovy/pull/550 GROOVY-8203: Add @Newify will cause ?. operator NPE You can merge this pull request into a Git repository by running: $ git pull https://github.com/paulk-asert/groovy groovy8203 Alternati

[GitHub] groovy pull request #549: GROOVY-8114: Include correct time unit in timeout ...

2017-05-24 Thread paulk-asert
GitHub user paulk-asert opened a pull request: https://github.com/apache/groovy/pull/549 GROOVY-8114: Include correct time unit in timeout error message PR for patch as supplied by Jochen Kemnade. You can merge this pull request into a Git repository by running: $ git pull http

[GitHub] groovy pull request #548: GROOVY-3270: GroovyConsole: Configurable output ar...

2017-05-24 Thread emilianbold
GitHub user emilianbold opened a pull request: https://github.com/apache/groovy/pull/548 GROOVY-3270: GroovyConsole: Configurable output area size Based on the solution started byJohn Wagenleitner. You can merge this pull request into a Git repository by running: $ git pull htt

[GitHub] groovy pull request #547: GROOVY-8186: Builder ExternalStrategy constructors...

2017-05-22 Thread paulk-asert
GitHub user paulk-asert opened a pull request: https://github.com/apache/groovy/pull/547 GROOVY-8186: Builder ExternalStrategy constructors have trouble with … …private fields You can merge this pull request into a Git repository by running: $ git pull https://github.com/pa

[GitHub] groovy pull request #546: GROOVY-7654: Iterable as List and Iterable.asList(...

2017-05-21 Thread blackdrag
Github user blackdrag commented on a diff in the pull request: https://github.com/apache/groovy/pull/546#discussion_r117645462 --- Diff: src/test/org/codehaus/groovy/runtime/DefaultGroovyMethodsTest.groovy --- @@ -236,7 +236,28 @@ public class DefaultGroovyMethodsTest extends Groo

[GitHub] groovy pull request #546: GROOVY-7654: Iterable as List and Iterable.asList(...

2017-05-21 Thread blackdrag
Github user blackdrag commented on a diff in the pull request: https://github.com/apache/groovy/pull/546#discussion_r117645390 --- Diff: src/test/org/codehaus/groovy/runtime/DefaultGroovyMethodsTest.groovy --- @@ -236,7 +236,28 @@ public class DefaultGroovyMethodsTest extends Groo

[GitHub] groovy pull request #546: GROOVY-7654: Iterable as List and Iterable.asList(...

2017-05-21 Thread armsargis
Github user armsargis commented on a diff in the pull request: https://github.com/apache/groovy/pull/546#discussion_r117642241 --- Diff: src/test/org/codehaus/groovy/runtime/DefaultGroovyMethodsTest.groovy --- @@ -236,7 +236,28 @@ public class DefaultGroovyMethodsTest extends Groo

[GitHub] groovy pull request #546: GROOVY-7654: Iterable as List and Iterable.asList(...

2017-05-21 Thread armsargis
Github user armsargis commented on a diff in the pull request: https://github.com/apache/groovy/pull/546#discussion_r117642093 --- Diff: src/test/org/codehaus/groovy/runtime/DefaultGroovyMethodsTest.groovy --- @@ -236,7 +236,28 @@ public class DefaultGroovyMethodsTest extends Groo

[GitHub] groovy pull request #546: GROOVY-7654: Iterable as List and Iterable.asList(...

2017-05-21 Thread blackdrag
Github user blackdrag commented on a diff in the pull request: https://github.com/apache/groovy/pull/546#discussion_r117640763 --- Diff: src/test/org/codehaus/groovy/runtime/DefaultGroovyMethodsTest.groovy --- @@ -236,7 +236,28 @@ public class DefaultGroovyMethodsTest extends Groo

[GitHub] groovy pull request #546: GROOVY-7654: Iterable as List and Iterable.asList(...

2017-05-21 Thread armsargis
GitHub user armsargis opened a pull request: https://github.com/apache/groovy/pull/546 GROOVY-7654: Iterable as List and Iterable.asList() have different semantics Introduce DefaultGroovyMethods.asType(Iterable, Class) to handle correctly 'asType' to iterables You can merge this pu

[GitHub] groovy pull request #545: GROOVY-7611: java.util.Optional should evaluate to...

2017-05-21 Thread jwagenleitner
GitHub user jwagenleitner opened a pull request: https://github.com/apache/groovy/pull/545 GROOVY-7611: java.util.Optional should evaluate to false if empty (Java8 VMPlugin) Target for this would be `2_5_X` and above. For `2_5_X` and `2_6_X` it would require that the release proce

[GitHub] groovy pull request #544: refactor: type safety and formatting

2017-05-20 Thread graemerocher
Github user graemerocher commented on a diff in the pull request: https://github.com/apache/groovy/pull/544#discussion_r117615150 --- Diff: src/main/org/codehaus/groovy/transform/trait/Traits.java --- @@ -355,19 +355,19 @@ static String getSuperTraitMethodName(ClassNode trait, Stri

[GitHub] groovy pull request #544: refactor: type safety and formatting

2017-05-20 Thread jwagenleitner
Github user jwagenleitner commented on a diff in the pull request: https://github.com/apache/groovy/pull/544#discussion_r117615134 --- Diff: src/main/org/codehaus/groovy/transform/trait/Traits.java --- @@ -355,19 +355,19 @@ static String getSuperTraitMethodName(ClassNode trait, Str

[GitHub] groovy pull request #544: refactor: type safety and formatting

2017-05-20 Thread graemerocher
Github user graemerocher commented on a diff in the pull request: https://github.com/apache/groovy/pull/544#discussion_r117614896 --- Diff: src/main/org/codehaus/groovy/transform/trait/Traits.java --- @@ -355,19 +355,19 @@ static String getSuperTraitMethodName(ClassNode trait, Stri

[GitHub] groovy pull request #544: refactor: type safety and formatting

2017-05-20 Thread graemerocher
Github user graemerocher commented on a diff in the pull request: https://github.com/apache/groovy/pull/544#discussion_r117614868 --- Diff: src/main/org/codehaus/groovy/transform/trait/Traits.java --- @@ -355,19 +355,19 @@ static String getSuperTraitMethodName(ClassNode trait, Stri

[GitHub] groovy pull request #544: refactor: type safety and formatting

2017-05-20 Thread jwagenleitner
GitHub user jwagenleitner opened a pull request: https://github.com/apache/groovy/pull/544 refactor: type safety and formatting You can merge this pull request into a Git repository by running: $ git pull https://github.com/jwagenleitner/groovy refactor Alternatively you can

[GitHub] groovy pull request #:

2017-05-20 Thread PascalSchumacher
Github user PascalSchumacher commented on the pull request: https://github.com/apache/groovy/commit/b02d2f57c09ba6ba46553ed77aff191ec9ab274e#commitcomment-22219191 In subprojects/parser-antlr4/src/main/java/org/apache/groovy/parser/antlr4/util/StringUtils.java: In subprojects/par

<    4   5   6   7   8   9   10   11   12   13   >