[GitHub] groovy pull request #757: GROOVY-8008: AIOOB inner class ctor params with ru...

2018-06-20 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/groovy/pull/757


---

[GitHub] groovy pull request #757: GROOVY-8008: AIOOB inner class ctor params with ru...

2018-06-18 Thread jwagenleitner 
Github user jwagenleitner commented on a diff in the pull request:

https://github.com/apache/groovy/pull/757#discussion_r196172656
  
--- Diff: src/main/java/org/codehaus/groovy/vmplugin/v5/Java5.java ---
@@ -405,6 +408,32 @@ public void configureClassNode(CompileUnit 
compileUnit, ClassNode classNode) {
 }
 }
 
+/**
+ * Synthetic parameters such as those added for inner class 
constructors may not be
+ * included in the parameter annotations array.  This is the case when 
at least one
+ * parameter of an inner class constructor is annotated with a RUNTIME 
retention
+ * policy.  This method will normalize the annotation array so that it 
contains the
+ * same number of elements as the array returned from {@link 
Constructor#getParameterTypes()}.
+ *
+ * If adjustment is required, the adjusted array will be pre-pended 
will zero-length
--- End diff --

Fixed, thanks.


---

[GitHub] groovy pull request #757: GROOVY-8008: AIOOB inner class ctor params with ru...

2018-06-17 Thread paulk-asert 
Github user paulk-asert commented on a diff in the pull request:

https://github.com/apache/groovy/pull/757#discussion_r195962344
  
--- Diff: src/main/java/org/codehaus/groovy/vmplugin/v5/Java5.java ---
@@ -405,6 +408,32 @@ public void configureClassNode(CompileUnit 
compileUnit, ClassNode classNode) {
 }
 }
 
+/**
+ * Synthetic parameters such as those added for inner class 
constructors may not be
+ * included in the parameter annotations array.  This is the case when 
at least one
+ * parameter of an inner class constructor is annotated with a RUNTIME 
retention
+ * policy.  This method will normalize the annotation array so that it 
contains the
+ * same number of elements as the array returned from {@link 
Constructor#getParameterTypes()}.
+ *
+ * If adjustment is required, the adjusted array will be pre-pended 
will zero-length
--- End diff --

minor typo: second 'will' should be 'with'


---

[GitHub] groovy pull request #757: GROOVY-8008: AIOOB inner class ctor params with ru...

2018-06-14 Thread jwagenleitner 
GitHub user jwagenleitner opened a pull request:

https://github.com/apache/groovy/pull/757

GROOVY-8008: AIOOB inner class ctor params with runtime annotations

Should also address 
[GROOVY-8505](https://issues.apache.org/jira/browse/GROOVY-8505) which is the 
same issue.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jwagenleitner/groovy 
8008-aioob-inner-class-ctor-param-annos

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/groovy/pull/757.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #757


commit e5e8da40dc3e2d1d141280ee5162247da7ed3083
Author: John Wagenleitner 
Date:   2018-06-15T02:37:56Z

GROOVY-8008: AIOOB inner class ctor params with runtime annotations




---