[GitHub] mcherkasov opened a new pull request #5865: Added validateNode method with discoData argument.
mcherkasov opened a new pull request #5865: Added validateNode method with discoData argument. URL: https://github.com/apache/ignite/pull/5865 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] AMashenkov opened a new pull request #5863: Ignite-10976: MVCC: Sql API methods should throws proper TransactionExceptions in case of tx failure.
AMashenkov opened a new pull request #5863: Ignite-10976: MVCC: Sql API methods should throws proper TransactionExceptions in case of tx failure. URL: https://github.com/apache/ignite/pull/5863 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sergey-chugunov-1985 edited a comment on issue #5814: IGNITE-10777 Cleanup remainders of JUnit4TestAdapter and other JUnit 3 API involving test suites
sergey-chugunov-1985 edited a comment on issue #5814: IGNITE-10777 Cleanup remainders of JUnit4TestAdapter and other JUnit 3 API involving test suites URL: https://github.com/apache/ignite/pull/5814#issuecomment-455593484 I really like how zk-related tests are split from a huge class into a separate classes each testing specific aspects of functionality. But I have a suggestion about naming of new ZookeeperDiscovery test classes. What if we include a name of major functionality covered by each class? I would suggest the following changes: - ZookeeperDiscoverySpiTest -> ZookeeperDiscoveryMiscTest - Test2 -> SegmentationAndConnectionRestoreTest - Test3 -> ConcurrectStartAndStartStopTest - Test4 -> TopologyChangeAndReconnectTest - Test5 -> CommunicationFailureTest - Test6 -> ClientDisconnectTest - Test7 -> SplitBrainTest - Test8 -> CustomEventsTest This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sergey-chugunov-1985 commented on issue #5814: IGNITE-10777 Cleanup remainders of JUnit4TestAdapter and other JUnit 3 API involving test suites
sergey-chugunov-1985 commented on issue #5814: IGNITE-10777 Cleanup remainders of JUnit4TestAdapter and other JUnit 3 API involving test suites URL: https://github.com/apache/ignite/pull/5814#issuecomment-455593484 I really like how zk-related tests are split from a huge class into a separate classes testing specific aspects of functionality. But I have a suggestion about naming of new ZookeeperDiscovery test classes. What if we include a name of major functionality covered by each class? I would suggest the following changes: - ZookeeperDiscoverySpiTest -> ZookeeperDiscoveryMiscTest - Test2 -> SegmentationAndConnectionRestoreTest - Test3 -> ConcurrectStartAndStartStopTest - Test4 -> TopologyChangeAndReconnectTest - Test5 -> CommunicationFailureTest - Test6 -> ClientDisconnectTest - Test7 -> SplitBrainTest - Test8 -> CustomEventsTest This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sk0x50 opened a new pull request #5862: IGNITE-10987 skip-zeros flag filters out empty partitions regardless the value of update counter
sk0x50 opened a new pull request #5862: IGNITE-10987 skip-zeros flag filters out empty partitions regardless the value of update counter URL: https://github.com/apache/ignite/pull/5862 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dspavlov commented on a change in pull request #5662: IGNITE-8227 Research possibility and implement JUnit test failure handler for TeamCity
dspavlov commented on a change in pull request #5662: IGNITE-8227 Research
possibility and implement JUnit test failure handler for TeamCity
URL: https://github.com/apache/ignite/pull/5662#discussion_r249099127
##
File path:
modules/core/src/test/java/org/apache/ignite/failure/TestFailingFailureHandler.java
##
@@ -0,0 +1,64 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.failure;
+
+import junit.framework.TestCase;
+import org.apache.ignite.Ignite;
+import org.apache.ignite.internal.util.tostring.GridToStringExclude;
+import org.apache.ignite.internal.util.typedef.internal.S;
+import org.apache.ignite.testframework.junits.GridAbstractTest;
+
+import static
org.apache.ignite.testframework.junits.GridAbstractTest.testIsRunning;
+
+/**
+ * Stops node and fails test.
+ */
+public class TestFailingFailureHandler extends StopNodeFailureHandler {
+/** Test. */
+@GridToStringExclude
+protected final GridAbstractTest test;
+
+/**
+ * @param test Test.
+ */
+public TestFailingFailureHandler(GridAbstractTest test) {
+this.test = test;
+}
+
+/** {@inheritDoc} */
+@Override public boolean handle(Ignite ignite, FailureContext failureCtx) {
+if (!testIsRunning.getAndSet(false)) {
+ignite.log().info("Critical issue detected after test finished.
Test failure handler ignore it.");
+
+return true;
+}
+
+boolean nodeStopped = super.handle(ignite, failureCtx);
+
+TestCase.fail(failureCtx.toString());
Review comment:
why this line is needed here? This will result in Assertion failed error and
no handling will be performed later.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] AMashenkov opened a new pull request #5864: IGNITE-10976: MVCC: Sql API methods should throws proper TransactionExceptions in case of tx failure.
AMashenkov opened a new pull request #5864: IGNITE-10976: MVCC: Sql API methods should throws proper TransactionExceptions in case of tx failure. URL: https://github.com/apache/ignite/pull/5864 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] AMashenkov closed pull request #5836: IGNITE-10954: Unmute missed tests.
AMashenkov closed pull request #5836: IGNITE-10954: Unmute missed tests. URL: https://github.com/apache/ignite/pull/5836 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rkondakov opened a new pull request #5858: Check the broken test on TC.
rkondakov opened a new pull request #5858: Check the broken test on TC. URL: https://github.com/apache/ignite/pull/5858 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] asfgit closed pull request #5842: IGNITE-8532: [ML] GA Grid: Implement Roulette Wheel Selection
asfgit closed pull request #5842: IGNITE-8532: [ML] GA Grid: Implement Roulette Wheel Selection URL: https://github.com/apache/ignite/pull/5842 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dspavlov commented on a change in pull request #5856: IGNITE-10974 Release page lock even if exception throws on beforeReleaseWrite
dspavlov commented on a change in pull request #5856: IGNITE-10974 Release page
lock even if exception throws on beforeReleaseWrite
URL: https://github.com/apache/ignite/pull/5856#discussion_r249041543
##
File path:
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/pagemem/PageMemoryImpl.java
##
@@ -1543,24 +1543,32 @@ private void writeUnlockPage(
if (markDirty)
setDirty(fullId, page, markDirty, false);
-beforeReleaseWrite(fullId, page + PAGE_OVERHEAD, pageWalRec);
-
-long pageId = PageIO.getPageId(page + PAGE_OVERHEAD);
+try {
+beforeReleaseWrite(fullId, page + PAGE_OVERHEAD, pageWalRec);
+}
+catch (IgniteCheckedException e) {
Review comment:
Sorry, I've missed you removed try-catch in the method. Questions is not
actual anymore
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] macrergate opened a new pull request #5857: IGNITE-6564 Incorrect calculation size and keySize for cluster cache metrics
macrergate opened a new pull request #5857: IGNITE-6564 Incorrect calculation size and keySize for cluster cache metrics URL: https://github.com/apache/ignite/pull/5857 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rkondakov opened a new pull request #5859: IGNITE-10768: Check test on TC.
rkondakov opened a new pull request #5859: IGNITE-10768: Check test on TC. URL: https://github.com/apache/ignite/pull/5859 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dspavlov commented on a change in pull request #5856: IGNITE-10974 Release page lock even if exception throws on beforeReleaseWrite
dspavlov commented on a change in pull request #5856: IGNITE-10974 Release page
lock even if exception throws on beforeReleaseWrite
URL: https://github.com/apache/ignite/pull/5856#discussion_r249042204
##
File path:
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/pagemem/PageMemoryImpl.java
##
@@ -1673,16 +1681,13 @@ private void setDirty(FullPageId pageId, long absPtr,
boolean dirty, boolean for
/**
*
*/
-void beforeReleaseWrite(FullPageId pageId, long ptr, boolean pageWalRec) {
-if (walMgr != null && (pageWalRec || walMgr.isAlwaysWriteFullPages())
&& !walMgr.disabled(pageId.groupId())) {
-try {
-walMgr.log(new PageSnapshot(pageId, ptr, pageSize(),
realPageSize(pageId.groupId(;
-}
-catch (IgniteCheckedException e) {
-// TODO ignite-db.
-throw new IgniteException(e);
-}
-}
+void beforeReleaseWrite(FullPageId pageId, long ptr, boolean pageWalRec)
throws IgniteCheckedException {
+boolean walIsNotDisable = !walMgr.disabled(pageId.groupId());
Review comment:
walMgr != null check was missed. Before refactoring this code block with
null WAL manager was not ever executed.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] dgovorukhin commented on a change in pull request #5856: IGNITE-10974 Release page lock even if exception throws on beforeReleaseWrite
dgovorukhin commented on a change in pull request #5856: IGNITE-10974 Release page lock even if exception throws on beforeReleaseWrite URL: https://github.com/apache/ignite/pull/5856#discussion_r249050920 ## File path: modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/pagemem/PageMemoryImpl.java ## @@ -1543,24 +1543,32 @@ private void writeUnlockPage( if (markDirty) Review comment: Done This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] asfgit closed pull request #108: IGNITE-10942:: Optimize background JIRA tickets sync
asfgit closed pull request #108: IGNITE-10942:: Optimize background JIRA tickets sync URL: https://github.com/apache/ignite-teamcity-bot/pull/108 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] asfgit closed pull request #5803: IGNITE-10507 Add flag for checking CRC sums of stored pages on disk
asfgit closed pull request #5803: IGNITE-10507 Add flag for checking CRC sums of stored pages on disk URL: https://github.com/apache/ignite/pull/5803 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dgovorukhin opened a new pull request #5856: IGNITE-10974 Release page lock even if exception throws on beforeReleaseWrite
dgovorukhin opened a new pull request #5856: IGNITE-10974 Release page lock even if exception throws on beforeReleaseWrite URL: https://github.com/apache/ignite/pull/5856 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] oignatenko opened a new pull request #5867: IGNITE-10758 remove from tests scaffolding annotations
oignatenko opened a new pull request #5867: IGNITE-10758 remove from tests scaffolding annotations URL: https://github.com/apache/ignite/pull/5867 - wip -- verified with diffs overview and rebuild This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] oignatenko closed pull request #5840: IGNITE-10927 Relieve JUnit3TestLegacySupport from inheriting deprecated junit.framework.Assert
oignatenko closed pull request #5840: IGNITE-10927 Relieve JUnit3TestLegacySupport from inheriting deprecated junit.framework.Assert URL: https://github.com/apache/ignite/pull/5840 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] asfgit closed pull request #5856: IGNITE-10974 Release page lock even if exception throws on beforeReleaseWrite
asfgit closed pull request #5856: IGNITE-10974 Release page lock even if exception throws on beforeReleaseWrite URL: https://github.com/apache/ignite/pull/5856 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] asfgit closed pull request #5814: IGNITE-10777 Cleanup remainders of JUnit4TestAdapter and other JUnit 3 API involving test suites
asfgit closed pull request #5814: IGNITE-10777 Cleanup remainders of JUnit4TestAdapter and other JUnit 3 API involving test suites URL: https://github.com/apache/ignite/pull/5814 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] joooger opened a new pull request #5855: IGNITE-10688: Expose SQL views for IO statistics.
joooger opened a new pull request #5855: IGNITE-10688: Expose SQL views for IO statistics. URL: https://github.com/apache/ignite/pull/5855 IGNITE-10688 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ibessonov opened a new pull request #5854: IGNITE-8575 Change Baseline auto-adjust parameters via console.sh
ibessonov opened a new pull request #5854: IGNITE-8575 Change Baseline auto-adjust parameters via console.sh URL: https://github.com/apache/ignite/pull/5854 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
