[GitHub] dgovorukhin opened a new pull request #5937: IGNITE-11095 fix flaky test
dgovorukhin opened a new pull request #5937: IGNITE-11095 fix flaky test URL: https://github.com/apache/ignite/pull/5937 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] 6uest opened a new pull request #5936: IGNITE-11086 IGNITE_REST_SECURITY_TOKEN_TIMEOUT parameter is set in d…
6uest opened a new pull request #5936: IGNITE-11086 IGNITE_REST_SECURITY_TOKEN_TIMEOUT parameter is set in d… URL: https://github.com/apache/ignite/pull/5936 …eciseconds instead of seconds. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dspavlov opened a new pull request #110: IGNITE-10989 Removing in-memory caches for data presented in new TcIgnited DB.
dspavlov opened a new pull request #110: IGNITE-10989 Removing in-memory caches for data presented in new TcIgnited DB. URL: https://github.com/apache/ignite-teamcity-bot/pull/110 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] asfgit closed pull request #5931: IGNITE-11048 Fixed - Start node with TTL caches causes failure handle…
asfgit closed pull request #5931: IGNITE-11048 Fixed - Start node with TTL caches causes failure handle… URL: https://github.com/apache/ignite/pull/5931 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] asfgit closed pull request #5764: IGNITE-10087 IgniteClientReconnectMassiveShutdownTest.testMassiveServersShutdown1 is flaky in master
asfgit closed pull request #5764: IGNITE-10087 IgniteClientReconnectMassiveShutdownTest.testMassiveServersShutdown1 is flaky in master URL: https://github.com/apache/ignite/pull/5764 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] AMashenkov commented on a change in pull request #5778: IGNITE-5983: Enable obtaining memory policy metrics via REST.
AMashenkov commented on a change in pull request #5778: IGNITE-5983: Enable
obtaining memory policy metrics via REST.
URL: https://github.com/apache/ignite/pull/5778#discussion_r251051201
##
File path:
modules/clients/src/test/java/org/apache/ignite/internal/processors/rest/JettyRestProcessorAbstractSelfTest.java
##
@@ -1975,6 +1979,54 @@ public void testVisorGateway() throws Exception {
jsonTaskResult(ret);
}
+/**
+ * @throws Exception If failed.
+ */
+@Test
+public void testDataRegionMetrics() throws Exception {
+String ret = content(F.asMap("cmd",
GridRestCommand.DATA_REGION_METRICS.key()));
+
+JsonNode res = validateJsonResponse(ret);
+
+assertTrue(res.size() > 0);
+
+info(GridRestCommand.DATA_REGION_METRICS.key().toUpperCase() + "
command result: " + ret);
+}
+
+/**
+ * @throws Exception If failed.
+ */
+@Test
+public void testDataStorageMetricsDisabled() throws Exception {
+String ret = content(F.asMap("cmd",
GridRestCommand.DATA_STORAGE_METRICS.key()));
+
+JsonNode res = validateJsonResponse(ret);
+
+assertTrue(res.asText().equalsIgnoreCase("Storage metrics are not
enabled"));
+
+info(GridRestCommand.DATA_STORAGE_METRICS.key().toUpperCase() + "
command result: " + ret);
+}
+
+/**
+ * @throws Exception If failed.
+ */
+@Test
+public void testDataStorageMetricsEnabled() throws Exception {
+stopAllGrids();
+
+memoryMetricsEnabled = true;
Review comment:
Test execution order is not defined usually.
Let's add additional check and restart the grid if this option has to be
changed.
Same change need to be done in testDataStorageMetricsDisabled().
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] dspavlov commented on a change in pull request #5662: IGNITE-8227 Research possibility and implement JUnit test failure handler for TeamCity
dspavlov commented on a change in pull request #5662: IGNITE-8227 Research
possibility and implement JUnit test failure handler for TeamCity
URL: https://github.com/apache/ignite/pull/5662#discussion_r251041326
##
File path:
modules/core/src/test/java/org/apache/ignite/failure/TestFailingFailureHandler.java
##
@@ -0,0 +1,62 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.failure;
+
+import junit.framework.TestCase;
+import org.apache.ignite.Ignite;
+import org.apache.ignite.internal.util.tostring.GridToStringExclude;
+import org.apache.ignite.internal.util.typedef.internal.S;
+import org.apache.ignite.testframework.junits.GridAbstractTest;
+
+import static
org.apache.ignite.testframework.junits.GridAbstractTest.testIsRunning;
+
+/**
+ * Stops node and fails test.
+ */
+public class TestFailingFailureHandler extends StopNodeFailureHandler {
+/** Test. */
+@GridToStringExclude
+protected final GridAbstractTest test;
+
+/**
+ * @param test Test.
+ */
+public TestFailingFailureHandler(GridAbstractTest test) {
+this.test = test;
+}
+
+/** {@inheritDoc} */
+@Override public boolean handle(Ignite ignite, FailureContext failureCtx) {
+if (!testIsRunning.getAndSet(false)) {
Review comment:
Is it possible that a failure handler will be called by different threads
with different exceptions? Will these exceptions be visible in a resulting test
failure?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] ivandasch opened a new pull request #5935: IGNITE-11059 Log tx lock timeout.
ivandasch opened a new pull request #5935: IGNITE-11059 Log tx lock timeout. URL: https://github.com/apache/ignite/pull/5935 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dspavlov commented on a change in pull request #5662: IGNITE-8227 Research possibility and implement JUnit test failure handler for TeamCity
dspavlov commented on a change in pull request #5662: IGNITE-8227 Research
possibility and implement JUnit test failure handler for TeamCity
URL: https://github.com/apache/ignite/pull/5662#discussion_r251034571
##
File path:
modules/core/src/test/java/org/apache/ignite/failure/ExpectThrowableFailureHandler.java
##
@@ -0,0 +1,82 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.failure;
+
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.List;
+import org.apache.ignite.Ignite;
+import org.apache.ignite.IgniteLogger;
+import org.apache.ignite.internal.util.typedef.X;
+import org.apache.ignite.internal.util.typedef.internal.S;
+import org.apache.ignite.testframework.junits.GridAbstractTest;
+
+/**
+ * Stops node and fails test.
+ */
+public class ExpectThrowableFailureHandler extends TestFailingFailureHandler {
+/** Expected throwables. */
+private final List> errs = new ArrayList<>();
Review comment:
we can use self-descriptive name expectedErrs instead of errs. It will make
code more readable
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] macrergate opened a new pull request #5933: IGNITE-8894 CommandHandler: Provide information about coordinator
macrergate opened a new pull request #5933: IGNITE-8894 CommandHandler: Provide information about coordinator URL: https://github.com/apache/ignite/pull/5933 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] a-polyakov opened a new pull request #5932: IGNITE-7883 add check property "key configuration" in cache configurations
a-polyakov opened a new pull request #5932: IGNITE-7883 add check property "key configuration" in cache configurations URL: https://github.com/apache/ignite/pull/5932 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] aealeksandrov opened a new pull request #5931: IGNITE-11048 Fixed - Start node with TTL caches causes failure handle…
aealeksandrov opened a new pull request #5931: IGNITE-11048 Fixed - Start node with TTL caches causes failure handle… URL: https://github.com/apache/ignite/pull/5931 …r activity. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] asfgit closed pull request #5918: IGNITE-10824: DML columns validation. Attempt #2
asfgit closed pull request #5918: IGNITE-10824: DML columns validation. Attempt #2 URL: https://github.com/apache/ignite/pull/5918 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] asfgit closed pull request #5824: IGNITE-10178 change tests that fail("Ignite JIRA ticket URL") to @Ignore("Ignite JIRA ticket URL")
asfgit closed pull request #5824: IGNITE-10178 change tests that fail("Ignite
JIRA ticket URL") to @Ignore("Ignite JIRA ticket URL")
URL: https://github.com/apache/ignite/pull/5824
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] aealeksandrov opened a new pull request #5930: IGNITE-11084 copyrights date now depend on build date.
aealeksandrov opened a new pull request #5930: IGNITE-11084 copyrights date now depend on build date. URL: https://github.com/apache/ignite/pull/5930 copyrights date now depend on build date. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] asfgit closed pull request #5924: IGNITE-11003: Added support of Random Forest
asfgit closed pull request #5924: IGNITE-11003: Added support of Random Forest URL: https://github.com/apache/ignite/pull/5924 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] tledkov-gridgain opened a new pull request #5929: Prototype for GNITE-7948 SQL: read only necessary fields into the row when possible
tledkov-gridgain opened a new pull request #5929: Prototype for GNITE-7948 SQL: read only necessary fields into the row when possible URL: https://github.com/apache/ignite/pull/5929 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] oignatenko closed pull request #5878: IGNITE-10179 use @BeforeClass and @AfterClass instead of isFirstTest() and isLastTest()
oignatenko closed pull request #5878: IGNITE-10179 use @BeforeClass and @AfterClass instead of isFirstTest() and isLastTest() URL: https://github.com/apache/ignite/pull/5878 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] devozerov opened a new pull request #5928: IGNITE-11083
devozerov opened a new pull request #5928: IGNITE-11083 URL: https://github.com/apache/ignite/pull/5928 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] devozerov closed pull request #5414: IGNITE-10299
devozerov closed pull request #5414: IGNITE-10299 URL: https://github.com/apache/ignite/pull/5414 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dmitrievanthony opened a new pull request #5927: IGNITE-11071: Example of machine learning on top of SQL table
dmitrievanthony opened a new pull request #5927: IGNITE-11071: Example of machine learning on top of SQL table URL: https://github.com/apache/ignite/pull/5927 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] asfgit closed pull request #5862: IGNITE-10987 skip-zeros flag filters out empty partitions regardless the value of update counter
asfgit closed pull request #5862: IGNITE-10987 skip-zeros flag filters out empty partitions regardless the value of update counter URL: https://github.com/apache/ignite/pull/5862 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sanpwc commented on a change in pull request #5875: IGNITE-10305
sanpwc commented on a change in pull request #5875: IGNITE-10305
URL: https://github.com/apache/ignite/pull/5875#discussion_r250946397
##
File path:
modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/twostep/GridReduceQueryExecutor.java
##
@@ -1338,4 +1345,36 @@ private static long retryTimeout(long qryTimeout) {
return IgniteSystemProperties.getLong(IGNITE_SQL_RETRY_TIMEOUT,
DFLT_RETRY_TIMEOUT);
}
+
+
+/**
+ * Prepare map query based on original sql.
+ *
+ * @param qry Two step query.
+ * @param params Query parameters.
+ * @return Updated map query list with one map query.
+ */
+private List
prepareMapQueryForSinglePartition(GridCacheTwoStepQuery qry, Object[] params) {
+boolean hasSubQries = false;
+
+for (GridCacheSqlQuery mapQry : qry.mapQueries())
+hasSubQries |= mapQry.hasSubQueries();
Review comment:
fixed.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] sanpwc commented on a change in pull request #5875: IGNITE-10305
sanpwc commented on a change in pull request #5875: IGNITE-10305
URL: https://github.com/apache/ignite/pull/5875#discussion_r250946337
##
File path:
modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/twostep/GridReduceQueryExecutor.java
##
@@ -634,8 +640,9 @@ else if (msg.page() == 0) {
boolean retry = false;
-// Always enforce join order on map side to have consistent
behavior.
-int flags = GridH2QueryRequest.FLAG_ENFORCE_JOIN_ORDER;
+int flags = singlePartMode ?
Review comment:
fixed.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] Klaster1 opened a new pull request #5926: IGNITE-9879 Web console: lazy load configuration routes
Klaster1 opened a new pull request #5926: IGNITE-9879 Web console: lazy load configuration routes URL: https://github.com/apache/ignite/pull/5926 https://issues.apache.org/jira/browse/IGNITE-9879 @nva @kuaw please review. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] AMashenkov commented on a change in pull request #5875: IGNITE-10305
AMashenkov commented on a change in pull request #5875: IGNITE-10305
URL: https://github.com/apache/ignite/pull/5875#discussion_r250935738
##
File path:
modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/twostep/GridReduceQueryExecutor.java
##
@@ -1338,4 +1345,36 @@ private static long retryTimeout(long qryTimeout) {
return IgniteSystemProperties.getLong(IGNITE_SQL_RETRY_TIMEOUT,
DFLT_RETRY_TIMEOUT);
}
+
+
+/**
+ * Prepare map query based on original sql.
+ *
+ * @param qry Two step query.
+ * @param params Query parameters.
+ * @return Updated map query list with one map query.
+ */
+private List
prepareMapQueryForSinglePartition(GridCacheTwoStepQuery qry, Object[] params) {
+boolean hasSubQries = false;
+
+for (GridCacheSqlQuery mapQry : qry.mapQueries())
+hasSubQries |= mapQry.hasSubQueries();
Review comment:
Seems, there is no need to check all queries, but find only first which has
sub-query.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] oignatenko opened a new pull request #5925: IGNITE-10179 get rid of isFirstTest() and isLastTest()
oignatenko opened a new pull request #5925: IGNITE-10179 get rid of isFirstTest() and isLastTest() URL: https://github.com/apache/ignite/pull/5925 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] zaleslaw opened a new pull request #5924: IGNITE-11003: Added support of Random Forest
zaleslaw opened a new pull request #5924: IGNITE-11003: Added support of Random Forest URL: https://github.com/apache/ignite/pull/5924 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ingvard opened a new pull request #5923: IGNITE-10995: A node must be stopped after a throwable into handleDem…
ingvard opened a new pull request #5923: IGNITE-10995: A node must be stopped after a throwable into handleDem… URL: https://github.com/apache/ignite/pull/5923 …andMessage. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] alamar commented on a change in pull request #5891: Ignite-10921
alamar commented on a change in pull request #5891: Ignite-10921 URL: https://github.com/apache/ignite/pull/5891#discussion_r250903962 ## File path: modules/core/src/test/java/org/apache/ignite/testsuites/IgniteBasicTestSuite.java ## @@ -208,6 +209,7 @@ ListeningTestLoggerTest.class, CacheLocalGetSerializationTest.class, +ConsistentIdImplicitlyExplicitlyTest.class Review comment: @zstan it is obvious from above code that there is logical grouping. However, ConsistentIdImplicitlyExplicitlyTest does not group logically with ConsistentIdImplicitlyExplicitlyTest. I think it should be either separated by extra newline or grouped logically with some other classes about system properties or consistent id. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
