Re: [PR] IGNITE-22071 Async component stop [ignite-3]

Cyrill commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579900229 ## modules/raft/src/integrationTest/java/org/apache/ignite/internal/raft/ItRaftGroupServiceTest.java: ## @@ -258,7 +258,10 @@ void beforeNodeStop() throws Exception {

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

Cyrill commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579901568 ## modules/raft/src/integrationTest/java/org/apache/ignite/internal/raft/ItRaftGroupServiceTest.java: ## @@ -221,8 +221,8 @@ String name() { } void

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

Cyrill commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579903175 ## modules/raft/src/integrationTest/java/org/apache/ignite/internal/raft/ItLearnersTest.java: ## @@ -120,8 +120,8 @@ Peer asPeer() { } void start()

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

Cyrill commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579905344 ## modules/placement-driver/src/integrationTest/java/org/apache/ignite/internal/placementdriver/PlacementDriverManagerTest.java: ## @@ -209,14 +209,14 @@ private void s

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

Cyrill commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579912671 ## modules/placement-driver/src/integrationTest/java/org/apache/ignite/internal/placementdriver/Node.java: ## @@ -52,13 +55,13 @@ class Node implements AutoCloseable {

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

Cyrill commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579915557 ## modules/network/src/testFixtures/java/org/apache/ignite/internal/network/utils/ClusterServiceTestUtils.java: ## @@ -178,24 +177,12 @@ public CompletableFuture start(

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

Cyrill commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579922138 ## modules/metastorage/src/integrationTest/java/org/apache/ignite/internal/metastorage/impl/ItMetaStorageServiceTest.java: ## @@ -201,8 +201,8 @@ private static class N

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

Cyrill commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579927727 ## modules/metastorage/src/integrationTest/java/org/apache/ignite/internal/metastorage/impl/ItMetaStorageManagerImplTest.java: ## @@ -139,9 +139,9 @@ void setUp(

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

Cyrill commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579932468 ## modules/distribution-zones/src/test/java/org/apache/ignite/internal/distributionzones/BaseDistributionZoneManagerTest.java: ## @@ -138,11 +134,11 @@ public void tear

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

Cyrill commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579935936 ## modules/client/src/test/java/org/apache/ignite/client/TestServer.java: ## @@ -315,10 +317,11 @@ public FakePlacementDriver placementDriver() { /** {@inheritDoc}

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

Cyrill commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579938244 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/SqlQueryProcessor.java: ## @@ -452,7 +452,13 @@ public synchronized void stop() throws Excepti

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

Cyrill commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579939781 ## modules/index/src/test/java/org/apache/ignite/internal/index/IndexManagerTest.java: ## @@ -123,8 +123,8 @@ public void setUp() { } @AfterEach -void t

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

Cyrill commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579943253 ## modules/index/src/test/java/org/apache/ignite/internal/index/IndexManagerTest.java: ## @@ -226,7 +226,10 @@ private void createAndStartComponents() {

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

Cyrill commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579982932 ## modules/compute/src/test/java/org/apache/ignite/internal/compute/ComputeComponentImplTest.java: ## @@ -477,12 +478,12 @@ void remoteExecutionReleasesStopLock() throw

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

Cyrill commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579984730 ## modules/core/src/main/java/org/apache/ignite/internal/manager/IgniteComponent.java: ## @@ -47,7 +47,7 @@ default void beforeNodeStop() { * Stops the component.

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

Cyrill commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579986903 ## modules/code-deployment/src/test/java/org/apache/ignite/deployment/metastore/DeploymentUnitStoreImplTest.java: ## @@ -102,12 +102,12 @@ public void setup() {

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

Cyrill commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579989020 ## modules/client-handler/src/main/java/org/apache/ignite/client/handler/ClientHandlerModule.java: ## @@ -228,10 +230,16 @@ public void stop() throws Exception {

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

Cyrill commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1580051040 ## modules/runner/src/main/java/org/apache/ignite/internal/app/LifecycleManager.java: ## @@ -148,12 +153,11 @@ private synchronized void stopAllComponents() {

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

Cyrill commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579989020 ## modules/client-handler/src/main/java/org/apache/ignite/client/handler/ClientHandlerModule.java: ## @@ -228,10 +230,16 @@ public void stop() throws Exception {

Re: [I] IBinarizable : Mapping complex objects [ignite]

satishviswanathan commented on issue #11325: URL: https://github.com/apache/ignite/issues/11325#issuecomment-2078107652 @ptupitsyn Thank you that cleared by confusions. However this issue still persist, the Address fields are not updated. Although the data is not serialized to the

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

Cyrill commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1580096027 ## modules/raft/src/integrationTest/java/org/apache/ignite/raft/server/ItSimpleCounterServerTest.java: ## @@ -97,14 +100,12 @@ void before() throws Exception {

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

Cyrill commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1580096804 ## modules/catalog/src/testFixtures/java/org/apache/ignite/internal/catalog/CatalogTestUtils.java: ## @@ -126,10 +124,8 @@ public void beforeNodeStop() { }

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

Cyrill commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1580096527 ## modules/catalog/src/testFixtures/java/org/apache/ignite/internal/catalog/CatalogTestUtils.java: ## @@ -91,11 +92,8 @@ public void beforeNodeStop() { }

Re: [I] IBinarizable : Mapping complex objects [ignite]

ptupitsyn commented on issue #11325: URL: https://github.com/apache/ignite/issues/11325#issuecomment-2078627474 Adding `address object` column to your DDL script fixes the issue. SQL engine does not drill down the nested object if there is no matching column. -- This is an automat

Re: [I] IBinarizable : Mapping complex objects [ignite]

ptupitsyn closed issue #11325: IBinarizable : Mapping complex objects URL: https://github.com/apache/ignite/issues/11325 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] Bump bouncycastle from 1.76 to 1.78.1 [ignite-3]

ptupitsyn merged PR #3663: URL: https://github.com/apache/ignite-3/pull/3663 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@i

Re: [PR] Bump org.openapi.generator from 7.4.0 to 7.5.0 [ignite-3]

ptupitsyn merged PR #3662: URL: https://github.com/apache/ignite-3/pull/3662 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@i

Re: [PR] Bump net.bytebuddy:byte-buddy from 1.14.12 to 1.14.14 [ignite-3]

ptupitsyn merged PR #3658: URL: https://github.com/apache/ignite-3/pull/3658 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@i

[PR] IGNITE-20294 Sql. Using UDF as a place for system_range function [ignite-3]

zstan opened a new pull request, #3666: URL: https://github.com/apache/ignite-3/pull/3666 Thank you for submitting the pull request. To streamline the review process of the patch and ensure better code quality we ask both an author and a reviewer to verify the following: ###

Re: [PR] IGNITE-21938 Sql. Cover SQL F041-07 feature by tests [ignite-3]

zstan commented on code in PR #3642: URL: https://github.com/apache/ignite-3/pull/3642#discussion_r1580508874 ## modules/sql-engine/src/integrationTest/sql/join/inner/test_table_from_outer_join_used_in_inner.test: ## @@ -0,0 +1,55 @@ +# name: sql/join/inner/test_table_from_outer

Re: [PR] IGNITE-21763 Adjust TxnResourceVacuumTask in order to vacuum persistent txn state [ignite-3]

sanpwc commented on code in PR #3591: URL: https://github.com/apache/ignite-3/pull/3591#discussion_r1580520355 ## modules/table/src/integrationTest/java/org/apache/ignite/internal/table/ItTransactionPrimaryChangeTest.java: ## @@ -87,7 +85,8 @@ protected void customizeInitParamet

Re: [PR] IGNITE-21763 Adjust TxnResourceVacuumTask in order to vacuum persistent txn state [ignite-3]

sanpwc commented on code in PR #3591: URL: https://github.com/apache/ignite-3/pull/3591#discussion_r1580520929 ## modules/table/src/integrationTest/java/org/apache/ignite/internal/table/ItTransactionTestUtils.java: ## @@ -0,0 +1,204 @@ +/* + * Licensed to the Apache Software Fou

Re: [PR] IGNITE-21763 Adjust TxnResourceVacuumTask in order to vacuum persistent txn state [ignite-3]

sanpwc commented on code in PR #3591: URL: https://github.com/apache/ignite-3/pull/3591#discussion_r1580522883 ## modules/table/src/integrationTest/java/org/apache/ignite/internal/table/ItTransactionTestUtils.java: ## @@ -0,0 +1,204 @@ +/* + * Licensed to the Apache Software Fou

Re: [PR] IGNITE-21763 Adjust TxnResourceVacuumTask in order to vacuum persistent txn state [ignite-3]

sanpwc commented on code in PR #3591: URL: https://github.com/apache/ignite-3/pull/3591#discussion_r1580539171 ## modules/transactions/src/main/java/org/apache/ignite/internal/tx/impl/PersistentTxStateVacuumizer.java: ## @@ -0,0 +1,129 @@ +/* + * Licensed to the Apache Software

Re: [PR] IGNITE-21763 Adjust TxnResourceVacuumTask in order to vacuum persistent txn state [ignite-3]

sanpwc commented on code in PR #3591: URL: https://github.com/apache/ignite-3/pull/3591#discussion_r1580520929 ## modules/table/src/integrationTest/java/org/apache/ignite/internal/table/ItTransactionTestUtils.java: ## @@ -0,0 +1,204 @@ +/* + * Licensed to the Apache Software Fou

Re: [PR] IGNITE-21763 Adjust TxnResourceVacuumTask in order to vacuum persistent txn state [ignite-3]

sanpwc commented on code in PR #3591: URL: https://github.com/apache/ignite-3/pull/3591#discussion_r1580544405 ## modules/table/src/integrationTest/java/org/apache/ignite/internal/table/ItTxResourcesVacuumTest.java: ## @@ -0,0 +1,559 @@ +/* + * Licensed to the Apache Software Fo

Re: [PR] IGNITE-21763 Adjust TxnResourceVacuumTask in order to vacuum persistent txn state [ignite-3]

sanpwc commented on code in PR #3591: URL: https://github.com/apache/ignite-3/pull/3591#discussion_r1580546725 ## modules/table/src/integrationTest/java/org/apache/ignite/internal/table/ItTxResourcesVacuumTest.java: ## @@ -0,0 +1,559 @@ +/* + * Licensed to the Apache Software Fo

Re: [PR] [IGNITE-21404] Do not wrap SqlException into RuntimeException for PlannerHelper.optimize. [ignite-3]

korlov42 merged PR #3625: URL: https://github.com/apache/ignite-3/pull/3625 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ig

<    1   2