[GitHub] [ignite] kotari4u opened a new pull request #6955: IGNITE-12261 - Issue with adding nested index dynamically - Adding tests

2019-10-08 Thread GitBox 
kotari4u opened a new pull request #6955: IGNITE-12261 - Issue with adding 
nested index dynamically - Adding tests
URL: https://github.com/apache/ignite/pull/6955
 
 
   IGNITE-12261 - Issue with adding nested index dynamically
   - Adding tests as per comment from pull request [IGNITE-12261 - Issue with 
adding nested index dynamically #6949 ]


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [ignite] ptupitsyn opened a new pull request #6954: IGNITE-10554 .NET: Fix NuGet jar file handling

2019-10-08 Thread GitBox 
ptupitsyn opened a new pull request #6954: IGNITE-10554 .NET: Fix NuGet jar 
file handling
URL: https://github.com/apache/ignite/pull/6954
 
 
   * Use MSBuild targets file to copy jar files from NuGet package to 
output/publish directory
   * Remove old ps1 scripts
   * Add logging config to NuGet
   * Refactor classpath resolver


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [ignite] agura closed pull request #6908: IGNITE-12231 Fixed logging RollbackRecords to WAL

2019-10-08 Thread GitBox 
agura closed pull request #6908: IGNITE-12231 Fixed logging RollbackRecords to 
WAL
URL: https://github.com/apache/ignite/pull/6908
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [ignite] agura commented on issue #6908: IGNITE-12231 Fixed logging RollbackRecords to WAL

2019-10-08 Thread GitBox 
agura commented on issue #6908: IGNITE-12231 Fixed logging RollbackRecords to 
WAL
URL: https://github.com/apache/ignite/pull/6908#issuecomment-539578677
 
 
   Merged to master branch.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [ignite] zaleslaw merged pull request #6952: IGNITE-9463: [ML] Update ML Tutorial with Boosting, Bagging, Online Learning

2019-10-08 Thread GitBox 
zaleslaw merged pull request #6952: IGNITE-9463: [ML] Update ML Tutorial with 
Boosting, Bagging, Online Learning
URL: https://github.com/apache/ignite/pull/6952
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [ignite] alamar opened a new pull request #6953: IGNITE-12271 Fix byte order in PDS code for Big Endian archs.

2019-10-08 Thread GitBox 
alamar opened a new pull request #6953: IGNITE-12271 Fix byte order in PDS code 
for Big Endian archs.
URL: https://github.com/apache/ignite/pull/6953
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [ignite] zaleslaw commented on issue #6943: Gg 23797

2019-10-08 Thread GitBox 
zaleslaw commented on issue #6943: Gg 23797
URL: https://github.com/apache/ignite/pull/6943#issuecomment-539524244
 
 
   Please close it, this is an incorrect place for this PR


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [ignite] zaleslaw commented on issue #6944: IGNITE-11724: [SPARK] IgniteSpark integration forget to close the IgniteContext

2019-10-08 Thread GitBox 
zaleslaw commented on issue #6944: IGNITE-11724: [SPARK] IgniteSpark 
integration forget to close the IgniteContext
URL: https://github.com/apache/ignite/pull/6944#issuecomment-539519033
 
 
   Dear @nizhikov please have a look on this minor fix


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [ignite] asfgit closed pull request #6950: IGNITE-12265 Include org.apache.ignite.client to javadoc

2019-10-08 Thread GitBox 
asfgit closed pull request #6950: IGNITE-12265 Include org.apache.ignite.client 
to javadoc
URL: https://github.com/apache/ignite/pull/6950
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [ignite] zaleslaw opened a new pull request #6952: IGNITE-9463: [ML] Update ML Tutorial with Boosting, Bagging, Online Learning

2019-10-08 Thread GitBox 
zaleslaw opened a new pull request #6952: IGNITE-9463: [ML] Update ML Tutorial 
with Boosting, Bagging, Online Learning
URL: https://github.com/apache/ignite/pull/6952
 
 
   …e features


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [ignite] Mmuzaf opened a new pull request #6951: Ignite 11073 12069 P2P Rebalance collaboration work

2019-10-08 Thread GitBox 
Mmuzaf opened a new pull request #6951: Ignite 11073 12069 P2P Rebalance 
collaboration work
URL: https://github.com/apache/ignite/pull/6951
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [ignite] agoncharuk opened a new pull request #6950: IGNITE-12265 Include org.apache.ignite.client to javadoc

2019-10-08 Thread GitBox 
agoncharuk opened a new pull request #6950: IGNITE-12265 Include 
org.apache.ignite.client to javadoc
URL: https://github.com/apache/ignite/pull/6950
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [ignite] kotari4u commented on issue #6947: IGNITE-12261 - Issue with adding nested index dynamically

2019-10-08 Thread GitBox 
kotari4u commented on issue #6947: IGNITE-12261 - Issue with adding nested 
index dynamically
URL: https://github.com/apache/ignite/pull/6947#issuecomment-539461473
 
 
   Creatdd another pull request with comment
   Closing this so that we can look at other
   https://github.com/apache/ignite/pull/6949


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [ignite] kotari4u closed pull request #6947: IGNITE-12261 - Issue with adding nested index dynamically

2019-10-08 Thread GitBox 
kotari4u closed pull request #6947: IGNITE-12261 - Issue with adding nested 
index dynamically
URL: https://github.com/apache/ignite/pull/6947
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [ignite] kotari4u opened a new pull request #6949: IGNITE-12261 - Issue with adding nested index dynamically

2019-10-08 Thread GitBox 
kotari4u opened a new pull request #6949: IGNITE-12261 - Issue with adding 
nested index dynamically
URL: https://github.com/apache/ignite/pull/6949
 
 
   Implemented suggestion please check and let me know for any issues. Thanks


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [ignite] ololo3000 opened a new pull request #6948: IGNITE-12268 Adds ability to set up custom REST processor.

2019-10-08 Thread GitBox 
ololo3000 opened a new pull request #6948: IGNITE-12268 Adds ability to set up 
custom REST processor.
URL: https://github.com/apache/ignite/pull/6948
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [ignite] AMashenkov commented on a change in pull request #6917: IGNITE-12189 Implementation correct limit for TextQuery

2019-10-08 Thread GitBox 
AMashenkov commented on a change in pull request #6917: IGNITE-12189 
Implementation correct limit for TextQuery
URL: https://github.com/apache/ignite/pull/6917#discussion_r332395577
 
 

 ##
 File path: 
modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/GridCacheFullTextQuerySelfTest.java
 ##
 @@ -59,6 +59,22 @@
 /** Cache name */
 private static final String PERSON_CACHE = "Person";
 
+/** Limitation to query response size */
+private static final int QUERY_LIMIT = 5;
+
+/**
+ * Container for expected values and all available entries
+ */
+private static final class TestPair{
 
 Review comment:
   Missed space before '{'


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [ignite] AMashenkov commented on a change in pull request #6917: IGNITE-12189 Implementation correct limit for TextQuery

2019-10-08 Thread GitBox 
AMashenkov commented on a change in pull request #6917: IGNITE-12189 
Implementation correct limit for TextQuery
URL: https://github.com/apache/ignite/pull/6917#discussion_r332394278
 
 

 ##
 File path: 
modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/GridCacheFullTextQuerySelfTest.java
 ##
 @@ -212,86 +255,84 @@ private static void clearCache(IgniteEx ignite) {
  *
  * @throws IgniteCheckedException if failed.
  */
-private static void validateQueryResults(IgniteEx ignite, Query qry, 
Set exp,
+private static void validateQueryResults(IgniteEx ignite, TextQuery qry, 
Set exp,
 boolean keepBinary) throws IgniteCheckedException {
 IgniteCache cache = ignite.cache(PERSON_CACHE);
 
 if (keepBinary) {
 IgniteCache cache0 = cache.withKeepBinary();
 
 try (QueryCursor> cursor = 
cache0.query(qry)) {
-Set exp0 = new HashSet<>(exp);
-
-List> all = new ArrayList<>();
-
-for (Cache.Entry entry : 
cursor.getAll()) {
-all.add(entry);
-
-assertEquals(entry.getKey().toString(), 
entry.getValue().field("name"));
 
-assertEquals(entry.getKey(), 
entry.getValue().field("age"));
+TestPair testPair = processExpectedWithBinary(exp, cursor);
 
-exp0.remove(entry.getKey());
-}
-
-checkForMissedKeys(ignite, exp0, all);
+assertResult(ignite, qry, testPair);
 }
 
 try (QueryCursor> cursor = 
cache0.query(qry)) {
-Set exp0 = new HashSet<>(exp);
-
-List> all = new ArrayList<>();
-
-for (Cache.Entry entry : 
cursor.getAll()) {
-all.add(entry);
 
-assertEquals(entry.getKey().toString(), 
entry.getValue().field("name"));
+TestPair testPair = processExpectedWithBinary(exp, cursor);
 
-assertEquals(entry.getKey(), 
entry.getValue().field("age"));
-
-exp0.remove(entry.getKey());
-}
-
-checkForMissedKeys(ignite, exp0, all);
+assertResult(ignite, qry, testPair);
 }
 }
 else {
 try (QueryCursor> cursor = 
cache.query(qry)) {
-Set exp0 = new HashSet<>(exp);
 
-List> all = new ArrayList<>();
+TestPair testPair = processExpected(exp, cursor);
 
-for (Cache.Entry entry : cursor.getAll()) {
-all.add(entry);
+assertResult(ignite, qry, testPair);
 
-assertEquals(entry.getKey().toString(), 
entry.getValue().name);
+}
 
-assertEquals(entry.getKey(), 
Integer.valueOf(entry.getValue().age));
+try (QueryCursor> cursor = 
cache.query(qry)) {
 
-exp0.remove(entry.getKey());
-}
+TestPair testPair = processExpected(exp, cursor);
 
-checkForMissedKeys(ignite, exp0, all);
+assertResult(ignite, qry, testPair);
 }
+}
+}
 
-try (QueryCursor> cursor = 
cache.query(qry)) {
-Set exp0 = new HashSet<>(exp);
+private static void assertResult(IgniteEx ignite, TextQuery qry,
+TestPair testPair) throws IgniteCheckedException {
+if (qry.getLimit() > 0){
+assertTrue(testPair.all.size() <= QUERY_LIMIT);
 
 Review comment:
   Should be:
   ```
   if (qry.getLimit() > 0)
   assertTrue(testPair.all.size() <= QUERY_LIMIT);
   else 
   checkForMissedKeys(ignite, testPair.expected, testPair.all);
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services