[GitHub] [ignite] samaitra commented on issue #6490: IGNITE-7285 Add default query timeout

2019-10-19 Thread GitBox
samaitra commented on issue #6490: IGNITE-7285 Add default query timeout URL: https://github.com/apache/ignite/pull/6490#issuecomment-544208026 > Additionally to comments for code lines there are some questions regarding testing approach. Actually, I do not see how different are

[GitHub] [ignite] samaitra commented on a change in pull request #6490: IGNITE-7285 Add default query timeout

2019-10-19 Thread GitBox
samaitra commented on a change in pull request #6490: IGNITE-7285 Add default query timeout URL: https://github.com/apache/ignite/pull/6490#discussion_r336758010 ## File path:

[GitHub] [ignite] samaitra commented on a change in pull request #6490: IGNITE-7285 Add default query timeout

2019-10-19 Thread GitBox
samaitra commented on a change in pull request #6490: IGNITE-7285 Add default query timeout URL: https://github.com/apache/ignite/pull/6490#discussion_r336758022 ## File path:

[GitHub] [ignite] samaitra commented on a change in pull request #6490: IGNITE-7285 Add default query timeout

2019-10-19 Thread GitBox
samaitra commented on a change in pull request #6490: IGNITE-7285 Add default query timeout URL: https://github.com/apache/ignite/pull/6490#discussion_r336758024 ## File path:

[GitHub] [ignite] samaitra commented on a change in pull request #6490: IGNITE-7285 Add default query timeout

2019-10-19 Thread GitBox
samaitra commented on a change in pull request #6490: IGNITE-7285 Add default query timeout URL: https://github.com/apache/ignite/pull/6490#discussion_r336757954 ## File path:

[GitHub] [ignite] samaitra commented on a change in pull request #6490: IGNITE-7285 Add default query timeout

2019-10-19 Thread GitBox
samaitra commented on a change in pull request #6490: IGNITE-7285 Add default query timeout URL: https://github.com/apache/ignite/pull/6490#discussion_r336757891 ## File path:

[GitHub] [ignite] samaitra commented on a change in pull request #6490: IGNITE-7285 Add default query timeout

2019-10-19 Thread GitBox
samaitra commented on a change in pull request #6490: IGNITE-7285 Add default query timeout URL: https://github.com/apache/ignite/pull/6490#discussion_r336757876 ## File path:

[GitHub] [ignite] samaitra commented on a change in pull request #6490: IGNITE-7285 Add default query timeout

2019-10-19 Thread GitBox
samaitra commented on a change in pull request #6490: IGNITE-7285 Add default query timeout URL: https://github.com/apache/ignite/pull/6490#discussion_r336757895 ## File path:

[GitHub] [ignite] samaitra commented on a change in pull request #6490: IGNITE-7285 Add default query timeout

2019-10-19 Thread GitBox
samaitra commented on a change in pull request #6490: IGNITE-7285 Add default query timeout URL: https://github.com/apache/ignite/pull/6490#discussion_r336757887 ## File path:

[GitHub] [ignite] samaitra commented on a change in pull request #6490: IGNITE-7285 Add default query timeout

2019-10-19 Thread GitBox
samaitra commented on a change in pull request #6490: IGNITE-7285 Add default query timeout URL: https://github.com/apache/ignite/pull/6490#discussion_r336757873 ## File path:

[GitHub] [ignite] samaitra commented on a change in pull request #6490: IGNITE-7285 Add default query timeout

2019-10-19 Thread GitBox
samaitra commented on a change in pull request #6490: IGNITE-7285 Add default query timeout URL: https://github.com/apache/ignite/pull/6490#discussion_r336756445 ## File path:

[GitHub] [ignite] nizhikov commented on a change in pull request #6963: IGNITE-9732: [Spark] Add joins to Spark Dataframe examples

2019-10-19 Thread GitBox
nizhikov commented on a change in pull request #6963: IGNITE-9732: [Spark] Add joins to Spark Dataframe examples URL: https://github.com/apache/ignite/pull/6963#discussion_r336724572 ## File path:

[GitHub] [ignite] nizhikov commented on a change in pull request #6963: IGNITE-9732: [Spark] Add joins to Spark Dataframe examples

2019-10-19 Thread GitBox
nizhikov commented on a change in pull request #6963: IGNITE-9732: [Spark] Add joins to Spark Dataframe examples URL: https://github.com/apache/ignite/pull/6963#discussion_r336724572 ## File path:

[GitHub] [ignite] nizhikov commented on a change in pull request #6963: IGNITE-9732: [Spark] Add joins to Spark Dataframe examples

2019-10-19 Thread GitBox
nizhikov commented on a change in pull request #6963: IGNITE-9732: [Spark] Add joins to Spark Dataframe examples URL: https://github.com/apache/ignite/pull/6963#discussion_r336724417 ## File path:

[GitHub] [ignite] nizhikov commented on a change in pull request #6963: IGNITE-9732: [Spark] Add joins to Spark Dataframe examples

2019-10-19 Thread GitBox
nizhikov commented on a change in pull request #6963: IGNITE-9732: [Spark] Add joins to Spark Dataframe examples URL: https://github.com/apache/ignite/pull/6963#discussion_r336724403 ## File path:

[GitHub] [ignite] nizhikov commented on a change in pull request #6963: IGNITE-9732: [Spark] Add joins to Spark Dataframe examples

2019-10-19 Thread GitBox
nizhikov commented on a change in pull request #6963: IGNITE-9732: [Spark] Add joins to Spark Dataframe examples URL: https://github.com/apache/ignite/pull/6963#discussion_r336724415 ## File path:

[GitHub] [ignite] nizhikov commented on a change in pull request #6963: IGNITE-9732: [Spark] Add joins to Spark Dataframe examples

2019-10-19 Thread GitBox
nizhikov commented on a change in pull request #6963: IGNITE-9732: [Spark] Add joins to Spark Dataframe examples URL: https://github.com/apache/ignite/pull/6963#discussion_r336724412 ## File path:

[GitHub] [ignite] nizhikov commented on a change in pull request #6963: IGNITE-9732: [Spark] Add joins to Spark Dataframe examples

2019-10-19 Thread GitBox
nizhikov commented on a change in pull request #6963: IGNITE-9732: [Spark] Add joins to Spark Dataframe examples URL: https://github.com/apache/ignite/pull/6963#discussion_r336724346 ## File path:

[GitHub] [ignite] nizhikov commented on a change in pull request #6963: IGNITE-9732: [Spark] Add joins to Spark Dataframe examples

2019-10-19 Thread GitBox
nizhikov commented on a change in pull request #6963: IGNITE-9732: [Spark] Add joins to Spark Dataframe examples URL: https://github.com/apache/ignite/pull/6963#discussion_r336724366 ## File path:

[GitHub] [ignite] nizhikov commented on a change in pull request #6963: IGNITE-9732: [Spark] Add joins to Spark Dataframe examples

2019-10-19 Thread GitBox
nizhikov commented on a change in pull request #6963: IGNITE-9732: [Spark] Add joins to Spark Dataframe examples URL: https://github.com/apache/ignite/pull/6963#discussion_r336724375 ## File path:

[GitHub] [ignite] nizhikov commented on a change in pull request #6963: IGNITE-9732: [Spark] Add joins to Spark Dataframe examples

2019-10-19 Thread GitBox
nizhikov commented on a change in pull request #6963: IGNITE-9732: [Spark] Add joins to Spark Dataframe examples URL: https://github.com/apache/ignite/pull/6963#discussion_r336724354 ## File path:

[GitHub] [ignite] nizhikov commented on a change in pull request #6963: IGNITE-9732: [Spark] Add joins to Spark Dataframe examples

2019-10-19 Thread GitBox
nizhikov commented on a change in pull request #6963: IGNITE-9732: [Spark] Add joins to Spark Dataframe examples URL: https://github.com/apache/ignite/pull/6963#discussion_r336724316 ## File path:

[GitHub] [ignite] nizhikov commented on a change in pull request #6963: IGNITE-9732: [Spark] Add joins to Spark Dataframe examples

2019-10-19 Thread GitBox
nizhikov commented on a change in pull request #6963: IGNITE-9732: [Spark] Add joins to Spark Dataframe examples URL: https://github.com/apache/ignite/pull/6963#discussion_r336724332 ## File path:

[GitHub] [ignite] nizhikov commented on a change in pull request #6963: IGNITE-9732: [Spark] Add joins to Spark Dataframe examples

2019-10-19 Thread GitBox
nizhikov commented on a change in pull request #6963: IGNITE-9732: [Spark] Add joins to Spark Dataframe examples URL: https://github.com/apache/ignite/pull/6963#discussion_r336724325 ## File path: