[GitHub] [ignite] dmekhanikov opened a new pull request #7044: [8.5-next]-[GG-23137] Cache SSL contexts in SslContextFactory

2019-11-08 Thread GitBox
dmekhanikov opened a new pull request #7044: [8.5-next]-[GG-23137] Cache SSL 
contexts in SslContextFactory
URL: https://github.com/apache/ignite/pull/7044
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [ignite] ptupitsyn merged pull request #7041: IGNITE-9033 .NET: specify expiry policy when creating cache using thin client

2019-11-08 Thread GitBox
ptupitsyn merged pull request #7041: IGNITE-9033 .NET: specify expiry policy 
when creating cache using thin client
URL: https://github.com/apache/ignite/pull/7041
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [ignite] ashapkin opened a new pull request #7041: IGNITE-9033 .NET: specify expiry policy when creating cache using thin client

2019-11-08 Thread GitBox
ashapkin opened a new pull request #7041: IGNITE-9033 .NET: specify expiry 
policy when creating cache using thin client
URL: https://github.com/apache/ignite/pull/7041
 
 
   Added ability to create dynamic caches for thin clients with expiry policies.
   
   - Added expiry policy property  to thin client cache configuration
   - Added withExpiryPolicy method to the client cache interface
   
   (cherry picked from commit b2b12eb31df3d240de8a657eec57cd6cbedb94fe)


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [ignite] ashapkin closed pull request #7041: IGNITE-9033 .NET: specify expiry policy when creating cache using thin client

2019-11-08 Thread GitBox
ashapkin closed pull request #7041: IGNITE-9033 .NET: specify expiry policy 
when creating cache using thin client
URL: https://github.com/apache/ignite/pull/7041
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [ignite] ashapkin commented on a change in pull request #7041: IGNITE-9033 .NET: specify expiry policy when creating cache using thin client

2019-11-08 Thread GitBox
ashapkin commented on a change in pull request #7041: IGNITE-9033 .NET: specify 
expiry policy when creating cache using thin client
URL: https://github.com/apache/ignite/pull/7041#discussion_r344220808
 
 

 ##
 File path: 
modules/platforms/dotnet/Apache.Ignite.Core/Impl/Client/Cache/CacheClient.cs
 ##
 @@ -42,6 +44,38 @@ namespace Apache.Ignite.Core.Impl.Client.Cache
 /// 
 internal sealed class CacheClient : ICacheClient, 
ICacheInternal
 {
+/// 
+/// Additional flag values for cache operations.
+/// 
+private enum ClientCacheRequestFlag : byte
+{
+/// 
+/// No flags
+/// 
+None = 0,
+
+/// 
+/// With keep binary flag.
+/// Reserved for other thin clients.
+/// 
+// ReSharper disable once ShiftExpressionRealShiftCountIsZero
+// ReSharper disable once UnusedMember.Local
+WithKeepBinary = 1 << 0,
+
+/// 
+/// With transactional binary flag.
+/// Reserved for IEP-34 Thin client: transactions support.
+/// 
+// ReSharper disable once ShiftExpressionRealShiftCountIsZero
 
 Review comment:
   Fixed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [ignite] ptupitsyn commented on a change in pull request #7041: IGNITE-9033 .NET: specify expiry policy when creating cache using thin client

2019-11-08 Thread GitBox
ptupitsyn commented on a change in pull request #7041: IGNITE-9033 .NET: 
specify expiry policy when creating cache using thin client
URL: https://github.com/apache/ignite/pull/7041#discussion_r344201771
 
 

 ##
 File path: 
modules/platforms/dotnet/Apache.Ignite.Core/Impl/Client/Cache/CacheClient.cs
 ##
 @@ -42,6 +44,38 @@ namespace Apache.Ignite.Core.Impl.Client.Cache
 /// 
 internal sealed class CacheClient : ICacheClient, 
ICacheInternal
 {
+/// 
+/// Additional flag values for cache operations.
+/// 
+private enum ClientCacheRequestFlag : byte
+{
+/// 
+/// No flags
+/// 
+None = 0,
+
+/// 
+/// With keep binary flag.
+/// Reserved for other thin clients.
+/// 
+// ReSharper disable once ShiftExpressionRealShiftCountIsZero
+// ReSharper disable once UnusedMember.Local
+WithKeepBinary = 1 << 0,
+
+/// 
+/// With transactional binary flag.
+/// Reserved for IEP-34 Thin client: transactions support.
+/// 
+// ReSharper disable once ShiftExpressionRealShiftCountIsZero
 
 Review comment:
   Unnecessary suppression


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [ignite] asfgit closed pull request #7017: IGNITE-12300

2019-11-08 Thread GitBox
asfgit closed pull request #7017: IGNITE-12300
URL: https://github.com/apache/ignite/pull/7017
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [ignite] asfgit closed pull request #7023: IGNITE-5247 Always use LITTLE_ENDIAN for communication SPI

2019-11-08 Thread GitBox
asfgit closed pull request #7023: IGNITE-5247 Always use LITTLE_ENDIAN for 
communication SPI
URL: https://github.com/apache/ignite/pull/7023
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [ignite] korlov42 opened a new pull request #7043: Gg 25448 WIP

2019-11-08 Thread GitBox
korlov42 opened a new pull request #7043: Gg 25448 WIP
URL: https://github.com/apache/ignite/pull/7043
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services