[GitHub] [ignite] samaitra commented on issue #6490: IGNITE-7285 Add default query timeout

2019-11-06 Thread GitBox
samaitra commented on issue #6490: IGNITE-7285 Add default query timeout URL: https://github.com/apache/ignite/pull/6490#issuecomment-550754365 > > @pavlukhin Thank you for reviewing and sharing feedback. > > If you note the tests in

[GitHub] [ignite] samaitra commented on issue #6490: IGNITE-7285 Add default query timeout

2019-10-27 Thread GitBox
samaitra commented on issue #6490: IGNITE-7285 Add default query timeout URL: https://github.com/apache/ignite/pull/6490#issuecomment-546778525 > > > Additionally to comments for code lines there are some questions regarding testing approach. Actually, I do not see how different are

[GitHub] [ignite] samaitra commented on issue #6490: IGNITE-7285 Add default query timeout

2019-10-19 Thread GitBox
samaitra commented on issue #6490: IGNITE-7285 Add default query timeout URL: https://github.com/apache/ignite/pull/6490#issuecomment-544208026 > Additionally to comments for code lines there are some questions regarding testing approach. Actually, I do not see how different are

[GitHub] [ignite] samaitra commented on issue #6490: IGNITE-7285 Add default query timeout

2019-05-03 Thread GitBox
samaitra commented on issue #6490: IGNITE-7285 Add default query timeout URL: https://github.com/apache/ignite/pull/6490#issuecomment-489287855 @pavlukhin I have updated the PR. Please take a look. This is an automated

[GitHub] [ignite] samaitra commented on issue #6490: IGNITE-7285 Add default query timeout

2019-04-27 Thread GitBox
samaitra commented on issue #6490: IGNITE-7285 Add default query timeout URL: https://github.com/apache/ignite/pull/6490#issuecomment-487287705 @AMashenkov thank you for reviewing the changes and sharing feedback, I have incorporated the review comments. Please review and share if