Hi Ignasi,
I think you are right, a little of context could definitely ease the review.
Recently I've been working with SoftLayer and I tried to fix some blocking
issue (PR#200, PR#204) but unfortunately they didn't fix them all.
In particular VirtualGuestToNodeMetadata happens to be slow and
Thinking more about it, I think *toolkit* is a better name. jclouds is not just
a library, is a set of libraries that can be used to manage the cloud, so I
think *toolkit* defines better what jclouds is.
I've just uploaded a commit with the slogan changed in the main page, and also
rebranded
We should also write a blog post announcing the new year changes: new site,
1.7.0 (with all its stuff) and 1.7.1, and ideally should be published along
with the new site, to properly announce it.
---
Reply to this email directly or view it on GitHub:
[jclouds-site-pull-requests
#192](https://jclouds.ci.cloudbees.com/job/jclouds-site-pull-requests/192/)
SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/58#issuecomment-36113017
Go to
http://10720684367b760da111-612fee7537882e5d5391dafbf9b878ad.r97.cf1.rackcdn.com/
to review your changes.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/58#issuecomment-36113179
[jclouds-site-pull-requests
#193](https://jclouds.ci.cloudbees.com/job/jclouds-site-pull-requests/193/)
SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/58#issuecomment-36114464
Thanks for the quick update! I'll run the live tests against a devstack later
today, but apart from the minor comments, in general it LGTM.
Just an advice: when committing changes that address review comments, don't
squash the commits, until the PR is ready to be merged. This way we can focus
[jclouds-site-pull-requests
#194](https://jclouds.ci.cloudbees.com/job/jclouds-site-pull-requests/194/)
SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/58#issuecomment-36116316
Go to
http://3c529895763ecb8a8cf5-8b5ff73a2fe803863960f0ac1c5775da.r50.cf1.rackcdn.com/
to review your changes.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/58#issuecomment-36116484
[jclouds » jclouds
#865](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/865/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
[jclouds-java-7-pull-requests
#1089](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1089/)
SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/303#issuecomment-36131730
In terms of ranking I think people search for things like digitalocean java
api, s3 java, etc. But I'm not sure how people search for this kind of
thing: perhaps portable isn't also relevant in searches… I just don't know,
and would also like to have feedback from more people on this :)
Just
You can merge this Pull Request by running:
git pull https://github.com/johnbendi/jclouds patch-1
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds/pull/304
-- Commit Summary --
* Update README.md
-- File Changes --
M README.md (4)
--
Made corrections for clarity of message.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/304#issuecomment-36135990
but Akka defines itself as a toolkit too
Ah...interesting data point. Thanks!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/58#issuecomment-36140965
@@ -1,7 +1,7 @@
jclouds
==
jclouds allows provisioning and control of cloud resources, including
blobstore
-and compute, from Java and Clojure. Our API gives allows developers to use
+and compute, from Java and Clojure. Our API gives/allows developers the
opportunity to use
I
@@ -12,7 +12,7 @@ Features
Even if you don't need the portable apis we provide, or could roll it your
own, programming against cloud environments can be challenging. We focus on
the following areas so that you can focus on using the cloud, rather than
troubleshooting it!
* SIMPLE
[jclouds » jclouds
#866](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/866/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
[jclouds-pull-requests
#620](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/620/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/304#issuecomment-36143141
[jclouds-java-7-pull-requests
#1090](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1090/)
SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/304#issuecomment-36143183
@demobox I have updated with your proposals.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/304#issuecomment-36144908
[jclouds » jclouds
#867](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/867/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
Thanks, @johnbendi? Could you squash down your three commits? Otherwise, +1 -
looks good to me!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/304#issuecomment-36150066
[jclouds-pull-requests
#621](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/621/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/304#issuecomment-36151165
[jclouds-java-7-pull-requests
#1091](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1091/)
SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/304#issuecomment-36151180
Is there an easy way of squashing on github without forcing me to clone the
repo?
You should be able to do this by [rebasing
locally](http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html)
and then force pushing to your repo. But there's no need to spend too much
time
+ * @author Pedro Navarro
+ */
+@Test(groups = live, testName = RoleAdminApiLiveTest, singleThreaded =
true)
+public class RoleAdminApiLiveTest extends BaseKeystoneApiLiveTest {
+
+ private Optional? extends RoleAdminApi roleAdminOption;
+
+ private Role testRole;
+
+
Go to
http://ad45a6d358f43958e25a-1b323d3a83db100c58eca5c5f5e6a3c4.r84.cf1.rackcdn.com/
to review your changes.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/58#issuecomment-36179544
+ public CDNContainer(String name, boolean enabled, boolean logRetention,
int ttl, URI uri, URI sslUri, URI streamingUri, URI iosUri) {
+ this.name = checkNotNull(name, name required);
+ this.enabled = enabled;
+ this.logRetention = logRetention;
+ this.ttl = ttl;
+
[jclouds » jclouds-labs-openstack
#873](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-openstack/873/)
SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
[jclouds-labs-openstack-pull-requests
#167](https://jclouds.ci.cloudbees.com/job/jclouds-labs-openstack-pull-requests/167/)
SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/79#issuecomment-36197272
+
+import com.google.common.base.Function;
+import com.google.common.base.Supplier;
+
+/**
+ * @author Jeremy Daggett
+ */
+@Singleton
+public class RegionToCDNEndpoint implements FunctionObject, URI {
+
+ private final SupplierMapString, SupplierURI endpointsSupplier;
+
+
32 matches
Mail list logo
