Squashed, rebased and merged. Many thanks @demobox and @iocanel !
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/39#issuecomment-37909638
Closed #17.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-cli/pull/17
[jclouds-cli-pull-requests
#18](https://jclouds.ci.cloudbees.com/job/jclouds-cli-pull-requests/18/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-cli/pull/17#issuecomment-37913796
Any news on this PR?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/45#issuecomment-37945418
[
https://issues.apache.org/jira/browse/JCLOUDS-446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13939393#comment-13939393
]
Izek Greenfield commented on JCLOUDS-446:
-
Yes
Script doesn't run
[
https://issues.apache.org/jira/browse/JCLOUDS-317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13939444#comment-13939444
]
Jacob Mourelos commented on JCLOUDS-317:
Looking at the [havana source
+1 - looks good to me. Thanks, @nacx!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-cli/pull/17#issuecomment-37956576
Commit is
[here](https://git-wip-us.apache.org/repos/asf?p=jclouds-karaf.git;a=commit;h=176deecd8e3f98165c41c6d72055b597ac0ed3d0)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/39#issuecomment-37957108
@nacx: Thanks for doing that. Should I squash/rebase this PR for merging as
well?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/82#issuecomment-37957831
@@ -44,7 +44,12 @@
private int deviceIndex = 1;
- /**
+public RegisterImageBackedByEbsOptions() {
+formParameters.put(BlockDeviceMapping.0.DeviceName, /dev/sda1);
+formParameters.put(RootDeviceName,/dev/sda1);
And a minor comment: missing space before
@@ -130,6 +135,22 @@ public RegisterImageBackedByEbsOptions
addNewBlockDevice(String deviceName,
return this;
}
+/**
+ *
+ * sets the ROOT device name to the specified name.
Sets (capital 'S), and please remove the blank line above. I know adds
above is also
@@ -130,6 +135,22 @@ public RegisterImageBackedByEbsOptions
addNewBlockDevice(String deviceName,
return this;
}
+/**
+ *
+ * sets the ROOT device name to the specified name.
+ *
+ * @param name
+ * The device name (e.g., /dev/sdh).
Simply
@@ -130,6 +135,22 @@ public RegisterImageBackedByEbsOptions
addNewBlockDevice(String deviceName,
return this;
}
+/**
+ *
+ * sets the ROOT device name to the specified name.
+ *
+ * @param name
+ * The device name (e.g., /dev/sdh).
+
+ * Options to specify metadata such as architecture or
secondary volumes to be
+ * associated with this image.
+ * @return imageId
+ *
+ * @see #describeImages
+ * @see #deregisterImage
+ * @see a href=
+ *
+
+request = (GeneratedHttpRequest)
request.getFilters().get(0).filter(request);
+
+assertRequestLineEquals(request, POST
https://ec2.us-east-1.amazonaws.com/ HTTP/1.1);
+assertNonPayloadHeadersEqual(request, Host:
ec2.us-east-1.amazonaws.com\n);
+
Thanks Andrew for the clarification. That is a relief to know that the main
repo is not touched :)
Rgds
Jai
On Tue, Mar 18, 2014 at 9:54 AM, Andrew Phillips
notificati...@github.comwrote:
The test failures was a bummer. I thought a commit to Github will only
update my fork branch and I can
You can merge this Pull Request by running:
git pull https://github.com/kstyrc/jclouds master
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds/pull/320
-- Commit Summary --
* JCLOUDS-184: Improving AzureBlob unit tests
* JCLOUDS-184: Improving
[jclouds-pull-requests
#667](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/667/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/320#issuecomment-37978819
[jclouds-java-7-pull-requests
#1137](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1137/)
SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/320#issuecomment-37979552
+import com.google.common.base.Supplier;
+import com.google.common.base.Throwables;
+import com.google.common.cache.CacheBuilder;
+import com.google.common.cache.CacheLoader;
+import com.google.common.cache.LoadingCache;
+
+/**
+ *
+ * @author Jasdeep Hundal
+ */
+@Singleton
+public
+ this.zoneToEndpointSupplier = checkNotNull(zoneToEndpointSupplier,
zoneToEndpointSupplier);
+ if(!apiVersionString.startsWith(v))
+ apiVersionString = v + apiVersionString;
+ this.apiVersion = apiVersionString;
+ this.endpointCache = CacheBuilder.newBuilder()
+ VersionsJsonResponse versions =
json.fromJson(Strings2.toStringAndClose(response),
VersionsJsonResponse.class);
+ for( VersionsJsonResponse.Version version :
versions.versions ) {
+if(apiVersion.equals(version.id)) {
+
+ break;
+}
+ }
+ } catch (Exception ex) {
+ throw Throwables.propagate(ex);
+ }
+ if (versionEndpointUri == null)
+ throw new
+ }
+ } catch (Exception ex) {
+ throw Throwables.propagate(ex);
+ }
+ if (versionEndpointUri == null)
+ throw new HttpException(Glance endpoint does not
support API version: +
@@ -46,6 +47,11 @@ public void handleError(HttpCommand command, HttpResponse
response) {
message = message != null ? message : String.format(%s - %s,
command.getCurrentRequest().getRequestLine(),
response.getStatusLine());
switch (response.getStatusCode()) {
+import com.google.common.base.Supplier;
+import com.google.common.base.Throwables;
+import com.google.common.cache.CacheBuilder;
+import com.google.common.cache.CacheLoader;
+import com.google.common.cache.LoadingCache;
+
+/**
+ *
+ * @author Jasdeep Hundal
+ */
+@Singleton
+public
+ public String status;
+ public String id;
+ public ListLink links;
+ }
+ public ListVersion versions;
+ }
+
+ private final SupplierMapString, SupplierURI zoneToEndpointSupplier;
+ private final String apiVersion;
+ private final
@@ -0,0 +1,44 @@
+{
[minor] I think we normally use smaller indents for JSON files? I may be wrong,
though.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/82/files#r10724813
I think we're missing some tests for this new functionality: what should happen
if the API version is/is not found, validating the http - https switch etc.
I'm not sure, though, whether the explicit use of HttpClient, as opposed to
adding the version negotiation call as an explicit API call
+import com.google.common.base.Supplier;
+import com.google.common.base.Throwables;
+import com.google.common.cache.CacheBuilder;
+import com.google.common.cache.CacheLoader;
+import com.google.common.cache.LoadingCache;
+
+/**
+ *
+ * @author Jasdeep Hundal
+ */
+@Singleton
+public
+ public String status;
+ public String id;
+ public ListLink links;
+ }
+ public ListVersion versions;
+ }
+
+ private final SupplierMapString, SupplierURI zoneToEndpointSupplier;
+ private final String apiVersion;
+ private final
+ break;
+}
+ }
+ } catch (Exception ex) {
+ throw Throwables.propagate(ex);
+ }
+ if (versionEndpointUri == null)
+ throw new
As per a previous discussion: +1 to this if the new response value
`https://glance.jclouds.org:9292/` is one that could be realistically returned
by an OpenStack installation. From what I recall, someone (@zack-shoylev?
@everett-toews?) confirmed that that was indeed the case.
---
Reply to
Thanks, @jasdeep-hundal!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/319#issuecomment-37987013
@@ -0,0 +1,44 @@
+{
I think it was actually 4 in the keystoneAuthResponse.json, but I'm not
consistent with that either here...
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/82/files#r10725757
+ public String status;
+ public String id;
+ public ListLink links;
+ }
+ public ListVersion versions;
+ }
+
+ private final SupplierMapString, SupplierURI zoneToEndpointSupplier;
+ private final String apiVersion;
+ private final
[jclouds ยป jclouds-labs-openstack
#927](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-openstack/927/)
UNSTABLE
Looks like there's a problem with this pull request
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
[jclouds-labs-openstack-pull-requests
#182](https://jclouds.ci.cloudbees.com/job/jclouds-labs-openstack-pull-requests/182/)
UNSTABLE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
Pushed to master and deployed.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/59#issuecomment-37999805
Thanks!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/59#issuecomment-38003514
Thinking about it some more, would it be possible/cleaner to use a
retryHandler instead of an
errorHandler to deal with the HttpClient behavior on HTTP responses with a
300 status code?
Well, the cleanest thing I can think of would be to hook in where the
success/failure of the call is
public class AzureBlobBlockUploadStrategyTest {
+ @Test(groups = unit, testName = AzureBlobBlockUploadStrategyTest)
Why has this moved here?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/320/files#r10731992
import java.util.List;
-import static org.easymock.EasyMock.anyObject;
-import static org.easymock.EasyMock.createMock;
-import static org.easymock.EasyMock.eq;
-import static org.easymock.EasyMock.expect;
-import static org.easymock.EasyMock.expectLastCall;
-import static
@@ -70,5 +65,29 @@ public void testExecute() throws Exception {
replay(slicer,client);
String etag = strat.execute(container, blob);
assertEquals(etag, Fake ETAG);
+
+ verify(slicer, client);
+ }
+
+ @Test(groups = unit, expectedExceptions =
@@ -70,5 +65,29 @@ public void testExecute() throws Exception {
replay(slicer,client);
String etag = strat.execute(container, blob);
assertEquals(etag, Fake ETAG);
+
+ verify(slicer, client);
What is the benefit of this? Are we interested in how often exactly the
@@ -112,4 +113,21 @@ public Integer answer() throws Throwable {
}
+ @Test
+ public void test504DoesRetry() {
+ AWSUtils utils = createMock(AWSUtils.class);
+ HttpCommand command = createMock(HttpCommand.class);
+
If I understand correctly, the change basically was delegate decision to retry
to parent class on 504? If I'm getting that right, +1 - looks good to me!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/317#issuecomment-38011814
jclouds-java-7-pull-requests #1128 UNSTABLE
Just for the record, that was a [spurious test
48 matches
Mail list logo
