Re: [jclouds] JCLOUDS-486 This will allow booting up nova servers with fixed IPs and p... (#313)

2014-03-20 Thread Andrew Phillips
> +serverApi.delete(serverId); > + } > + } > + } > + > + private Server createServer(String regionId, Server.Status serverStatus) { > + ServerApi serverApi = api.getServerApiForZone(regionId); > + CreateServerOptions options = new CreateServerOptions(); > +

Re: [jclouds] JCLOUDS-486 This will allow booting up nova servers with fixed IPs and p... (#313)

2014-03-20 Thread Andrew Phillips
> -} > + } > + } > + } > + > + @Test > + public void testCreateInWrongAvailabilityZone() { > + String serverId = null; > + for (String zoneId : zones) { > + ServerApi serverApi = api.getServerApiForZone(zoneId); > + try { > +serverId = cr

Re: [jclouds] JCLOUDS-486 This will allow booting up nova servers with fixed IPs and p... (#313)

2014-03-20 Thread Andrew Phillips
> + withImage(server.getImage().getId()). > + name("newName"). > + adminPass("password"). > + ipv4Address("1.1.1.1"). > + ipv6Address("fe80::100"); > + > +serverApi.rebuild(serverId, options); > + > +

Re: [jclouds] JCLOUDS-486 This will allow booting up nova servers with fixed IPs and p... (#313)

2014-03-20 Thread Andrew Phillips
> + /** > +* This needs to be supported by the provider, and is usually not > supported. > +* However this can be tested on devstack: > +* In apis/openstack-nova: > +* mvn -Plive clean install > "-Dtest.openstack-nova.endpoint=http://localhost:5000/v2.0"; > "-Dtest.openstack-no

Re: [jclouds] JCLOUDS-486 This will allow booting up nova servers with fixed IPs and p... (#313)

2014-03-20 Thread Andrew Phillips
> +serverId = createServer(zoneId, "nova", > Server.Status.ACTIVE).getId(); > +Server server = serverApi.get(serverId); > +assertEquals(server.getStatus(), Server.Status.ACTIVE); > + } finally { > +serverApi.delete(serverId); > + } >

Re: [jclouds] JCLOUDS-486 This will allow booting up nova servers with fixed IPs and p... (#313)

2014-03-20 Thread Andrew Phillips
> - } > - } > -} > - > -@Test > -public void testCreateInAvailabilityZone() { > -String serverId = null; > -for (String zoneId : zones) { > -ServerApi serverApi = api.getServerApiForZone(zoneId); > -try { > -serverId

Re: [jclouds] JCLOUDS-486 This will allow booting up nova servers with fixed IPs and p... (#313)

2014-03-20 Thread Andrew Phillips
> @@ -364,6 +386,16 @@ public CreateServerOptions availabilityZone(String > availabilityZone) { > public Set getNetworks() { >return networks; > } > + > + /** > +* Get custom networks specified for the server. [minor] Gets --- Reply to this email directly or view it on G

[jira] [Comment Edited] (JCLOUDS-458) Google Cloud Storage support

2014-03-20 Thread Roney Thomas (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13942722#comment-13942722 ] Roney Thomas edited comment on JCLOUDS-458 at 3/21/14 3:40 AM:

Re: [jclouds] JCLOUDS-486 This will allow booting up nova servers with fixed IPs and p... (#313)

2014-03-20 Thread Andrew Phillips
> + return this; > + } > + > + /** > + * @return A new Network object. > + */ > + public Network build() { > + return new Network(networkUuid, portUuid, fixedIp); > + } > + > + /** > + * @param in The target Network > + * @return A Bu

Re: [jclouds] JCLOUDS-486 This will allow booting up nova servers with fixed IPs and p... (#313)

2014-03-20 Thread Andrew Phillips
> + public int hashCode() { > + return Objects.hashCode(networkUuid, portUuid, fixedIp); > + } > + > + @Override > + public boolean equals(Object obj) { > + if (this == obj) return true; > + if (obj == null || getClass() != obj.getClass()) return false; > + Network that

Re: [jclouds] JCLOUDS-486 This will allow booting up nova servers with fixed IPs and p... (#313)

2014-03-20 Thread Andrew Phillips
> + * See the License for the specific language governing permissions and > + * limitations under the License. > + */ > +package org.jclouds.openstack.nova.v2_0.domain; > + > +import java.beans.ConstructorProperties; > + > +import com.google.common.base.Objects; > +import com.google.common.base.Obj

Re: [jclouds] JCLOUDS-486 This will allow booting up nova servers with fixed IPs and p... (#313)

2014-03-20 Thread Andrew Phillips
> + */ > +package org.jclouds.openstack.nova.v2_0.domain; > + > +import java.beans.ConstructorProperties; > + > +import com.google.common.base.Objects; > +import com.google.common.base.Objects.ToStringHelper; > + > +import static com.google.common.base.Preconditions.checkArgument; > + > +/** > + *

Re: [jclouds] JCLOUDS-486 This will allow booting up nova servers with fixed IPs and p... (#313)

2014-03-20 Thread Andrew Phillips
> @@ -575,4 +606,15 @@ public NovaTemplateOptions configDrive(boolean > configDrive) { >this.configDrive = configDrive; >return this; > } > + > + /** > +* @param novaNetworks The list of network declarations. > +* Nova-specific network declarations allow for specifyin

Re: [jclouds] JCLOUDS-486 This will allow booting up nova servers with fixed IPs and p... (#313)

2014-03-20 Thread Andrew Phillips
> @@ -545,6 +567,15 @@ public NovaTemplateOptions networks(Iterable > networks) { > } > > /** > +* Ensures NovaTemplateOptions can work with networks specified as > Strings. What's the `` for here? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/j

Re: [jclouds] JCLOUDS-486 This will allow booting up nova servers with fixed IPs and p... (#313)

2014-03-20 Thread Andrew Phillips
> @@ -537,7 +558,8 @@ public NovaTemplateOptions nodeNames(Iterable > nodeNames) { > } > > /** > -* {@inheritDoc} > +* Ensures NovaTemplateOptions can work with networks specified as > Strings. What's the `` for here? --- Reply to this email directly or view it on GitHub: http

[jira] [Commented] (JCLOUDS-458) Google Cloud Storage support

2014-03-20 Thread Roney Thomas (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13942722#comment-13942722 ] Roney Thomas commented on JCLOUDS-458: -- Deliverables : Google Cloud Storage Support

Re: [jclouds-examples] Remove RestContext from Rackspace examples (#35)

2014-03-20 Thread Ignasi Barrera
Didn't notice that when going through the PR. and agree. Examples should be creating only one context! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-examples/pull/35#issuecomment-38228840

Jenkins build is still unstable: jclouds » jclouds-labs-openstack #935

2014-03-20 Thread BuildHive
See

Re: [jclouds] JCLOUDS-184: Improving AzureBlob unit tests for AzureBlobBlockUploadStrategyTest (#320)

2014-03-20 Thread BuildHive
[jclouds » jclouds #931](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/931/) SUCCESS This pull request looks good [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/320#issuecomment

Re: [jclouds-examples] Remove RestContext from Rackspace examples (#35)

2014-03-20 Thread Jeremy Daggett
@demobox Thanks for the feedback! Removal of RestContext was the first step in a bunch of example changes coming. I can update with your suggestions in the next PR which is underway now. WDYT? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-examples/pull

Re: [jclouds-examples] Remove RestContext from Rackspace examples (#35)

2014-03-20 Thread Andrew Phillips
> I can update with your suggestions in the next PR which is underway now. > WDYT? Works for me! Would just be curious to see what we feel collectively about creating two contexts vs. using `unwrap` to get at the API... --- Reply to this email directly or view it on GitHub: https://github.com/

Re: [jclouds] JCLOUDS-184: Improving AzureBlob unit tests for AzureBlobBlockUploadStrategyTest (#320)

2014-03-20 Thread Andrew Phillips
> jclouds-java-7-pull-requests #1146 UNSTABLE Spurious [test failure](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/org.apache.jclouds$jclouds-compute/1146/testReport/junit/org.jclouds.compute.util/ConcurrentOpenSocketFinderTest/testChecksSocketsConcurrently/) --- Reply to th

Re: [jclouds-examples] Remove RestContext from Rackspace examples (#35)

2014-03-20 Thread Andrew Phillips
Most of the cleanup is great, thanks @jdaggett! Just a comment about those examples where we use both the ComputeService view and the API. This refactoring now ends up creating _two_ contexts in those cases, which I'm not sure is a good thing to be recommending? @everett-toews @zack-shoylev Wha

Re: [jclouds-examples] Remove RestContext from Rackspace examples (#35)

2014-03-20 Thread Andrew Phillips
> .credentials(username, apiKey) > .overrides(overrides) > -.modules(modules) > -.buildView(ComputeServiceContext.class); > - > - computeService = context.getComputeService(); > - novaContext = context.unwrap(); > +.modules(mod

Re: [jclouds-examples] Remove RestContext from Rackspace examples (#35)

2014-03-20 Thread Andrew Phillips
> @@ -77,12 +81,10 @@ public static void main(String[] args) throws IOException > { > } > > public UploadDirectoryToCDN(String username, String apiKey) { > - BlobStoreContext context = ContextBuilder.newBuilder(PROVIDER) > -.credentials(username, apiKey) > -.

Re: [jclouds-examples] Remove RestContext from Rackspace examples (#35)

2014-03-20 Thread Andrew Phillips
> @@ -67,11 +71,10 @@ public static void main(String[] args) throws IOException > { > } > > public UploadObjects(String username, String apiKey) { > - BlobStoreContext context = ContextBuilder.newBuilder(PROVIDER) > -.credentials(username, apiKey) > -.buildVi

Re: [jclouds-examples] Remove RestContext from Rackspace examples (#35)

2014-03-20 Thread Andrew Phillips
> @@ -22,12 +22,13 @@ > * Constants used by the Rackspace Examples. > * > * @author Everett Toews > + * @authot Jeremy Daggett [minor] "author" --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-examples/pull/35/files#r10816711

Re: [jclouds] JCLOUDS-184: Improving AzureBlob unit tests for AzureBlobBlockUploadStrategyTest (#320)

2014-03-20 Thread CloudBees pull request builder plugin
[jclouds-java-7-pull-requests #1146](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1146/) UNSTABLE Looks like there's a problem with this pull request --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/320#issuecomment-38221925

Re: [jclouds-examples] Remove RestContext from Rackspace examples (#35)

2014-03-20 Thread Andrew Phillips
> @@ -212,6 +215,7 @@ private void mountVolume(NodeMetadata node) { > */ > public void close() throws IOException { >Closeables.close(cinderApi, true); > + Closeables.close(nova, true); If we stick with one context, we wouldn't need this, I guess? --- Reply to this email dir

Re: [jclouds-examples] Remove RestContext from Rackspace examples (#35)

2014-03-20 Thread Andrew Phillips
> .credentials(username, apiKey) > -.modules(modules) > -.buildView(ComputeServiceContext.class); > - computeService = context.getComputeService(); > - nova = context.unwrap(); > - serverApi = nova.getApi().getServerApiForZone(ZONE); > - volu

Re: [jclouds-examples] Remove RestContext from Rackspace examples (#35)

2014-03-20 Thread Andrew Phillips
> .credentials(username, apiKey) > .modules(modules) > -.overrides(overrides) > -.buildView(ComputeServiceContext.class); > - computeService = context.getComputeService(); > - nova = context.unwrap(); > - volumeAttachmentApi = > nova

Re: [jclouds] JCLOUDS-505: Deprecate unused ObjectMD5 (#322)

2014-03-20 Thread BuildHive
[jclouds » jclouds #930](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/930/) SUCCESS This pull request looks good [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/322#issuecomment

Re: [jclouds] JCLOUDS-184: Improving AzureBlob unit tests for AzureBlobBlockUploadStrategyTest (#320)

2014-03-20 Thread CloudBees pull request builder plugin
[jclouds-pull-requests #676](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/676/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/320#issuecomment-38221041

Re: [jclouds] JCLOUDS-505: Deprecate unused ObjectMD5 (#322)

2014-03-20 Thread CloudBees pull request builder plugin
[jclouds-java-7-pull-requests #1145](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1145/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/322#issuecomment-38218321

Re: [jclouds] JCLOUDS-505: Remove unused ObjectMD5 (#321)

2014-03-20 Thread CloudBees pull request builder plugin
[jclouds-java-7-pull-requests #1144](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1144/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/321#issuecomment-38217877

Re: [jclouds] JCLOUDS-505: Deprecate unused ObjectMD5 (#322)

2014-03-20 Thread CloudBees pull request builder plugin
[jclouds-pull-requests #675](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/675/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/322#issuecomment-38217492

Re: [jclouds] JCLOUDS-505: Remove unused ObjectMD5 (#321)

2014-03-20 Thread CloudBees pull request builder plugin
[jclouds-pull-requests #674](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/674/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/321#issuecomment-38217431

Jenkins build is still unstable: jclouds » jclouds-labs-openstack #934

2014-03-20 Thread BuildHive
See

Re: [jclouds] JCLOUDS-505: Deprecate unused ObjectMD5 (#322)

2014-03-20 Thread Andrew Phillips
Add a "will be removed in 1.8.0" warning? Otherwise, good to go for me, +1 (pending PR builders, obviously). Thanks, @andrewgaul! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/322#issuecomment-38216555

Re: [jclouds] JCLOUDS-505: Remove unused ObjectMD5 (#321)

2014-03-20 Thread BuildHive
[jclouds » jclouds #929](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/929/) SUCCESS This pull request looks good [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/321#issuecomment

Jenkins build is back to stable : jclouds » jclouds #929

2014-03-20 Thread BuildHive
See

Re: [jclouds] JCLOUDS-505: Remove unused ObjectMD5 (#321)

2014-03-20 Thread Andrew Phillips
Pending PR builders, definitely +1, good to go for me - thanks for the cleanup, @andrewgaul! Do we know if e.g. this is maybe used in labs? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/321#issuecomment-38211729

[jclouds] JCLOUDS-505: Deprecate unused ObjectMD5 (#322)

2014-03-20 Thread Andrew Gaul
Also deprecate org.jclouds.atmos.blobstore.strategy.FindMD5InUserMetadata and org.jclouds.azureblob.blobstore.strategy.FindMD5InBlobProperties which are themselves unused. You can merge this Pull Request by running: git pull https://github.com/maginatics/jclouds remove-object-md5-1.7.x Or you c

[jclouds] JCLOUDS-505: Remove unused ObjectMD5 (#321)

2014-03-20 Thread Andrew Gaul
The only users of this seem to be org.jclouds.atmos.blobstore.strategy.FindMD5InUserMetadata and org.jclouds.azureblob.blobstore.strategy.FindMD5InBlobProperties which are themselves unused. You can merge this Pull Request by running: git pull https://github.com/maginatics/jclouds remove-object-

Re: [jclouds] Add ssh-agent support via jsch agentproxy (#312)

2014-03-20 Thread Andrew Phillips
> jclouds-pull-requests #673 UNSTABLE Another [spurious test failure](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/org.apache.jclouds$jclouds-compute/673/testReport/junit/org.jclouds.compute.callables/BlockUntilInitScriptStatusIsZeroThenReturnOutputTest/testloopUntilTrueOrThrowCance

Re: [jclouds] Add ssh-agent support via jsch agentproxy (#312)

2014-03-20 Thread CloudBees pull request builder plugin
[jclouds-java-7-pull-requests #1143](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1143/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/312#issuecomment-38207968

Re: [jclouds] Add ssh-agent support via jsch agentproxy (#312)

2014-03-20 Thread CloudBees pull request builder plugin
[jclouds-pull-requests #673](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/673/) UNSTABLE Looks like there's a problem with this pull request --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/312#issuecomment-38206878

[jira] [Created] (JCLOUDS-505) Deprecate and remove org.jclouds.blobstore.functions.ObjectMD5

2014-03-20 Thread Andrew Gaul (JIRA)
Andrew Gaul created JCLOUDS-505: --- Summary: Deprecate and remove org.jclouds.blobstore.functions.ObjectMD5 Key: JCLOUDS-505 URL: https://issues.apache.org/jira/browse/JCLOUDS-505 Project: jclouds

Re: [jclouds] Add ssh-agent support via jsch agentproxy (#312)

2014-03-20 Thread Andrew Phillips
> jclouds » jclouds #928 UNSTABLE Spurious [test failure](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/org.apache.jclouds$jclouds-core/928/testReport/junit/org.jclouds.rest.functions/PresentWhenApiVersionLexicographicallyAtOrAfterSinceApiVersionTest/testCacheIsFasterWhenNoAnnotationPre

Jenkins build became unstable: jclouds » jclouds #928

2014-03-20 Thread BuildHive
See

Re: [jclouds] Add ssh-agent support via jsch agentproxy (#312)

2014-03-20 Thread BuildHive
[jclouds » jclouds #928](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/928/) UNSTABLE Looks like there's a problem with this pull request [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclou

Re: [jclouds-examples] Remove RestContext from Rackspace examples (#35)

2014-03-20 Thread Ignasi Barrera
Closed #35. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-examples/pull/35

Re: [jclouds-examples] Remove RestContext from Rackspace examples (#35)

2014-03-20 Thread Ignasi Barrera
[Merged](https://git-wip-us.apache.org/repos/asf?p=jclouds-examples.git;a=commit;h=40da9b47850f6794381f9cd7557ab034300aa375). Thanks! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-examples/pull/35#issuecomment-38190676

[jira] [Commented] (JCLOUDS-180) Audit MD5 enforcement via new live tests

2014-03-20 Thread Andrew Gaul (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13941892#comment-13941892 ] Andrew Gaul commented on JCLOUDS-180: - [~Bhash90] Presently all (known) providers enf

[jira] [Commented] (JCLOUDS-180) Audit MD5 enforcement via new live tests

2014-03-20 Thread Bhathiya Supun (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13941719#comment-13941719 ] Bhathiya Supun commented on JCLOUDS-180: I like to work on this issue,Where it s

[jira] [Updated] (JCLOUDS-504) search for group name in tags

2014-03-20 Thread Izek Greenfield (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-504?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Izek Greenfield updated JCLOUDS-504: Description: By now aws-ec2 search for group in the securityGroup name and keyPair. it wil