Re: [jclouds] Delete objects in a container efficiently. (#214)

> + final String fullPath = parentIsFolder(options, md) ? > options.getDir() > + + "/" + md.getName() : md.getName(); > + > +// Attempt to acquire a semaphore within the time limit. At least > +// one outstanding future should complete within this peri

Re: [jclouds] Delete objects in a container efficiently. (#214)

> + switch (md.getType()) { > + case BLOB: > +blobDelFuture = executorService.submit(new Callable() { > + @Override > + public Void call() { > + blobStore.removeBlob(containerName, fullPath); > + retu

Re: [jclouds-labs-openstack] JCLOUDS-494: Change EndpointParam parser to negotiate version for Glance API (#82)

@everett-toews : This running on a stock Devstack (just pulled from master today) inside an Ubuntu Precise instance running in VirtualBox. The test runs on OS X, so there was a minimal amount of host configuration needed to make it work: https://gist.github.com/jasdeep-hundal/852739ae46539858714

Re: [jclouds] JCLOUDS-515: Don't require availability zone when creating volumes in cinder (#327)

[jclouds-java-7-pull-requests #1164](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1164/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/327#issuecomment-38639908

Re: [jclouds] JCLOUDS-515: Don't require availability zone when creating volumes in cinder (#327)

[jclouds-pull-requests #694](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/694/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/327#issuecomment-38639405

Re: [jclouds] JCLOUDS-515: Don't require availability zone when creating volumes in cinder (#327)

[jclouds » jclouds #950](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/950/) SUCCESS This pull request looks good [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/327#issuecomment

[jira] [Commented] (JCLOUDS-515) Cinder volume create does not require availability zone

[ https://issues.apache.org/jira/browse/JCLOUDS-515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13947352#comment-13947352 ] Jasdeep Hundal commented on JCLOUDS-515: PR: https://github.com/jclouds/jclouds/p

[jclouds] JCLOUDS-515: Don't require availability zone when creating volumes in cinder (#327)

Fixes: https://issues.apache.org/jira/browse/JCLOUDS-515 You can merge this Pull Request by running: git pull https://github.com/jasdeep-hundal/jclouds no_require_avail_zone_cinder Or you can view, comment on it, or merge it online at: https://github.com/jclouds/jclouds/pull/327 -- Commit

[jira] [Created] (JCLOUDS-515) Cinder volume create does not require availability zone

Jasdeep Hundal created JCLOUDS-515: -- Summary: Cinder volume create does not require availability zone Key: JCLOUDS-515 URL: https://issues.apache.org/jira/browse/JCLOUDS-515 Project: jclouds

[jira] [Commented] (JCLOUDS-513) Publish sources.jar using standard artifact/classifier name

[ https://issues.apache.org/jira/browse/JCLOUDS-513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13947344#comment-13947344 ] Shevek commented on JCLOUDS-513: I think it does. OK, back to the drawing board on why ou

[jira] [Closed] (JCLOUDS-513) Publish sources.jar using standard artifact/classifier name

[ https://issues.apache.org/jira/browse/JCLOUDS-513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shevek closed JCLOUDS-513. -- Resolution: Invalid > Publish sources.jar using standard artifact/classifier name > --

Re: [jclouds-labs-openstack] Fix failing Glance expect tests on master (#84)

+1 - thanks, @jdaggett! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/84#issuecomment-38634346

Re: [jclouds] WIP JCLOUDS-514: Add ability to attach block volumes at boot through the Nova ServerApi (#326)

[jclouds » jclouds #949](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/949/) SUCCESS This pull request looks good [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/326#issuecomment

Re: [jclouds] WIP JCLOUDS-514: Add ability to attach block volumes at boot through the Nova ServerApi (#326)

[jclouds-java-7-pull-requests #1163](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1163/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/326#issuecomment-38629844

Re: [jclouds] Add ssh-agent support via jsch agentproxy (#312)

[jclouds-java-7-pull-requests #1162](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1162/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/312#issuecomment-38629843

Re: [jclouds] WIP JCLOUDS-514: Add ability to attach block volumes at boot through the Nova ServerApi (#326)

Thanks for taking care of this @jasdeep-hundal! To add it to the compute service api, what I'd do is to extend the [TemplateOptions](https://github.com/jclouds/jclouds/blob/master/compute/src/main/java/org/jclouds/compute/options/TemplateOptions.java) class by adding a method that accepts a list

Re: [jclouds] WIP JCLOUDS-514: Add ability to attach block volumes at boot through the Nova ServerApi (#326)

[jclouds-pull-requests #693](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/693/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/326#issuecomment-38629321

Re: [jclouds] Add ssh-agent support via jsch agentproxy (#312)

[jclouds-pull-requests #692](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/692/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/312#issuecomment-38629249

Re: [jclouds] Add ssh-agent support via jsch agentproxy (#312)

> byte[] privateKey = loginCredentials.getPrivateKey().getBytes(); > jsch.addIdentity(loginCredentials.getUser(), privateKey, null, > emptyPassPhrase); > + } else { The checkArgument above makes the resulting else branch impossible to reach... --- Reply to this email dir

Re: [jclouds] Add ssh-agent support via jsch agentproxy (#312)

[jclouds » jclouds #948](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/948/) SUCCESS This pull request looks good [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/312#issuecomment

Jenkins build is back to normal : jclouds » jclouds #948

See

Re: [jclouds-labs-openstack] Updates to Rackspace Cloud Files CDN (#85)

In general, thanks a lot for the cleanup, @jdaggett! Just some questions about test naming: there are a lot of `...Fail()` tests that do not obviously seem to fail (e.g. they don't expect an exception). Could we give them more specific names to describe which kind of failure on the server they a

[jira] [Commented] (JCLOUDS-513) Publish sources.jar using standard artifact/classifier name

[ https://issues.apache.org/jira/browse/JCLOUDS-513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13947230#comment-13947230 ] Ignasi Barrera commented on JCLOUDS-513: That's because the {{jclouds}} project i

Re: [jclouds-labs-openstack] Updates to Rackspace Cloud Files CDN (#85)

[jclouds-labs-openstack-pull-requests #187](https://jclouds.ci.cloudbees.com/job/jclouds-labs-openstack-pull-requests/187/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/85#issuecomment-38626630

Re: [jclouds-labs-openstack] Updates to Rackspace Cloud Files CDN (#85)

[jclouds » jclouds-labs-openstack #952](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-openstack/952/) SUCCESS This pull request looks good [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub: https://github.com/jcloud

Re: [jclouds-labs-openstack] Updates to Rackspace Cloud Files CDN (#85)

> @@ -105,34 +123,64 @@ public void testListWithOptions() throws Exception { >} > } > > - public void testEnableAndDisable() throws Exception { > + public void testListWithOptionsFail() throws Exception { Similar comments as above --- Reply to this email directly or view it on G

Re: [jclouds-labs-openstack] Updates to Rackspace Cloud Files CDN (#85)

> assertAuthentication(server); > assertRequest(server.takeRequest(), "PUT", > "/v1/MossoCloudFS_5bcf396e-39dd-45ff-93a1-712b9aba90a9/container-1"); > + } finally { > + server.shutdown(); > + } > + } > + > + public void testEnableFail() throws Exception {

Re: [jclouds-labs-openstack] Updates to Rackspace Cloud Files CDN (#85)

> @@ -81,6 +77,28 @@ public void testList() throws Exception { >} > } > > + public void testListFail() throws Exception { What failure exactly are we testing here? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/85/file

Re: [jclouds-labs-openstack] Updates to Rackspace Cloud Files CDN (#85)

> + MockWebServer server = mockOpenStackServer(); > + server.enqueue(addCommonHeaders(new > MockResponse().setBody(stringFromResource("/access.json"; > + server.enqueue(addCommonHeaders(new > MockResponse().setResponseCode(404).setBody(stringFromResource("/cdn_container_list.js

Re: [jclouds-labs-openstack] Updates to Rackspace Cloud Files CDN (#85)

> @@ -86,6 +117,45 @@ public void testGet() throws Exception { >} > } > > + /** > +* By default, this method is disabled due to daily purge limitations of > 25 objects per day. > +*/ > + @Test(enabled = false) Do we want to commit tests that are disabled? What is the int

Re: [jclouds-labs-openstack] Updates to Rackspace Cloud Files CDN (#85)

> + } > + > + public void testUpdate() throws Exception { > + for (String regionId : regions) { > + UpdateCDNContainerOptions opts = new UpdateCDNContainerOptions(); > + opts.ttl(1234567); > + opts.logRetention(true); > + opts.enabled(false); > + >

Re: [jclouds-labs-openstack] Updates to Rackspace Cloud Files CDN (#85)

> @@ -86,6 +117,45 @@ public void testGet() throws Exception { >} > } > > + /** > +* By default, this method is disabled due to daily purge limitations of > 25 objects per day. > +*/ > + @Test(enabled = false) > + public void testPurgeObject() throws Exception { > +

Re: [jclouds-labs-openstack] Updates to Rackspace Cloud Files CDN (#85)

> @@ -43,6 +56,24 @@ public CloudFilesCDNApiLiveTest() { >super(); > } > > + public void testEnable() throws Exception { > + for (String regionId : regions) { > + assertNotNull(api.cdnApiInRegion(regionId).enable(name)); > + } > + } > + > + public void testEnab

[jclouds-labs-openstack] Updates to Rackspace Cloud Files CDN (#85)

This PR provides several updates the Rackspace Cloud Files CDN functionality. - refactor of StaticWeb related headers - pulled up from CloudFilesHeaders to SwiftHeaders - cleaned up tests and removed dead code JIRA: https://issues.apache.org/jira/browse/JCLOUDS-423 You can merge this Pull Reque

[jira] [Commented] (JCLOUDS-514) Need to be able to attach block volumes at instance creation in Nova

[ https://issues.apache.org/jira/browse/JCLOUDS-514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13947191#comment-13947191 ] Jasdeep Hundal commented on JCLOUDS-514: PR: https://github.com/jclouds/jclouds/p

[jclouds] WIP JCLOUDS-514: Add ability to attach block volumes at boot through the Nova ServerApi (#326)

Fixes: https://issues.apache.org/jira/browse/JCLOUDS-514 Looking for comments to get going in the right direction with this, still needs: - Tests - Possibly a way to access this through the ComputeService API? Not necessary for my use case, but if it's easy I'm willing to help out here. You can m

[jira] [Commented] (JCLOUDS-281) Missing Nova creating compute instance with Bootable Volume

[ https://issues.apache.org/jira/browse/JCLOUDS-281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13947198#comment-13947198 ] Jasdeep Hundal commented on JCLOUDS-281: [~bklau2006]: Please see the PR in JCLOU

[jira] [Created] (JCLOUDS-514) Need to be able to attach block volumes at instance creation in Nova

Jasdeep Hundal created JCLOUDS-514: -- Summary: Need to be able to attach block volumes at instance creation in Nova Key: JCLOUDS-514 URL: https://issues.apache.org/jira/browse/JCLOUDS-514 Project: jcl

[jira] [Commented] (JCLOUDS-513) Publish sources.jar using standard artifact/classifier name

[ https://issues.apache.org/jira/browse/JCLOUDS-513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13947082#comment-13947082 ] Shevek commented on JCLOUDS-513: For example, compare this: http://search.maven.org/#art

[jira] [Created] (JCLOUDS-513) Publish sources.jar using standard artifact/classifier name

Shevek created JCLOUDS-513: -- Summary: Publish sources.jar using standard artifact/classifier name Key: JCLOUDS-513 URL: https://issues.apache.org/jira/browse/JCLOUDS-513 Project: jclouds Issue Type

Re: [jclouds-labs-openstack] Fix failing Glance expect tests on master (#84)

Closed #84. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/84

Re: [jclouds-labs] [JCLOUDS-500] Initial commit for docker (#57)

[jclouds-labs-pull-requests #137](https://jclouds.ci.cloudbees.com/job/jclouds-labs-pull-requests/137/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/57#issuecomment-38606328

Jenkins build is back to stable : jclouds-labs-openstack » jclouds openstack-glance api #312

See

Jenkins build is back to stable : jclouds-labs-openstack #312

See

Re: [jclouds-labs] [JCLOUDS-500] Initial commit for docker (#57)

[jclouds » jclouds-labs #896](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs/896/) SUCCESS This pull request looks good [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/5

Re: [jclouds-labs] [JCLOUDS-500] Initial commit for docker (#57)

@nacx live tests are healthy too, ``` Results : Tests run: 14, Failures: 0, Errors: 0, Skipped: 0 --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/57#issuecomment-38604658

Re: [jclouds-labs-openstack] Fix failing Glance expect tests on master (#84)

Merged. Thanks @jdaggett This is good to close. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/84#issuecomment-38603489

Re: [jclouds-labs-openstack] Fix failing Glance expect tests on master (#84)

About to merge --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/84#issuecomment-38602877

Re: [jclouds-labs-openstack] Fix failing Glance expect tests on master (#84)

[jclouds-labs-openstack-pull-requests #186](https://jclouds.ci.cloudbees.com/job/jclouds-labs-openstack-pull-requests/186/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/84#issuecomment-38599235

Re: [jclouds-labs-openstack] Fix failing Glance expect tests on master (#84)

[jclouds » jclouds-labs-openstack #950](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-openstack/950/) SUCCESS This pull request looks good [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub: https://github.com/jcloud

Jenkins build is back to stable : jclouds » jclouds-labs-openstack #950

See

[jclouds-labs-openstack] Fix failing Glance expect test on master (#84)

This PR is to fix the Glance v1 API Expect test failures on the master branch. Glance is very much in flux at the moment with the v1 and v2 APIs, and there are several outstanding PRs that need to be revisited : https://github.com/jclouds/jclouds-labs-openstack/pull/77 https://github.com/jclouds

Re: [jclouds] Delete objects in a container efficiently. (#214)

> + final String fullPath = parentIsFolder(options, md) ? > options.getDir() > + + "/" + md.getName() : md.getName(); > + > +// Attempt to acquire a semaphore within the time limit. At least > +// one outstanding future should complete within this peri

Jenkins build is still unstable: jclouds-labs-openstack #311

See

Jenkins build is still unstable: jclouds-labs-openstack » jclouds openstack-glance api #311

See

Jenkins build is still unstable: jclouds » jclouds-labs-openstack #949

See

Re: [jclouds-labs-openstack] OS Neutron Extension Router (#83)

> jclouds » jclouds-labs-openstack #948 UNSTABLE known unrelated issue --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/83#issuecomment-38585722

Re: [jclouds-labs-openstack] OS Neutron Extension Router (#83)

[jclouds-labs-openstack-pull-requests #185](https://jclouds.ci.cloudbees.com/job/jclouds-labs-openstack-pull-requests/185/) UNSTABLE Looks like there's a problem with this pull request --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/8

[jira] [Commented] (JCLOUDS-458) Google Cloud Storage support

[ https://issues.apache.org/jira/browse/JCLOUDS-458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13946590#comment-13946590 ] Roney Thomas commented on JCLOUDS-458: -- This was my proposal http://www.google-melan

Jenkins build is still unstable: jclouds » jclouds-labs-openstack #948

See

Re: [jclouds-labs-openstack] OS Neutron Extension Router (#83)

[jclouds » jclouds-labs-openstack #948](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-openstack/948/) UNSTABLE Looks like there's a problem with this pull request [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub: h

Re: [jclouds-labs-openstack] OS Neutron Extension Router (#47)

Closed #47. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/47

Re: [jclouds-labs-openstack] OS Neutron Extension Router (#47)

This should be closed. merged https://github.com/jclouds/jclouds-labs-openstack/pull/83 instead. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/47#issuecomment-38584962

Re: [jclouds-labs-openstack] OS Neutron Extension Router (#83)

Closed #83. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/83

Re: [jclouds-labs-openstack] OS Neutron Extension Router (#83)

merged --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/83#issuecomment-38584885

Re: [jclouds-labs-openstack] OS Neutron Extension Router (#47)

Oops! But this is the one that will be merged if I did it right: https://github.com/jclouds/jclouds-labs-openstack/pull/83 --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/47#issuecomment-38584011

[jclouds-labs-openstack] OS Neutron Extension Router (#83)

Original PR here: https://github.com/jclouds/jclouds-labs-openstack/pull/47 This rebases so it can be merged. No further changes in this PR. You can merge this Pull Request by running: git pull https://github.com/rackerlabs/jclouds-labs-openstack os-neutron-router Or you can view, comment on

Re: [jclouds] Add ssh-agent support via jsch agentproxy (#312)

Started this in the branch. Will finish and merge tonight. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/312#issuecomment-38568968

Re: [jclouds] Add ssh-agent support via jsch agentproxy (#312)

>Does that make some kind of sense? @nacx: thoughts on this? Yep. I think it would be cleaner. Returning a "fake" agent relies on clients calling the "isAvailable" method to know if the agent is there, and there is no practical way to prevent them from calling the "query" method that will always

Re: [jclouds] Add ssh-agent support via jsch agentproxy (#312)

[jclouds-pull-requests #691](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/691/) FAILURE Looks like there's a problem with this pull request --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/312#issuecomment-38557724

Re: [jclouds] Add ssh-agent support via jsch agentproxy (#312)

[jclouds » jclouds #947](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/947/) FAILURE Looks like there's a problem with this pull request [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jcloud

Build failed in Jenkins: jclouds » jclouds #947

See Changes: [ext-pasi.1.niemi] Add ssh agent support via sch agentproxy -- [...truncated 4202 lines...] [INFO] Exclude: **/README.txt [INFO] Exclude: **/DEPENDENCIES [INFO] Exclude: **/

Re: [jclouds] Add ssh-agent support via jsch agentproxy (#312)

[jclouds-java-7-pull-requests #1161](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1161/) FAILURE Looks like there's a problem with this pull request --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/312#issuecomment-38556586

Re: [jclouds] Add ssh-agent support via jsch agentproxy (#312)

[jclouds-java-7-pull-requests #1160](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1160/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/312#issuecomment-38556216

Jenkins build is still unstable: jclouds » jclouds-labs-openstack #947

See

Re: [jclouds] Add ssh-agent support via jsch agentproxy (#312)

[jclouds-pull-requests #690](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/690/) UNSTABLE Looks like there's a problem with this pull request --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/312#issuecomment-38555608

Re: [jclouds] Add ssh-agent support via jsch agentproxy (#312)

[jclouds » jclouds #946](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/946/) SUCCESS This pull request looks good [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/312#issuecomment

Re: [jclouds-karaf] [JCLOUDS-511] Correcting features with dependency-only bundles (#40)

Apparently, when I split the rackspace features into pieces I forgot to remove the dependency attribute from cloud identity/dns. Having a feature that only defines "dependencies" without defining anything else is wrong as it will fail to install the required stuff in an environment that is using

Re: [jclouds] Add ssh-agent support via jsch agentproxy (#312)

> @@ -156,6 +157,15 @@ public String getPrivateKey() { > } > > /** > +* @return true if there is a private key attached that is not encrypted > +*/ > + public boolean hasUnencryptedPrivateKey() { > + return getPrivateKey() != null > + && !getPrivateKey().isEmpty() >

Re: [jclouds] Delete objects in a container efficiently. (#214)

> Looks like a network glitch on cloudbees. Looks like things [should be working again](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/). We should be fine for the next PR build... --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/214#issuec

Re: [jclouds] Add ssh-agent support via jsch agentproxy (#312)

Also thanks from me for the cleanup, @psiniemi! Just a curiosity question: why do we actually need the "connector wrapper" class? Could we configure Guice to try to inject the JSch connector _directly_, or do we need a new instance for every connection? In that case, perhaps make it a factory ra

Re: [jclouds] Add ssh-agent support via jsch agentproxy (#312)

> + public boolean isAvailable() { > + return false; > + } > + @Override > + public String getName() { > + return "agent-unavailable"; > + } > +}; > + } > + } > + > +

Re: [jclouds] Add ssh-agent support via jsch agentproxy (#312)

> @@ -58,9 +65,40 @@ public Factory(BackoffLimitedRetryHandler > backoffLimitedRetryHandler, Injector i > >@Override >public SshClient create(HostAndPort socket, LoginCredentials > credentials) { > - SshClient client = new SshjSshClient(backoffLimitedRetryHandler, > soc

Re: [jclouds] Add ssh-agent support via jsch agentproxy (#312)

> @@ -176,6 +201,14 @@ public int getSessionTimeout() { > } > > /** > +* > +* @return Ssh agent connector > +*/ > + public Connector getAgentConnector() { > +return agentConnector; [minor] Indentation --- Reply to this email directly or view it on GitHub: https://g

Re: [jclouds] Add ssh-agent support via jsch agentproxy (#312)

> + } > + @Override > + public boolean isAvailable() { > + return false; > + } > + @Override > + public Strin

Re: [jclouds] Add ssh-agent support via jsch agentproxy (#312)

> injector.injectMembers(client);// add logger > return client; >} > } > + private static class AgentProvider implements Provider, > SshClient.SshAgentAvailable { > + > + @Override > + public Connector get() { > + try { > +return Conn

Re: [jclouds] Add ssh-agent support via jsch agentproxy (#312)

> injector.injectMembers(client);// add logger > return client; >} > } > + private static class AgentProvider implements Provider, > SshClient.SshAgentAvailable { [minor] Add blank line before this class? --- Reply to this email directly or view it on GitHub: ht

Re: [jclouds] Add ssh-agent support via jsch agentproxy (#312)

> byte[] privateKey = loginCredentials.getPrivateKey().getBytes(); > jsch.addIdentity(loginCredentials.getUser(), privateKey, null, > emptyPassPhrase); > + } else { Simply `} else if {`? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jc

Re: [jclouds] Add ssh-agent support via jsch agentproxy (#312)

> @@ -160,11 +171,14 @@ public Session create() throws Exception { > session.setTimeout(sessionTimeout); >if (loginCredentials.getPrivateKey() == null) { > session.setPassword(loginCredentials.getPassword()); > - } else { > - > checkArgument(!loginCredentia

Re: [jclouds] Add ssh-agent support via jsch agentproxy (#312)

>this.hostAndPort = checkNotNull(hostAndPort, "hostAndPort"); >this.loginCredentials = checkNotNull(loginCredentials, > "loginCredentials for %", hostAndPort); >this.connectTimeout = connectTimeout; >this.sessionTimeout = sessionTimeout; >this.proxy = checkN

Re: [jclouds] Add ssh-agent support via jsch agentproxy (#312)

> @@ -156,6 +157,15 @@ public String getPrivateKey() { > } > > /** > +* @return true if there is a private key attached that is not encrypted > +*/ > + public boolean hasUnencryptedPrivateKey() { > + return getPrivateKey() != null > + && !getPrivateKey().isEmpty() >

Re: [jclouds] Add ssh-agent support via jsch agentproxy (#312)

> @@ -34,6 +34,12 @@ > > } > > + interface SshAgentAvailable { > + > + boolean isSshAgentAvailable(); > + > + } [minor] Remove blank lines and rename to something like `SshAgentFeatureFlag` or `SshClientFeatures` or so? --- Reply to this email directly or view it on GitHub: http

Re: [jclouds] Add ssh-agent support via jsch agentproxy (#312)

Thanks for the cleanup and the squash @psiniemi! Code looks much more clean now, and like the `AgentProvider approach`. Just a couple minors about style and one comment about the connector configuration, but nice cleanup! --- Reply to this email directly or view it on GitHub: https://github.com/

Re: [jclouds] Add ssh-agent support via jsch agentproxy (#312)

> @@ -136,10 +156,15 @@ public SSHClient create() throws Exception { >ssh.connect(hostAndPort.getHostText(), > hostAndPort.getPortOrDefault(22)); >if (loginCredentials.getPassword() != null) { > ssh.authPassword(loginCredentials.getUser(), > loginCredentials.getPassword(

Re: [jclouds] Add ssh-agent support via jsch agentproxy (#312)

> + } > + @Override > + public boolean isAvailable() { > + return false; > + } > + @Override > + public Strin

Re: [jclouds] Add ssh-agent support via jsch agentproxy (#312)

> +return ConnectorFactory.getDefault().createConnector(); > + } catch (final AgentProxyException e) { > +return new Connector() { > + @Override > + public void query(Buffer buffer) throws AgentProxyException { > + throw n

Re: [jclouds] Add ssh-agent support via jsch agentproxy (#312)

> @@ -122,15 +127,21 @@ public Builder from(SessionConnection in) { > > .connectTimeout(in.connectTimeout).sessionTimeout(in.sessionTimeout); >} > > + public Builder agentConnector(Connector agentConnector) { > + this.agentConnector = agentConnector; > +

[GitHub] Please reset your password

Hey, we heard you lost your GitHub password. Say it ain't so! Use the following link within the next 24 hours to reset your password: https://github.com/login/jclouds-mirror/750623e00c561a66cf92ad3b68d8c0c198b4aaa6cea0304ad4169ea5972de440b67c5ce8c9329dbf Thanks, The GitHub Team

Re: [jclouds] Add ssh-agent support via jsch agentproxy (#312)

[jclouds-java-7-pull-requests #1159](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1159/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/312#issuecomment-38539081

Jenkins build is still unstable: jclouds » jclouds-labs-openstack #946

See

  1   2   >