@@ -65,8 +65,17 @@
if (launchSpec.getSecurityGroupIds().size() 0)
options.withSecurityGroupIds(launchSpec.getSecurityGroupIds());
options.asType(checkNotNull(launchSpec.getInstanceType(),
instanceType));
- if (launchSpec.getSubnetId() != null)
-
if (subnetId != null) {
-
AWSRunInstancesOptions.class.cast(instanceOptions).withSubnetId(subnetId);
+ if(associatePublicIpAddress){
+
AWSRunInstancesOptions.class.cast(instanceOptions).associatePublicIpAddressAndSubnetId(subnetId);
+ if
return false;
- } else if (!monitoringEnabled.equals(other.monitoringEnabled))
- return false;
- if (ramdiskId == null) {
+ if (publicIpAddressAssociated == null) {
+if (other.publicIpAddressAssociated != null)
+ return false;
+
@@ -124,9 +124,13 @@ public void endElement(String uri, String name, String
qName) {
} else if (qName.equals(ramdiskId)) {
builder.ramdiskId(currentOrNull());
} else if (qName.equals(enabled)) {
- String monitoringEnabled = currentOrNull();
- if
Will do the style adjustments.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/333#issuecomment-40567156
First of all thanks for the contribution @lahirus!
There were already many live tests failing in master, so I assume those
failures aren't related to your changes. However, before merging this pull
requests, some unit tests that assert your additions should be added to the
following classes
*
You can merge this Pull Request by running:
git pull https://github.com/maginatics/jclouds deleteallkeys-cleanup
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds/pull/349
-- Commit Summary --
* Create a separate function to delete directories.
[jclouds-pull-requests
#760](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/760/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/349#issuecomment-40573788
Reopened #44.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/44
Closed #44.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/44
jclouds-karaf-pull-requests #65 UNSTABLE
Still [test
failures](https://jclouds.ci.cloudbees.com/job/jclouds-karaf-pull-requests/org.apache.jclouds.karaf$itests/65/testReport/)
here. Let's try to kick this again, since BuildHive looks happier.
---
Reply to this email directly or view it on
jclouds-karaf-pull-requests #66 UNSTABLE
Some [internal
failures](https://jclouds.ci.cloudbees.com/job/jclouds-karaf-pull-requests/66/testReport/)
here:
```
java.rmi.NotBoundException: 57010a6b-49ec-442f-800b-02bcb550999c
```
Will definitely need to run this again.
---
Reply to this email
Thanks for the detailed review, @nacx!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/333#issuecomment-40593176
[jclouds-karaf-pull-requests
#67](https://jclouds.ci.cloudbees.com/job/jclouds-karaf-pull-requests/67/)
UNSTABLE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/44#issuecomment-40594542
jclouds-karaf-pull-requests #67 UNSTABLE
Still 9 [test
failures](https://jclouds.ci.cloudbees.com/job/jclouds-karaf-pull-requests/org.apache.jclouds.karaf$itests/67/testReport/),
all related to attempts to get Guava 16. Will try with a clean job.
---
Reply to this email directly or view it on
[jclouds » jclouds-karaf
#902](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-karaf/902/)
SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
You can merge this Pull Request by running:
git pull https://github.com/jclouds/jclouds-site 1.7.2-release
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds-site/pull/78
-- Commit Summary --
* Updating latest_version after the 1.7.2 release
*
@@ -37,6 +37,13 @@
category rdf:resource=http://projects.apache.org/category/library; /
Have also run this through the [W3C validator](www.w3.org/RDF/Validator/), and
looks OK.
---
Reply to this email directly or view it on GitHub:
+---
+layout: releasenotes
+title: Release Notes for Version 1.7.2
+date: 2014-04-15 12:00:00
+release_notes: true
+permalink: /releasenotes/1.7.2/
+---
+
+## Introduction
+
+jclouds version 1.7.2 is the fourth release of jclouds as an Apache TLP.
+
+You can read the official
Javadoc publishing is still in progress, so please do not merge yet.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/78#issuecomment-40599468
+1 - looks good to me. Thanks, @andrewgaul!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/348#issuecomment-40600374
Thanks for the rebase. +1 - looks good to me!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/347#issuecomment-40600312
Go to
http://3efa0e8a8afa4b274313-6ff4b0ac0b88286df433b3166873cfe9.r89.cf1.rackcdn.com/
to review your changes.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/78#issuecomment-40601043
[jclouds-site-pull-requests
#245](https://jclouds.ci.cloudbees.com/job/jclouds-site-pull-requests/245/)
SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/78#issuecomment-40600850
Also aligning POMs
You can merge this Pull Request by running:
git pull https://github.com/jclouds/jclouds-examples 1.7.2-release
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds-examples/pull/43
-- Commit Summary --
* Updating the examples after
/parent
groupIdorg.apache.jclouds.examples/groupId
artifactIdjclouds-examples/artifactId
- version1.7.2-SNAPSHOT/version
+ version1.7.3-SNAPSHOT/version
Do we know _why_ we are versioning the examples to follow the main project, by
the way? `jclouds.version` would seem to be the
OK. so this actually looks happy:
@nacx: thoughts on the code change itself?
---
Reply to this email directly or view it on GitHub:
Reopened #43.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/43
Closed #43.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/43
[jclouds-site-pull-requests
#247](https://jclouds.ci.cloudbees.com/job/jclouds-site-pull-requests/247/)
SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/78#issuecomment-40607143
[jclouds-site-pull-requests
#248](https://jclouds.ci.cloudbees.com/job/jclouds-site-pull-requests/248/)
SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/78#issuecomment-40607892
Go to
http://27ab977fb82fa8a0508a-c30439210f2f43cb2cd0872a10be16ca.r50.cf1.rackcdn.com/
to review your changes.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/78#issuecomment-40606494
Go to
http://df7211661a67f8c4467f-969794664f15282c4bc7dc1c636f53b9.r65.cf1.rackcdn.com/
to review your changes.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/78#issuecomment-40608147
[jclouds-karaf-pull-requests
#68](https://jclouds.ci.cloudbees.com/job/jclouds-karaf-pull-requests/68/)
UNSTABLE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/43#issuecomment-40608705
[jclouds-site-pull-requests
#246](https://jclouds.ci.cloudbees.com/job/jclouds-site-pull-requests/246/)
SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/78#issuecomment-40606296
/parent
groupIdorg.apache.jclouds.examples/groupId
artifactIdjclouds-examples/artifactId
- version1.7.2-SNAPSHOT/version
+ version1.7.3-SNAPSHOT/version
Is the versioning scheme for the examples themselves important?
I would be fine leaving them at 1.0 just so they never have to
[jclouds » jclouds-karaf
#903](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-karaf/903/)
UNSTABLE
Looks like there's a problem with this pull request
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
Merged and published the site! /cc @erjohnso
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/74#issuecomment-40610959
@demobox Also, can you make sure you upgrade to jekyll 1.5.1 before generating
the site?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/78#issuecomment-40618772
@demobox Also, can you make sure you upgrade to jekyll 1.5.1 before
generating the site?
Will do. Was there a problem with a recent publish?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/78#issuecomment-40619170
Yes. My publish (using Jekyll 1.2.1) regenerated the atom feed by mistake.
Thanks for spotting @everett_toews!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/78#issuecomment-40619968
jclouds-karaf-pull-requests #68 UNSTABLE
jclouds » jclouds-karaf #903 UNSTABLE
Weird. DEV@cloud is [happy
now](https://jclouds.ci.cloudbees.com/job/jclouds-karaf-pull-requests/68/testReport/)
(only Checkstyle problems), but BuildHive is [unable to find the
[jclouds-site-pull-requests
#249](https://jclouds.ci.cloudbees.com/job/jclouds-site-pull-requests/249/)
SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/78#issuecomment-40628384
you'll need to pull again to make sure you get my commit.
Just fetched and rebased, but didn't see any new commit, @everett-toews?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/78#issuecomment-40628679
/parent
groupIdorg.apache.jclouds.examples/groupId
artifactIdjclouds-examples/artifactId
- version1.7.2-SNAPSHOT/version
+ version1.7.3-SNAPSHOT/version
Looks like we're currently tied for leaving at 1.0 vs. bumping per release
;-) Anyone else have any thoughts on this?
---
Closed #44.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/44
See https://buildhive.cloudbees.com/job/jclouds/job/jclouds-karaf/904/changes
Go to
http://8f85018f69b89c73adff-97d8ea1ac20094508906d609e15c6d4d.r33.cf1.rackcdn.com/
to review your changes.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/78#issuecomment-40644063
You can merge this Pull Request by running:
git pull https://github.com/rackerlabs/jclouds-site generic-logging
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds-site/pull/79
-- Commit Summary --
* More generic logging example code
-- File
Go to
http://75854f83a688a542d91a-044f721232b599b2e7c0dda317c1e105.r85.cf1.rackcdn.com/
to review your changes.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/79#issuecomment-40646165
You can merge this Pull Request by running:
git pull
https://github.com/rackerlabs/jclouds-site?utm_campaign=websiteutm_source=sendgrid.comutm_medium=email
move-providers
Or you can view, comment on it, or merge it online at:
[jclouds-site-pull-requests
#252](https://jclouds.ci.cloudbees.com/job/jclouds-site-pull-requests/252/)?utm_campaign=websiteutm_source=sendgrid.comutm_medium=email
SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
Go to
http://b3a8b596ab588e217c58-c93180b22108c71f35b2c601a3a6910b.r27.cf1.rackcdn.com/
to review your changes.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/80#issuecomment-40648145
Closed #80.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/80
[jclouds-site-pull-requests
#253](https://jclouds.ci.cloudbees.com/job/jclouds-site-pull-requests/253/)
SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/79#issuecomment-40653182
Go to
http://5fd6fcdd2401a4209bd9-585f196bc4aa09b43320dcea5a0fe438.r16.cf1.rackcdn.com/
to review your changes.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/79#issuecomment-40653392
@@ -114,14 +114,21 @@ You'll also need a logback.xml configuration file on
your classpath. Here's an e
## a id=enable/aEnable Logging
-Below is some example code of how to enable your code to use SLF4J. The
SLF4JLoggingModule needs to be passed in to the ContextBuilder of whatever
[jclouds » jclouds
#1034](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1034/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
Reopened #23.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/23
See https://buildhive.cloudbees.com/job/jclouds/job/jclouds-karaf/906/changes
Changes:
[gaul] Allow stdin for blobstore writes
--
[...truncated 499 lines...]
Downloading:
[jclouds » jclouds-karaf
#906](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-karaf/906/)?utm_campaign=websiteutm_source=sendgrid.comutm_medium=email
FAILURE
Looks like there's a problem with this pull request
[(what's
OK, let's see what happens if we go back to wrapping jsch-agentproxy-sshj and
skip jsch-agentproxy-jsch entirely.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/43#issuecomment-40679592
[jclouds-karaf-pull-requests
#70](https://jclouds.ci.cloudbees.com/job/jclouds-karaf-pull-requests/70/)
UNSTABLE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/43#issuecomment-40681528
See https://buildhive.cloudbees.com/job/jclouds/job/jclouds-karaf/907/changes
Closed #43.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/43
Reopened #43.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/43
66 matches
Mail list logo
