Re: [jclouds] Enforce that all commas have trailing whitespace (#359)

> jclouds-java-7-pull-requests #1256 FAILURE > jclouds-pull-requests #786 FAILURE Jenkins slaves going offline: ``` FATAL: channel is already closed hudson.remoting.ChannelClosedException: channel is already closed ``` Let's try that one again... --- Reply to this email directly or view it on Git

Re: [jclouds] Enforce that all commas have trailing whitespace (#359)

Closed #359. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/359#event-119003171

Jenkins build is back to normal : jclouds » allloadbalancer #2589

See

[jclouds] Enforce that all commas have trailing whitespace (#359)

You can merge this Pull Request by running: git pull https://github.com/andrewgaul/jclouds checkstyle-comma Or you can view, comment on it, or merge it online at: https://github.com/jclouds/jclouds/pull/359 -- Commit Summary -- * Enforce that all commas have trailing whitespace -- File

Jenkins build is back to normal : jclouds » jclouds GleSYS core #2589

See

Re: [jclouds-site] JCLOUDS-147: First experiment with Javadoc iframe (#93)

@demobox Manually doing the merged version wasn't that difficult. Copy over the jclouds-labs-openstack/* dirs to the respective jclouds/apis and jclouds/providers dirs. Then update the jclouds/apis/pom.xml and jclouds/providers/pom.xml files. Automating it will take a some effort though as scri

Re: [jclouds-site] Align the Install button with the content below it (#97)

> jclouds-site-pull-requests #299 FAILURE ``` /home/jenkins/.gem/ruby/1.9.1/gems/execjs-2.0.2/lib/execjs/runtimes.rb:51:in `autodetect': Could not find a JavaScript runtime. See https://github.com/sstephenson/execjs for a list of available runtimes. (ExecJS::RuntimeUnavailable) ``` Hm? Build bro

Re: [jclouds] JCLOUDS-505: Remove unused ObjectMD5 (#357)

[jclouds-pull-requests #783](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/783/) FAILURE Looks like there's a problem with this pull request --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/357#issuecomment-42411977

Build failed in Jenkins: jclouds » jclouds-labs-aws #819

See Changes: [romancoedo] Created the skeleton of the Glacier API. -- [...truncated 1036 lines...] [INFO] Exclude: **/bin/** [INFO] Exclude: **/.settings/** [INFO] Exclude: **/

Re: [jclouds-labs-openstack] Adds paging fail tests for Queues. (#96)

> + server.shutdown(); > + } > + } > + > + public void listPagedIterableCollectionQueuesFail() throws Exception { > + MockWebServer server = mockOpenStackServer(); > + server.enqueue(new MockResponse().setBody(accessRackspace)); > + server.enqueue(new MockResponse

Jenkins build became unstable: jclouds » jclouds compute core #2591

See

Re: [jclouds-site] JCLOUDS-147: First experiment with Javadoc iframe (#93)

[jclouds-site-pull-requests #298](https://jclouds.ci.cloudbees.com/job/jclouds-site-pull-requests/298/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/93#issuecomment-42492618

Re: [jclouds-labs-openstack] Adds paging fail tests for Queues. (#96)

> jclouds » jclouds-labs-openstack #1092 UNSTABLE I'm guessing this is the [expected test failure](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-openstack/org.apache.jclouds.labs$openstack-marconi/1092/testReport/junit/org.jclouds.openstack.marconi.v1.features/QueueApiMockTest/list

Re: [jclouds] Update ServiceType References (#356)

+1 --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/356#issuecomment-42704261

[jclouds-site] Align the Install button with the content below it (#97)

You can merge this Pull Request by running: git pull https://github.com/rackerlabs/jclouds-site install-button-wart Or you can view, comment on it, or merge it online at: https://github.com/jclouds/jclouds-site/pull/97 -- Commit Summary -- * Align the Install button with the content bel

Re: [jclouds-labs-openstack] Adds paging fail tests for Queues. (#96)

> @@ -178,6 +179,42 @@ public void listOnePageOfQueues() throws Exception { >} > } > > + public void listOnePageOfQueuesFail() throws Exception { > + MockWebServer server = mockOpenStackServer(); > + server.enqueue(new MockResponse().setBody(accessRackspace)); > + ser

Jenkins build is back to normal : jclouds » jclouds ElasticHosts BlueSquare London provider #2589

See

Jenkins build is back to normal : jclouds » jclouds cloudservers api #2589

See

Jenkins build is back to normal : jclouds » jclouds HP Cloud Compute provider #2589

See

Re: [jclouds] JCLOUDS-561: Properly populate the ssh agent connection in the builder methods (#358)

Pushed to [master](https://git-wip-us.apache.org/repos/asf?p=jclouds.git;a=commit;h=aef9fc8d8399483cca9a874bc60327c70cca74c4) and [1.7.x](https://git-wip-us.apache.org/repos/asf?p=jclouds.git;a=commit;h=9398373f94c1e31eb49ef056e07f877b85ce9854). --- Reply to this email directly or view it on Gi

Re: [jclouds-labs-aws] Created the skeleton of the Glacier API. (#3)

[jclouds » jclouds-labs-aws #827](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-aws/827/) SUCCESS This pull request looks good [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-la

Re: [jclouds-labs-openstack] Adds paging fail tests for Queues. (#96)

Yep. You can't have parameterized classes in the annotations, as the type of the generic parameter belongs to the instance of the object and not the definition of the class, which is what you need in the annotations. I don't like the idea of returning `null`, as the api will behave different th

Re: [jclouds-labs] JCLOUDS-544: Add missing ERROR value to teh Event.Status enum (#59)

[jclouds-labs-pull-requests #146](https://jclouds.ci.cloudbees.com/job/jclouds-labs-pull-requests/146/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/59#issuecomment-42785339

Re: [jclouds-labs] JCLOUDS-544: Add missing ERROR value to teh Event.Status enum (#59)

Just removed the unnecessary calls to `verify`. If someone changes the predicate in such a way, we can discuss the details and the proper tests in the review :) Let's keep this test just testing the expected functionality. --- Reply to this email directly or view it on GitHub: https://github.com

Re: [jclouds] Enforce that all commas have trailing whitespace (#359)

[jclouds-pull-requests #786](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/786/) FAILURE Looks like there's a problem with this pull request --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/359#issuecomment-42474836

Jenkins build is back to normal : jclouds » jclouds Rackspace Next Generation Cloud DNS UK provider #2589

See

[jira] [Commented] (JCLOUDS-147) Transfer jclouds API docs site and generation process to jclouds.apache.org

[ https://issues.apache.org/jira/browse/JCLOUDS-147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13992560#comment-13992560 ] Andrew Phillips commented on JCLOUDS-147: - >From [~everett-toews]: "Manually doin

Build failed in Jenkins: jclouds » jclouds-labs-aws #818

See Changes: [romancoedo] Created the skeleton of the Glacier API. -- [...truncated 962 lines...] Test suite progress: tests succeeded: 38, failed: 0, skipped: 0. Starting test

Jenkins build is back to normal : jclouds » jclouds skeletons project #2589

See

Re: [jclouds] Enforce that all commas have trailing whitespace (#359)

[jclouds » jclouds #1075](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1075/) SUCCESS This pull request looks good [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/359#issuecomme

Re: [jclouds-labs-aws] Created the skeleton of the Glacier API. (#3)

[jclouds-labs-aws-pull-requests #5](https://jclouds.ci.cloudbees.com/job/jclouds-labs-aws-pull-requests/5/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-aws/pull/3#issuecomment-42784023

Re: [jclouds-labs] JCLOUDS-544: Add missing ERROR value to teh Event.Status enum (#59)

Closed #59. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/59#event-118663905

Re: [jclouds-labs-openstack] Adds paging fail tests for Queues. (#96)

> @@ -114,7 +114,7 @@ > @GET > @ResponseParser(ParseQueues.class) > @Consumes(MediaType.APPLICATION_JSON) > - @Fallback(EmptyPaginatedCollectionOnNotFoundOr404.class) > + @Fallback(NullOnNotFoundOr404.class) > @Path("queues") > Queues list(ListQueuesOptions options); Should

Jenkins build is back to normal : jclouds » jclouds Rackspace Cloud Databases UK provider #2589

See

Re: [jclouds-labs-openstack] Add live test for signPutBlob. (#94)

> @@ -83,13 +94,29 @@ public void trySign() throws InterruptedException, > ExecutionException { > continue; > } > String containerName = Iterables.getLast(containers).getName(); > - PageSet blobs = > region.list(containerName); > - if (blobs.isEmpt

Re: [jclouds] openstack console (#339)

[jclouds-pull-requests #790](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/790/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/339#issuecomment-42589997

Jenkins build is back to normal : jclouds » jclouds GoGrid provider #2589

See

[jira] [Commented] (JCLOUDS-558) JSON parse error on createNodesInGroup

[ https://issues.apache.org/jira/browse/JCLOUDS-558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13993549#comment-13993549 ] Everett Toews commented on JCLOUDS-558: --- Filed a bug over in OpenStack Nova https:

Re: [jclouds-examples] Add example DeleteServer.java (#47)

FWIW I've just tested DeleteServer.java on my instance of GCE and it seems to have worked properly (my server instance disappeared). --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-examples/pull/47#issuecomment-42400086

Re: [jclouds] JCLOUDS-514: Add ability to attach block volumes at boot through the Nova ServerApi (#326)

I won't be able to review this as I'll be heading out the OpenStack Summit this weekend. Are you going to be there too @jasdeep-hundal? It'd be great to meet you! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/326#issuecomment-42717032

Jenkins build is back to normal : jclouds » jclouds Amazon Elastic Load Balancer provider #2589

See

Re: [jclouds-labs] JCLOUDS-544: Add missing ERROR value to teh Event.Status enum (#59)

[jclouds » jclouds-labs #1009](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs/1009/) SUCCESS This pull request looks good [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pul

Re: [jclouds-labs-google] [JCLOUDS-550] fix for obsolete machineTypes (#24)

[jclouds » jclouds-labs-google #873](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-google/873/) SUCCESS This pull request looks good [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclo

Re: [jclouds-labs-openstack] Adds paging fail tests for Queues. (#96)

[jclouds-labs-openstack-pull-requests #224](https://jclouds.ci.cloudbees.com/job/jclouds-labs-openstack-pull-requests/224/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/96#issuecomment-42700010

[jclouds-labs-aws] Created the skeleton of the Glacier API. (#3)

You can merge this Pull Request by running: git pull https://github.com/rcoedo/jclouds-labs-aws upstream Or you can view, comment on it, or merge it online at: https://github.com/jclouds/jclouds-labs-aws/pull/3 -- Commit Summary -- * Created the skeleton of the Glacier API. -- File Cha

Re: [jclouds-labs-openstack] Adds paging fail tests for Queues. (#96)

I tried switching the EmptyPaginatedCollectionOnNotFoundOr404 to generic but had issues using the class in the annotation then. The wildcard ? didn't seem to work as a fix. I haven't tried the evil fix yet, but would prefer to avoid it (for now). I will have another look at switching the fallbac

Re: [jclouds] JCLOUDS-505: Remove unused ObjectMD5 (#357)

> jclouds-pull-requests #783 FAILURE > jclouds-java-7-pull-requests #1253 FAILURE Some Jenkins "channel closed" error: ``` FATAL: channel is already closed hudson.remoting.ChannelClosedException: channel is already closed ``` Let's try that again... --- Reply to this email directly or view it on

Re: [jclouds-labs-openstack] Adds paging fail tests for Queues. (#96)

> EmptyPaginatedCollectionOnNotFoundOr404 returns PaginatedCollection > However Queues extends PaginatedCollection and not Object. Without having taking a long look at the code...should EPCONFO404 not be a generic class, i.e. `EmptyPaginatedCollectionOnNotFoundOr404 returns PaginatedCollection`?

Re: [jclouds] JCLOUDS-505: Remove unused ObjectMD5 (#321)

Thanks for checking, @jdaggett! Committed to [master](https://git-wip-us.apache.org/repos/asf?p=jclouds.git;a=commit;h=a45124c51a80e96f033059584dd4ef3763b56804) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/321#issuecomment-42400806

Re: [jclouds-labs-openstack] Adds paging fail tests for Queues. (#96)

I don't know how to fix this (without introducing a lot of code). The problem is that the fallback for Queues list(ListQueuesOptions options); is EmptyPaginatedCollectionOnNotFoundOr404 EmptyPaginatedCollectionOnNotFoundOr404 returns PaginatedCollection However Queues extends PaginatedCollection

Re: [jclouds-labs-google] [JCLOUDS-550] fix for obsolete machineTypes (#24)

[jclouds-labs-google-pull-requests #56](https://jclouds.ci.cloudbees.com/job/jclouds-labs-google-pull-requests/56/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-google/pull/24#issuecomment-42644423

Re: [jclouds-labs] JCLOUDS-544: Add missing ERROR value to teh Event.Status enum (#59)

[jclouds-labs-pull-requests #145](https://jclouds.ci.cloudbees.com/job/jclouds-labs-pull-requests/145/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/59#issuecomment-42435543

Jenkins build is back to normal : jclouds » jclouds ec2 api #2589

See

Re: [jclouds-labs-openstack] Update ServiceType References (#95)

Merged to master 02ab5a9 --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/95#issuecomment-42705688

Jenkins build is back to normal : jclouds » jclouds compute core #2589

See

Re: [jclouds-labs] JCLOUDS-544: Add missing ERROR value to teh Event.Status enum (#59)

> + > + public EventDonePredicate(DigitalOceanApi api) { > + this.api = checkNotNull(api, "api must not be null"); > + } > + > + @Override > + public boolean apply(Integer input) { > + Event event = api.getEventApi().get(input); > + switch (event.getStatu

Re: [jclouds] JCLOUDS-505: Remove unused ObjectMD5 (#357)

Closed #357. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/357#event-118904008

Re: [jclouds-labs-aws] Created the skeleton of the Glacier API. (#3)

> + } catch (IOException e) { > + throw new HttpException("Error signing request", e); > + } > + return hashedPayload; > + } > + > + private byte[] hmacSha256(byte[] key, String s) { > + try { > + Mac hmacSHA256 = crypto.hmacSHA256(key); > + return hm

Re: [jclouds] Enforce that all commas have trailing whitespace (#359)

Closed #359. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/359#event-119011447

Jenkins build is back to normal : jclouds » jclouds sqs api #2589

See

Jenkins build is back to normal : jclouds » jclouds Rackspace Cloud Load Balancers US provider #2589

See

Re: [jclouds-labs] JCLOUDS-544: Add missing ERROR value to teh Event.Status enum (#59)

> + * > + * @author Ignasi Barrera > + */ > +@Test(groups = "unit", testName = "EventDonePredicateTest") > +public class EventDonePredicateTest { > + > + public void testEventProgress() { > + EventApi eventApi = EasyMock.createMock(EventApi.class); > + DigitalOceanApi api = EasyMock.cr

Re: [jclouds] Enforce that all commas have trailing whitespace (#359)

Reopened #359. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/359#event-119003175

Re: [jclouds] Update ServiceType References (#356)

Merged to master 64ecd49 --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/356#issuecomment-42708055

Re: [jclouds-labs] JCLOUDS-544: Add missing ERROR value to teh Event.Status enum (#59)

> +public class EventDonePredicateTest { > + > + public void testEventProgress() { > + EventApi eventApi = EasyMock.createMock(EventApi.class); > + DigitalOceanApi api = EasyMock.createMock(DigitalOceanApi.class); > + > + expect(eventApi.get(1)).andReturn(event(Status.DONE)); > +

Jenkins build is back to stable : jclouds » jclouds-labs-openstack #1093

See

Jenkins build is back to normal : jclouds » jclouds rackspace clouddns api #2589

See

Jenkins build is back to normal : jclouds » jclouds script builder #2589

See

Re: [jclouds-labs-openstack] Adds paging fail tests for Queues. (#96)

> @@ -178,6 +179,42 @@ public void listOnePageOfQueues() throws Exception { >} > } > > + public void listOnePageOfQueuesFail() throws Exception { > + MockWebServer server = mockOpenStackServer(); > + server.enqueue(new MockResponse().setBody(accessRackspace)); > + ser

Jenkins build is back to normal : jclouds » allcompute #2589

See

Re: [jclouds-labs-aws] Created the skeleton of the Glacier API. (#3)

> +import java.io.IOException; > +import java.net.URL; > +import java.util.Properties; > +import java.util.Set; > + > +import org.jclouds.ContextBuilder; > +import org.jclouds.concurrent.config.ExecutorServiceModule; > +import org.testng.annotations.Test; > + > +import com.google.common.collect.Imm

Re: [jclouds] Enforce that all commas have trailing whitespace (#359)

Another timeout? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/359#issuecomment-42516260

Re: [jclouds] Enable whitespace around Checkstyle rule (#360)

Haven't checked in detail for functional changes, as I assume it's all whitespace-related fixes. If that is indeed the case, +1 - looks good to me. Many thanks, @andrewgaul! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/360#issuecomment-42621052

Re: [jclouds] Enable whitespace around Checkstyle rule (#360)

> @@ -241,7 +241,7 @@ public void > testExecHostnameConcurrentlyWithSameSessions() throws Exception { > @Override > public ExecResponse call() { >ExecResponse response = client.exec("hostname"); > - //System.out.println("complete

Re: [jclouds-site] JCLOUDS-147: First experiment with Javadoc iframe (#93)

> Shall I add a commit for that? Yes, please! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/93#issuecomment-42487283

Re: [jclouds] JCLOUDS-561: Properly populate the ssh agent connection in the builder methods (#358)

> @@ -107,7 +107,7 @@ public SSHClientConnection build() { > >protected Builder fromSSHClientConnection(SSHClientConnection in) { > return > hostAndPort(in.getHostAndPort()).connectTimeout(in.getConnectTimeout()).loginCredentials( > - in.getLoginCredentials());

Re: [jclouds-site] JCLOUDS-147: First experiment with Javadoc iframe (#93)

@everett-toews: Ping? Thoughts on this? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/93#issuecomment-42409793

Re: [jclouds-labs] JCLOUDS-544: Add missing ERROR value to teh Event.Status enum (#59)

Addressed the comments and added a unit test. Will amend the typo in the commit message when squashing the commits before merging. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/59#issuecomment-42521849

[jira] [Assigned] (JCLOUDS-558) JSON parse error on createNodesInGroup

[ https://issues.apache.org/jira/browse/JCLOUDS-558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Everett Toews reassigned JCLOUDS-558: - Assignee: Everett Toews > JSON parse error on createNodesInGroup > -

Re: [jclouds] JCLOUDS-561: Properly populate the ssh agent connection in the builder methods (#358)

Thanks, @nacx! Do we need any (unit) tests for this? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/358#issuecomment-42442684

Re: [jclouds] Enable whitespace around Checkstyle rule (#360)

Committed to master. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/360#issuecomment-42625731

Jenkins build is back to normal : jclouds » jclouds CloudSigma API #2589

See

Jenkins build is back to normal : jclouds » jclouds ElasticHosts Peer1 Toronto provider #2589

See

Jenkins build is back to normal : jclouds » jclouds enterprise Module #2589

See

Re: [jclouds] Enforce that all commas have trailing whitespace (#359)

Reopened #359. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/359#event-118921897

Re: [jclouds-labs-aws] Created the skeleton of the Glacier API. (#3)

It's good to see progress on this and that you're getting familiar with the jclouds internals. Don't get intimidated by the reviews! Nice job @rcoedo! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-aws/pull/3#issuecomment-42649933

Re: [jclouds-labs-openstack] Update ServiceType References (#95)

> Not related, and I will get them in another PR. OK, thanks! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/95#issuecomment-42400144

Jenkins build is back to normal : jclouds » jclouds loadbalancer core #2589

See