Re: [jclouds-labs-google] JCLOUDS-458: Addressing suggestions in PR-31 (#33)

2014-07-14 Thread BuildHive
[jclouds » jclouds-labs-google #1120](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-google/1120/) SUCCESS This pull request looks good [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub:

Re: [jclouds-labs-google] JCLOUDS-458: Addressing suggestions in PR-31 (#33)

2014-07-14 Thread CloudBees pull request builder plugin
[jclouds-labs-google-pull-requests #95](https://jclouds.ci.cloudbees.com/job/jclouds-labs-google-pull-requests/95/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-google/pull/33#issuecomment-48870538

Re: [jclouds] JCLOUDS-607: ComputeService.createNodesInGroup throws NPE on FloatingIPApi.create() (7641bd6)

2014-07-14 Thread Andrew Phillips
Also fixed all remaining checkstyle errors in the nova api. Thanks, @nacx! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/commit/7641bd61cd56f7f5a4da5ac89769c1d200abe79f#commitcomment-6993673

Jenkins build is back to stable : jclouds-1.7.x-branch » jclouds compute core #116

2014-07-14 Thread jenkins-no-reply
See https://jclouds.ci.cloudbees.com/job/jclouds-1.7.x-branch/org.apache.jclouds$jclouds-compute/116/

Jenkins build is back to normal : jclouds-1.7.x-branch » jclouds Open Hosting East1 provider #116

2014-07-14 Thread jenkins-no-reply
See https://jclouds.ci.cloudbees.com/job/jclouds-1.7.x-branch/org.apache.jclouds.provider$openhosting-east1/116/

[jira] [Created] (JCLOUDS-625) VolumeBuilder does not allow null id while VolumeImpl allows it to be nullable

2014-07-14 Thread Werner Buck (JIRA)
Werner Buck created JCLOUDS-625: --- Summary: VolumeBuilder does not allow null id while VolumeImpl allows it to be nullable Key: JCLOUDS-625 URL: https://issues.apache.org/jira/browse/JCLOUDS-625

[jclouds] JCLOUDS-625 - VolumeBuilder does not allow null id while VolumeImpl allows it to be nullable (#437)

2014-07-14 Thread Werner Buck
VolumeBuilder does not allow null id while VolumeImpl allows it to be nullable. You can merge this Pull Request by running: git pull https://github.com/wernerb/jclouds patch-1 Or you can view, comment on it, or merge it online at: https://github.com/jclouds/jclouds/pull/437 -- Commit

[jira] [Commented] (JCLOUDS-625) VolumeBuilder does not allow null id while VolumeImpl allows it to be nullable

2014-07-14 Thread Werner Buck (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14060539#comment-14060539 ] Werner Buck commented on JCLOUDS-625: - Pull request is at

[jira] [Created] (JCLOUDS-626) OutOfMemoryException with FileSystem provider, large content from non-repeatable input streams

2014-07-14 Thread Nikola Knezevic (JIRA)
Nikola Knezevic created JCLOUDS-626: --- Summary: OutOfMemoryException with FileSystem provider, large content from non-repeatable input streams Key: JCLOUDS-626 URL:

[jira] [Created] (JCLOUDS-627) Add support for aborting putBlob operations

2014-07-14 Thread Nikola Knezevic (JIRA)
Nikola Knezevic created JCLOUDS-627: --- Summary: Add support for aborting putBlob operations Key: JCLOUDS-627 URL: https://issues.apache.org/jira/browse/JCLOUDS-627 Project: jclouds Issue

Re: [jclouds] JCLOUDS-625 - VolumeBuilder does not allow null id while VolumeImpl allows it to be nullable (#437)

2014-07-14 Thread BuildHive
[jclouds » jclouds #1360](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1360/) SUCCESS This pull request looks good [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub:

Re: [jclouds] JCLOUDS-625 - VolumeBuilder does not allow null id while VolumeImpl allows it to be nullable (#437)

2014-07-14 Thread CloudBees pull request builder plugin
[jclouds-pull-requests #986](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/986/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/437#issuecomment-48892073

Re: [jclouds] JCLOUDS-625 - VolumeBuilder does not allow null id while VolumeImpl allows it to be nullable (#437)

2014-07-14 Thread CloudBees pull request builder plugin
[jclouds-java-7-pull-requests #1457](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1457/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/437#issuecomment-48892463

[jira] [Updated] (JCLOUDS-607) ComputeService.createNodesInGroup throws NPE on FloatingAPI.create()

2014-07-14 Thread Ignasi Barrera (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-607?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignasi Barrera updated JCLOUDS-607: --- Fix Version/s: 1.7.4 ComputeService.createNodesInGroup throws NPE on FloatingAPI.create()

[jira] [Resolved] (JCLOUDS-471) FloatingIPApi.create() does not work, pool needed

2014-07-14 Thread Ignasi Barrera (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignasi Barrera resolved JCLOUDS-471. Resolution: Fixed FloatingIPApi.create() does not work, pool needed

Re: [jclouds] Unasync OpenStack Nova and Extension APIs (#417)

2014-07-14 Thread BuildHive
[jclouds » jclouds #1361](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1361/) SUCCESS This pull request looks good [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub:

Re: [jclouds] Unasync OpenStack Nova and Extension APIs (#417)

2014-07-14 Thread CloudBees pull request builder plugin
[jclouds-pull-requests #987](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/987/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/417#issuecomment-48923967

Re: [jclouds] Unasync OpenStack Nova and Extension APIs (#417)

2014-07-14 Thread CloudBees pull request builder plugin
[jclouds-java-7-pull-requests #1458](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1458/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/417#issuecomment-48924571

Re: [jclouds-chef] JCLOUDS-624 - Fixed bug in ListNodes (#46)

2014-07-14 Thread Luciano Sabença
Closed #46. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-chef/pull/46#event-141318044

Re: [jclouds-chef] JCLOUDS-624 - Fixed bug in ListNodes (#46)

2014-07-14 Thread Luciano Sabença
Hi! I will close this PR and open a new one with this bug fixed. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-chef/pull/46#issuecomment-48927267

[jclouds-chef] JCLOUDS-624 - Fixed bug in ListNodes (#47)

2014-07-14 Thread Luciano Sabença
Details can be found at: https://issues.apache.org/jira/browse/JCLOUDS-624 Any suggestions are very welcome! To fix this bug, I used the approach debated in the above link: create new methods to do the operation using an ExecutorService provided by the user.The the old methods are still working,

Re: [jclouds-chef] JCLOUDS-624 - Fixed bug in ListNodes (#47)

2014-07-14 Thread CloudBees pull request builder plugin
[jclouds-chef-pull-requests #109](https://jclouds.ci.cloudbees.com/job/jclouds-chef-pull-requests/109/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-chef/pull/47#issuecomment-48930284

Re: [jclouds] Unasync OpenStack Nova and Extension APIs (#417)

2014-07-14 Thread Zack Shoylev
+1 --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/417#issuecomment-48939334

[jira] [Created] (JCLOUDS-628) PROPERTY_MAX_CONNECTIONS_PER_CONTEXT not honored for https connections

2014-07-14 Thread Shri Javadekar (JIRA)
Shri Javadekar created JCLOUDS-628: -- Summary: PROPERTY_MAX_CONNECTIONS_PER_CONTEXT not honored for https connections Key: JCLOUDS-628 URL: https://issues.apache.org/jira/browse/JCLOUDS-628 Project:

Re: [jclouds-labs-google] JCLOUDS-458: Addressing suggestions in PR-31 (#33)

2014-07-14 Thread Bhathiya
@demobox @nacx I made the suggested changes and would like to know your concenrns. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-google/pull/33#issuecomment-48964295

Re: [jclouds-labs-google] JCLOUDS-458: Addressing suggestions in PR-31 (#33)

2014-07-14 Thread Matt Stephenson
This is looking pretty good to me. I'd like to get a +1 from both @demobox and @nacx before we merge it in. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-google/pull/33#issuecomment-48968435

Re: [jclouds-labs-google] JCLOUDS-458: Addressing suggestions in PR-31 (#33)

2014-07-14 Thread Ignasi Barrera
+/** + * This will parse and set an appropriate exception on the command object. + */ +@Singleton +public class GoogleCloudStorageErrorHandler implements HttpErrorHandler { + public void handleError(HttpCommand command, HttpResponse response) { + // it is important to always read

Re: [jclouds-labs-google] JCLOUDS-458: Addressing suggestions in PR-31 (#33)

2014-07-14 Thread Ignasi Barrera
+Class? extends Exception expected) { + assertCodeMakes(method, uri, statusCode, message, application/json, content, expected); + } + + private void assertCodeMakes(String method, URI uri, int statusCode, String message, String contentType, +String

Re: [jclouds-labs-google] JCLOUDS-458: Addressing suggestions in PR-31 (#33)

2014-07-14 Thread Ignasi Barrera
+Class? extends Exception expected) { + assertCodeMakes(method, uri, statusCode, message, application/json, content, expected); + } + + private void assertCodeMakes(String method, URI uri, int statusCode, String message, String contentType, +String

Re: [jclouds] [JCLOUDS-263] Usage of internalURL services' endpoints (#142)

2014-07-14 Thread Jamal CHAQOURI
Hi, I'm using jclouds BlobStore API with Rackspace as provider. The InternalUrlModule is only available for keystone v2_0 not for v1_1. That differs from PublicURLOrInternalIfNull, which has two different classes. Is this done on purpose? or, can i do a PR to make InternalUrlModule available

Re: [jclouds] JCLOUDS-622: remove calls to InputSupplier methods (#436)

2014-07-14 Thread Shri Javadekar
I like the BlahAndClose methods. Makes code reading easier and using these methods is less error prone. I'm still a little fuzzy about about MultiPartForm gets used in the context of other blobstore operations. But the change itself seems to do what is says. Looks good! --- Reply to this