Re: [jclouds-labs-aws] JCLOUDS-457: BlobStore MultiPartUpload strategy (#40)

2014-07-18 Thread BuildHive
[jclouds » jclouds-labs-aws #1162](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-aws/1162/) SUCCESS This pull request looks good [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-

Re: [jclouds-labs-aws] JCLOUDS-457: BlobStore MultiPartUpload strategy (#40)

2014-07-18 Thread CloudBees pull request builder plugin
[jclouds-labs-aws-pull-requests #88](https://jclouds.ci.cloudbees.com/job/jclouds-labs-aws-pull-requests/88/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-aws/pull/40#issuecomment-49501647

Re: [jclouds-labs-aws] JCLOUDS-457: BlobStore MultiPartUpload strategy (#40)

2014-07-18 Thread Roman Coedo
> + private volatile int part; > + > + @Inject > + public BaseSlicingStrategy(PayloadSlicer slicer) { > + this.slicer = checkNotNull(slicer, "slicer"); > + this.total = 0; > + this.copied = 0; > + this.partSizeInMB = 0; > + this.part = 0; > + } > + > + //TODO: Inj

Re: [jclouds] JCLOUDS-622: Remove last vestiges of InputSupplier (#438)

2014-07-18 Thread CloudBees pull request builder plugin
[jclouds-java-7-pull-requests #1480](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1480/) UNSTABLE Looks like there's a problem with this pull request --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/438#issuecomment-49500652

Re: [jclouds] JCLOUDS-622: Remove last vestiges of InputSupplier (#438)

2014-07-18 Thread CloudBees pull request builder plugin
[jclouds-pull-requests #1009](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/1009/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/438#issuecomment-49500572

Re: [jclouds] JCLOUDS-622: Remove last vestiges of InputSupplier (#438)

2014-07-18 Thread BuildHive
[jclouds » jclouds #1390](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1390/) SUCCESS This pull request looks good [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/438#issuecomme

Re: [jclouds] [JCLOUDS-474] refactor SoftLayer support (#431)

2014-07-18 Thread Andrea Turli
Hi @andrewgaul I'm not able to do that just now as I don't have access to my laptop for next 2 weeks. Sorry about that. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/431#issuecomment-49499874

Re: [jclouds] JCLOUDS-622: Remove last vestiges of InputSupplier (#438)

2014-07-18 Thread Andrew Gaul
> @@ -20,9 +20,7 @@ > import java.io.InputStream; > import java.io.IOException; > > -import com.google.common.io.InputSupplier; > - > -public interface Payload extends InputSupplier, Closeable { > +public interface Payload extends Closeable { > By that, do you mean merging it to master once th

Re: [jclouds] JCLOUDS-622: Remove last vestiges of InputSupplier (#438)

2014-07-18 Thread Andrew Gaul
@aledsage wrote: > Is deleting Strings2.toString(InputSupplier) rather than deprecating it too > aggressive for 1.8? Agreed and I added back this method in 0df905a870563236bb095772ae00a1975ec3aece. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/438

[jira] [Resolved] (JCLOUDS-622) Guava 18 compatibility

2014-07-18 Thread Andrew Gaul (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Gaul resolved JCLOUDS-622. - Resolution: Fixed Fix Version/s: 1.8.0 > Guava 18 compatibility > --

[jira] [Comment Edited] (JCLOUDS-622) Guava 18 compatibility

2014-07-18 Thread Andrew Gaul (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14067381#comment-14067381 ] Andrew Gaul edited comment on JCLOUDS-622 at 7/19/14 4:49 AM: -

[jira] [Commented] (JCLOUDS-622) Guava 18 compatibility

2014-07-18 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14067383#comment-14067383 ] ASF subversion and git services commented on JCLOUDS-622: - Commit

[jira] [Commented] (JCLOUDS-622) Guava 18 compatibility

2014-07-18 Thread Andrew Gaul (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14067381#comment-14067381 ] Andrew Gaul commented on JCLOUDS-622: - @aled.sage Thanks for pointing this out; we di

Re: [jclouds-labs] Fix DockerErrorHandler’s use of Strings2.toString (#69)

2014-07-18 Thread Andrew Gaul
For example, many users call one of the following: ``` newPayload(ByteStreams.toByteArray(new FileInputStream(File))) newPayload(new FileInputStream(File)) ``` The former leaks a file descriptor and consumes extra memory while the latter disables repeatable payloads. Instead users should call t

Re: [jclouds-labs] Fix DockerErrorHandler’s use of Strings2.toString (#69)

2014-07-18 Thread Andrew Gaul
@aledsage wrote: > I also cleaned up some other deprecated code that seemed like quick wins. The > replacement for new StringPayload(value) is quite long winded (particularly > when you want to specify the charset)! > > Payloads.newByteSourcePayload(ByteSource.wrap(value.getBytes(Charset.forName

Re: [jclouds] Allow Javadoc to reference imports (#446)

2014-07-18 Thread CloudBees pull request builder plugin
[jclouds-java-7-pull-requests #1479](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1479/) FAILURE Looks like there's a problem with this pull request --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/446#issuecomment-49499345

Re: [jclouds] Allow Javadoc to reference imports (#446)

2014-07-18 Thread BuildHive
[jclouds » jclouds #1389](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1389/) ABORTED [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/446#issuecomment-49496917

[jira] [Commented] (JCLOUDS-631) Slowdown of putBlob operation for the FileSystem provider

2014-07-18 Thread Andrew Gaul (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14067310#comment-14067310 ] Andrew Gaul commented on JCLOUDS-631: - [~knl] Can you share some more quantitative me

[jira] [Comment Edited] (JCLOUDS-631) Slowdown of putBlob operation for the FileSystem provider

2014-07-18 Thread Andrew Gaul (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14067310#comment-14067310 ] Andrew Gaul edited comment on JCLOUDS-631 at 7/19/14 1:04 AM: -

Re: [jclouds] Allow Javadoc to reference imports (#446)

2014-07-18 Thread CloudBees pull request builder plugin
[jclouds-pull-requests #1008](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/1008/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/446#issuecomment-49494835

Re: [jclouds-labs-aws] JCLOUDS-457: BlobStore MultiPartUpload strategy (#40)

2014-07-18 Thread Roman Coedo
> +import org.jclouds.glacier.blobstore.strategy.PayloadSlice; > +import org.jclouds.glacier.util.ContentRange; > +import org.jclouds.io.internal.BasePayloadSlicer; > +import org.testng.annotations.Test; > + > +@Test(groups = {"unit"}) > +public class BaseSlicingStrategyTest { > + @Test > + pub

Re: [jclouds-labs-aws] JCLOUDS-457: BlobStore MultiPartUpload strategy (#40)

2014-07-18 Thread Andrew Gaul
> + private final SlicingStrategy slicer; > + > + @Inject > + public SequentialMultipartUploadStrategy(GlacierClient client, > SlicingStrategy slicer) { > + this.client = checkNotNull(client, "client"); > + this.slicer = checkNotNull(slicer, "slicer"); > + } > + > + @Override >

Re: [jclouds-labs-aws] JCLOUDS-457: BlobStore MultiPartUpload strategy (#40)

2014-07-18 Thread Andrew Gaul
Overall looks good although I am concerned about excessive number of parts with smaller blobs. This really is not a unique problem to glacier and perhaps something we should look at with a more general MPU strategy. --- Reply to this email directly or view it on GitHub: https://github.com/jclou

Re: [jclouds-labs-aws] JCLOUDS-457: BlobStore MultiPartUpload strategy (#40)

2014-07-18 Thread Andrew Gaul
> + return total - copied; > + } > + > + @Override > + public void startSlicing(Payload payload) { > + this.payload = checkNotNull(payload, "payload"); > + this.copied = 0; > + this.total = > checkNotNull(payload.getContentMetadata().getContentLength(), > "contentLength"

Re: [jclouds-labs-aws] JCLOUDS-457: BlobStore MultiPartUpload strategy (#40)

2014-07-18 Thread Andrew Gaul
> + private volatile int part; > + > + @Inject > + public BaseSlicingStrategy(PayloadSlicer slicer) { > + this.slicer = checkNotNull(slicer, "slicer"); > + this.total = 0; > + this.copied = 0; > + this.partSizeInMB = 0; > + this.part = 0; > + } > + > + //TODO: Inj

Re: [jclouds-labs-aws] JCLOUDS-457: BlobStore MultiPartUpload strategy (#40)

2014-07-18 Thread CloudBees pull request builder plugin
[jclouds-labs-aws-pull-requests #87](https://jclouds.ci.cloudbees.com/job/jclouds-labs-aws-pull-requests/87/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-aws/pull/40#issuecomment-49493716

Re: [jclouds-labs-aws] JCLOUDS-457: BlobStore MultiPartUpload strategy (#40)

2014-07-18 Thread BuildHive
[jclouds » jclouds-labs-aws #1159](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-aws/1159/) SUCCESS This pull request looks good [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-

Re: [jclouds-labs-aws] JCLOUDS-457: BlobStore MultiPartUpload strategy (#40)

2014-07-18 Thread Andrew Gaul
> +import org.jclouds.glacier.blobstore.strategy.PayloadSlice; > +import org.jclouds.glacier.util.ContentRange; > +import org.jclouds.io.internal.BasePayloadSlicer; > +import org.testng.annotations.Test; > + > +@Test(groups = {"unit"}) > +public class BaseSlicingStrategyTest { > + @Test > + pub

Re: [jclouds-labs-aws] JCLOUDS-457: BlobStore MultiPartUpload strategy (#40)

2014-07-18 Thread Andrew Gaul
> +package org.jclouds.glacier.blobstore.strategy; > + > +import static com.google.common.base.Preconditions.checkNotNull; > + > +import org.jclouds.glacier.util.ContentRange; > +import org.jclouds.io.Payload; > + > +public class PayloadSlice { > + private final Payload payload; > + private fin

[jclouds-labs-aws] JCLOUDS-457: BlobStore MultiPartUpload strategy (#40)

2014-07-18 Thread Roman Coedo
The code related to the MultiPartUpload strategy has been added. MultiPart uploads use an upload strategy (e.g. sequential vs parallel) and also a slicing strategy to split the payload in different parts. You can merge this Pull Request by running: git pull https://github.com/rcoedo/jclouds-labs

[jira] [Commented] (JCLOUDS-334) createContainerInLocation returns true even if container exists

2014-07-18 Thread Andrew Gaul (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14067251#comment-14067251 ] Andrew Gaul commented on JCLOUDS-334: - This yields a confusing error when creating a

Jenkins build is back to normal : jclouds-labs-aws » jcloud elb api #142

2014-07-18 Thread jenkins-no-reply
See

Jenkins build is back to normal : jclouds-labs-aws #142

2014-07-18 Thread jenkins-no-reply
See

Jenkins build is back to normal : jclouds-labs-aws #142

2014-07-18 Thread jenkins-no-reply
See

Re: [jclouds] Close streams in integration tests (#445)

2014-07-18 Thread BuildHive
[jclouds » jclouds #1388](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1388/) SUCCESS This pull request looks good [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/445#issuecomme

Re: [jclouds-labs-aws] JCLOUDS-457: Fix complete MPU archive size (#39)

2014-07-18 Thread Andrew Gaul
Closed #39. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-aws/pull/39#event-143314245

Re: [jclouds-labs-aws] JCLOUDS-457: Fix complete MPU archive size (#39)

2014-07-18 Thread CloudBees pull request builder plugin
[jclouds-labs-aws-pull-requests #86](https://jclouds.ci.cloudbees.com/job/jclouds-labs-aws-pull-requests/86/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-aws/pull/39#issuecomment-49492777

Re: [jclouds-labs-aws] JCLOUDS-457: Fix complete MPU archive size (#39)

2014-07-18 Thread BuildHive
[jclouds » jclouds-labs-aws #1156](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-aws/1156/) SUCCESS This pull request looks good [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-

[jira] [Commented] (JCLOUDS-457) Amazon Glacier support

2014-07-18 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14067233#comment-14067233 ] ASF subversion and git services commented on JCLOUDS-457: - Commit

Re: [jclouds-labs-aws] JCLOUDS-457: Fix complete MPU archive size (#39)

2014-07-18 Thread Andrew Gaul
Pushed to master as f7d2319ce04950ed989d2751407173c0f58af645. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-aws/pull/39#issuecomment-49492705

Re: [jclouds-labs-aws] JCLOUDS-457: Fix complete MPU archive size (#39)

2014-07-18 Thread Andrew Gaul
:+1: should use natural units instead of scaled ones. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-aws/pull/39#issuecomment-49492518

[jclouds] Allow Javadoc to reference imports (#446)

2014-07-18 Thread Andrew Gaul
These style errors continue to creep in due to IDE misconfiguration so we might as well stop checking for it. You can merge this Pull Request by running: git pull https://github.com/andrewgaul/jclouds unused-imports-javadoc Or you can view, comment on it, or merge it online at: https://githu

[jclouds-labs-aws] JCLOUDS-457: Fix complete MPU archive size (#39)

2014-07-18 Thread Roman Coedo
The completeMultipartUpload operation is taking the archive size parameter in MB but it should be bytes. You can merge this Pull Request by running: git pull https://github.com/rcoedo/jclouds-labs-aws archivesizefix Or you can view, comment on it, or merge it online at: https://github.com/jc

Re: [jclouds] Close streams in integration tests (#445)

2014-07-18 Thread CloudBees pull request builder plugin
[jclouds-java-7-pull-requests #1478](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1478/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/445#issuecomment-49492181

Re: [jclouds] [JCLOUDS-474] refactor SoftLayer support (#431)

2014-07-18 Thread Andrew Gaul
@andreaturli Can you address the 70 or so Checkstyle violations that this pull request introduced? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/431#issuecomment-49492141

Re: [jclouds] Close streams in integration tests (#445)

2014-07-18 Thread Andrew Gaul
Did you run `mvn install -pl blobstore` first? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/445#issuecomment-49491954

Re: [jclouds] Close streams in integration tests (#445)

2014-07-18 Thread CloudBees pull request builder plugin
[jclouds-pull-requests #1007](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/1007/) UNSTABLE Looks like there's a problem with this pull request --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/445#issuecomment-49491835

Re: [jclouds] Close streams in integration tests (#445)

2014-07-18 Thread Andrew Phillips
Java 7 - unit tests pass, integration tests fail: ``` ..\jclouds> git branch * fd-leak master ..\jclouds> mvn -v Apache Maven 3.2.1 (ea8b2b07643dbb1b84b6d16e1f08391b666bc1e9; 2014-02-14T18:37:52+01:00) Maven home: C:\Program Files (x86)\Apache\maven-3.2.1\bin\.. Java version: 1.7.0_40, vendor:

Re: [jclouds] Enable more filesystem integration tests (#444)

2014-07-18 Thread CloudBees pull request builder plugin
[jclouds-java-7-pull-requests #1477](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1477/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/444#issuecomment-49491382

Re: [jclouds] Close streams in integration tests (#445)

2014-07-18 Thread Andrew Gaul
I expect that if `mvn integration-test -pl :filesystem -Plive` failed intermittently before, it will always succeed afterwards. Java version should not matter although the previous success and failure probability relies on the whim of the garbage collector. --- Reply to this email directly or

Re: [jclouds] Enable more filesystem integration tests (#444)

2014-07-18 Thread CloudBees pull request builder plugin
[jclouds-pull-requests #1006](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/1006/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/444#issuecomment-49490822

Re: [jclouds] Close streams in integration tests (#445)

2014-07-18 Thread Andrew Phillips
+1 - changes look fine to me. What would we expect as the result of `mvn clean integration-test` for this? Any differences between Java 6 and Java 7? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/445#issuecomment-49490784

Jenkins build is back to stable : jclouds » jclouds #1387

2014-07-18 Thread BuildHive
See

Re: [jclouds] Enable more filesystem integration tests (#444)

2014-07-18 Thread Andrew Phillips
> Your failures have nothing to do with this pull request I will address them > in another commit and > rebase this one. OK, great, thanks! And thanks to KK too, I guess ;-) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/444#issuecomment-49489936

Re: [jclouds] Close streams in integration tests (#445)

2014-07-18 Thread Andrew Gaul
> @@ -516,14 +516,7 @@ public void run() { > public static String getContentAsStringOrNullAndClose(Blob blob) throws > IOException { >checkNotNull(blob, "blob"); >checkNotNull(blob.getPayload(), "blob.payload"); > - if (blob.getPayload().getInput() == null) I am not famil

Re: [jclouds] Close streams in integration tests (#445)

2014-07-18 Thread Andrew Gaul
@demobox @zack-shoylev Please test this on Windows since it should address test failures you previously experienced. Relates to discussion in #444. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/445#issuecomment-49487462

[jclouds] Close streams in integration tests (#445)

2014-07-18 Thread Andrew Gaul
Also remove bogus delete workaround. Previously unclosed FileInputStream caused test failures on Windows which cannot delete open files. Found with Kohsuke's file-leak-detector. You can merge this Pull Request by running: git pull https://github.com/andrewgaul/jclouds fd-leak Or you can view,

Re: [jclouds] Enable more filesystem integration tests (#444)

2014-07-18 Thread Andrew Gaul
I found multiple fd leaks due to poor `Payload` management via Kohsuke's file-leak-detector. Your failures have nothing to do with this pull request I will address them in another commit and rebase this one. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclou

Re: [jclouds] Enable more filesystem integration tests (#444)

2014-07-18 Thread Andrew Gaul
@demobox Are these new failures or did they exist before my changes? Sleeping in `org.jclouds.filesystem.util.Utils.deleteRecursively` is obviously incorrect and looks like it is trying to let the garbage collector close an open `FileInputStream`. --- Reply to this email directly or view it on

Re: [jclouds] Enable more filesystem integration tests (#444)

2014-07-18 Thread Andrew Gaul
> @@ -58,23 +58,21 @@ protected void validateMetadata(BlobMetadata metadata) > throws IOException { >// TODO: not yet implemented > } > > + // TODO: requires Java 7 xattr support Done. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/

Re: [jclouds] Enable more filesystem integration tests (#444)

2014-07-18 Thread Andrew Gaul
>try { > File containerFile = openFolder(container); > File[] children = containerFile.listFiles(); > if (null != children) { > for (File child : children) > - Utils.deleteRecursively(child); > + if (options.isRecursive(

Re: [jclouds-examples] Fix build (#55)

2014-07-18 Thread Ignasi Barrera
> @@ -21,8 +21,8 @@ >4.0.0 > > org.apache.jclouds > -jclouds-project > -1.7.3-SNAPSHOT > +jclouds > +1.7.3 The jclouds parent is intended for the jclouds projects (the ones that are part of jclouds), and the examples in this repo are not that case. They are just like

Re: [jclouds-examples] Fix build (#55)

2014-07-18 Thread Ignasi Barrera
> @@ -318,7 +318,7 @@ private static ChefService initChefService(final String > client, final String val > > System.out.printf(">> initializing %s%n", > builder.getApiMetadata()); > > -ChefContext context = builder.build(); > +ChefContext context = (ChefCo

[jira] [Commented] (JCLOUDS-557) jclouds fails on CloudStack 4.3 - listProjects with domainid fails

2014-07-18 Thread Aled Sage (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14066789#comment-14066789 ] Aled Sage commented on JCLOUDS-557: --- https://issues.apache.org/jira/browse/CLOUDSTACK-6

Re: [jclouds-examples] Fix build (#55)

2014-07-18 Thread Andrew Phillips
> @@ -21,8 +21,8 @@ >4.0.0 > > org.apache.jclouds > -jclouds-project > -1.7.3-SNAPSHOT > +jclouds > +1.7.3 > Should I change jclouds.version to 1.7.3 as well? I would think so, but we should probably check with @nacx and/or @everett-toews... --- Reply to this email

Re: [jclouds-examples] Fix build (#55)

2014-07-18 Thread Sergey Kraŭčenia
> @@ -21,8 +21,8 @@ >4.0.0 > > org.apache.jclouds > -jclouds-project > -1.7.3-SNAPSHOT > +jclouds > +1.7.3 Should I also change to 1.7.3 as well? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-examples/pull/55/files#r1512542

Re: [jclouds-examples] Fix build (#55)

2014-07-18 Thread Sergey Kraŭčenia
> @@ -21,8 +21,8 @@ >4.0.0 > > org.apache.jclouds > -jclouds-project > -1.7.3-SNAPSHOT > +jclouds > +1.7.3 Yes, it worked --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-examples/pull/55/files#r15125271

Re: [jclouds-examples] Fix build (#55)

2014-07-18 Thread Andrew Phillips
> @@ -21,8 +21,8 @@ >4.0.0 > > org.apache.jclouds > -jclouds-project > -1.7.3-SNAPSHOT > +jclouds > +1.7.3 Could you try with `1.7.3` instead of `1.7.3-SNAPSHOT` --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-examples/pull/55

Re: [jclouds-examples] Fix build (#55)

2014-07-18 Thread Sergey Kraŭčenia
> @@ -318,7 +318,7 @@ private static ChefService initChefService(final String > client, final String val > > System.out.printf(">> initializing %s%n", > builder.getApiMetadata()); > > -ChefContext context = builder.build(); > +ChefContext context = (ChefCo

Re: [jclouds-examples] Fix build (#55)

2014-07-18 Thread Sergey Kraŭčenia
> @@ -21,8 +21,8 @@ >4.0.0 > > org.apache.jclouds > -jclouds-project > -1.7.3-SNAPSHOT > +jclouds > +1.7.3 I tried build it but it failed with the following error ``` ❯ mvn clean package

Re: [jclouds-site] Updated Cloudsoft entry (#112)

2014-07-18 Thread Andrew Phillips
> Merged and deployed. Thanks, @everett-toews! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/112#issuecomment-49460774

Re: [jclouds-examples] Fix build (#55)

2014-07-18 Thread Andrew Phillips
> @@ -318,7 +318,7 @@ private static ChefService initChefService(final String > client, final String val > > System.out.printf(">> initializing %s%n", > builder.getApiMetadata()); > > -ChefContext context = builder.build(); > +ChefContext context = (ChefCo

Re: [jclouds-examples] Fix build (#55)

2014-07-18 Thread Andrew Phillips
> @@ -21,8 +21,8 @@ >4.0.0 > > org.apache.jclouds > -jclouds-project > -1.7.3-SNAPSHOT > +jclouds > +1.7.3 Why is this needed? Is it not possible to inherit from `jclouds-project` 1.7.3? What's the error? --- Reply to this email directly or view it on GitHub: https:/

[jclouds-examples] Fix build (#55)

2014-07-18 Thread Sergey Kraŭčenia
Fix compilation error and project parent pom properties You can merge this Pull Request by running: git pull https://github.com/skrauchenia/jclouds-examples fix-build Or you can view, comment on it, or merge it online at: https://github.com/jclouds/jclouds-examples/pull/55 -- Commit Summary

Re: [jclouds-site] Fix typo in ServerLove provider name. (#113)

2014-07-18 Thread Everett Toews
A highly appropriate fix! :) Merged and deployed. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/113#issuecomment-49457867

Re: [jclouds-site] Fix typo in ServerLove provider name. (#113)

2014-07-18 Thread Everett Toews
Closed #113. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/113#event-143190241

Re: [jclouds-labs-openstack] Neutron Refactoring (#111)

2014-07-18 Thread Everett Toews
@zack-shoylev @jdaggett @ccustine I started a new wiki page [OpenStack Testing](https://wiki.apache.org/jclouds/Testing%20OpenStack) to capture the how-to info you provided Zack. Let's continue to expand on it. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jc

Re: [jclouds-site] Updated Cloudsoft entry (#112)

2014-07-18 Thread Everett Toews
Merged and deployed. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/112#issuecomment-49455344

Build failed in Jenkins: jclouds-labs-aws #141

2014-07-18 Thread jenkins-no-reply
See -- [...truncated 2445 lines...] [WARNING] :36: warning - Tag @link: reference n

Build failed in Jenkins: jclouds-labs-aws #141

2014-07-18 Thread jenkins-no-reply
See -- [...truncated 2446 lines...] [WARNING] :31: warning - Tag @link: reference n

Build failed in Jenkins: jclouds-labs-aws » jcloud elb api #141

2014-07-18 Thread jenkins-no-reply
See -- [INFO] [INFO] [

Jenkins build is back to normal : jclouds » jclouds Azure Components Core #2686

2014-07-18 Thread jenkins-no-reply
See

Jenkins build is back to normal : jclouds #2686

2014-07-18 Thread jenkins-no-reply
See

Re: [jclouds] JCLOUDS-622: Remove last vestiges of InputSupplier (#438)

2014-07-18 Thread Andrew Phillips
> @@ -20,9 +20,7 @@ > import java.io.InputStream; > import java.io.IOException; > > -import com.google.common.io.InputSupplier; > - > -public interface Payload extends InputSupplier, Closeable { > +public interface Payload extends Closeable { > I resubmitted this pull request and we can merge

Re: [jclouds] Enable more filesystem integration tests (#444)

2014-07-18 Thread Andrew Phillips
Here's Java 6. Again, unit tests pass but integration tests fail: ``` ...jclouds\apis\filesystem> mvn -v Apache Maven 3.2.1 (ea8b2b07643dbb1b84b6d16e1f08391b666bc1e9; 2014-02-14T18:37:52+01:00) Maven home: C:\Program Files (x86)\Apache\maven-3.2.1\bin\.. Java version: 1.6.0_20, vendor: Sun Microsy

Re: [jclouds] Enable more filesystem integration tests (#444)

2014-07-18 Thread Andrew Phillips
Here's the output on Java 7: ``` > mvn -v Apache Maven 3.2.1 (ea8b2b07643dbb1b84b6d16e1f08391b666bc1e9; 2014-02-14T18:37:5 2+01:00) Maven home: C:\Program Files (x86)\Apache\maven-3.2.1\bin\.. Java version: 1.7.0_40, vendor: Oracle Corporation Java home: C:\Program Files\Java\jdk1.7.0_40\jre Defaul

Re: [jclouds] [JCLOUDS-474] refactor SoftLayer support (#431)

2014-07-18 Thread Andrew Phillips
I can't get hold of the logs of the PR builds for this any more, but it looks like SoftLayer now has [quite a few Checkstyle violations](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/lastBuild/org.apache.jclouds.provider$softlayer/violations/). Could someone kindly have a look at th

Re: [jclouds-site] Fix typo in ServerLove provider name. (#113)

2014-07-18 Thread Andrew Phillips
+1 - looks good to me. Thanks, @alanmimms! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/113#issuecomment-49449031

[jclouds-site] Fix typo in ServerLove provider name. (#113)

2014-07-18 Thread Alan Mimms
You can merge this Pull Request by running: git pull https://github.com/alanmimms/jclouds-site patch-1 Or you can view, comment on it, or merge it online at: https://github.com/jclouds/jclouds-site/pull/113 -- Commit Summary -- * Fix typo in ServerLove provider name. -- File Changes --

Re: [jclouds-site] Fix typo in ServerLove provider name. (#113)

2014-07-18 Thread CloudBees pull request builder plugin
[jclouds-site-pull-requests #357](https://jclouds.ci.cloudbees.com/job/jclouds-site-pull-requests/357/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/113#issuecomment-49447582

Re: [jclouds-chef] JCLOUDS-624 - Fixed bug in ListNodes (#47)

2014-07-18 Thread Andrew Phillips
> WDYT? The suggestion looks good to me (unsurprisingly ;-)), but if we feel it's too much work at this late stage for something that won't be around for that long anyway, I'd also be OK with dropping the Options object and simply having an ExecutorService argument at the end of the overloaded

Re: [jclouds] Enable more filesystem integration tests (#444)

2014-07-18 Thread Andrew Phillips
+1 - looks good to me. But will try to test first, too. Thanks, @andrewgaul! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/444#issuecomment-49446770

Re: [jclouds] Enable more filesystem integration tests (#444)

2014-07-18 Thread Andrew Phillips
> @@ -58,23 +58,21 @@ protected void validateMetadata(BlobMetadata metadata) > throws IOException { >// TODO: not yet implemented > } > > + // TODO: requires Java 7 xattr support [minor] Add the message into the SkipException? --- Reply to this email directly or view it on GitHub

Re: [jclouds] Enable more filesystem integration tests (#444)

2014-07-18 Thread Andrew Phillips
>try { > File containerFile = openFolder(container); > File[] children = containerFile.listFiles(); > if (null != children) { > for (File child : children) > - Utils.deleteRecursively(child); > + if (options.isRecursive(

Re: [jclouds] JCLOUDS-549: Fix NPE in LoginCredentials.toString (#374)

2014-07-18 Thread Andrew Phillips
> jclouds » jclouds #1386 UNSTABLE Unrelated [test failure](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/org.apache.jclouds$jclouds-compute/1386/testReport/junit/org.jclouds.compute.callables/BlockUntilInitScriptStatusIsZeroThenReturnOutputTest/testloopUntilTrueOrThrowCancellationExcep

Re: [jclouds] JCLOUDS-549: Fix NPE in LoginCredentials.toString (#374)

2014-07-18 Thread Andrew Phillips
Thanks for the update, @aledsage and the review, @nacx! Just catching up here - I'm on vacations so a little slow responding to pings ;-) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/374#issuecomment-49446279

Re: [jclouds] JCLOUDS-549: Fix NPE in LoginCredentials.toString (#374)

2014-07-18 Thread Andrew Phillips
> @@ -79,8 +78,6 @@ public Builder noPassword() { > >public Builder privateKey(String privateKey) { > this.privateKey = Optional.fromNullable(privateKey); > - if (password == null) > -noPassword(); If I understand correctly, this and the above are no longer

Re: [jclouds-chef] JCLOUDS-624 - Fixed bug in ListNodes (#47)

2014-07-18 Thread Ignasi Barrera
After the recent discussion, I think we could add some final changes to leave things consistent and easier to use for end users: * Previous versions of jclouds used the internal jclouds executor and fetched the nodes concurrently by default. * With this change nodes will be by default obtained i

Re: [jclouds-chef] JCLOUDS-624 - Fixed bug in ListNodes (#47)

2014-07-18 Thread Ignasi Barrera
> * @return The details of all existing nodes. > */ > Iterable listNodes(); > > /** > +* Lists the details of all existing nodes, executing concurrently using > the executorService. > +* > +* @return The details of all existing nodes. > +*/ > + Iterable listNo

Re: [jclouds-labs] Fix DockerErrorHandler’s use of Strings2.toString (#69)

2014-07-18 Thread Andrew Phillips
Thanks for the cleanup, @aledsage! +1 - looks good to me, too! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/69#issuecomment-49444198

  1   2   >