I've thought about this a bit more this weekend, and I think it should be
better to just address the renaming of the *Concurrently methods now. We're
about to release 1.8.0, and it would be ideal if jclouds-chef could be merged
into the main repo for the release.
With the renaming change, the
@@ -79,8 +78,6 @@ public Builder noPassword() {
public Builder privateKey(String privateKey) {
this.privateKey = Optional.fromNullable(privateKey);
- if (password == null)
-noPassword();
Correct. And nothing can subsequently set the private field to
@demobox @mattstep I have few PRs that depends on this. Can we proceed to
merge this ?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/33#issuecomment-49624505
Closed #390.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/390#event-143775282
Reopened #390.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/390#event-143775289
Closed #442.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/442#event-143779308
Reopened #442.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/442#event-143779345
See https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1398/changes
[jclouds » jclouds
#1398](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1398/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
Yes, let me try to get to that today. Last chance @demobox
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/33#issuecomment-49639051
[jclouds-pull-requests
#1012](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/1012/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/390#issuecomment-49640174
[
https://issues.apache.org/jira/browse/JCLOUDS-554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14068892#comment-14068892
]
ASF subversion and git services commented on JCLOUDS-554:
-
Commit
[jclouds-pull-requests
#1013](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/1013/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/442#issuecomment-49640609
Merged to master `0d77d8c`
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/390#issuecomment-49641024
Closed #390.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/390#event-143807428
[
https://issues.apache.org/jira/browse/JCLOUDS-628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14064033#comment-14064033
]
Shri Javadekar edited comment on JCLOUDS-628 at 7/21/14 5:56 PM:
[
https://issues.apache.org/jira/browse/JCLOUDS-554?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jeremy Daggett resolved JCLOUDS-554.
Resolution: Fixed
Fix Version/s: 1.8.0
openstack-nova defaults to API v1.1
Closed #442.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/442#event-143811394
Reopened #442.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/442#event-143812329
Closed #442.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/442#event-143814314
[jclouds-pull-requests
#1014](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/1014/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/442#issuecomment-49650562
See
https://jclouds.ci.cloudbees.com/job/jclouds/org.apache.jclouds.driver$jclouds-apachehc/2692/
--
[INFO]
[INFO]
See https://jclouds.ci.cloudbees.com/job/jclouds/2692/changes
Changes:
[jdaggett] JCLOUDS-554: Update Nova default API to v2
--
[...truncated 29205 lines...]
[JENKINS] Archiving
https://jclouds.ci.cloudbees.com/job/jclouds/ws/providers/gogrid/pom.xml to
[jclouds-java-7-pull-requests
#1486](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1486/)
SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/442#issuecomment-49652540
@demobox, @nacx, very nice discussion :-)!
WDYT?
I agree with the solution! It seems very good to me!
About the simpler solution to release 1.8.0, I think that is a good way to
address it. It is important release version 1.8.0 with this bug fixed, because
this one invalidates important
[jclouds » jclouds
#1399](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1399/) ABORTED
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/442#issuecomment-49655079
Let's do this then. Rename the methods to remove the Concurrently prefix and
address the options thing after 1.8.0 in the main jclouds repo.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-chef/pull/47#issuecomment-49656362
See https://jclouds.ci.cloudbees.com/job/jclouds/2693/changes
[jclouds-pull-requests
#1015](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/1015/) FAILURE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/443#issuecomment-49660310
See
https://jclouds.ci.cloudbees.com/job/jclouds/org.apache.jclouds.driver$jclouds-apachehc/2693/
See https://jclouds.ci.cloudbees.com/job/jclouds-labs-openstack/391/
--
[...truncated 475 lines...]
Downloaded:
http://repo.cloudbees.com/content/repositories/central/com/google/google/5/google-5.pom
(3 KB at 126.3 KB/sec)
Downloading:
See
https://jclouds.ci.cloudbees.com/job/jclouds-labs-openstack/org.apache.jclouds.labs$openstack-glance/391/
--
[...truncated 348 lines...]
Downloaded:
[jclouds-java-7-pull-requests
#1487](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1487/)
FAILURE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/443#issuecomment-49662896
[jclouds » jclouds-chef
#1198](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-chef/1198/)
FAILURE
Looks like there's a problem with this pull request
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
[jclouds-chef-pull-requests
#114](https://jclouds.ci.cloudbees.com/job/jclouds-chef-pull-requests/114/)
FAILURE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-chef/pull/47#issuecomment-49666948
See https://buildhive.cloudbees.com/job/jclouds/job/jclouds-chef/1198/changes
Changes:
[luciano.sabenca] JCLOUDS-624 - Fixed bug in ListNodes
--
[...truncated 111 lines...]
[INFO]
[INFO] --- maven-jar-plugin:2.4:test-jar (default) @ chef-project ---
[jclouds » jclouds-chef
#1199](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-chef/1199/)
SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
See https://buildhive.cloudbees.com/job/jclouds/job/jclouds-chef/1199/changes
[jclouds-chef-pull-requests
#115](https://jclouds.ci.cloudbees.com/job/jclouds-chef-pull-requests/115/)
SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-chef/pull/47#issuecomment-49669343
Done!
@nacx, @demobox, please take a look at this! :-D
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-chef/pull/47#issuecomment-49669280
This PR removes 4 deprecated methods from the Nova Volume API that moved to the
Volume Attachment API. Added the correct Volume Attachment Extension API
namespace, updated tests, and minor cleanup.
You can merge this Pull Request by running:
git pull https://github.com/rackspace/jclouds
[jclouds-java-7-pull-requests
#1488](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1488/)
UNSTABLE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/443#issuecomment-49672109
[
https://issues.apache.org/jira/browse/JCLOUDS-567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jeremy Daggett updated JCLOUDS-567:
---
Summary: Upgrade Apache HttpClient to 4.3 (was: Upgrade Apache HttpClient
to 4.3.3)
This PR upgrades the Apache HttpClient dependency to version 4.3.4 intended for
the 1.8 release.
JIRA: https://issues.apache.org/jira/browse/JCLOUDS-567
You can merge this Pull Request by running:
git pull https://github.com/rackspace/jclouds upgrade-httpclient
Or you can view, comment on
:+1: for the actual change, although generally does the Apache HTTP Client
provide any utility over the standard one?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/449#issuecomment-49673395
[
https://issues.apache.org/jira/browse/JCLOUDS-533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14069457#comment-14069457
]
Andrew Gaul commented on JCLOUDS-533:
-
We should not commit this until we investigate
We should not commit this until we investigate how it interacts with
user-provided encryption keys:
https://aws.amazon.com/blogs/aws/s3-encryption-with-your-keys/
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/344#issuecomment-49676357
See https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1402/changes
Changes:
[gaul] Use xattr for filesystem blob metadata
--
[...truncated 11321 lines...]
[INFO] jclouds ElasticHosts Amsterdam provider ... SKIPPED
[INFO] jclouds ElasticHosts
[jclouds » jclouds
#1402](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1402/) FAILURE
Looks like there's a problem with this pull request
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
Honestly I would prefer to fail on any Checkstyle failures, and if some are too
common or noisy, disable the unneeded checks. The intent of our use of
Checkstyle is to reduce reviewer overhead while maintaining a coherent
formatting; if a committer has to periodically fix up violations then we
[jclouds-pull-requests
#1017](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/1017/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/448#issuecomment-49677860
[jclouds-java-7-pull-requests
#1489](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1489/)
SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/448#issuecomment-49678257
@andrewgaul Thanks! Wait, isn't the Apache HttpClient the standard Java http
library? ;) There was a discussion a while back around using the
[Metrics](http://metrics.dropwizard.io/) library for HttpClient instrumentation
in jclouds, but I can't find it! I believe that an instrumented http
[jclouds-pull-requests
#1018](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/1018/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/449#issuecomment-49678884
[jclouds-java-7-pull-requests
#1490](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1490/)
SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/449#issuecomment-49679194
[jclouds » jclouds
#1403](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1403/) ABORTED
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/443#issuecomment-49685403
[jclouds » jclouds
#1404](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1404/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
See https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1404/changes
[jclouds » jclouds
#1405](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1405/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
59 matches
Mail list logo
