@demobox, I've cherry-picked the commit onto master, shall I close the PR
manually?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/568#issuecomment-59170282
See https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1797/
--
GitHub pull request #433 to jclouds/jclouds
Building remotely on s-3517c7f6 in workspace
https://buildhive.cloudbees.com/job/jclouds/job/jclouds/ws/
Fetching changes from the remote Git
[jclouds » jclouds
#1797](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1797/) FAILURE
Looks like there's a problem with this pull request
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
[jclouds » jclouds
#1798](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1798/) FAILURE
Looks like there's a problem with this pull request
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
[jclouds-pull-requests-java-6
#204](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests-java-6/204/)
SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/433#issuecomment-59183246
[jclouds-pull-requests
#1292](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/1292/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/433#issuecomment-59184906
Did a rebase because it has been a long time and there were merge conflicts.
Also @jdaggett you had a comment about ParseAccessTest that I had a question
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/433#issuecomment-59185690
[jclouds-pull-requests
#1293](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/1293/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/433#issuecomment-59185925
did a global import order fix so that all following changes don#39;t have this.
Main change was to consolidate the Deployment value type. A follow-up PR will
take out the private fields, equals, etc. with auto-value.
You can merge this Pull Request by running:
git pull
cc @abayer
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/92#issuecomment-59222099
}
- public String getPrivateIpAddress() {
- return privateIpAddress;
+ private Deployment(Builder builder) {
Using constructor pattern like this leads to far less chance of mistake when
builders are used.
---
Reply to this email directly or view it on GitHub:
}
- public String getPrivateIpAddress() {
- return privateIpAddress;
+ private Deployment(Builder builder) {
Also, intentionally didn't do a nullable sweep. This is just reorganizing the
fields however good or bad they are.
---
Reply to this email directly or view it on
+ instanceStatus + , instanceStateDetails= +
instanceStateDetails + , instanceErrorCode=
+ instanceErrorCode + , instanceSize= + instanceSize + ,
privateIpAddress= + privateIpAddress
+ , publicIpAddress= + publicIpAddress + ];
}
+
+ public
[jclouds-labs-pull-requests
#315](https://jclouds.ci.cloudbees.com/job/jclouds-labs-pull-requests/315/)
SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/92#issuecomment-59223175
[jclouds » jclouds-labs
#1696](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs/1696/)
SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
For this particular extension, it just adds a field to the response, so the
field needs to be added to the `Server` domain class :
@Named(OS-EXT-AZ:availability_zone)
private final OptionalString availabilityZones;
For the tests, since this is _technically_ an extension, I suggest that
Diwaker Gupta created JCLOUDS-753:
-
Summary: HttpCommandExecutorService(s) vulnerable to POODLE
Key: JCLOUDS-753
URL: https://issues.apache.org/jira/browse/JCLOUDS-753
Project: jclouds
Issue
Closed #568.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/568#event-179079167
[
https://issues.apache.org/jira/browse/JCLOUDS-753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14172901#comment-14172901
]
Diwaker Gupta commented on JCLOUDS-753:
---
I should note that `getInstance(TLS)` or
Users can now create images from persistent disks.
When images are made from PD the rawDisk attribute is not present.
This changes Image.java to treat it as an Optionallt;RawDiskgt; instead.
You can merge this Pull Request by running:
git pull
[jclouds-labs-google-pull-requests
#159](https://jclouds.ci.cloudbees.com/job/jclouds-labs-google-pull-requests/159/)
SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/59#issuecomment-59274346
[
https://issues.apache.org/jira/browse/JCLOUDS-649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14172924#comment-14172924
]
Daniel Broudy commented on JCLOUDS-649:
---
After talking to Chris I made the
[
https://issues.apache.org/jira/browse/JCLOUDS-753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14173013#comment-14173013
]
Andrew Phillips commented on JCLOUDS-753:
-
Thanks for raising this, [~diwaker]!
+ /**
+* Creates an image resource in the specified project from the provided
persistent disk.
+*
+* @param imageName the name of the created image
+* @param sourceDisk fully qualified URL for the persistent disk to
create the image from
+* @return an Operation
@@ -70,5 +86,36 @@ private void assertImageEquals(Image result, Image
expected) {
assertEquals(result.getName(), expected.getName());
}
+ @Test(groups = live)
+ public void testInsertDisk() {
+ assertZoneOperationDoneSucessfully(diskApi().createInZone(DISK_NAME,
Thanks @danbroudy! Just a couple comments. Apart from that, lgtm!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/59#issuecomment-59285602
You can merge this Pull Request by running:
git pull https://github.com/andreaturli/jclouds-site feature/softlayer
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds-site/pull/134
-- Commit Summary --
* add softlayer getting started
-- File
[jclouds-site-pull-requests
#409](https://jclouds.ci.cloudbees.com/job/jclouds-site-pull-requests/409/)
SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/134#issuecomment-59287417
Go to
http://38a1978b0178d686f80d-7e234dfdb2a13218b9e9179aca636b27.r31.cf5.rackcdn.com/
to review your changes.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/134#issuecomment-59287587
@@ -70,5 +86,36 @@ private void assertImageEquals(Image result, Image
expected) {
assertEquals(result.getName(), expected.getName());
}
+ @Test(groups = live)
+ public void testInsertDisk() {
+ assertZoneOperationDoneSucessfully(diskApi().createInZone(DISK_NAME,
+ /**
+* Creates an image resource in the specified project from the provided
persistent disk.
+*
+* @param imageName the name of the created image
+* @param sourceDisk fully qualified URL for the persistent disk to
create the image from
+* @return an Operation
I did have a question about how to handle backwards compatibility with
Image.getRawDisk().
Is it ok that I have changed the return value from a RawDisk to an
OptionalRawDisk?
---
Reply to this email directly or view it on GitHub:
[jclouds-labs-google-pull-requests
#160](https://jclouds.ci.cloudbees.com/job/jclouds-labs-google-pull-requests/160/)
SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/59#issuecomment-59293469
[jclouds » jclouds-labs-google
#1475](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-google/1475/)
SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
@danbroudy Yeah it is perfectly fine to change the return type here in a labs
project. If we had released this before the PR, then we would have to wait
until 2.0, so this worked out nicely. I don't have time to review this in
detail but I'll be back with a review in a couple of hours.
---
tdsoftlayer/td
-td/td
+tdSG,US-CA,US-TX,US-VA,US-WA,NL,HK,NSFTW-IL,AU,CA-ON,GB/td
Wow, now there is a list of ISO codes! I wonder if you can add an `p/` tag
right after `US-WA` to split it into two lines. ?
---
Reply to this email directly or view it on
+
+{% highlight java %}
+// Get a context with softlayer that offers the portable BlobStore API
+BlobStoreContext context = ContextBuilder.newBuilder(swift)
+ .credentials(tenantName:accessKey, apiKey)
+
[jclouds-labs-pull-requests
#316](https://jclouds.ci.cloudbees.com/job/jclouds-labs-pull-requests/316/)
FAILURE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/70#issuecomment-59307882
[jclouds » jclouds-labs
#1697](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs/1697/)
FAILURE
Looks like there's a problem with this pull request
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
See https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs/1697/changes
Changes:
[kulakov.ilya] CloudSigma2 ComputeService.
--
[...truncated 2545 lines...]
[INFO] Exclude: **/*.iml
[INFO] Exclude: **/*.eml
[INFO] Exclude: **/*.ipr
[INFO] Exclude:
40 matches
Mail list logo
