[
https://issues.apache.org/jira/browse/JCLOUDS-1302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16016818#comment-16016818
]
Andrew Gaul commented on JCLOUDS-1302:
--
This will require someone writing a new provider:
zreal created JCLOUDS-1302:
--
Summary: wish to support the OSS of the Aliyun
Key: JCLOUDS-1302
URL: https://issues.apache.org/jira/browse/JCLOUDS-1302
Project: jclouds
Issue Type: Wish
[
https://issues.apache.org/jira/browse/JCLOUDS-1258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16016788#comment-16016788
]
zreal commented on JCLOUDS-1258:
when I change the
[
https://issues.apache.org/jira/browse/JCLOUDS-1258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16016769#comment-16016769
]
zreal commented on JCLOUDS-1258:
Hi, Michelle Zhang.
when I create a bucket using
Good!
Have you been able to run the live tests for the affected APIs?
>By the way how is the @ApiVersion actually injected in places like FormSigner,
>for example? I think the value is being taken from AWSEC2ApiMetadata but I
>couldn't work out how jclouds configures Guice (or whatever) to
Updates made.
I was able to switch to using `@SinceApiVersion`, very pleased with that. The
[key
thing](https://github.com/jclouds/jclouds/pull/1102/commits/3bff59d28c5260e18504c6570ad5cb47117a3d48#diff-7d8365e45e83df7988b1084146439d71R158)
is that I needed to change the override from a
@geomacy pushed 3 commits.
3bff59d Use @SinceApiVersion rather than a custom annotation.
110b188 Use Optional rather than returning null.
74e4245 Apply the version check in FormSignerV2 as well as V4
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
Unit tests may fail because they hardcode the expected version. Live tests will
tell us if the change is safe. Let's run them for the classes that use the
annotation.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
@nacx
I can add the annotation at class level.
I originally started using `@SinceApiVersion`, and having the annotation at
both method and class level, but found that various tests broke, because
various APIs are annotated `@SinceApiVersion`.I will take a look at that
again, but
andrewgaul commented on this pull request.
> +* @param prefix
+*
+*/
+ private void removeObjectsWithPrefix(String container, String prefix) {
+ String nextMarker = null;
+ ObjectApi objectApi = api.getObjectApi(regionId, container);
+ do {
+
I like the annotation approach and agree that the flexibility needed in ARM,
where they deploy new versions of the APIs quite often (but keeping backward
compatibility) might not be needed here.
A couple questions:
* It would be worth considering the annotation at class level too. Could you
I think we should edit the FormSignerV2 as well
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1102#issuecomment-302394483
andreaturli commented on this pull request.
looks really useful as we discussed on IRC.
Some minor comments, but @geomacy your impl is even cleaner than expected using
the annotation.
Thanks!
> @@ -101,7 +105,25 @@
this.serviceAndRegion = serviceAndRegion;
}
- @Override public
[
https://issues.apache.org/jira/browse/JCLOUDS-1293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16015586#comment-16015586
]
Stuart Hendren commented on JCLOUDS-1293:
-
An example retry handler that also needs the above
archupsg03 commented on this pull request.
> +* @param prefix
+*
+*/
+ private void removeObjectsWithPrefix(String container, String prefix) {
+ String nextMarker = null;
+ ObjectApi objectApi = api.getObjectApi(regionId, container);
+ do {
+
15 matches
Mail list logo
