andreaturli commented on this pull request.
lgtm, some minor comments
also tested `PacketComputeServiceLiveTest` which look alright.
why only against `2.0.x`?
>
+ PublicKey userKey = readPublicKey(options.getPublicKey());
+ final String fingerprint = computeFingerprint(userKey);
+
Svetoslav Neykov created JCLOUDS-1309:
-
Summary: GCE SecurityGroupExtension implementation
Key: JCLOUDS-1309
URL: https://issues.apache.org/jira/browse/JCLOUDS-1309
Project: jclouds
[
https://issues.apache.org/jira/browse/JCLOUDS-1308?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ignasi Barrera updated JCLOUDS-1308:
Component/s: jclouds-compute
> Azure ARM Default Network
> -
>
>
[
https://issues.apache.org/jira/browse/JCLOUDS-1308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16049272#comment-16049272
]
Svetoslav Neykov commented on JCLOUDS-1308:
---
Having a shared network makes sense as that's how
[
https://issues.apache.org/jira/browse/JCLOUDS-1308?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ignasi Barrera updated JCLOUDS-1308:
Affects Version/s: 2.0.1
> Azure ARM Default Network
> -
>
>
[
https://issues.apache.org/jira/browse/JCLOUDS-1308?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ignasi Barrera updated JCLOUDS-1308:
Labels: azurecompute-arm (was: )
> Azure ARM Default Network
> -
[
https://issues.apache.org/jira/browse/JCLOUDS-1308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16049269#comment-16049269
]
Ignasi Barrera commented on JCLOUDS-1308:
-
The old implementation presented several issues:
*
I've split the `aws-ec2` changes into a sperate PR
https://github.com/jclouds/jclouds/pull/1113
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/#issuecomment-308454066
Splitting the amazon changes from https://github.com/jclouds/jclouds/pull/
into this PR to make it easier to merge.
I've already tested these changes.
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds/pull/1113
-- Commit Summary --
*
Graeme Miller created JCLOUDS-1308:
--
Summary: Azure ARM Default Network
Key: JCLOUDS-1308
URL: https://issues.apache.org/jira/browse/JCLOUDS-1308
Project: jclouds
Issue Type: Bug
@andreaturli please review.
Apologies for the noise in the PR; I've formatted the class to 3-space indent.
There is a small set of changes:
* Generate a unique name for the generated key pair if the user does not
provide a key. We were generating them with repeated names.
* Improve the check
nacx requested changes on this pull request.
Thanks @danielestevez!
> +* The metrics API includes operations to get insights into entities
> within your
+* subscription.
+*
+* @see https://docs.microsoft.com/en-us/rest/api/monitor/metrics;>docs
+*/
+ @Delegate
+
12 matches
Mail list logo