Re: [jclouds/jclouds-labs] Improve duplicate ssh key check in Packet (#397)

2017-06-14 Thread Andrea Turli
andreaturli commented on this pull request. lgtm, some minor comments also tested `PacketComputeServiceLiveTest` which look alright. why only against `2.0.x`? > + PublicKey userKey = readPublicKey(options.getPublicKey()); + final String fingerprint = computeFingerprint(userKey); +

[jira] [Created] (JCLOUDS-1309) GCE SecurityGroupExtension implementation

2017-06-14 Thread Svetoslav Neykov (JIRA)
Svetoslav Neykov created JCLOUDS-1309: - Summary: GCE SecurityGroupExtension implementation Key: JCLOUDS-1309 URL: https://issues.apache.org/jira/browse/JCLOUDS-1309 Project: jclouds

[jira] [Updated] (JCLOUDS-1308) Azure ARM Default Network

2017-06-14 Thread Ignasi Barrera (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1308?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignasi Barrera updated JCLOUDS-1308: Component/s: jclouds-compute > Azure ARM Default Network > - > >

[jira] [Commented] (JCLOUDS-1308) Azure ARM Default Network

2017-06-14 Thread Svetoslav Neykov (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16049272#comment-16049272 ] Svetoslav Neykov commented on JCLOUDS-1308: --- Having a shared network makes sense as that's how

[jira] [Updated] (JCLOUDS-1308) Azure ARM Default Network

2017-06-14 Thread Ignasi Barrera (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1308?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignasi Barrera updated JCLOUDS-1308: Affects Version/s: 2.0.1 > Azure ARM Default Network > - > >

[jira] [Updated] (JCLOUDS-1308) Azure ARM Default Network

2017-06-14 Thread Ignasi Barrera (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1308?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignasi Barrera updated JCLOUDS-1308: Labels: azurecompute-arm (was: ) > Azure ARM Default Network > -

[jira] [Commented] (JCLOUDS-1308) Azure ARM Default Network

2017-06-14 Thread Ignasi Barrera (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16049269#comment-16049269 ] Ignasi Barrera commented on JCLOUDS-1308: - The old implementation presented several issues: *

Re: [jclouds/jclouds] JCLOUDS-1307: Invalidate security groups even if already externally deleted. (#1111)

2017-06-14 Thread Svet
I've split the `aws-ec2` changes into a sperate PR https://github.com/jclouds/jclouds/pull/1113 -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/#issuecomment-308454066

[jclouds/jclouds] JCLOUDS-1307: aws-ec2: Invalidate SG on removal even if already externally deleted (#1113)

2017-06-14 Thread Svet
Splitting the amazon changes from https://github.com/jclouds/jclouds/pull/ into this PR to make it easier to merge. I've already tested these changes. You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds/pull/1113 -- Commit Summary -- *

[jira] [Created] (JCLOUDS-1308) Azure ARM Default Network

2017-06-14 Thread Graeme Miller (JIRA)
Graeme Miller created JCLOUDS-1308: -- Summary: Azure ARM Default Network Key: JCLOUDS-1308 URL: https://issues.apache.org/jira/browse/JCLOUDS-1308 Project: jclouds Issue Type: Bug

[jclouds/jclouds-labs] Improve duplicate ssh key check in Packet (#397)

2017-06-14 Thread Ignasi Barrera
@andreaturli please review. Apologies for the noise in the PR; I've formatted the class to 3-space indent. There is a small set of changes: * Generate a unique name for the generated key pair if the user does not provide a key. We were generating them with repeated names. * Improve the check

Re: [jclouds/jclouds-labs] Implements metrics and metricdefinitions API (#396)

2017-06-14 Thread Ignasi Barrera
nacx requested changes on this pull request. Thanks @danielestevez! > +* The metrics API includes operations to get insights into entities > within your +* subscription. +* +* @see https://docs.microsoft.com/en-us/rest/api/monitor/metrics;>docs +*/ + @Delegate +