@andrewgaul @timuralp any other blockers for merging this PR
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1105#issuecomment-316906273
[
https://issues.apache.org/jira/browse/JCLOUDS-1322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16094927#comment-16094927
]
Andrew Gaul commented on JCLOUDS-1322:
--
Just to be clear, jclouds does not issue a
[
https://issues.apache.org/jira/browse/JCLOUDS-1322?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Gaul updated JCLOUDS-1322:
-
Affects Version/s: 2.0.2
> Zero length putBlob is making two network calls
> --
[
https://issues.apache.org/jira/browse/JCLOUDS-1322?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Gaul updated JCLOUDS-1322:
-
Priority: Minor (was: Major)
> Zero length putBlob is making two network calls
> -
[
https://issues.apache.org/jira/browse/JCLOUDS-1322?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Gaul updated JCLOUDS-1322:
-
Description:
Zero length putBlob is making two (duplicate) network calls instead of one.
This is
[
https://issues.apache.org/jira/browse/JCLOUDS-1322?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Gaul updated JCLOUDS-1322:
-
Component/s: (was: jclouds-core)
jclouds-blobstore
> Zero length putBlob is
> You should add a test for putting a zero-length blob to
> BaseBlobStoreIntegrationTest and test this against a few providers. We
> probably want a second test for streaming zero-length InputStream payloads as
> well.
@andrewgaul I've added integration tests for zero-length `String`, `ByteSour
@ChaithanyaGK pushed 1 commit.
22692e6 Code cleanup and added integration tests
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/jclouds/jclouds/pull/1120/files/467eeccb71b1e041301b0b4d720c6b22ec37a401..22692e66b2ddc8adec4f55a74cbe9f1f9
Closed #1122.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1122#event-1172143924
Took some time to get to the bottom of it :).
Merged to
[master](https://git1-us-west.apache.org/repos/asf/jclouds/?p=jclouds.git;a=commit;h=0c054c18359fc2bd0f1de2344b6e021a38aed695)
and
[2.0.x](https://git1-us-west.apache.org/repos/asf/jclouds/?p=jclouds.git;a=commit;h=5b57b73cf744cd316c028edd2
> > could you explain the motivation for this change? I don't understand what
> > this addresses except optimizing the rare case of a zero-length PUT.
>
> @andrewgaul Every time I initiate a multipart upload to azure using S3Proxy
> it creates an empty blob, where I've encountered this issue.
S
nacx approved this pull request.
Looks like this had to be kind of a pain to debug :) Thanks @neykov!
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1122#pullrequestreview-51152916
Fixes `BaseComputeServiceAdapterLiveTest.testCreateAndRunAService` for CentOS
7. `disown` in `jetty.sh` is not enough to detach the process from the current
session so it's terminated when jclouds closes the connection.
You can view, comment on, or merge this pull request online at:
https://gi
ChaithanyaGK commented on this pull request.
> @@ -779,6 +782,22 @@ private static void addHeader(Multimap
> headers, Headers header,
return parts.build();
}
+ private static GeneratedHttpRequest
stripExpectHeaderIfContentZero(GeneratedHttpRequest request) {
+ boolean isBod
14 matches
Mail list logo
