Re: [jclouds/jclouds] OpenStack Keystone V3 - different auth "domains" support (JCLOUDS-1414) (#1204)

2018-05-08 Thread Alix Lourme
@nacx : I will do that (your reviews, thanks) this wednesday. About `useTenant` flag I will be more explicit and add a unit test to prove the use case. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [jclouds/jclouds] OpenStack Keystone V3 - different auth "domains" support (JCLOUDS-1414) (#1204)

2018-05-08 Thread Alix Lourme
axel3rd commented on this pull request. >} else if (DOMAIN.equals(parts[0])) { return DomainScope.create(Name.create(parts[1])); } else { return DomainIdScope.create(Id.create(parts[1])); } } + + private Object

Re: [jclouds/jclouds] OpenStack Keystone V3 - different auth "domains" support (JCLOUDS-1414) (#1204)

2018-05-08 Thread Ignasi Barrera
nacx approved this pull request. Just some small comments. Thanks for the contribution @axel3rd! >} else if (DOMAIN.equals(parts[0])) { return DomainScope.create(Name.create(parts[1])); } else { return DomainIdScope.create(Id.create(parts[1])); } } +