@andreaturli Sorry it was a bad merge from upstream on my side, the SSH and
BlockStorage features are not that big of a change. It is 15 files after i
correctly synced with upstream
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on
Yes, I will add it to Throwables2.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/439#issuecomment-402714108
Hi @alibazlamit thanks for your perseverance
I really need to encourage you to open smaller PR: 75 files bring in a huge
amount of changes and it is impossible to review all of them carefully. Can you
take the time to close this PR and open up small incremental PRs maybe?
I think the first one
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds-labs/pull/440
-- Commit Summary --
* [JCLOUDS-1430] - add region and zone API
-- File Changes --
M aliyun-ecs/src/main/java/org/jclouds/aliyun/ecs/ECSComputeServiceApi.java
(4)
M
[
https://issues.apache.org/jira/browse/JCLOUDS-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16533500#comment-16533500
]
ASF subversion and git services commented on JCLOUDS-1430:
--
Commit
merged at
[master](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/5bd2a80f)
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/438#issuecomment-402682152
Closed #438.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/438#event-1717762779
Thanks @nacx squashed and merging if builder is happy
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/438#issuecomment-402678453
>RESOURCE_BUSY - Another operation is in progress on an asset. Could
>alternatively be mapped to ConcurrentModificationException. But it is not on
>the list of exceptions allowed to propagate.
Looks like a good candidate to be added to the list. Wanna add it too and use
that exception here?
I think this is correct.
I will add this as 4th commit (before squashing).
RESOURCE_BUSY - Another operation is in progress on an asset. Could
alternatively be mapped to ConcurrentModificationException. But it is not on
the list of exceptions allowed to propagate.
--
You are receiving this
nacx approved this pull request.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/438#pullrequestreview-134584676
Thanks, @FileIOUtility! LGTM
>From the discussion about response codes, I've revisited the error handler and
>there are some errors we could consider propagating better:
```java
case 400:
if (message.contains("RESOURCE_NOT_FOUND")
|| message.contains("OPERATION_NOT_SUPPORTED")) {
Is it OK to squash these 3 commits before you merge?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/439#issuecomment-402666510
nacx approved this pull request.
> @@ -121,10 +121,9 @@ public void testListServersWithDatacenterFiltering()
> throws Exception {
return
Uris.uriBuilder("/caas/2.4/6ac1e746-b1ea-4da5-a24e-caf1a978789d/server/server");
}
- public void testListServers_404() throws Exception {
-
@andreaturli pushed 1 commit.
99057d5 more comments addressed
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/438/files/cc9caf994662bf4f1f03b56f4372c09f190d1999..99057d5101294fbfee489357b3217f1678c8f2ee
andreaturli commented on this pull request.
> @@ -52,15 +52,15 @@
@Consumes(MediaType.APPLICATION_JSON)
@RequestFilters(FormSign.class)
@QueryParams(keys = {"Version", "Format", "SignatureVersion", "ServiceCode",
"SignatureMethod"},
-values = {"2014-05-26", "JSON", "1.0", "ecs",
16 matches
Mail list logo
