Re: [jclouds/jclouds] [JCLOUDS-1428] Support for SAS token based Authentication for Azure Blob Storage (#1270)

2019-02-13 Thread Aliaksandra Kharushka
@ak58588 pushed 5 commits. 8c4114a2f2cf29d751158b98013aaf8bb187e125 [JCLOUDS-1428] Support for SAS token based Authentication for Azure Blob Storage #1270 - javadoc 73be36dd9ce96fa5d1a1cc3d11602bcb84245bdd fixed javadoc 053ec63e62b12d48de716444bb8026cce8a7cd35 fixed javadoc

Re: [jclouds/jclouds] [JCLOUDS-1428] Support for SAS token based Authentication for Azure Blob Storage (#1270)

2019-02-13 Thread Aliaksandra Kharushka
@ak58588 pushed 1 commit. 5605117a04315ee05f677248faa138dbe98991a7 Update providers/azureblob/src/main/java/org/jclouds/azureblob/config/AzureBlobHttpApiModule.java -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [jclouds/jclouds] [JCLOUDS-1428] Support for SAS token based Authentication for Azure Blob Storage (#1270)

2019-02-13 Thread Aliaksandra Kharushka
@ak58588 pushed 1 commit. 0526b25208647125c29951be57bb4a9a5f172c5d Update providers/azureblob/src/main/java/org/jclouds/azureblob/blobstore/AzureBlobRequestSigner.java -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [jclouds/jclouds] [JCLOUDS-1428] Support for SAS token based Authentication for Azure Blob Storage (#1270)

2019-02-13 Thread Aliaksandra Kharushka
@ak58588 pushed 1 commit. 1e7eb302b4b4073eabdb89c48bea08fc557d32ae Update providers/azureblob/src/main/java/org/jclouds/azureblob/blobstore/AzureBlobRequestSigner.java -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [jclouds/jclouds] [JCLOUDS-1428] Support for SAS token based Authentication for Azure Blob Storage (#1270)

2019-02-13 Thread Aliaksandra Kharushka
@ak58588 pushed 1 commit. 04b1106156309cfed77a0af86fc83dac71411cae Update providers/azureblob/src/main/java/org/jclouds/azure/storage/filters/SharedKeyLiteAuthentication.java -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [jclouds/jclouds] [JCLOUDS-1428] Support for SAS token based Authentication for Azure Blob Storage (#1270)

2019-02-13 Thread Aliaksandra Kharushka
@ak58588 pushed 1 commit. b76d8fb669369b267bb6ce0ea39d3a3b96557baf Update providers/azureblob/src/main/java/org/jclouds/azure/storage/filters/SharedKeyLiteAuthentication.java -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [jclouds/jclouds] [JCLOUDS-1428] Support for SAS token based Authentication for Azure Blob Storage (#1270)

2019-02-13 Thread Ignasi Barrera
nacx requested changes on this pull request. > } - + + /** +* this is an updated filter method, which decides whether the SAS or SharedKeyLite +* is used and applies the right filtering. +* ```suggestion ``` >utils.logRequest(signatureLog, request, "<<");

Re: [jclouds/jclouds] [JCLOUDS-1428] Support for SAS token based Authentication for Azure Blob Storage (#1270)

2019-02-13 Thread Aliaksandra Kharushka
ak58588 commented on this pull request. > @@ -63,6 +64,17 @@ protected final String guiceProvideTimeStamp(@TimeStamp > Supplier cache) protected String provideTimeStamp(@TimeStamp Supplier cache) { return cache.get(); } + + /** + * checks which Authentication type is

Re: [jclouds/jclouds] [JCLOUDS-1428] Support for SAS token based Authentication for Azure Blob Storage (#1270)

2019-02-13 Thread Aliaksandra Kharushka
@ak58588 pushed 1 commit. 4aa45985829b0d77afa89404c8ac7fa57c4b18a0 [JCLOUDS-1428] Support for SAS token based Authentication for Azure Blob Storage #1270 - changes authSAS method and cheking logic -- You are receiving this because you are subscribed to this thread. View it on GitHub:

[jira] [Commented] (JCLOUDS-1426) Jclouds does not return all private ip address of aws ec2 instance

2019-02-13 Thread Ishtiaq (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16767083#comment-16767083 ] Ishtiaq commented on JCLOUDS-1426: -- So you are saying “RunningInstence” is what has wrong values

[jira] [Commented] (JCLOUDS-1426) Jclouds does not return all private ip address of aws ec2 instance

2019-02-13 Thread Ishtiaq (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16767072#comment-16767072 ] Ishtiaq commented on JCLOUDS-1426: -- I’ll give it a try for sure -is there a way to find nobody else

[jira] [Comment Edited] (JCLOUDS-1426) Jclouds does not return all private ip address of aws ec2 instance

2019-02-13 Thread Ignasi Barrera (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16767043#comment-16767043 ] Ignasi Barrera edited comment on JCLOUDS-1426 at 2/13/19 10:50 AM: ---

[jira] [Commented] (JCLOUDS-1426) Jclouds does not return all private ip address of aws ec2 instance

2019-02-13 Thread Ignasi Barrera (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16767043#comment-16767043 ] Ignasi Barrera commented on JCLOUDS-1426: - As [~andreaturli] said, currently jclouds reads the

[jira] [Comment Edited] (JCLOUDS-1426) Jclouds does not return all private ip address of aws ec2 instance

2019-02-13 Thread Ignasi Barrera (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16767043#comment-16767043 ] Ignasi Barrera edited comment on JCLOUDS-1426 at 2/13/19 10:51 AM: ---

Re: [jclouds/jclouds] [JCLOUDS-1428] Support for SAS token based Authentication for Azure Blob Storage (#1270)

2019-02-13 Thread Ignasi Barrera
nacx commented on this pull request. > @@ -63,6 +64,17 @@ protected final String guiceProvideTimeStamp(@TimeStamp > Supplier cache) protected String provideTimeStamp(@TimeStamp Supplier cache) { return cache.get(); } + + /** + * checks which Authentication type is used

[jira] [Commented] (JCLOUDS-1426) Jclouds does not return all private ip address of aws ec2 instance

2019-02-13 Thread Ishtiaq (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16767022#comment-16767022 ] Ishtiaq commented on JCLOUDS-1426: -- Any update would be highly appreciated > Jclouds does not return

[jira] [Commented] (JCLOUDS-1426) Jclouds does not return all private ip address of aws ec2 instance

2019-02-13 Thread Ishtiaq (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16767021#comment-16767021 ] Ishtiaq commented on JCLOUDS-1426: -- Hi guys, what is happening with this issue? I'm stuck with this

Re: [jclouds/jclouds] [JCLOUDS-1428] Support for SAS token based Authentication for Azure Blob Storage (#1270)

2019-02-13 Thread Aliaksandra Kharushka
ak58588 commented on this pull request. > @@ -63,6 +64,17 @@ protected final String guiceProvideTimeStamp(@TimeStamp > Supplier cache) protected String provideTimeStamp(@TimeStamp Supplier cache) { return cache.get(); } + + /** + * checks which Authentication type is

Re: [jclouds/jclouds] [JCLOUDS-1428] Support for SAS token based Authentication for Azure Blob Storage (#1270)

2019-02-13 Thread Aliaksandra Kharushka
ak58588 commented on this pull request. > @@ -63,6 +64,17 @@ protected final String guiceProvideTimeStamp(@TimeStamp > Supplier cache) protected String provideTimeStamp(@TimeStamp Supplier cache) { return cache.get(); } + + /** + * checks which Authentication type is

Re: [jclouds/jclouds] [JCLOUDS-1428] Support for SAS token based Authentication for Azure Blob Storage (#1270)

2019-02-13 Thread Aliaksandra Kharushka
ak58588 commented on this pull request. > @@ -63,6 +64,17 @@ protected final String guiceProvideTimeStamp(@TimeStamp > Supplier cache) protected String provideTimeStamp(@TimeStamp Supplier cache) { return cache.get(); } + + /** + * checks which Authentication type is