Re: [jclouds/jclouds-site] DO NOT MERGE: Testing PR builds (#221)

2018-11-13 Thread Ignasi Barrera
Closed #221. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/221#event-1963663684

Re: [jclouds/jclouds-site] DO NOT MERGE: Testing PR builds (#221)

2018-11-13 Thread Ignasi Barrera
Reopened #221. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/221#event-1963663774

Re: [jclouds/jclouds-site] DO NOT MERGE: Testing PR builds (#221)

2018-11-13 Thread Ignasi Barrera
Closed #221. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/221#event-1963657856

Re: [jclouds/jclouds-site] DO NOT MERGE: Testing PR builds (#221)

2018-11-13 Thread Ignasi Barrera
Reopened #221. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/221#event-1963658014

Re: [jclouds/jclouds-site] DO NOT MERGE: Testing PR builds (#221)

2018-11-13 Thread Ignasi Barrera
Reopened #221. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/221#event-1963655042

Re: [jclouds/jclouds-site] DO NOT MERGE: Testing PR builds (#221)

2018-11-13 Thread Ignasi Barrera
Closed #221. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/221#event-1963654943

Re: [jclouds/jclouds-site] DO NOT MERGE: Testing PR builds (#221)

2018-11-13 Thread Ignasi Barrera
Reopened #221. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/221#event-1963625839

Re: [jclouds/jclouds-site] DO NOT MERGE: Testing PR builds (#221)

2018-11-13 Thread Ignasi Barrera
Closed #221. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/221#event-1963625691

Re: [jclouds/jclouds-site] DO NOT MERGE: Testing PR builds (#221)

2018-11-13 Thread Ignasi Barrera
Reopened #221. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/221#event-1963622400

Re: [jclouds/jclouds-site] DO NOT MERGE: Testing PR builds (#221)

2018-11-13 Thread Ignasi Barrera
Closed #221. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/221#event-1963622247

Re: [jclouds/jclouds-site] DO NOT MERGE: Testing PR builds (#221)

2018-11-13 Thread Ignasi Barrera
Reopened #221. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/221#event-1963612432

Re: [jclouds/jclouds-site] DO NOT MERGE: Testing PR builds (#221)

2018-11-13 Thread Ignasi Barrera
Closed #221. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/221#event-1963612314

Re: [jclouds/jclouds-site] DO NOT MERGE: Testing PR builds (#221)

2018-11-13 Thread Ignasi Barrera
Closed #221. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/221#event-1963608938

Re: [jclouds/jclouds-site] DO NOT MERGE: Testing PR builds (#221)

2018-11-13 Thread Ignasi Barrera
Reopened #221. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/221#event-1963609107

[jclouds/jclouds-site] DO NOT MERGE: Testing PR builds (#221)

2018-11-13 Thread Ignasi Barrera
You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds-site/pull/221 -- Commit Summary -- * Testing PR builds -- File Changes -- M _layouts/home.html (2) -- Patch Links -- https://github.com/jclouds/jclouds-site/pull/221.patch

Re: [jclouds/jclouds-cli] DO NOT MERGE: Testing ASF Jenkins PR integration (#42)

2018-11-13 Thread Ignasi Barrera
Closed #42. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-cli/pull/42#event-1963590709

Re: [jclouds/jclouds-cli] DO NOT MERGE: Testing ASF Jenkins PR integration (#42)

2018-11-13 Thread Ignasi Barrera
Reopened #42. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-cli/pull/42#event-1963353674

Re: [jclouds/jclouds-cli] DO NOT MERGE: Testing ASF Jenkins PR integration (#42)

2018-11-13 Thread Ignasi Barrera
Closed #42. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-cli/pull/42#event-1963353526

[jclouds/jclouds-cli] DO NOT MERGE: Testing ASF Jenkins PR integration (#42)

2018-11-13 Thread Ignasi Barrera
You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds-cli/pull/42 -- Commit Summary -- * Testing ASF Jenkins PR integration -- File Changes -- A .java-version (1) M README.md (2) -- Patch Links --

Re: [jclouds/jclouds] Update to maven-compiler-plugin to 3.6.2 (#1256)

2018-11-12 Thread Ignasi Barrera
nacx approved this pull request. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1256#pullrequestreview-174127141

Re: [jclouds/jclouds] Adds method listAvailableSizes to VirtualMachineApi (#1257)

2018-11-12 Thread Ignasi Barrera
nacx approved this pull request. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1257#pullrequestreview-174126535

Re: [jclouds/jclouds] Update to plexus-compiler 2.8.1 (#1255)

2018-11-12 Thread Ignasi Barrera
nacx approved this pull request. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1255#pullrequestreview-174127003

Re: [jclouds/jclouds] Improve Jetty installation for live tests (#1230)

2018-11-02 Thread Ignasi Barrera
Looks like the version with the fix require Java 8: https://www.eclipse.org/lists/jetty-announce/msg00080.html Let's revert this and file a proper JIRA issue to track the Jetty thing. It's not a critical thing, as the Jetty statement is mostly used just for tests. -- You are receiving this

Re: [jclouds/jclouds] Improve Jetty installation for live tests (#1230)

2018-11-01 Thread Ignasi Barrera
@andreaturli Any chance you can use this branch to upgrade Jetty to fix the vulnerability? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1230#issuecomment-435021317

Re: [jclouds/jclouds] JCLOUDS-1460: Feat/adding aws instances (#1245)

2018-10-24 Thread Ignasi Barrera
Thanks for the effort! Basically, because we don't push code to GitHub but to the Apache Git repository. This is just a mirror of that one and whatever is pushed just here gets removed when the Apache Git repo is mirrored. Now that you have gotten into the wonderful world of rebasing :) would

[jira] [Commented] (JCLOUDS-1463) MachineTypeToHardware throws exception when region has no available zone

2018-10-24 Thread Ignasi Barrera (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16661857#comment-16661857 ] Ignasi Barrera commented on JCLOUDS-1463: - The fix is merged to master and 2.1.x. I don't know

[jira] [Resolved] (JCLOUDS-1463) MachineTypeToHardware throws exception when region has no available zone

2018-10-24 Thread Ignasi Barrera (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1463?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignasi Barrera resolved JCLOUDS-1463. - Resolution: Fixed Fix Version/s: 2.1.2 2.2.0

Re: [jclouds/jclouds] JCLOUDS-1463: Do not return MachineTypes from zones that are not available for deploy (#1250)

2018-10-24 Thread Ignasi Barrera
Merged to [master]( http://git-wip-us.apache.org/repos/asf/jclouds/commit/9dd50b39) and [2.1.x](http://git-wip-us.apache.org/repos/asf/jclouds/commit/53c011a3). -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [jclouds/jclouds] JCLOUDS-1463: Do not return MachineTypes from zones that are not available for deploy (#1250)

2018-10-24 Thread Ignasi Barrera
Closed #1250. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1250#event-1922549229

Re: [jclouds/jclouds] JCLOUDS-1463: Do not return MachineTypes from zones that are not available for deploy (#1250)

2018-10-23 Thread Ignasi Barrera
@nacx pushed 1 commit. 3dea314 Added unit tests -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds/pull/1250/files/eaae0b15589c78681bbf0fc7e55b49dd0dcc6456..3dea3146e80c33c8b28417080db4b64e42b01109

[jira] [Commented] (JCLOUDS-1463) MachineTypeToHardware throws exception when region has no available zone

2018-10-23 Thread Ignasi Barrera (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16661208#comment-16661208 ] Ignasi Barrera commented on JCLOUDS-1463: - I've just created this patch: https://github.com

[jclouds/jclouds] JCLOUDS-1463: Do not return MachineTypes from zones that are not available for deploy (#1250)

2018-10-23 Thread Ignasi Barrera
https://issues.apache.org/jira/browse/JCLOUDS-1463 You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds/pull/1250 -- Commit Summary -- * JCLOUDS-1463: Do not return MachineTypes from zones that are not available for deploy -- File Changes --

[jira] [Commented] (JCLOUDS-1463) MachineTypeToHardware throws exception when region has no available zone

2018-10-23 Thread Ignasi Barrera (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16660329#comment-16660329 ] Ignasi Barrera commented on JCLOUDS-1463: - Do you have access to the zones in {{asia-east2

[jira] [Updated] (JCLOUDS-1431) Support AU geo for Live Tests

2018-10-19 Thread Ignasi Barrera (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignasi Barrera updated JCLOUDS-1431: Component/s: jclouds-labs jclouds-compute > Support AU geo for L

[jira] [Resolved] (JCLOUDS-1431) Support AU geo for Live Tests

2018-10-19 Thread Ignasi Barrera (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignasi Barrera resolved JCLOUDS-1431. - Resolution: Fixed > Support AU geo for Live Te

Re: [jclouds/jclouds-labs] JCLOUDS-1431 - Support AU geo for Live Tests (#446)

2018-10-19 Thread Ignasi Barrera
Closed #446. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/446#event-1914224442

Re: [jclouds/jclouds-labs] JCLOUDS-1431 - Support AU geo for Live Tests (#446)

2018-10-19 Thread Ignasi Barrera
Squashed and merged to [master](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/85c46b82) and [2.1.x](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/f7b8c2ca). Thx! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or

Re: [jclouds/jclouds-labs] JCLOUDS-1431 - Support AU geo for Live Tests (#446)

2018-10-19 Thread Ignasi Barrera
nacx commented on this pull request. >assertNotNull(cloneImageId); assertTrue(serverNormalPredicate.apply(serverId), "server was not NORMAL after timeout"); } + @Test(dependsOnMethods = "testCloneServerToMakeCustomerImage") + public void testListCustomerImages() { +

Re: [jclouds/jclouds-labs] JCLOUDS-1431 - Support AU geo for Live Tests (#446)

2018-10-19 Thread Ignasi Barrera
nacx commented on this pull request. > +import org.jclouds.rest.annotations.Fallback; +import org.jclouds.rest.annotations.MapBinder; +import org.jclouds.rest.annotations.PayloadParam; +import org.jclouds.rest.annotations.RequestFilters; +import org.jclouds.rest.binders.BindToJsonPayload; +

[jclouds/jclouds] CVE-2015-5262: Upgrade Apache Http driver to 4.3.6 (#1247)

2018-10-18 Thread Ignasi Barrera
https://nvd.nist.gov/vuln/detail/CVE-2015-5262 You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds/pull/1247 -- Commit Summary -- * CVE-2015-5262: Upgrade Apache Http driver to 4.3.6 -- File Changes -- M drivers/apachehc/pom.xml (2) --

[jclouds/jclouds] CVE-2015-5262: Upgrade Apache Http driver to 4.3.6 (#1246)

2018-10-18 Thread Ignasi Barrera
https://nvd.nist.gov/vuln/detail/CVE-2015-5262 You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds/pull/1246 -- Commit Summary -- * CVE-2015-5262: Upgrade Apache Http driver to 4.3.6 -- File Changes -- M drivers/apachehc/pom.xml (2) --

[jira] [Resolved] (JCLOUDS-1457) Add Clean Server operation to ServerApi

2018-10-18 Thread Ignasi Barrera (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignasi Barrera resolved JCLOUDS-1457. - Resolution: Fixed > Add Clean Server operation to Server

[jira] [Updated] (JCLOUDS-1457) Add Clean Server operation to ServerApi

2018-10-18 Thread Ignasi Barrera (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignasi Barrera updated JCLOUDS-1457: Component/s: jclouds-compute > Add Clean Server operation to Server

[jira] [Updated] (JCLOUDS-1457) Add Clean Server operation to ServerApi

2018-10-18 Thread Ignasi Barrera (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignasi Barrera updated JCLOUDS-1457: Fix Version/s: 2.1.2 > Add Clean Server operation to Server

Re: [jclouds/jclouds-labs] JCLOUDS-1457 - Add Clean Server operation to ServerApi. (#450)

2018-10-18 Thread Ignasi Barrera
Merged to [master](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/54249bd3) and [2.1.x](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/6b4aa2c8). Thanks! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on

Re: [jclouds/jclouds-labs] JCLOUDS-1457 - Add Clean Server operation to ServerApi. (#450)

2018-10-18 Thread Ignasi Barrera
Closed #450. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/450#event-1911788117

Re: [jclouds/jclouds-labs] JCLOUDS-1431 - Support AU geo for Live Tests (#446)

2018-10-18 Thread Ignasi Barrera
nacx approved this pull request. Just a couple minors. Will merge once addressed. > +import javax.ws.rs.Path; +import javax.ws.rs.Produces; +import javax.ws.rs.core.MediaType; + +@RequestFilters({ BasicAuthentication.class, OrganisationIdFilter.class }) +@Consumes(MediaType.APPLICATION_JSON)

Re: [jclouds/jclouds-labs] JCLOUDS-1457 - Add Clean Server operation to ServerApi. (#450)

2018-10-18 Thread Ignasi Barrera
Thanks! Just one minor. Once addressed I'll merge the PR. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/450#issuecomment-430943763

Re: [jclouds/jclouds-labs] JCLOUDS-1457 - Add Clean Server operation to ServerApi. (#450)

2018-10-18 Thread Ignasi Barrera
nacx approved this pull request. > @@ -150,6 +150,17 @@ String cloneServer(@PayloadParam("id") String id, > @PayloadParam("imageName") Str @MapBinder(BindToJsonPayload.class) void startServer(@PayloadParam("id") String id); + @Named("server:cleanServer") + @POST +

Re: [jclouds/jclouds] Make NovaErrorHandler logging of sensitive information configurable (#1243)

2018-10-18 Thread Ignasi Barrera
Merged to [master](http://git-wip-us.apache.org/repos/asf/jclouds/commit/8b17dfea) and [2.1.x](http://git-wip-us.apache.org/repos/asf/jclouds/commit/437f944e). Thanks @olivergondza! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on

Re: [jclouds/jclouds] Make NovaErrorHandler logging of sensitive information configurable (#1243)

2018-10-18 Thread Ignasi Barrera
Closed #1243. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1243#event-1911726852

Re: [jclouds/jclouds] Mark srouceImage as Nullable to avoid NullPointerException while attaching local-ssd disk in GCE (#1242)

2018-10-18 Thread Ignasi Barrera
Merged to [master](http://git-wip-us.apache.org/repos/asf/jclouds/commit/f7b83f45) and [2.1.x](http://git-wip-us.apache.org/repos/asf/jclouds/commit/71dbce55). Thanks @maismail! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on

Re: [jclouds/jclouds] Mark srouceImage as Nullable to avoid NullPointerException while attaching local-ssd disk in GCE (#1242)

2018-10-18 Thread Ignasi Barrera
Closed #1242. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1242#event-1911717382

[jira] [Commented] (JCLOUDS-1461) During multiple chunk upload on Google Cloud Storage, errors are logged whereas upload is successful

2018-10-18 Thread Ignasi Barrera (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16654914#comment-16654914 ] Ignasi Barrera commented on JCLOUDS-1461: - By default, jclouds tries to retry requests upon

Re: [jclouds/jclouds] Mark srouceImage as Nullable to avoid NullPointerException while attaching local-ssd disk in GCE (#1242)

2018-10-16 Thread Ignasi Barrera
It's just a null check in a domain model that was not hit in a path reachable from the portable abstraction... I'm fine with the path as-is. @demobox? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

[jira] [Commented] (JCLOUDS-1460) Add support for t3 instance types in AWS ec2

2018-10-15 Thread Ignasi Barrera (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16650379#comment-16650379 ] Ignasi Barrera commented on JCLOUDS-1460: - This should be easy to add. Wanna try contributing

Re: [jclouds/jclouds-labs] Remove deprecated Azure provider (#449)

2018-10-15 Thread Ignasi Barrera
Reopened #449. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/449#event-1904138862

Re: [jclouds/jclouds-labs] Remove deprecated Azure provider (#449)

2018-10-15 Thread Ignasi Barrera
Testing new PR build -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/449#issuecomment-429859062

Re: [jclouds/jclouds-labs] Remove deprecated Azure provider (#449)

2018-10-15 Thread Ignasi Barrera
Closed #449. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/449#event-1904138684

[jclouds/jclouds-labs] Remove deprecated Azure provider (#449)

2018-10-15 Thread Ignasi Barrera
Azure ARM has been there for a while and it does not make sense to keep this in labs. You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds-labs/pull/449 -- Commit Summary -- * Remove deprecated Azure provider -- File Changes -- D

Re: [jclouds/jclouds] Improve Jetty installation for live tests (#1230)

2018-10-15 Thread Ignasi Barrera
Closing and re-opening to test new PR build -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1230#issuecomment-429773301

Re: [jclouds/jclouds] Improve Jetty installation for live tests (#1230)

2018-10-15 Thread Ignasi Barrera
Reopened #1230. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1230#event-1903538974

Re: [jclouds/jclouds] Improve Jetty installation for live tests (#1230)

2018-10-15 Thread Ignasi Barrera
Closed #1230. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1230#event-1903538849

Re: [jclouds/jclouds-site] JCLOUDS-1458 Create Dimension Data Provider Guide (#220)

2018-10-11 Thread Ignasi Barrera
nacx commented on this pull request. > + +{% highlight java %} +/* + * Deploy Network Domain to the Zone / Datacenter we wish to operate on. The response from this API is the Network Domain Identifier. + */ +String networkDomainId = api.getNetworkApi().deployNetworkDomain(AU9,

Re: [jclouds/jclouds-examples] Added Dimension Data examples (#94)

2018-10-11 Thread Ignasi Barrera
merged to master as a145a8fd[](http://git-wip-us.apache.org/repos/asf/jclouds-examples/commit/a145a8fd). Thanks, @trevorflanagan! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [jclouds/jclouds-examples] Added Dimension Data examples (#94)

2018-10-11 Thread Ignasi Barrera
Closed #94. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-examples/pull/94#event-1897728163

Re: [jclouds/jclouds-examples] Added Dimension Data examples (#94)

2018-10-11 Thread Ignasi Barrera
nacx approved this pull request. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-examples/pull/94#pullrequestreview-163731854

Re: [jclouds/jclouds-site] JCLOUDS-1458 Create Dimension Data Provider Guide (#220)

2018-10-11 Thread Ignasi Barrera
Could you also add the provider in the providers page, and link to the guide? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/220#issuecomment-428854692

Re: [jclouds/jclouds-site] JCLOUDS-1458 Create Dimension Data Provider Guide (#220)

2018-10-11 Thread Ignasi Barrera
nacx commented on this pull request. > + +Dimension Data CloudControl allows for Tags to be applied to assets. There are two parts to the tagging process, first a tag key needs to be created, second the tag key is applied to an asset. + +Create a tag key. We will use this to tag the assets

Re: [jclouds/jclouds-site] JCLOUDS-1458 Create Dimension Data Provider Guide (#220)

2018-10-11 Thread Ignasi Barrera
nacx commented on this pull request. > +{% highlight java %} +/* + * Deploy Network Domain to the Zone / Datacenter we wish to operate on. The response from this API is the Network Domain Identifier. + */ +String networkDomainId =

Re: [jclouds/jclouds-examples] Added Dimension Data examples (#94)

2018-10-11 Thread Ignasi Barrera
nacx commented on this pull request. Thanks for the fixes. Just some minor comments and it will be ready to be merged! > +``` +git clone https://github.com/jclouds/jclouds-examples.git +cd jclouds-examples/dimensiondata/ +``` + +To download all dependencies, run: + +``` +mvn

Re: [jclouds/jclouds-examples] Added Dimension Data examples (#94)

2018-10-10 Thread Ignasi Barrera
nacx requested changes on this pull request. Thanks, @trevorflanagan! Examples and documentation contributions are super great and highly appreciated. Thanks! Please, add also a README either linking to the jclouds guide or just explain how to set up an account, etc, so users landing here know

Re: [jclouds/jclouds-site] JCLOUDS-1458 Create Dimension Data Provider Guide (#220)

2018-10-10 Thread Ignasi Barrera
nacx requested changes on this pull request. Thanks for taking your time to write the docs @trevorflanagan. This is highly appreciated! > + +-- + +## Concepts + +The jclouds library wraps the [Dimension Data CloudControl

Re: [jclouds/jclouds-labs] JCLOUDS-1454 Implement ServerToServerWithExternalIp function for dimensiondata (#448)

2018-10-05 Thread Ignasi Barrera
nacx commented on this pull request. Just a couple minor comments. Thanks @btrishkin! > +import org.jclouds.dimensiondata.cloudcontrol.domain.Server; +import org.jclouds.dimensiondata.cloudcontrol.domain.internal.ServerWithExternalIp; + +import javax.inject.Inject; +import

[jira] [Resolved] (JCLOUDS-1455) Update ParseResponse to log error details. Add ParseTests for Domain Objects in NetworkApi and ServerApi

2018-10-05 Thread Ignasi Barrera (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1455?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignasi Barrera resolved JCLOUDS-1455. - Resolution: Fixed Fix Version/s: 2.2.0 > Update ParseResponse to log er

Re: [jclouds/jclouds-labs] JCLOUDS-1455 - Update ParseResponse to log error details. Add ParseTests for Domain Objects in NetworkApi and ServerApi (#445)

2018-10-05 Thread Ignasi Barrera
Closed #445. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/445#event-1886596826

Re: [jclouds/jclouds-labs] JCLOUDS-1455 - Update ParseResponse to log error details. Add ParseTests for Domain Objects in NetworkApi and ServerApi (#445)

2018-10-05 Thread Ignasi Barrera
Merged to [master](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/ff3bdab6) and [2.1.x](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/09853b55). Thanks @jawnclarke! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or

Re: [jclouds/jclouds-labs] JCLOUDS-1455 - Update ParseResponse to log error details. Add ParseTests for Domain Objects in NetworkApi and ServerApi (#445)

2018-10-05 Thread Ignasi Barrera
nacx approved this pull request. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/445#pullrequestreview-161925262

Re: [jclouds/jclouds-site] Replace the ApacheCon banner with 'support the ASF' (#219)

2018-10-04 Thread Ignasi Barrera
NP, I'll do :) -- You are receiving this because you modified the open/close state. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/219#issuecomment-426993105

[jira] [Commented] (JCLOUDS-1132) Amazon AWS - Create Volume - query params reported as unrecognized

2018-10-03 Thread Ignasi Barrera (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16637285#comment-16637285 ] Ignasi Barrera commented on JCLOUDS-1132: - Yes, I think it makes sense. And even if it breaks

Re: [jclouds/jclouds-site] Replace the ApacheCon banner with 'support the ASF' (#219)

2018-10-03 Thread Ignasi Barrera
nacx approved this pull request. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/219#pullrequestreview-161063677

Re: [jclouds/jclouds-site] Replace the ApacheCon banner with 'support the ASF' (#219)

2018-10-03 Thread Ignasi Barrera
This looks like already merged? >I have skepticism about any of these banners, but this improves the current >page. I'm fine with removing them. Feel free! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [jclouds/jclouds] Fix/azure resource removal (#1240)

2018-09-18 Thread Ignasi Barrera
nacx commented on this pull request. Thanks, @nakomis! And many thanks for taking care of adding new tests. It's highly appreciated! > @@ -98,7 +109,8 @@ protected VirtualMachineInStatePredicateFactory > provideVirtualMachineRunningPred @Named(TIMEOUT_RESOURCE_DELETED) protected

Re: [jclouds/jclouds] JCLOUDS-1447: URL encode source header on copyObject (#1238)

2018-09-12 Thread Ignasi Barrera
nacx approved this pull request. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1238#pullrequestreview-154608939

[jira] [Commented] (JCLOUDS-1447) S3 CopyObject requires x-amz-copy-source to be URL encoded

2018-09-12 Thread Ignasi Barrera (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16611813#comment-16611813 ] Ignasi Barrera commented on JCLOUDS-1447: - I agree with you [~rami.hanni...@documill.com

[jira] [Updated] (JCLOUDS-1447) S3 CopyObject requires x-amz-copy-source to be URL encoded

2018-09-12 Thread Ignasi Barrera (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignasi Barrera updated JCLOUDS-1447: Priority: Major (was: Minor) > S3 CopyObject requires x-amz-copy-source to be

Re: [jclouds/jclouds] JCLOUDS-1447: URL encode source header on copyObject (#1238)

2018-09-12 Thread Ignasi Barrera
>can you think of any other providers that need to URL encode headers? I'm mostly familiar with compute providers, and those don't use HTTP headers as extensively as Blob storage providers, so I'd say we're fine. @davidcurrie could you please add some unit tests to the

Re: [jclouds/jclouds-labs] [JCLOUDS-1430] Aliyun ECS (#443)

2018-09-10 Thread Ignasi Barrera
Thanks, @andreaturli! I think we should merge this now and keep iterating on it. Thanks for all the effort! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [jclouds/jclouds-labs] [JCLOUDS-1430] Aliyun ECS (#443)

2018-09-10 Thread Ignasi Barrera
nacx approved this pull request. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/443#pullrequestreview-153710254

[jira] [Updated] (JCLOUDS-1447) S3 CopyObject requires x-amz-copy-source to be URL encoded

2018-09-07 Thread Ignasi Barrera (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignasi Barrera updated JCLOUDS-1447: Description: S3 CopyObject requires x-amz-copy-source to be URL encoded as per [https

[jira] [Updated] (JCLOUDS-1447) S3 CopyObject requires x-amz-copy-source to be URL encoded

2018-09-07 Thread Ignasi Barrera (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignasi Barrera updated JCLOUDS-1447: Labels: aws-s3 (was: ) > S3 CopyObject requires x-amz-copy-source to be URL enco

[jira] [Commented] (JCLOUDS-1347) Using BlobStore to copy a blob with non-ascii characters in its name fails to AWS signature error

2018-09-07 Thread Ignasi Barrera (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16607358#comment-16607358 ] Ignasi Barrera commented on JCLOUDS-1347: - Indeed. [~gaul] can we mark this as resolved too

Re: [jclouds/jclouds] JCLOUDS-1441: Enables support for ARM regions in China (#1237)

2018-09-05 Thread Ignasi Barrera
nacx approved this pull request. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1237#pullrequestreview-152388787

Re: [jclouds/jclouds] JCLOUDS-1441: Enables support for ARM regions in China (#1237)

2018-09-05 Thread Ignasi Barrera
nacx commented on this pull request. > @@ -54,7 +54,12 @@ public class AzureComputeHttpApiModule extends HttpApiModule { private static final Pattern OAUTH_TENANT_PATTERN = Pattern - .compile("https://login.microsoft(?:online)?.com/([^/]+)/oauth2/token"); +

Re: [jclouds/jclouds] JCLOUDS-1441: Enables support for ARM regions in China (#1237)

2018-09-04 Thread Ignasi Barrera
nacx commented on this pull request. > @@ -92,7 +97,14 @@ protected final String > provideTenant(@Named("oauth.endpoint") final String oauth if (!m.matches()) { throw new IllegalArgumentException("Could not parse tenantId from: " + oauthEndpoint); } - return

Re: [jclouds/jclouds] [JCLOUDS-1415] - Support GCE shared VPC (#1236)

2018-08-31 Thread Ignasi Barrera
nacx commented on this pull request. > checkArgument(!iterator.hasNext(), "Error: Please specify only one network/subnetwork in TemplateOptions when using GCE."); } String region = ZONE == location.getScope() ? location.getParent().getId() :

Re: [jclouds/jclouds] JCLOUDS-1441: Enables support for ARM regions in China (#1237)

2018-08-30 Thread Ignasi Barrera
Thanks! A couple hints to do this properly: Is there any way we can determine if the `ContextBuilder` was created for China? (For example by looking at the `endpoint` that has been configured? If we can determine that, then I'd suggest the following approach to make the whole thing

Re: [jclouds/jclouds] [JCLOUDS-1415] - Support GCE shared VPC (#1236)

2018-08-30 Thread Ignasi Barrera
nacx commented on this pull request. Thanks @tormath1! > @@ -220,6 +225,14 @@ protected void configure() { return CacheBuilder.newBuilder().build(in); } + +@Provides +@Singleton +protected LoadingCache> firewallsMap( +CacheLoader> in) { +return

[jira] [Resolved] (JCLOUDS-1443) unable to resolve URI with complex host

2018-08-23 Thread Ignasi Barrera (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1443?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignasi Barrera resolved JCLOUDS-1443. - Resolution: Fixed > unable to resolve URI with complex h

[jira] [Updated] (JCLOUDS-1443) unable to resolve URI with complex host

2018-08-23 Thread Ignasi Barrera (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1443?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignasi Barrera updated JCLOUDS-1443: Fix Version/s: 2.1.2 2.2.0 > unable to resolve URI with complex h

<    1   2   3   4   5   6   7   8   9   10   >