Pushed to
[master](http://git-wip-us.apache.org/repos/asf/jclouds/commit/053dfd01) and
[2.1.x](http://git-wip-us.apache.org/repos/asf/jclouds/commit/93a805ca). Thanks
@axel3rd!
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on
Closed #1204.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1204#event-1619345086
> I will do that (your reviews, thanks) this wednesday. About useTenant flag I
> will be more explicit and add a unit test to prove the use case.
Done, with `useTenant` renamed with [some
explanation](https://github.com/jclouds/jclouds/pull/1204/files#diff-918e1e161307a179875339dfa9caceedR109),
@nacx : I will do that (your reviews, thanks) this wednesday. About `useTenant`
flag I will be more explicit and add a unit test to prove the use case.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
axel3rd commented on this pull request.
>} else if (DOMAIN.equals(parts[0])) {
return DomainScope.create(Name.create(parts[1]));
} else {
return DomainIdScope.create(Id.create(parts[1]));
}
}
+
+ private Object
nacx approved this pull request.
Just some small comments. Thanks for the contribution @axel3rd!
>} else if (DOMAIN.equals(parts[0])) {
return DomainScope.create(Name.create(parts[1]));
} else {
return DomainIdScope.create(Id.create(parts[1]));
}
}
+
Cf. [JCLOUDS-1414](https://issues.apache.org/jira/browse/JCLOUDS-1414)
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds/pull/1204
-- Commit Summary --
* OpenStack Keystone V3 - different auth "domains" support (JCLOUDS-1414)
-- File Changes
