Re: [jclouds/jclouds-labs] JCLOUDS-1181 oneandone-vpn-api (#319)

Closed #319. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/319#event-805473797

Re: [jclouds/jclouds-labs] JCLOUDS-1181 oneandone-vpn-api (#319)

Pushed to master as [4e397202](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/4e397202). Thanks @alibazlamit! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [jclouds/jclouds-labs] JCLOUDS-1181 oneandone-vpn-api (#319)

Squashed. Thanks. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/319#issuecomment-250150406

Re: [jclouds/jclouds-labs] JCLOUDS-1181 oneandone-vpn-api (#319)

Mind squashing the commits so I can cleanly merge it? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/319#issuecomment-250109508

Re: [jclouds/jclouds-labs] JCLOUDS-1181 oneandone-vpn-api (#319)

nacx commented on this pull request. > +import com.google.inject.TypeLiteral; +import java.io.ByteArrayInputStream; +import java.util.logging.Level; +import java.util.logging.Logger; +import java.util.zip.ZipInputStream; +import javax.inject.Inject; +import javax.inject.Singleton; +import

Re: [jclouds/jclouds-labs] JCLOUDS-1181 oneandone-vpn-api (#319)

nacx approved this pull request. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/319#pullrequestreview-1891528

Re: [jclouds/jclouds-labs] JCLOUDS-1181 oneandone-vpn-api (#319)

alibazlamit commented on this pull request. > +import com.google.inject.TypeLiteral; +import java.io.ByteArrayInputStream; +import java.util.logging.Level; +import java.util.logging.Logger; +import java.util.zip.ZipInputStream; +import javax.inject.Inject; +import javax.inject.Singleton;

Re: [jclouds/jclouds-labs] JCLOUDS-1181 oneandone-vpn-api (#319)

@alibazlamit pushed 1 commit. 426a288 remove public constructor -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds-labs/pull/319/files/4331e099037b24edea158bfa3d20228c9c39035d..426a288b57f1de9a554568766ebd966399ab0d39

Re: [jclouds/jclouds-labs] JCLOUDS-1181 oneandone-vpn-api (#319)

nacx commented on this pull request. > +import com.google.inject.TypeLiteral; +import java.io.ByteArrayInputStream; +import java.util.logging.Level; +import java.util.logging.Logger; +import java.util.zip.ZipInputStream; +import javax.inject.Inject; +import javax.inject.Singleton; +import

Re: [jclouds/jclouds-labs] JCLOUDS-1181 oneandone-vpn-api (#319)

@alibazlamit pushed 1 commit. 4331e09 Updated with changes -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds-labs/pull/319/files/debbc9b5bc3c2d072ee55d9f184d3c59ed778fb8..4331e099037b24edea158bfa3d20228c9c39035d

Re: [jclouds/jclouds-labs] JCLOUDS-1181 oneandone-vpn-api (#319)

alibazlamit commented on this pull request. > + public static class ToZipStream implements Function ZipInputStream> { + + @Inject + public ToZipStream() { + super(); + } + + @Override + public ZipInputStream apply(VPNConfig input) { + try

Re: [jclouds/jclouds-labs] JCLOUDS-1181 oneandone-vpn-api (#319)

nacx requested changes on this pull request. Done reviewing. Thanks @alibazlamit! > @@ -62,9 +65,10 @@ @Named("vpn:configurations:get") @GET @Path("/{vpnId}/configuration_file") - @SelectJson("config_zip_file") + @ResponseParser(VPNConfigParser.class) Is this parser class

Re: [jclouds/jclouds-labs] JCLOUDS-1181 oneandone-vpn-api (#319)

alibazlamit commented on this pull request. > + @GET + @Fallback(Fallbacks.EmptyListOnNotFoundOr404.class) + List getList(GenericQueryOptions options); + + @Named("vpn:get") + @GET + @Path("/{vpnId}") + @Fallback(Fallbacks.NullOnNotFoundOr404.class) + Vpn get(@PathParam("vpnId")

Re: [jclouds/jclouds-labs] JCLOUDS-1181 oneandone-vpn-api (#319)

@alibazlamit pushed 1 commit. debbc9b Fixed eol -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds-labs/pull/319/files/cdc081ebd87932804176473980ef7faf59076b4a..debbc9b5bc3c2d072ee55d9f184d3c59ed778fb8

Re: [jclouds/jclouds-labs] JCLOUDS-1181 oneandone-vpn-api (#319)

@alibazlamit pushed 1 commit. cdc081e Updated Changes. -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds-labs/pull/319/files/4f275a8ce0ed1e4738587b3ed6a9e410cf70a259..cdc081ebd87932804176473980ef7faf59076b4a

Re: [jclouds/jclouds-labs] JCLOUDS-1181 oneandone-vpn-api (#319)

alibazlamit commented on this pull request. > + @GET + @Fallback(Fallbacks.EmptyListOnNotFoundOr404.class) + List getList(GenericQueryOptions options); + + @Named("vpn:get") + @GET + @Path("/{vpnId}") + @Fallback(Fallbacks.NullOnNotFoundOr404.class) + Vpn get(@PathParam("vpnId")

Re: [jclouds/jclouds-labs] JCLOUDS-1181 oneandone-vpn-api (#319)

nacx commented on this pull request. > + @GET + @Fallback(Fallbacks.EmptyListOnNotFoundOr404.class) + List getList(GenericQueryOptions options); + + @Named("vpn:get") + @GET + @Path("/{vpnId}") + @Fallback(Fallbacks.NullOnNotFoundOr404.class) + Vpn get(@PathParam("vpnId") String

Re: [jclouds/jclouds-labs] JCLOUDS-1181 oneandone-vpn-api (#319)

alibazlamit commented on this pull request. > + @GET + @Fallback(Fallbacks.EmptyListOnNotFoundOr404.class) + List getList(GenericQueryOptions options); + + @Named("vpn:get") + @GET + @Path("/{vpnId}") + @Fallback(Fallbacks.NullOnNotFoundOr404.class) + Vpn get(@PathParam("vpnId")

Re: [jclouds/jclouds-labs] JCLOUDS-1181 oneandone-vpn-api (#319)

@alibazlamit pushed 1 commit. 4f275a8 Review changes applied -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds-labs/pull/319/files/057a2df15be24f6d76029394e39493c08738639e..4f275a8ce0ed1e4738587b3ed6a9e410cf70a259

Re: [jclouds/jclouds-labs] JCLOUDS-1181 oneandone-vpn-api (#319)

nacx requested changes on this pull request. Thanks @alibazlamit! > +import org.jclouds.rest.annotations.Fallback; +import org.jclouds.rest.annotations.MapBinder; +import org.jclouds.rest.annotations.RequestFilters; +import org.jclouds.rest.annotations.SelectJson; +import

Re: [jclouds/jclouds-labs] JCLOUDS-1181 oneandone-vpn-api (#319)

@alibazlamit pushed 1 commit. 89ae677 removed checkstyle skip -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds-labs/pull/319/files/8ca167c97b501d2fe28b6a3a34fbdc0df96dbf7f..89ae677061d0aae07945036e187487e3964f8d42

[jclouds/jclouds-labs] JCLOUDS-1181 oneandone-vpn-api (#319)

@nacx Ready for review, Thanks. You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds-labs/pull/319 -- Commit Summary -- * JCLOUDS-1181 oneandone-vpn-api -- File Changes -- M