@@ -303,13 +303,15 @@ Options can also be specified for extension modules
blob-builder (if content-length ;; Special case, arg is prim.
(.contentLength blob-builder content-length)
blob-builder)
+ blob-builder (if
@@ -303,13 +303,15 @@ Options can also be specified for extension modules
blob-builder (if content-length ;; Special case, arg is prim.
(.contentLength blob-builder content-length)
blob-builder)
+ blob-builder (if
Closed #383.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/383#event-125699934
Pushed to master. Finally putting this nightmare year-old pull request to rest!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/383#issuecomment-8759
This promotes type-safety. Keep the String interface for unknown
content types.
You can merge this Pull Request by running:
git pull https://github.com/andrewgaul/jclouds
blobbuilder-contenttype-mediatype
Or you can view, comment on it, or merge it online at:
Pending PR builders, +1 - looks good to me. Thanks, @andrewgaul!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/383#issuecomment-44362071
@@ -119,6 +120,8 @@
PayloadBlobBuilder contentMD5(byte[] md5);
+ PayloadBlobBuilder contentType(MediaType contentType);
Nice! :+1:
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/383/files#r13115700
[jclouds ยป jclouds
#1158](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1158/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
@@ -123,7 +123,7 @@
(is (= http://localhost/container/path; (str (.getEndpoint request
(is (= PUT (.getMethod request)))
(is (= 10 (first (.get (.getHeaders request) Content-Length
-(is (nil?
+(is (= application/unknown
If I have to spend more time writing
