Thanks, @hsbhathiya! Could you squash'n'rebase your commits? If that's tricky,
please let us know and we can do that during the merge...
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/336#issuecomment-39197309
I am not familiar with full range of functionalities in git. have I done it
correct?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/336#issuecomment-39251409
[jclouds-pull-requests
#724](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/724/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/336#issuecomment-39252433
[jclouds-java-7-pull-requests
#1194](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1194/)
SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/336#issuecomment-39252970
[jclouds-pull-requests
#725](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/725/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/336#issuecomment-39256359
[jclouds » jclouds
#984](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/984/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
[jclouds-java-7-pull-requests
#1195](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1195/)
SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/336#issuecomment-39256864
have I done it correct?
Looks perfect, thanks! Committed to
[master](https://git-wip-us.apache.org/repos/asf?p=jclouds.git;a=commit;h=c308bb9bcbb9ee615fe22d68a06449dd0af9232e)
---
Reply to this email directly or view it on GitHub:
Closed #336.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/336
:)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/336#issuecomment-39274389
Congratulations on your first commit to jclouds @hsbhathiya. Looking forward to
more :-)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/336#issuecomment-39277522
Some Azureblob live- test fail when the System User has name with Upper case
letters.Can simulated by running live test with -Duser.name=BhathiyaHS (Any
name with upper case letters).
You can merge this Pull Request by running:
git pull https://github.com/hsbhathiya/jclouds master
Or you
When I replace 'prefix' with ' CONTAINER_PREFIX ' all the test cases
succeded.Before that there was a
error in ' testCreateContainer ' and build failed.
testCreateContainer
java.lang.IllegalArgumentException: Validation on '[java.lang.String arg0,
[jclouds » jclouds
#979](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/979/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
[jclouds-java-7-pull-requests
#1191](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1191/)
SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/336#issuecomment-39061836
@@ -87,7 +87,9 @@ public void testListContainers() throws Exception {
public void testCreateContainer() throws Exception {
boolean created = false;
while (!created) {
- privateContainer = prefix + new SecureRandom().nextInt();
+
+ privateContainer =
@@ -87,7 +87,9 @@ public void testListContainers() throws Exception {
public void testCreateContainer() throws Exception {
boolean created = false;
while (!created) {
- privateContainer = prefix + new SecureRandom().nextInt();
+
+ privateContainer =
Thanks, @hsbhathiya! As @shrinandj pointed out, you can remove the parentheses
around `(CONTAINER_PREFIX + new SecureRandom().nextInt())`. If you could update
the PR, we can get this merged.
---
Reply to this email directly or view it on GitHub:
[jclouds » jclouds
#980](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/980/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
[jclouds-pull-requests
#722](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/722/) UNSTABLE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/336#issuecomment-39129949
[jclouds-java-7-pull-requests
#1192](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1192/)
SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/336#issuecomment-39130256
21 matches
Mail list logo
