jclouds » jclouds #1041 UNSTABLE
Unrelated [test
Committed to
[master](https://git-wip-us.apache.org/repos/asf?p=jclouds.git;a=commit;h=c6cb169dee73de8c75c6850b504b6644c12d2ba1).
Thanks for cleaning up, @shrinandj!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/349#issuecomment-41019749
[jclouds-pull-requests
#766](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/766/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/349#issuecomment-40968239
[jclouds-java-7-pull-requests
#1236](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1236/)
SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/349#issuecomment-40968532
[jclouds » jclouds
#1041](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1041/) UNSTABLE
Looks like there's a problem with this pull request
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
Compilation error now:
```
plugin:3.1:compile (default-compile) on project jclouds-blobstore: Compilation
failure
/scratch/jenkins/workspace/jclouds-pull-requests/blobstore/src/main/java/org/jclouds/blobstore/strategy/internal/DeleteAllKeysInList.java:[180,57]
cannot find symbol
symbol : class
Your're right. This is a purely refactoring commit.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/349#issuecomment-40847919
@@ -177,6 +177,26 @@ private String getMessage(final String containerName,
return listing;
}
+ private ListenableFutureVoid deleteDirectory(
Done.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/349/files#r11788434
@@ -177,6 +177,26 @@ private String getMessage(final String containerName,
return listing;
}
+ private ListenableFutureVoid deleteDirectory(
I don't see the change yet - have you pushed the updated commit?
---
Reply to this email directly or view it on GitHub:
[jclouds-pull-requests
#763](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/763/) FAILURE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/349#issuecomment-40854428
[jclouds-java-7-pull-requests
#1233](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1233/)
FAILURE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/349#issuecomment-40854480
[jclouds » jclouds
#1037](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1037/) FAILURE
Looks like there's a problem with this pull request
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
@@ -177,6 +177,26 @@ private String getMessage(final String containerName,
return listing;
}
+ private ListenableFutureVoid deleteDirectory(
[minor] Could you move `final ListContainerOptions options, ` up one row?
---
Reply to this email directly or view it on GitHub:
Just to make sure I'm understanding this correctly: it's purely a refactoring
commit? Only one minor formatting comment, otherwise looks good to me.
Thanks, @shrinandj!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/349#issuecomment-40781268
You can merge this Pull Request by running:
git pull https://github.com/maginatics/jclouds deleteallkeys-cleanup
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds/pull/349
-- Commit Summary --
* Create a separate function to delete directories.
[jclouds-pull-requests
#760](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/760/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/349#issuecomment-40573788
16 matches
Mail list logo
