Re: [jclouds] Fixes an issue where the number of retries was always set to 1. (#368)

2014-05-17 Thread Shri Javadekar
Duh... nevermind then! :-) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/368#issuecomment-43424762

Re: [jclouds] Fixes an issue where the number of retries was always set to 1. (#368)

2014-05-16 Thread Andrew Phillips
jclouds » jclouds #1102 FAILURE Broken BuildHive again. +1 - looks good to me too. Thanks, @zack-shoylev! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/368#issuecomment-43210814

Re: [jclouds] Fixes an issue where the number of retries was always set to 1. (#368)

2014-05-16 Thread Shri Javadekar
The change itself looks good. Can we have a unit test for this? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/368#issuecomment-43235344

Re: [jclouds] Fixes an issue where the number of retries was always set to 1. (#368)

2014-05-16 Thread Andrew Phillips
@shrinandj The change is _in_ a test class ;-) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/368#issuecomment-43397530

[jclouds] Fixes an issue where the number of retries was always set to 1. (#368)

2014-05-15 Thread Zack Shoylev
You can merge this Pull Request by running: git pull https://github.com/rackspace/jclouds mocktest-connection-retries Or you can view, comment on it, or merge it online at: https://github.com/jclouds/jclouds/pull/368 -- Commit Summary -- * Fixes an issue where the number of retries was

Re: [jclouds] Fixes an issue where the number of retries was always set to 1. (#368)

2014-05-15 Thread CloudBees pull request builder plugin
[jclouds-pull-requests #808](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/808/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/368#issuecomment-43159367

Re: [jclouds] Fixes an issue where the number of retries was always set to 1. (#368)

2014-05-15 Thread CloudBees pull request builder plugin
[jclouds-java-7-pull-requests #1277](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1277/) UNSTABLE Looks like there's a problem with this pull request --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/368#issuecomment-43158914

Re: [jclouds] Fixes an issue where the number of retries was always set to 1. (#368)

2014-05-15 Thread BuildHive
[jclouds » jclouds #1102](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1102/) FAILURE Looks like there's a problem with this pull request [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub:

Re: [jclouds] Fixes an issue where the number of retries was always set to 1. (#368)

2014-05-15 Thread CloudBees pull request builder plugin
[jclouds-java-7-pull-requests #1274](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1274/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/368#issuecomment-43142763

Re: [jclouds] Fixes an issue where the number of retries was always set to 1. (#368)

2014-05-15 Thread Andrew Gaul
:+1: --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/368#issuecomment-43150122

Re: [jclouds] Fixes an issue where the number of retries was always set to 1. (#368)

2014-05-15 Thread Zack Shoylev
Closed #368. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/368#event-121276115

Re: [jclouds] Fixes an issue where the number of retries was always set to 1. (#368)

2014-05-15 Thread Andrew Gaul
@@ -62,7 +62,9 @@ @SuppressWarnings(serial) public A api(String uri, String provider, Properties overrides) { - overrides.setProperty(PROPERTY_MAX_RETRIES, 1); + if(!overrides.containsKey(PROPERTY_MAX_RETRIES)) { Add whitespace between if and (. --- Reply to this email

Re: [jclouds] Fixes an issue where the number of retries was always set to 1. (#368)

2014-05-15 Thread Zack Shoylev
About to rebase and merge --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/368#issuecomment-43155345

Re: [jclouds] Fixes an issue where the number of retries was always set to 1. (#368)

2014-05-15 Thread CloudBees pull request builder plugin
[jclouds-pull-requests #807](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/807/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/368#issuecomment-43158943

Re: [jclouds] Fixes an issue where the number of retries was always set to 1. (#368)

2014-05-15 Thread BuildHive
[jclouds » jclouds #1101](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1101/) SUCCESS This pull request looks good [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub:

Re: [jclouds] Fixes an issue where the number of retries was always set to 1. (#368)

2014-05-15 Thread CloudBees pull request builder plugin
[jclouds-pull-requests #804](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/804/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/368#issuecomment-43141803

Re: [jclouds] Fixes an issue where the number of retries was always set to 1. (#368)

2014-05-15 Thread Zack Shoylev
merged --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/368#issuecomment-43156821

Re: [jclouds] Fixes an issue where the number of retries was always set to 1. (#368)

2014-05-15 Thread CloudBees pull request builder plugin
[jclouds-java-7-pull-requests #1278](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1278/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/368#issuecomment-43160221