}, userExecutor);
- return returnVal;
+ }
@ccustine Could you address this comment?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/394/files#r14132935
}, userExecutor);
- return returnVal;
+ }
@andrewgaul The answer got lost in the outdated diff below... not sure how to
avoid this but if anyone has any hints let me know. Click on the Show
outdated diff below this comment and we covered this question below. I also
}, userExecutor);
- return returnVal;
+ }
Copied from previous comment:
Yes, a byproduct of enabling CDN on the container (what enableAndCache does)
is if the container doesn't exist, it gets created. So it only makes one call
instead of two, and it also fixes an issue
:+1: @jdaggett can you merge this and the backport?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/394#issuecomment-47008539
[jclouds-pull-requests
#927](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/927/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/394#issuecomment-47011555
[jclouds-java-7-pull-requests
#1398](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1398/)
SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/394#issuecomment-47012238
[jclouds » jclouds
#1275](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1275/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
Closed #394.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/394#event-134704376
@@ -24,4 +25,13 @@
public HPCloudObjectStorageContainerLiveTest() {
provider = hpcloud-objectstorage;
}
+
+ @Override
+ @Test
+ public void testPublicAccessInNonDefaultLocation() { throw new
SkipException(Locations are ignored); }
[minor] Do we prefer
+ fail(static test Strings do not parse to URI: + ex.getMessage());
+ }
+
+ expect(mockSupplier.get())
+ .andReturn(endpoints)
+ .anyTimes();
+
expect(mockFactory.createForApiTypeAndVersion(ServiceType.OBJECT_STORE, null))
+
+1, looks good to me, too. Thanks, @ccustine! As @everett-toews said: good to
see you around!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/394#issuecomment-47039729
@@ -24,4 +25,13 @@
public HPCloudObjectStorageContainerLiveTest() {
provider = hpcloud-objectstorage;
}
+
+ @Override
+ @Test
+ public void testPublicAccessInNonDefaultLocation() { throw new
SkipException(Locations are ignored); }
@demobox Whatever you guys
[jclouds-pull-requests
#903](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/903/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/394#issuecomment-46505714
[jclouds » jclouds
#1243](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1243/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
Added new tests for provideCDNUrl and provideStorageUrl and fixed new
checkstyle dings, all pointed out by @demobox. Squashed and rebased on master
with Jira issue in comment. Let me know if there is anything else I should fix
up.
---
Reply to this email directly or view it on GitHub:
[jclouds-pull-requests
#871](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/871/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/394#issuecomment-45597472
[jclouds-java-7-pull-requests
#1342](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1342/)
SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/394#issuecomment-45598131
[jclouds » jclouds
#1205](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1205/) UNSTABLE
Looks like there's a problem with this pull request
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
@ccustine Thanks a ton for updating this. It's great to see you here. :)
I see that the pom.xml file didn't get updated to use the dependency for the
new Swift API.
dependency
groupIdorg.apache.jclouds.labs/groupId
artifactIdopenstack-swift/artifactId
@everett-toews Yes, this is a refactoring of the current provider and I am
aware that the new provider in labs will be replacing this one at some point.
The plan for now was to refactor the existing code so that it will be possible
to backport to 1.7.4. Myself and @Phanatic are planning to
@@ -69,12 +69,7 @@ protected HPCloudObjectStorageBlobStore(BlobStoreContext
context, BlobUtils blob
@Override
public boolean createContainerInLocation(Location location, String
container, CreateContainerOptions options) {
- try {
- return
@@ -69,12 +69,7 @@ protected HPCloudObjectStorageBlobStore(BlobStoreContext
context, BlobUtils blob
@Override
public boolean createContainerInLocation(Location location, String
container, CreateContainerOptions options) {
- try {
- return
@shrinandj I added a comment on the actual Jira issue at
https://issues.apache.org/jira/browse/JCLOUDS-584 just pointing out the major
changes. Let me know if you have questions about specific parts of the code by
adding line comments here in the PR and I will address them.
---
Reply to this
@@ -72,6 +76,10 @@ public boolean apply(@Nullable StorageMetadata input) {
assert metadata.getPublicUri() != null : metadata;
+ SocketOpen socketOpen =
context.utils().injector().getInstance(SocketOpen.class);
+ PredicateHostAndPort socketTester =
@@ -36,9 +36,7 @@
test.hpcloud-objectstorage.api-version1.0/test.hpcloud-objectstorage.api-version
test.hpcloud-objectstorage.build-version /
!--
-Identity must be tenantName:userName. Note that the following
-credentials are the HP Cloud username and
jclouds-java-7-pull-requests #1329 SUCCESS
Some new [Checkstyle
violations](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1329/org.apache.jclouds.provider$hpcloud-objectstorage/violations/).
Could you have a look at those, @ccustine?
---
Reply to this email directly or
}, userExecutor);
- return returnVal;
+ }
I may be missing something here, but now, if `isPublicRead` is true,
`createContainerInLocation` is never called? Is that intentional?
---
Reply to this email directly or view it on GitHub:
@@ -69,12 +69,7 @@ protected HPCloudObjectStorageBlobStore(BlobStoreContext
context, BlobUtils blob
@Override
public boolean createContainerInLocation(Location location, String
container, CreateContainerOptions options) {
- try {
- return
+ public static class HPCloudObjectStorageEndpointModule extends
KeystoneAuthenticationModule {
+ @Provides
+ @Singleton
+ @Storage
+ protected SupplierURI
provideStorageUrl(RegionIdToURISupplier.Factory factory,
+
I may have missed something, but I can't see any obvious tests for the new
logic in `HPCloudObjectStorageRestClientModule`? Add a unit test for that?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/394#issuecomment-45293686
https://issues.apache.org/jira/browse/JCLOUDS-584
You can merge this Pull Request by running:
git pull https://github.com/ccustine/jclouds fixes/JCLOUDS-584
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds/pull/394
-- Commit Summary --
* HP Cloud
[jclouds-java-7-pull-requests
#1329](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1329/)
SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/394#issuecomment-45146630
[jclouds » jclouds
#1186](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1186/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
Hey Chris,
Thanks for adding support for the 13.5 API. Could you list some points (maybe
in the commit message itself) about what the actual changes are? Will make it
easier to understand the code changes.
---
Reply to this email directly or view it on GitHub:
34 matches
Mail list logo
