[jclouds » jclouds
#1262](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1262/) FAILURE
Looks like there's a problem with this pull request
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
@@ -159,11 +159,18 @@ public static ImageType fromValue(String v) {
private final String snapshotId;
private final long volumeSize;
private final boolean deleteOnTermination;
+ private final String volumeType;
+ private final Integer iops;
+ private final
Review comments addressed - it's still a little wishy-washy on
primitive/non-primitive for encrypted, because there are a few places where it
frankly makes sense to go with nullable Booleans, but it's much more consistent
now.
---
Reply to this email directly or view it on GitHub:
[jclouds-pull-requests
#909](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/909/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/408#issuecomment-46602774
[jclouds-java-7-pull-requests
#1380](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1380/)
SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/408#issuecomment-46602943
[jclouds » jclouds
#1250](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1250/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
Live tests are added and passing.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/408#issuecomment-46617134
Oops, one test was a bit flaky. Fixed.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/408#issuecomment-46618857
[jclouds-pull-requests
#911](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/911/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/408#issuecomment-46621876
[jclouds-java-7-pull-requests
#1382](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1382/)
SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/408#issuecomment-46622156
[jclouds-pull-requests
#912](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/912/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/408#issuecomment-46624776
[jclouds » jclouds
#1253](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1253/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
Whoops again - ran the full battery of live tests, found another problem - we
do need the truthy dance for now, unless we switch BlockDeviceMapping to
primitives for encrypted, and I'm not going to do that unless I know why
deleteOnTermination's a non-primitive there.
---
Reply to this email
[jclouds-pull-requests
#913](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/913/) UNSTABLE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/408#issuecomment-46637358
[jclouds-java-7-pull-requests
#1384](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1384/)
SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/408#issuecomment-46637429
Add CreateVolumeOptions, modified everything that I could find that cares about
parsing or creating volumes (and EBS-backed images, since that's connected) to
support the new fields as well. Live tests and unit tests should be updated.
---
Reply to this email directly or view it on GitHub:
[jclouds-pull-requests
#906](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/906/) FAILURE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/408#issuecomment-46509389
The jclouds-pull-requests build 906 failure looks spurious - will wait and see
if the others barf too.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/408#issuecomment-46509445
@@ -159,11 +159,18 @@ public static ImageType fromValue(String v) {
private final String snapshotId;
private final long volumeSize;
private final boolean deleteOnTermination;
+ private final String volumeType;
+ private final Integer iops;
+ private final
- public EbsBlockDevice(@Nullable String snapshotId, long volumeSize,
boolean deleteOnTermination) {
+ public EbsBlockDevice(@Nullable String snapshotId, long volumeSize,
boolean deleteOnTermination,
aside: consider auto-value to write this class, including its tostring etc :)
+@Nullable
Boolean deleteOnTermination,
+@Nullable String
volumeType,
+@Nullable
Integer iops,
+
@@ -139,6 +139,14 @@ public RunInstancesOptions withBlockDeviceMappings(Set?
extends BlockDeviceMapp
if (mapping.getEbsDeleteOnTermination() != null)
formParameters.put(String.format(BlockDeviceMapping.%d.Ebs.DeleteOnTermination,
i),
- .id(vol-2a21e543)
- .status(Volume.Status.CREATING)
- .availabilityZone(us-east-1a)
- .region(us-east-1)
- .id(vol-2a21e543)
-
@@ -160,6 +163,24 @@ void testCreateVolumeFromSnapshotInAvailabilityZone() {
}
@Test(dependsOnMethods = testCreateSnapshotInRegion)
+ void testCreateVolumeFromSnapshotInAvailabilityZoneWithOptions() {
+ Volume volume = client.createVolumeInAvailabilityZone(defaultZone,
+
- public EbsBlockDevice(@Nullable String snapshotId, long volumeSize,
boolean deleteOnTermination) {
+ public EbsBlockDevice(@Nullable String snapshotId, long volumeSize,
boolean deleteOnTermination,
For new classes, oh yeah, lots of wonderful new things without even going
@@ -160,6 +163,24 @@ void testCreateVolumeFromSnapshotInAvailabilityZone() {
}
@Test(dependsOnMethods = testCreateSnapshotInRegion)
+ void testCreateVolumeFromSnapshotInAvailabilityZoneWithOptions() {
+ Volume volume = client.createVolumeInAvailabilityZone(defaultZone,
+
- .id(vol-2a21e543)
- .status(Volume.Status.CREATING)
- .availabilityZone(us-east-1a)
- .region(us-east-1)
- .id(vol-2a21e543)
-
@@ -160,6 +163,24 @@ void testCreateVolumeFromSnapshotInAvailabilityZone() {
}
@Test(dependsOnMethods = testCreateSnapshotInRegion)
+ void testCreateVolumeFromSnapshotInAvailabilityZoneWithOptions() {
+ Volume volume = client.createVolumeInAvailabilityZone(defaultZone,
+
@@ -159,11 +159,18 @@ public static ImageType fromValue(String v) {
private final String snapshotId;
private final long volumeSize;
private final boolean deleteOnTermination;
+ private final String volumeType;
+ private final Integer iops;
+ private final
sfsg keep on truckin
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/408#issuecomment-46510530
[jclouds-java-7-pull-requests
#1377](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1377/)
SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/408#issuecomment-46511695
Note - still missing adding these to the createVolume* methods, but
that#39;s going to involve a non-trivial change to something like
CreateVolumeOptions.class rather than the current simple arguments.
You can merge this Pull Request by running:
git pull https://github.com/abayer/jclouds-1
[jclouds » jclouds
#1238](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1238/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
33 matches
Mail list logo
