Closed #399.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/399#event-133841319
@shrinandj Reworded commit message and pushed to master and 1.7.x.
@diwakergupta 1.7.4 will likely release in mid- to late-July, following the
same cadence as previous minor releases.
---
Reply to this email directly or view it on GitHub:
@Inject(optional = true)
@Named(Constants.PROPERTY_MAX_RETRIES)
- private int retryCountLimit = 5;
+ static final int NUM_RETRIES = 5;
@andrewgaul Done.
@zack-shoylev There is already a test for this. test401ShouldRetry4Times().
---
Reply to this email directly or view it on
@@ -60,6 +67,16 @@ protected RetryOnRenew(LoadingCacheCredentials, Auth
authenticationResponseCac
this.backoffHandler = backoffHandler;
}
+ /*
+* The reason retries need to be tracked is that it is possible that a
token
+* * can be expired at any time. The reason
[jclouds-pull-requests
#899](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/899/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/399#issuecomment-46360356
[jclouds » jclouds
#1237](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1237/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
[jclouds-pull-requests
#875](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/875/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/399#issuecomment-45673417
[jclouds-java-7-pull-requests
#1346](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1346/)
SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/399#issuecomment-45673735
[jclouds » jclouds
#1209](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1209/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
@Inject(optional = true)
@Named(Constants.PROPERTY_MAX_RETRIES)
- private int retryCountLimit = 5;
+ static final int NUM_RETRIES = 5;
Should this be non-final since it is injectable?
---
Reply to this email directly or view it on GitHub:
@@ -60,6 +67,16 @@ protected RetryOnRenew(LoadingCacheCredentials, Auth
authenticationResponseCac
this.backoffHandler = backoffHandler;
}
+ /*
+* The reason retries need to be tracked is that it is possible that a
token
+* * can be expired at any time. The reason
@zack-shoylev could you also look at this pull request?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/399#issuecomment-45683808
authenticationResponseCache.invalidateAll();
retry = true;
} else {
- retry = false;
+ // This request has failed before
+ if (count + 1 = NUM_RETRIES) {
+
@Inject(optional = true)
@Named(Constants.PROPERTY_MAX_RETRIES)
- private int retryCountLimit = 5;
+ static final int NUM_RETRIES = 5;
Perhaps this case should also be tested.
---
Reply to this email directly or view it on GitHub:
This looks good. Any notes I have could be applied to the original code as well.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/399#issuecomment-45689559
Reauthenticate on HTTP 401. Orig commit:
578a77d6313ce0945f8d29e82103e09787622c58
Closes #589.
You can merge this Pull Request by running:
git pull https://github.com/maginatics/jclouds
fix_401_unauthorized_non_keystone
Or you can view, comment on it, or merge it online at:
[jclouds-pull-requests
#867](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/867/) UNSTABLE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/399#issuecomment-45553707
[jclouds-java-7-pull-requests
#1338](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1338/)
UNSTABLE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/399#issuecomment-45553873
These are related to the change I made. I'll take a look and update the review
request.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/399#issuecomment-45554781
[jclouds » jclouds
#1198](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1198/) UNSTABLE
Looks like there's a problem with this pull request
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
These are related to the change I made. I'll take a look and update the
review request.
Thanks, @shrinandj!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/399#issuecomment-45563817
21 matches
Mail list logo
