During release week we like to do a little house cleaning in the jclouds world.
That means sweeping out the pull request queue.
This PR is over 6 months old. Please update us on its status here. If we don't
hear anything, we will take that as lazy consensus that the PR is no longer
relevant
Closed #220.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/220#event-147810874
Is there anything else that needs to be done here?
Looks like it needs at least a rebase - can't be merged as-is right now?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/220#issuecomment-45497254
[jclouds-pull-requests
#868](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/868/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/220#issuecomment-4320
[jclouds-java-7-pull-requests
#1339](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1339/)
SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/220#issuecomment-4476
@@ -99,7 +99,9 @@ private StubAtmosAsyncClient(LocalAsyncBlobStore blobStore,
AtmosObject.Factory
container = directoryName;
path = null;
}
- return Futures.transform(blobStore.createContainerInLocation(null,
container), new FunctionBoolean, URI() {
+
@@ -137,7 +141,8 @@ public URI apply(String from) {
public ListenableFutureVoid deletePath(String path) {
if (path.indexOf('/') == path.length() - 1) {
// chop off the trailing slash
- return
Futures.transform(blobStore.deleteContainerIfEmpty(path.substring(0,
@@ -148,7 +153,8 @@ public Void apply(Boolean from) {
} else {
String container = path.substring(0, path.indexOf('/'));
path = path.substring(path.indexOf('/') + 1);
- return blobStore.removeBlob(container, path);
+ blobStore.removeBlob(container,
@@ -213,17 +226,12 @@ public AtmosObject newObject() {
public ListenableFutureBoolean pathExists(final String path) {
if (path.indexOf('/') == path.length() - 1) {
// chop off the trailing slash
- return blobStore.containerExists(path.substring(0, path.length() -
+
+ /**
+* Override parent method because it uses strange futures and listenables
+* that creates problem in the test if more than one test that deletes the
+* container is executed
+*
+* @param container
+* @return
+*/
+ @Override
+ public void
@@ -72,7 +69,7 @@ public BlobStore getBlobStore() {
@Override
public AsyncBlobStore getAsyncBlobStore() {
- return ablobStore;
+ return null;
}
Should this PR then add a `@Deprecated` or so, explaining not to call this? Or
at least some Javadoc? Or is the intention
jclouds-java-7-pull-requests #1339 SUCCESS
Some [Checkstyle
violations](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1339/violations/)
- not sure which of these are related to this change, though. Could you have a
quick look, @shrinandj? Thanks!
---
Reply to this email
Is there anything else that needs to be done here?
There is one feature that I am developing in jclouds that is made easier
because of this change. Let me know if there's anything I can do to help make
progress on this.
I do not think `LocalAsyncBlobStore` is the appropriate place to
Is there anything else that needs to be done here?
There is one feature that I am developing in jclouds that is made easier
because of this change. Let me know if there's anything I can do to help make
progress on this.
---
Reply to this email directly or view it on GitHub:
jclouds-java-7-pull-requests #1107 UNSTABLE
Unrelated [test
failure](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/org.apache.jclouds$jclouds-compute/1107/testReport/org.jclouds.compute.util/ConcurrentOpenSocketFinderTest/testChecksSocketsConcurrently/).
+1 from me.
[jclouds » jclouds
#885](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/885/) UNSTABLE
Looks like there's a problem with this pull request
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
jclouds » jclouds #885 UNSTABLE
jclouds-java-7-pull-requests #1106 UNSTABLE
Both
[jclouds » jclouds
#887](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/887/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
18 matches
Mail list logo
