Removed `S3RedirectionRetryHandlerExpectTest` and pushed to master as
80a44300352ec3951e96eacee8f91daebdde298e and 1.8.x as
e7c398321a56bd88d1b732f17dcc8b8a5c563d31.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/475#issuecomment-52834089
.addHeader(Date,
CONSTANT_DATE)
- .addHeader(Authorization,
AWS identity:p32RsBr2inawMBeCkkiA228BT2w=)
Why was the change in identity needed?
---
Reply to this email directly or view it on GitHub:
.addHeader(Date,
CONSTANT_DATE)
- .addHeader(Authorization,
AWS identity:p32RsBr2inawMBeCkkiA228BT2w=)
I changed the signature, not the identity. Refer to
+1 - code change looks fine to me. Curious about the identify change too.
Thanks, @andrewgaul!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/475#issuecomment-51812430
We cannot merge this as-is due to
`S3RedirectionRetryHandlerExpectTest.testRedirectOnHeadBucketChangesRequestToGetBucket`
failures. However I do not understand this test and thus am not sure how to
fix it.
---
Reply to this email directly or view it on GitHub:
.addHeader(Date,
CONSTANT_DATE)
- .addHeader(Authorization,
AWS identity:p32RsBr2inawMBeCkkiA228BT2w=)
I see.
---
Reply to this email directly or view it on GitHub:
Change looks good to me.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/475#issuecomment-51816730
However I do not understand this test and thus am not sure how to fix it.
It looks like we're supposed to have fallback logic that handles a 301 by
falling back from a HEAD to a GET? I guess you got that too, of course...so if
the question is why are we doing that, I fear we'll need to ping
I also don't see any obvious logic that resets from HEAD to GET in
[S3RedirectionRetryHandler](https://github.com/jclouds/jclouds/blob/master/apis/s3/src/main/java/org/jclouds/s3/handlers/S3RedirectionRetryHandler.java).
In fact, I also don't see how the _first_ request [in the
[jclouds-java-6-pull-requests
#7](https://jclouds.ci.cloudbees.com/job/jclouds-java-6-pull-requests/7/)
FAILURE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/475#issuecomment-51725677
[jclouds » jclouds
#1491](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1491/) UNSTABLE
Looks like there's a problem with this pull request
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
[jclouds-pull-requests
#1078](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/1078/)
UNSTABLE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/475#issuecomment-51727443
Addressed other failures, but unsure what the intent of
`S3RedirectionRetryHandlerExpectTest.testRedirectOnHeadBucketChangesRequestToGetBucket`
is.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/475#issuecomment-51732956
[jclouds-java-6-pull-requests
#8](https://jclouds.ci.cloudbees.com/job/jclouds-java-6-pull-requests/8/)
FAILURE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/475#issuecomment-51733096
[jclouds-pull-requests
#1079](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/1079/)
UNSTABLE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/475#issuecomment-51735365
[jclouds » jclouds
#1492](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1492/) ABORTED
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/475#issuecomment-51737407
16 matches
Mail list logo
