Re: [jclouds/jclouds] JCLOUDS-1460: Add support for aws ec2 t3 instance types (#1244)

2018-10-17 Thread Simone Locci
Closed #1244. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1244#event-1909339275

Re: [jclouds/jclouds] JCLOUDS-1460: Add support for aws ec2 t3 instance types (#1244)

2018-10-17 Thread Andrea Turli
thanks @pimuzzo for the clarification Feel free to close this yourself, and maybe help with the review of #1245, as you are waiting for (some) same features contained there! Thanks! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on

Re: [jclouds/jclouds] JCLOUDS-1460: Add support for aws ec2 t3 instance types (#1244)

2018-10-17 Thread Simone Locci
I think too that the @trentontrees 's PR supersedes this one :peace_symbol: @andreaturli you can close this one, there will be other opportunities to collaborate -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [jclouds/jclouds] JCLOUDS-1460: Add support for aws ec2 t3 instance types (#1244)

2018-10-16 Thread Simone Locci
pimuzzo commented on this pull request. > @@ -429,6 +435,69 @@ public static EC2HardwareBuilder t2_large() { .processors(ImmutableList.of(new Processor(1.0, 0.4))).rootDeviceType(RootDeviceType.EBS); } + /** +* @see InstanceType#T3_NANO +*/ + public static

Re: [jclouds/jclouds] JCLOUDS-1460: Add support for aws ec2 t3 instance types (#1244)

2018-10-16 Thread Trent Schmidt
We did our work separately. The code in PR #1245 is slightly different than this. I do think that #1245 supersedes this, but that PR is current blocked because of a build error. The `t3()` method in this PR is slightly different as well. -- You are receiving this because you are subscribed

Re: [jclouds/jclouds] JCLOUDS-1460: Add support for aws ec2 t3 instance types (#1244)

2018-10-16 Thread Andrea Turli
I'm confused guys, does #1245 supersede this one? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1244#issuecomment-430414297

Re: [jclouds/jclouds] JCLOUDS-1460: Add support for aws ec2 t3 instance types (#1244)

2018-10-16 Thread Simone Locci
@pimuzzo pushed 1 commit. 9a3c172 Add CPU speed -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds/pull/1244/files/31c2831cb6db734a355f70aa2b191f6452f9a383..9a3c172b1b2ffbfab7d1c5290077b0f8b065b432

Re: [jclouds/jclouds] JCLOUDS-1460: Add support for aws ec2 t3 instance types (#1244)

2018-10-16 Thread Trent Schmidt
trentontrees commented on this pull request. > @@ -429,6 +435,69 @@ public static EC2HardwareBuilder t2_large() { .processors(ImmutableList.of(new Processor(1.0, 0.4))).rootDeviceType(RootDeviceType.EBS); } + /** +* @see InstanceType#T3_NANO +*/ + public static