merged
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1010#issuecomment-247129173
Closed #1010.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1010#event-789701771
andrewgaul approved this pull request.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1010#pullrequestreview-29746
>I will try to do a separate PR for it (out of scope for this one).
Great :) Thanks!
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1010#issuecomment-247084474
@nacx 1176: I will try to do a separate PR for it (out of scope for this one).
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1010#issuecomment-247083691
Does this also fix JCLOUDS-1176? (Just asking to understand the scope of this
PR :))
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1010#issuecomment-247080469
@zack-shoylev pushed 1 commit.
c18747d review fixes
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/jclouds/jclouds/pull/1010/files/304c72c3e24e376cebbb98bd3b8f8ad6ecd72dac..c18747de0aeb80b3a6ab9eae5c6ceddf6c8e3a1a
> @@ -753,8 +770,24 @@ public Void call() {
> return null;
> }
> throw new RuntimeException("After " + retryCountLimit + " retries:
> " + lastException);
> + }
> +
> + // JDK-4715154
> + private void closeDirectBuffer(MappedByteBuffer mbb) {
> @@ -753,8 +770,24 @@ public Void call() {
> return null;
> }
> throw new RuntimeException("After " + retryCountLimit + " retries:
> " + lastException);
> + }
> +
> + // JDK-4715154
> + private void closeDirectBuffer(MappedByteBuffer mbb) {
>
> }
> +} catch (Exception e) {
> + logger.debug(e.toString());
> + // close pipe so client is notified of an exception
> + Closeables2.closeQuietly(input);
> + Closeables2.closeQuietly(output);
Would these work
> @@ -57,7 +57,7 @@
> public class RegionScopedSwiftBlobStoreParallelLiveTest extends
> BaseBlobStoreIntegrationTest {
>
> private final File BIG_FILE = new File("random.dat");
> - private final long SIZE = 10; //10 * 1000 * 1000;
> + private final long SIZE = 1000; //10 *
> @@ -753,8 +770,24 @@ public Void call() {
> return null;
> }
> throw new RuntimeException("After " + retryCountLimit + " retries:
> " + lastException);
> + }
> +
> + // JDK-4715154
> + private void closeDirectBuffer(MappedByteBuffer mbb) {
>
> @@ -753,8 +770,24 @@ public Void call() {
> return null;
> }
> throw new RuntimeException("After " + retryCountLimit + " retries:
> " + lastException);
> + }
> +
> + // JDK-4715154
> + private void closeDirectBuffer(MappedByteBuffer mbb) {
> @@ -706,12 +709,23 @@ public void downloadBlob(String container, String name,
> File destination, Execut
>
> Futures.getUnchecked(Futures.allAsList(results));
>
> + raf.getChannel().force(true);
> + raf.getChannel().close();
> + raf.close();
> +
> +
14 matches
Mail list logo
