makes sense please remember to open a jira issue to track the improvements you
want to make.
merged at
[2.0.x](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/69ef8765)
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view
I prefer to put effort in supporting more windowsconfiguration parameters in
the TemplateOptions rather than focusing on this bit.
I'd like to pick this simple change in 2.0.x as well. Thanks.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or
merged at
[master](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/2fe3e0c1)
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/371#issuecomment-287792683
Closed #371.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/371#event-1006888516
does it need to be backport to 2.0.x, @bostko ?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/371#issuecomment-287792337
+1 merging
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/371#issuecomment-287791413
@andreaturli Are you happy to merge this without the ListenerProtocol you
suggested, or would you like to see that implemented?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
bostko commented on this pull request.
> @@ -54,6 +54,7 @@
protected String networkSecurityGroupName;
protected String reservedIPName;
protected Boolean provisionGuestAgent;
+ protected Boolean winrmUseHttps;
Thank you very much for the suggestion.
Looks good however I am more
the build failure looks related, see
https://jclouds.ci.cloudbees.com/job/jclouds-labs-pull-requests/org.apache.jclouds.labs$azurecompute/1710/testReport/junit/org.jclouds.azurecompute.features/DeploymentApiMockTest/testCreateWindows/
--
You are receiving this because you are subscribed to this
andreaturli commented on this pull request.
a minor comment, but overall looks good
> @@ -54,6 +54,7 @@
protected String networkSecurityGroupName;
protected String reservedIPName;
protected Boolean provisionGuestAgent;
+ protected Boolean winrmUseHttps;
isn't `String
rebuild please
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/371#issuecomment-287523859
mvn build seems to be successful however jenkins report it failed.
```
[INFO] BUILD SUCCESS
[INFO]
[INFO] Total time: 5:23.302s
[INFO] Finished at: Sat Mar 18 03:42:33 EDT 2017
...
[JENKINS] Archiving
12 matches
Mail list logo
